=== kukacz_ is now known as kukacz [19:13] smoser: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/334141 [19:13] enables bionic for integration tests [19:26] powersj: gracias. [19:26] looking at the image modification issue you brought up now [19:27] We use qemu-image create with the original qcow as a backing file [19:34] heh it does indeed look like we setup the image (i.e. install new deb) before creating the copy doh! [19:35] powersj: so i had thought someon this. [19:36] all ears :) [19:36] when you create an image it should create a qcow2 backed by the /srv/ file [19:37] then, the snapshot can qcow2 off of that.. the issue wth that is that ew kind of need snapshot to be persistent [19:37] so maybe when we snapshot it should "realize" the image.. rather than snapshost-qcow2 -> image->qcow2 -> /srv [19:37] as the image thing can be deleted. [19:39] Snapshot today calls platforms/nocloudkvm.py which creates a qcow backed by the /srv/ file and you are saying what needs to change is image, which should create a a qcow [19:42] * powersj goes and gets food [19:46] https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+ref/fix/cii-kvmimage-preserve-original [20:12] smoser: looking [20:14] that was what i had started a while ago [20:15] powersj: rad the commit message and the 'also have to modify'... [20:15] i think it'd be sufficient if we just di da copy (shutil.copy) [20:15] that way the snapshto woudl be backed by the imagein /srv/ [20:18] smoser: that looks good [20:19] going to propose it? [20:20] oh yeah gotta change snapshot [20:20] powersj: i can see if i can do that quick [20:21] (this was a while ago... so my brain wsant too fresh) [20:26] ug. [20:26] htis is why i gave up. it gets ugly there. [21:50] powersj: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334147 [21:51] i'm running tox here... it did run a quick test of nocloud kvm for me. [21:51] but not throughogh testing [21:52] smoser: ok I'll play with it and let you know by eod [21:52] thanks! [21:52] well, k'm about to eod. [21:52] really appreciate it! [21:52] but yeah, give some feedback. thanks. [22:29] powersj: merged yoru cloud-init bionic so we'll hopefully get results of that tonight. [22:29] thanks. and with that, i do go afk [22:29] awesome [22:29] o/ cya