/srv/irclogs.ubuntu.com/2017/11/22/#snappy.txt

gsilvaptkyrofa, about the command, the only way I can make them match is if I explicitly set the string to be "snapcraft, version xxx" in both commands. Is that okay?00:08
kyrofagsilvapt, I'd leave the Click one `prog`00:09
gsilvaptkyrofa, sounds okay to me but the problem is that when you run the tests it does not print snapcraft. Instead it prints run, version xxx00:09
gsilvaptMaybe that is related with the tests, I do not know00:10
kyrofagsilvapt, oh that's unfortunate indeed00:10
kyrofagsilvapt, yeah, hardcode it then00:10
gsilvaptOk, I will do that, verify again the tests and submit the changes00:10
gsilvaptkyrofa, thank you!00:10
mupIssue snapcraft#1666 closed: Refactor to support elf patching <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/issue/1666>00:50
mupPR snapcraft#1744 closed: elf: conversion from libraries <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1744>00:50
mupPR snapcraft#1725 closed: tests: share the cache in ros tests <Created by elopio> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1725>01:50
=== elijah_ is now known as elijah
mborzeckimorning guys05:56
mupPR snapd#4264 closed: tests: force delete when tests are restore to avoid suite failure <Created by sergiocazzolato> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4264>06:31
mupPR snapd#4240 closed: spread.yaml: increase workers for opensuse to 3 <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4240>06:39
mupPR snapd#4266 opened: snapstate: add new refresh-hints helper and use it <Created by mvo5> <https://github.com/snapcore/snapd/pull/4266>06:53
zyga-ubuntugood morning07:01
mvohey zyga-ubuntu , good morning07:02
zyga-ubuntu:-)07:11
zyga-ubuntuI'm still in non-{wayland,x} text mode07:11
zyga-ubuntuusing another computer for code reviews07:12
zyga-ubuntuthis is particularly refreshin07:12
zyga-ubuntulots of free memory and full-screen, single focus applications07:12
mvozyga-ubuntu: haha, nice07:13
zyga-ubuntuI spent some time yesterday trying to untangle our prepare/restore code07:23
zyga-ubuntuif not permanantly then at least enough to get good measurements of what is changing07:23
zyga-ubuntuand I must say that code is complex and confusing07:23
zyga-ubuntunot just in the actions taken but in their placement and justification07:24
zyga-ubuntu(or lack or thereof)07:24
mvozyga-ubuntu: yeah, its all over the place07:24
zyga-ubuntuI'll keep at it as it needs to be in proper shape to detect tests that change too much07:25
mupPR snapd#4267 opened: snapstate: move catalogRefresh into its own helper  <Created by mvo5> <https://github.com/snapcore/snapd/pull/4267>07:40
* kalikiana o/07:46
zyga-ubuntumvo: review on 426607:46
mvozyga-ubuntu: ta07:48
zyga-ubuntuI marked it as changes requested but just midlly so, we can merge this quickly07:50
mvozyga-ubuntu: thanks, the can-auto-refresh question is interessting as it raises a bigger questions07:59
mvopedronis: do you think the new refresh-hints code should also consult "CanAutoRefresh", or should we do the refresh-hints even if the device is still bootstraping? I guess we want to honor CanAutoRefresh but I want to double check. I also think you are right about RefreshOptions:RefreshNop, I think we want this, I will followup on this08:01
mvozyga-ubuntu: thanks again for the quick review :)08:03
zyga-ubuntu:-)08:03
pedronismvo: yes, I think we want to consult CanAutoRefresh  (otherwise will just consider partial information or don't have a device session yet)08:26
mvopedronis: +1 - thank you08:28
* zyga-ubuntu tries something mergable instead08:56
zyga-ubuntumvo: trivial merge on 426809:00
mupPR snapd#4268 opened: spread.yaml: move prepare-each closer to restore-each <Created by zyga> <https://github.com/snapcore/snapd/pull/4268>09:00
mupPR snapd#4269 opened: timeutil: new refresh timer parser <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4269>09:11
mupPR snapd#4270 opened: timeutil: remove support to parse weekday schedules <Created by mvo5> <https://github.com/snapcore/snapd/pull/4270>09:13
mvomborzecki: heh, looks like we need to solve conflicts here ;) either way is fine with me, I can wait for your merge or you can review mine and merge into yours (or wait until master is in)09:16
mvomborzecki: should be very simple in any case09:16
mborzeckimvo: yup, i'm wiring a comment on gh09:17
mborzeckii'm actually using some of the pieces that you remove :)09:18
mvomborzecki: yeah, happy to revert those bits09:18
mvomborzecki: the key of the PR (I can make it smaller) is that the weekday parsing in v1 is not supported in snapstate so its dead code and caused one confusion in the validation already09:19
mborzeckihmm ok, i mean it's not a big problem, if it gets merged before 4269, i'll just bring back the missing pieces09:21
mvomborzecki: no worries, I can do that now to make your life easier, its the weekday part of the struct and the weekdayMap that you need, right?09:22
mborzeckibut i'm guessing 4269 will be a longer review, so I wouldn't want to block you09:23
mvomborzecki: yeah, let me rework my PR (was not aware of yours) so that the impact for you is minimal09:23
mborzeckimvo: only if you have time for this, otherwise i can fix this myself in my PR09:24
mborzeckimvo: would appreciate you taking a look at 4269 BTW :)09:25
mvomborzecki: re-added the weekday/weekday map now. I check the other one out once I finished my current PR. I glanced over it and it looked good from a very brief look09:26
mborzeckimvo: thanks09:34
zyga-ubuntuhmm09:49
zyga-ubuntuso, what does ${GOPATH%%:*} expand to?09:50
zyga-ubuntubecause as far as I can see, to nothing at all09:50
zyga-ubuntu%% will strip the longest suffix of "*" which is everything09:51
jameshit'll strip the suffix of ":*" -- not "*"09:51
jameshso effectively remove everything including and after the first colon09:52
zyga-ubuntuare you sure?09:53
zyga-ubuntuah09:53
zyga-ubunturight, I made a typo in my tests09:53
zyga-ubuntuthanks!09:53
zyga-ubuntu:-)09:55
zyga-ubuntumvo: can you please force-merge 426809:56
zyga-ubuntuI could try again and waste an hour but I think the situation is riddiculus enough not to do that09:57
zyga-ubuntuand the error is clearly some store flue on refresh deltas09:57
mupPR snapd#4268 closed: spread.yaml: move prepare-each closer to restore-each <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4268>09:59
zyga-ubuntuthanks!10:00
zyga-ubuntumvo: another quick PR to look at 427110:01
mvoyw10:01
mupPR snapd#4271 opened: spread.yaml: fix shellcheck issues and trivial refactor <Created by zyga> <https://github.com/snapcore/snapd/pull/4271>10:02
zyga-ubuntumborzecki: errors in your schedule PR10:17
zyga-ubuntumborzecki: real unit tests failures in overlord/snapstate10:18
mborzeckizyga-ubuntu: thx, on it10:18
zyga-ubuntumvo: btw, I'm on FF57 now (actually on nightly so 59) and I can use umatrix10:18
zyga-ubuntumvo: try again, maybe your extension was fixed now10:18
zyga-ubuntumvo: ff 59 with umatrix is the fastest browser on any system I used10:19
zyga-ubuntu(umatrix cutting the number of crap javascript from ads and tracking)10:19
mvozyga-ubuntu: I have a bunch that I missed, but things are mostly good again. umatrix, cookie auto-delete, noscript are my essential ones, I also have a custom one that I need to port in time (based on the passhash extension)10:22
mborzeckimvo: things are fast again!10:22
mupPR snapd#4272 opened: snapstate: ensure RefreshSchedule() gives accurate results <Created by mvo5> <https://github.com/snapcore/snapd/pull/4272>10:23
pedronismvo: ^  the description  there has "git push ..." in the middle, could you fix it10:25
mvopedronis: autsch, sorry for that10:25
pedronisnot sure if it lost bits or just need the bit removed10:25
mvopedronis: apparently a wrongly focused window, the original commit message is correct10:27
mvopedronis: most of the PRs this morning are based on what we talked about yesterday, I they capture your suggestions, they should make 4161 simpler10:27
=== __chip__ is now known as Chipaca
zyga-ubuntumvo: review on 427210:33
zyga-ubuntumborzecki: do you think 4269 can be split?10:33
zyga-ubuntumborzecki: I'm often doing small reviews while waiting for local spread run to finish but 1K PR is not in that class10:34
mborzeckifor sure i can put the first 2 patches in a separate pr10:34
zyga-ubuntumborzecki: thank you, I'll gadly review that10:34
mupPR snapd#4273 opened: timeutil: introduce helpers for weekdays and TimeOfDay <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4273>10:39
mborzeckizyga-ubuntu: ^^10:39
zyga-ubuntuthanks10:41
Chipacamborzecki: doesn't that TimeOfDay Add method mess up on DST change?10:43
Chipaca11pm + 6h isn't always 5am10:43
zyga-ubuntuChipaca: I commented on a similar aspect10:43
zyga-ubuntumborzecki: commented10:44
mborzeckihmm not sure you can do anythign about this TimeOfDay as it's not aware of actual date10:44
zyga-ubuntumborzecki: yeah, it depends on how it is used10:45
Chipacazyga-ubuntu: i think we can ignore leap seconds though -- we're explicitly not supporting them as a valid time10:47
zyga-ubuntuChipaca: +110:47
mupPR snapd#4271 closed: spread.yaml: fix shellcheck issues and trivial refactor <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4271>10:47
mborzeckiimo, it's the same way as time.Time.Add() is not aware of DST only until you do presentation10:47
Chipacamborzecki: it all depends on how this is then used, though10:48
zyga-ubuntuChipaca: trivial 427410:50
mupPR snapd#4274 opened: spread.yaml: bump delta ref to 2.29 <Created by zyga> <https://github.com/snapcore/snapd/pull/4274>10:50
Chipacathat's a review size i can _do_10:51
* Chipaca in pain and on pain meds -- not a good combo10:51
pedronisChipaca: :(10:54
Chipacapedronis: ¯\_(ツ)_/¯10:54
mupPR snapd#4275 opened: spread.yaml,tests: move most of project-wide prepare/restore to separate file <Created by zyga> <https://github.com/snapcore/snapd/pull/4275>10:55
zyga-ubuntuChipaca: take care, I'm sorry for your pain :|10:55
zyga-ubuntuanother small refactor for spread.yaml ^10:55
zyga-ubuntu10% executed locally so I assume it's okay, rest will show up in real testing10:55
Chipacazyga-ubuntu: this one is to work with your changes to spread?10:56
zyga-ubuntuChipaca: this is all preparation work, I made so many changes trying to untangle and understand this it was impossible to review10:56
zyga-ubuntuChipaca: I can propose the spread PR for reference10:56
zyga-ubuntuChipaca: the problem is we don't really prepare/restore cleanly10:56
zyga-ubuntuChipaca: and I will hopefully changed that by EOD, without introducing any extre time costs10:57
zyga-ubuntuChipaca: have a look at spread#47 please10:57
mupPR spread#47: Add support for project-wide measure-each stanza <Created by zyga> <https://github.com/snapcore/spread/pull/47>10:57
kalikianazyga-ubuntu: I'm getting this again :-( ` open /var/lib/snapd/hostfs/home/cris/snap/lxd/common/snapcraft9xy6a3v1/core_3440.assert: no such file or directory [...] subprocess.CalledProcessError: Command '['lxc', 'file', 'push', '/home/cris/snap/lxd/common/snapcraft9clif0ke/snapcraft_x1.snap', 'helga:snapcraft-multipass/run/snapcraft_x1.snap']' returned non-zero exit status 1.`10:57
zyga-ubuntukalikiana: which of the files is missing? any denials?10:58
zyga-ubuntuChipaca: in my approach the measure-each code ensures that files on / (and just that filesystem) and outside of /tmp don't change, mount table doesn't change, packages don't change and sysctl doesn't change10:59
zyga-ubuntuChipaca: but it changes all the time as prepare/restore is a bit wonky and I need to clean it up before addressing some real problems10:59
mupPR snapd#4253 closed: task tunner: extended task runner test <Created by stolowski> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/4253>11:01
kalikianazyga-ubuntu: not that I can see...11:01
kalikianaI'm trying again with `snappy-debug scanlog` open11:02
kalikianazyga-ubuntu: this is btw snapcraft as a snap, with lxd from apt11:02
zyga-ubuntumvo: approved 427211:02
mvozyga-ubuntu: ta11:02
zyga-ubuntukalikiana: too many errors recently11:02
zyga-ubuntukalikiana: I have LXD issues to address b11:02
zyga-ubuntukalikiana: but our integration test suite is so unreliable I took a dive into it11:03
mvozyga-ubuntu: thanks again for this review, that made things a lot better (checkRefreshSchedle was pretty terrible)11:03
kalikianazyga-ubuntu: is there anything that changed in lxd recently? I'm quite sure snapcraft changed nothing11:03
zyga-ubuntukalikiana: I don't know, sorry :/11:03
mvokalikiana: there was a new stable lxd recently I think, but that is really all I know11:04
mvostable channel lxd snap to be precise11:04
mupPR snapcraft#1750 closed: kernel plugin: don't assume /lib/firmware is present if !kernel-with-firmware <Created by piso77> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1750>11:04
mvokalikiana: yesterday to be precise. and also a new cnadidate a bit later11:05
kalikianamvo: I guess I'll try if the snap suffers from the same issue - what I find super puzzling is that hostfs is in the path at all, and considering it's empty in the host that would easily explain why lxd can't access it11:05
mupPR snapcraft#1643 closed: tests: run daily autopkgtest in travis <Created by elopio> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1643>11:07
zyga-ubuntumborzecki: approved 427311:08
mborzeckita11:08
mupPR snapd#4267 closed: snapstate: move catalogRefresh into its own helper  <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4267>11:09
zyga-ubuntumvo: trivial comment on 4266 (from pedronis, not me), +2 otherwise and ready to land11:09
zyga-ubuntumvo: thank you for updating 4262 :)11:10
zyga-ubuntuChipaca: do you feel like reviewing 4254 from mvo (it's about SNAP_DID_REEXEC)11:11
zyga-ubuntu?11:11
mupPR snapd#4256 closed: snap-confine: add workaround for snap-confine on 4.13/upstream <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4256>11:11
mupPR snapd#4262 closed: store: do not log the http body for catalog updates <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4262>11:11
* Chipaca looks11:11
zyga-ubuntumvo: we still ship a configure hook in core, is the plan to remove that entirely and switch to internally-handled configuration?11:17
pedroniszyga-ubuntu: the plan is to remove it, we still have more work to do to fix 2.30 to make that possible11:27
pedronisthough11:27
zyga-ubuntupedronis: I see11:27
pedronishttps://forum.snapcraft.io/t/new-configure-snapd-task-and-reverting/277411:28
zyga-ubuntupedronis: I just noticed we do something odd in prepare code11:28
zyga-ubuntuwe enable refresh on external spread backends11:28
zyga-ubuntubut only if the configure hook exists11:28
kalikianazyga-ubuntu: concerning denials: none, I'm only seeing unrelated ones eg. Telegram now11:31
kalikianawhich makes sense if all it does is read an empty folder11:31
zyga-ubuntukalikiana: is this locally or in some CI system?11:34
zyga-ubuntukalikiana: do you have any changes on the system that is affected?11:34
kalikianazyga-ubuntu: all local, xenial with backports11:35
zyga-ubuntumborzecki: is 4270 safe to merge now?11:41
mborzeckizyga-ubuntu: yes11:42
zyga-ubuntumvo: trivial comment on 425211:42
zyga-ubuntumvo: and more comments on 427211:42
mupPR snapd#4270 closed: timeutil: remove support to parse weekday schedules <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4270>11:42
zyga-ubuntu4263 needs a 2nd review11:43
mupPR snapd#4254 closed: cmd, errtracker: get rid of SNAP_DID_REEXEC environment <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4254>11:43
zyga-ubuntumborzecki: can you finish your review o 4109, it's small and has been lingering for too long11:44
mupPR snapd#4171 closed: tests: adding test to test physical memory observe interface <Created by sergiocazzolato> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4171>11:44
zyga-ubuntumborzecki: conflicts in 427311:46
pstolowskimborzecki, .. and in 426911:49
niemeyercjwatson: Aww.. no more gimme?11:51
niemeyerHellos!11:52
cjwatsonniemeyer: thank you for the music11:52
jameshzyga-ubuntu: hi.  I was wondering if you have any ideas about how to write a spread test for my user-mounts PR.  I haven't included any interface that add user mounts at this stage, so I'm not sure where to start11:53
mborzeckipushed an update to 4273, 4269 will be fixed later as currently it will conflict with 427311:56
zyga-ubuntujamesh: I think it should be a part of the desktop interface (right?)11:59
zyga-ubuntujamesh: alternatively just use a test snap, install it, hack the profile and run update-ns12:00
zyga-ubuntujamesh: (and, more importantly, hack the profile, discard the ns and run snap-confine again so that it sets up things)12:00
jameshzyga-ubuntu: the desktop innnterface will use it for portals eventually, but that isn't part of the PR12:00
zyga-ubuntujamesh: look at the advanced content interface test for inspiration12:00
jameshzyga-ubuntu: also, what's the most convenient way to run a single spread test locally?12:01
zyga-ubuntujamesh: look at tests/main/interfaces-content-mkdir-writable12:01
zyga-ubuntujamesh: the qemu backend, you can iterate very quickly (ish)12:01
zyga-ubuntujamesh: I'm running it all the time12:01
zyga-ubuntujamesh: I pushed images to spread.zygoon.pl/images12:01
zyga-ubuntujamesh: so pick one and look at spread docs on how to use12:02
zyga-ubuntujamesh: (just put to ~/spread/qemu)12:02
jameshthanks12:02
zyga-ubuntujamesh: then SPREAD_DEBUG_EACH=0 spread qemu:ubuntu-16.04-64:tests/main/12:02
zyga-ubuntujamesh: then SPREAD_DEBUG_EACH=0 spread -debug -v -reuse qemu:ubuntu-16.04-64:tests/main/12:02
zyga-ubuntu(2nd line is better)12:02
zyga-ubuntujamesh: the desire for the spread test is to see that this really really works with confinment and what not12:03
zyga-ubuntujamesh: and weird kernels and other unexpected stuff12:03
zyga-ubuntumvo: small typo in 426612:04
zyga-ubuntumvo: small tweak needed in 425212:04
* zyga-ubuntu is trying to get the PR page list down to one 12:05
pedronis#4158 needs a 2nd review12:06
mupPR #4158: snapctl: don't error out on start/stop/restart from configure hook during install or refresh <Created by stolowski> <https://github.com/snapcore/snapd/pull/4158>12:06
zyga-ubuntulooking12:07
jameshzyga-ubuntu: okay.  fwiw, the unit tests in the PR are all passing now: it looks like the run yesterday hit some problem trying to talk to the VMs12:07
zyga-ubuntujamesh: yeah, our perpetual problem of not having a batch system12:07
cachiomvo, hey12:16
cachiomvo, looking at the issue with "Job for snapd.service canceled"12:16
cachiomvo, any idea how to deal with it?12:17
cachiomvo, retrying in case of error could be a solution?12:17
=== Son_Goku is now known as Conan_Kudo
=== Conan_Kudo is now known as Son_Goku
zyga-ubuntupstolowski: review on 415812:27
zyga-ubuntuhmm, so MATCH is in the top-level spread context, this is a problem if we want to use it in scripts :/12:27
mupPR snapd#4274 closed: spread.yaml: bump delta ref to 2.29 <Created by zyga> <Merged by niemeyer> <https://github.com/snapcore/snapd/pull/4274>12:28
zyga-ubuntuhello niemeyer :)12:29
zyga-ubuntuthank!12:29
zyga-ubuntuthanks* :)12:29
niemeyerzyga-ubuntu: Hey!12:29
niemeyerzyga-ubuntu: Man, I found your brother last night12:29
niemeyerzyga-ubuntu: https://www.youtube.com/watch?v=cHjf-YmIBCs12:30
zyga-ubuntuniemeyer: oh?12:30
zyga-ubuntuhahaha12:31
zyga-ubuntuyeah, actually he even sounds similar in some way12:31
zyga-ubuntuI hit the case where spread tarball changes while we are making it, hmmm,12:31
pedronisthat is a fun one :(12:31
zyga-ubuntumaybe once I'm done with refactoring/untangling it will become evident12:32
zyga-ubuntuI bet something is not done right somewhere12:32
zyga-ubuntuservice lingers or something like that12:32
niemeyerzyga-ubuntu: Yeah, the voice tone, the looks, and even the shirt!12:33
zyga-ubuntuniemeyer: surreal a bit :)12:33
niemeyer:P12:33
zyga-ubuntuniemeyer: my accent is better though (haha, maybe)12:33
niemeyerzyga-ubuntu: Well, not better, but less german :-)12:35
niemeyer(I don't see accents as bad in general.. just means we speak another language too)12:36
Son_Gokuaccents don't necessarily imply another language12:39
zyga-ubuntuoh god yes12:39
zyga-ubuntuI watched a review of a game recently12:39
zyga-ubuntuand geez12:39
zyga-ubuntuthis guy was unberable12:39
Son_GokuIMO, they tell a story of the person's origin and history12:39
zyga-ubuntusomewhere from US presumably but _MAN_12:40
Son_GokuI've intentionally smoothed out the accent and speech style I grew up with, because it can confuse people12:40
Son_Gokuand even then, I don't have all of it out of my speech12:41
zyga-ubuntuok, I'm done watching my weird mirror :)12:41
kalikianaSon_Goku: you're like Jack Barrowman :-D12:43
kalikianaalthough arguably his original accent is worse12:43
Son_Gokuwell, I'm not *quite* so flamboyant12:43
Son_Gokubut yes12:43
kalikianahaha, yeah12:43
Son_Gokuwell, for the first half of my childhood was spent in Indiana (US Midwest) and the second half was in Mississippi (US South), so I have bits of both in my speech12:44
zyga-ubuntuafk, see you at the call12:46
mvozyga-ubuntu: the plan is to not ship the configure hook in core, yes12:48
mvocachio: hey, thanks for chasing the "job canceled" issue, I have no good answer, a retry is certainly not a bad idea, maybe this gives us even a better idea what exactly is causing this12:50
mvozyga-ubuntu: thanks also for the reviews, I chase the open points now :)12:51
cachiomvo, I'll try it12:52
zyga-ubuntumvo: thank you! :)12:52
* kalikiana coffee break12:58
Chipacamvo: should we ask systemd peeps about that?13:00
zyga-ubuntuI'll be late 2 min13:00
zyga-ubuntuhmm13:04
zyga-ubuntusome issues joining13:04
zyga-ubuntuhmm :/13:05
mvoChipaca: its only on 14.04 and on our crufty backport13:17
Chipacamwhudson: is the plan to have go 1.10 in B?13:38
zyga-ubuntuChipaca: are you rejoining?13:44
zyga-ubuntuok, I'll break for lunch and I'll push forward in a moment :)13:48
Chipacazyga-ubuntu: question for you i think: why do osutil.Find[UG]id return a uint64?14:02
zyga-ubuntuChipaca: I believe that is what the golang 1.9 code we borrowed did do14:04
zyga-ubuntuChipaca: and we just ran along14:04
Chipacahmm14:05
* Chipaca looks14:05
zyga-ubuntuofftopic, 3C and rain, I really don't envy commuters14:05
Chipacazyga-ubuntu: golang uses strings for uids and gids14:05
Chipacazyga-ubuntu: in the os/user package14:05
Chipacaelsewhere it uses uint32's14:05
Chipaca(hilariously)14:05
zyga-ubuntuChipaca: then I don't remember, I think there were two layers of this?14:06
zyga-ubuntuChipaca: or maybe as simple and naive as what parseint returns14:06
zyga-ubuntu*uint14:07
Chipacazyga-ubuntu: also: those functions return a 0 on error, which can be bad14:08
Chipacabut i don't know if i want to fix the in this pr14:08
Chipacahmm14:08
cachioogra_, hey14:17
cachioogra_, https://paste.ubuntu.com/26020272/14:18
cachiothe timexone in ubuntu core is n/a by defaulty14:18
cachioogra_, is it a known issue?14:18
Chipacazyga-ubuntu, mvo: in snap-seccomp/main.go's findGid we check a regexp, and then call osutil.FindGid which checks a regexp14:20
Chipacazyga-ubuntu, mvo: those regexps differ14:20
Chipacazyga-ubuntu, mvo: quoth the raven, "WAT"14:20
Chipacazyga-ubuntu, mvo: ignore me, i got that wrong14:20
ogra_cachio, not that i'm aware ... file it ...14:22
cachioogra_, ok tx14:22
ogra_cachio, is that x86 or arm ?14:22
ogra_(on arm the fixrtc script checks for n/a and sets it properly, on x86 we do not use the fixrtc script afaik)14:23
zyga-ubuntumvo: the one with weirder features is probably correct14:23
zyga-ubuntuer14:23
zyga-ubuntuChipaca: ^14:23
zyga-ubuntuChipaca: can you paste them here please?14:23
cachioogra_, all of them14:24
cachioogra_, in the pi3 also14:24
Chipacazyga-ubuntu: sorry, i got confused, but let me show you how14:24
ogra_cachio, ah, well ... we should set it to UTC as default at build time i guess14:25
Chipacazyga-ubuntu: in snap-seccomp main: group must match "^[a-z][-a-z0-9_]*$"14:25
zyga-ubuntuthat is probably incorrect (just too restrictive)14:26
Chipacazyga-ubuntu: in snap-update-ns entry: x-snapd.gid must match "(^[0-9]+$)|(^[a-z_][a-z0-9_-]*[$]?$)"14:28
zyga-ubuntuthis one is correct but also matches numbers (as just direct group i)14:28
zyga-ubuntuso if you want to take one, take the latter one and remove the number part14:29
zyga-ubuntuChipaca: the 2nd one is correct, I looked at the spec and, weirdly enough, that's what valid names are14:29
Chipacazyga-ubuntu: group names can end in $ but otherwise have no $ in them?14:31
Chipacawhat does that $ mean? (i presume it's special somehow)14:31
Chipaca(i'm not changing that regexp in this round)14:31
Chipaca(next one? sure)14:31
cachioogra_, it is set to UTC but the description is n/a14:32
zyga-ubuntuyes14:32
cachioTime zone: n/a (UTC, +0000)14:32
zyga-ubuntuChipaca: it's special, it means14:33
zyga-ubuntu...14:33
zyga-ubuntuman I should have commented that somewhere14:33
ogra_cachio, yes, i see that ... but if you set it manually the description says UTC as well14:33
ogra_Time zone: UTC (UTC, +0000)14:33
Chipacazyga-ubuntu: yeah :-) a "where does this regexp come from" would be good14:33
cachioogra_, yes14:33
zyga-ubuntuChipaca: it should be in the git log14:33
* zyga-ubuntu looks14:33
ogra_so we need to find how to set it like this during build and apply that14:33
ogra_cachio, can you check if /etc/timezone says n/a on an image that exposes the issue ?14:34
zyga-ubuntuChipaca: man, I suck :/14:34
ogra_(i missed to check it before setting it ... )14:35
zyga-ubuntuChipaca: probably in the PR then14:35
zyga-ubuntuChipaca: I remember an URL with all the things explained14:35
cachioogra_, Etc/UTC14:35
ogra_interesting14:35
ogra_it doesnt say Etc here14:35
ogra_ogra@pi3:~$ cat /etc/timezone14:35
ogra_UTC14:35
cachioI have an old image14:36
cachiolet me check in a new one14:36
ogra_cachio, aha... setting it to Etc/UTC results in:14:36
ogra_Time zone: n/a (UTC, +0000)14:36
ogra_dropping the Etc/ fixes it14:36
cachiohehe14:36
cachioogra_, checking in a new image for pi314:37
cachio1 minute14:37
kalikianakyrofa: ping14:38
mupPR snapcraft#1754 opened: nodejs plugin: pass proxy configuration to yarn <Created by cjwatson> <https://github.com/snapcore/snapcraft/pull/1754>14:38
Chipacacachio: ogra_: Etc/ is a directory in tzdata14:38
ogra_Chipaca, tell that to systemd-timedated14:38
ogra_:)14:38
ogra_seems it expects not a path but a TZ name in /etc/timezone14:39
ogra_hmm, or not14:40
ogra_ogra@pi3:~$ cat /etc/timezone14:40
ogra_Europe/Berlin14:40
ogra_that works correctly14:40
ogra_only Etc/ doesnt14:40
ogra_i mean ... it shows the correct TZ (UTC) in brackets ...14:40
ogra_but n/a as description14:41
Chipacaogra_: what does list-timezones give you?14:41
ogra_though ... perhaps the test should not use the description at all14:41
ogra_and instead look inside the brackets where the actual TZ name sits14:41
Chipacaogra_: timedatectl list-timezones | grep -i etc14:41
ogra_nothing14:42
ogra_ogra@pi3:~$ sudo timedatectl list-timezones|grep -i utc14:42
ogra_UTC14:42
Chipacaso there you go14:42
ogra_ogra@pi3:~$ sudo timedatectl list-timezones|grep -i etc14:42
ogra_ogra@pi3:~$14:42
ogra_well, but thats technically correct14:42
Chipacaogra_: and what happens if you try to set the timezone to something known-bad, e.g. "potato"14:42
kalikianasergiusens: ping14:42
mupBug #1733881 opened: timezone set to n/a on ubuntu core <Snappy:New> <https://launchpad.net/bugs/1733881>14:43
ogra_ogra@pi3:~$ sudo timedatectl |grep Time14:43
ogra_       Time zone: n/a (UTC, +0000)14:43
ogra_ogra@pi3:~$ cat /etc/timezone14:43
ogra_Etc/UTC14:43
sergiusenskalikiana just speak up14:43
ogra_Chipaca, it complains14:43
Chipacaogra_: where did the Etc/UTC come from?14:43
ogra_Chipaca, my theor is that the test should really look inside the brackets14:43
ogra_Chipaca, a default14:44
ppisati$ ./runtests.sh static14:44
ppisati./runtests.sh: line 49: mypy: command not found14:44
ppisatisergiusens: ^14:44
ppisatielopio: ^14:44
ppisatikyrofa: ^14:44
ogra_Chipaca, i think thats the default tzdata ships14:44
ppisatifrom origin/master at the time of this writing14:44
sergiusensppisati pip install -r requirements-devel.txt14:44
Chipacaogra_: maybe tzdata and timedatectl conflict?14:44
ogra_might be14:44
ogra_but there is no way to omit tzdata14:45
ogra_it is super essential14:45
ppisatisergiusens: ta14:45
ogra_we'd have to completely change debootstrap and the archive setup for the package (not making it essential)14:45
kalikianasergiusens: do you know this code? I'm getting a failure in https://github.com/snapcore/snapcraft/blob/master/snapcraft/internal/sources/_local.py#L51 which uses https://github.com/snapcore/snapcraft/blob/master/snapcraft/file_utils.py#L8614:46
Chipacaogra_: are you writing /etc/timezone, or /etc/localtime?14:46
niemeyercachio: Getting an error on master while trying to run the snap-info spread test:14:46
ogra_Chipaca, only timezone ...14:46
niemeyer+ apt install -y '/home/gopath/snapd_*.deb'14:46
Chipacaogra_: might be relevant: #155480614:47
mupBug #1554806: Change of behavior: "dpkg-reconfigure -f noninteractive" unconditionally overwrites /etc/timezone now <tzdata (Ubuntu):Confirmed> <https://launchpad.net/bugs/1554806>14:47
niemeyercachio: That's bogus indeed.. the quoting kills the wildcard14:47
kalikianasergiusens: For some reason in the context of LXD on a remote machine and sshfs+sftp, it's not resolving symlinks14:47
niemeyercachio: Curious that it's not being an issue?14:47
sergiusenskalikiana most likely related to the underlying filesystem, you might need to quirk it14:48
cachioniemeyer, mmmm, I'll fix it14:48
ogra_Chipaca, well ... more an issue with writable symlinking ...14:48
ogra_ogra@pi3:~$ ls -l /etc/localtime14:48
ogra_lrwxrwxrwx 1 root root 23 Nov 22 05:24 /etc/localtime -> /etc/writable/localtime14:48
ogra_ogra@pi3:~$ ls -l /etc/writable/localtime14:48
ogra_lrwxrwxrwx 1 root root 33 Nov 22 15:39 /etc/writable/localtime -> /usr/share/zoneinfo/Europe/Berlin14:48
ogra_ogra@pi3:~$14:48
kalikianasergiusens: I noticed link_or_copy.follow_symlinks defaults to False, but shutil copytree is called with symlinks=True - that struck me as odd, but I also don't really know the code14:48
cachioniemeyer, just 1 min after I finish the fedora 2714:48
ogra_we have this multi staged symlinks there that always caused some issues14:48
niemeyercachio: Thanks.. I really wonder how that's not affecting other runs14:48
ogra_to fix atomic writing ...14:48
kalikianasergiusens: I exhausted sshfs' options more or less... it has 3 link-related options, none of which make that code path work14:49
kalikianasergiusens: where I just want to understand why it breaks in the first place14:49
kalikianaif I manually poke the files in the container, all is fine14:50
sergiusenskalikiana we've had symlink issues when the underlying fs was hfs, what does, 'poke the files in the container' mean? Through python APIs?14:50
Chipacaogra_: timedatectl will always print UTC when timezone is unset / unknown / bogus14:51
ogra_Chipaca, well, it works correct if the "Etc/" is dropped from /etc/timezone14:52
ogra_i.e. if the tz entry matches what list-timezones provides14:52
ogra_the easiest would simply be to put UTC into /etc/timezone at build time14:52
kalikianasergiusens: I mean doing `ls -la` or `cat` on the files that give me "[Errno 2] No such file or directory" in Python14:53
ogra_but OTOH i still think the test is wrong to match the description and not the TZ14:53
sergiusenskalikiana broken symlinks do that in python14:53
ogra_it should look between the brackets, not at the descriptive name14:53
ogra_i.e.14:54
ogra_Time zone: Europe/Berlin (CET, +0100)14:54
ogra_you want to match CET here, not "Europe/Berlin"14:54
ogra_(since this will also be what date uses for example ... the rest is just nice to have but not technically relevant)14:55
kalikianasergiusens: right, except I can access the very same files from the container through sshfs via ls and cat14:55
kalikianaI might be overlooking something here14:55
kalikianasergiusens: if it's relevant, it's all relative links14:55
sergiusenskalikiana break the code in pieces by writing small implementations or activate the debugger (pdb)14:57
kalikianayeah, that's what I'll do now, just wanted to query if there were any obvious gotcha's with the current code15:02
kalikianathanks15:02
niemeyerI honestly don't understand.. it consistently fails every single time for me.. how come we don't have broken tests in travis15:06
Chipacaniemeyer: what fails for you?15:08
niemeyerChipaca: + apt install -y '/home/gopath/snapd_*.deb'15:09
niemeyerChipaca: This can't possibly work.. the quoting kills the wildcard15:09
cjwatsonIt probably turns into a regex interpreted by apt, so might work if it's actually called snapd.deb?15:10
cjwatsonhttps://travis-ci.org/snapcore/snapcraft/jobs/305836865 doesn't obviously seem to be my problem (this is for https://github.com/snapcore/snapcraft/pull/1754, which doesn't change anything in that area) - known breakage?15:10
mupPR snapcraft#1754: nodejs plugin: pass proxy configuration to yarn <Created by cjwatson> <https://github.com/snapcore/snapcraft/pull/1754>15:10
Chipacaniemeyer: where is that command coming from?15:12
Chipacaniemeyer: (grep doesn't find it here)15:12
mvoChipaca: what command?15:13
Chipacamvo: the apt install -y '...'15:13
cjwatsonso set -x output is a bit misleading here15:14
cg_hey everyone. i'm new to snapcraft and trying to wrap my head around what are probably some simple concepts. right now, the issue is that i have two dependencies, currently defined as parts, and one needs to know the path of the other, or at least a path to some files that need to be shared so it can build.15:14
cjwatsontests/lib/prepare.sh:        distro_install_local_package "$GOHOME"/snapd_*.deb15:14
cg_could anyone help me figure this out?15:14
niemeyerChipaca: Must be distro_install_build_snapd15:14
cjwatsonit then gets quoted when distro_install_local_package calls   apt install $flags "$@"15:14
Chipacacjwatson: niemeyer: but distro_install_local_package "$GOHOME"/snapd_*.deb <- the * isn't quoted15:14
cjwatsonand set -x renders that as single-quotes, but that doesn't mean it was called that way15:14
Chipacaah15:14
cjwatsonthe problem is that snapd_*.deb didn't exist so the glob didn't expand15:14
cjwatsonand something didn't pick that up as a failure earlier when it would have been 90% less confusing15:15
cjwatson(or, yes, possibly from distro_install_build_snapd as the caller; same either way)15:15
niemeyercjwatson: Yeah, that must be it15:16
niemeyerEither it's failing, or the prepare is just bogus and is not doing what it should15:16
niemeyerThe only thing I'm doing special here is to try to run a single test instead of the whole suite15:17
niemeyerlinode:ubuntu-16.04-64:tests/main/snap-info15:17
mupPR snapcraft#1749 closed:  tests: add a script to run autopkgtests in the ppa  <Created by elopio> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1749>15:17
* zyga-ubuntu is done with the kids and returns to work15:23
mvozyga-ubuntu: hm, the debian-sid tests are slightly strange, it fails with "snap-confine has elevated permissions and is not confined but should be. Refusing to continue to avoid permission escalation attacks", I think I try to ssh into one15:24
zyga-ubuntumvo: looks like snap-confine is built without apparmor15:26
zyga-ubuntumvo: we may need to change the dpkg vendor test (remove it) in debian/rules15:26
zyga-ubuntumvo: hmmm, actually15:27
zyga-ubuntumvo: that probably makes no sense15:27
mvozyga-ubuntu: I thought I had done that already15:28
zyga-ubuntumvo: yeah, worth looking into for sure15:29
* zyga-ubuntu listens to "not your kind people" today15:29
mupPR snapd#4263 closed: overlord/devicestate:  best effort to go to early full retries for registration on the like of DNS no host <Created by pedronis> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4263>15:36
gsilvakyrofa:  have you seen the PR? It failed for some reason but I can't tell why15:38
gsilvaHello all, by the way15:38
mupPR snapd#4109 closed: cmd/libsnap: fix parsing of empty mountinfo fields <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4109>15:38
zyga-ubuntupedronis: posted question on 426015:42
cg_Anyone available to help with what I'm gonna guess are some pretty basic questions?15:43
zyga-ubuntucg_: just ask your questions please, we'll do our best15:44
cg_Yeah, tried that before but didn't want to just keep spamming...15:45
cg_Alright, so I'm building a ROS project. It has two dependencies that I've been installing outside of ROS: our ethercat kernel modules and a library that provides an interface to ethercat.15:46
pedroniszyga-ubuntu: that's auto-import, not the store,  not sure what those files are though15:46
pedronisleft overs?15:46
zyga-ubuntucg_: are you working on a classic or a core device? (classic = with typical package manager + snapd on the side; core = with just snapd)15:47
pedronisI would need to dig more15:47
zyga-ubuntupedronis: aha15:47
zyga-ubuntupedronis: my measurement code can capture that15:47
zyga-ubuntupedronis: thanks for looking15:47
zyga-ubuntupedronis: I'll untangle the restore code and will be able to find those (hopefully) quickly15:47
zyga-ubuntucg_: btw, kyrofa here is a ros expert15:47
zyga-ubuntucg_: for kernel modules on core device you will need your own kernel + gadget snap15:47
kyrofakalikiana, pong15:48
cg_zyga-ubuntu: i'm working with classic right now, hoping to move to core15:48
zyga-ubuntucg_: we may need a snapd interface for the ethercat but I don't know what this, just speculating so far15:48
zyga-ubuntucg_: ok15:48
zyga-ubuntucg_: that's fine, it's a well-defined move for this kind of thing15:48
cg_zyga-ubuntu: so before i even start dealing with the kernel nonsense, i'm trying to get my head around what feels like some real Snapcraft 101 crap. I need to provide the paths to different dependencies so they can install correctly. The interface that helps us communicate with our ethercat driver needs to know the path to the ethercat library, and then ROS needs to know the path to the interface.15:50
kalikianakyrofa: Hey. Was wondering about file_utils.py / _local.py if you happend to know about its custom handling of symlinks. I'm doing some testing atm why the code would say "file not found" when ls and friends are happy with the files15:51
cg_zyga-ubuntu: In my manual install world, I'd just clone my repos into ~/, build from there, point to ~/EtherCAT_Master or whatever15:51
zyga-ubuntucg_: path as in runtime path or build time?15:51
kyrofakalikiana, I am familiar with it, could you give me more details?15:52
zyga-ubuntucg_: suggestion: unless you absolutely must, try to snap hello world code first to see what you get and how it is built15:52
cg_zyga-ubuntu: I'm gonna need both. Totally hung up at build time right now.15:52
zyga-ubuntucg_: and then how it operates (both are differnt)15:52
zyga-ubuntucg_: I know ... little about ros (/me looks at ROS topic mug from roscon) but build time should be handled by snapcraft15:52
cg_zyga-ubuntu: these aren't ROS dependencies, as far as it is concerned. they're just C libraries that we reference, ROS has no idea what to do with them.15:53
zyga-ubuntucg_: if not kyrofa or sergiusens can help you and make fixes to snapcraft; you can also ask on the forum (forum.snapcraft.io) or talk in rocket.ubuntu.com (snapcrafters hang out there routinely)15:53
zyga-ubuntucg_: I'm mostly focused on runtime side of snapd15:53
cg_zyga-ubuntu: The ROS aspect of this really doesn't matter. If I install these dependencies manually, my ROS part builds happily, everything works great. I'm just trying to cut out the manual steps.15:54
cg_zyga-ubuntu: But yeah, right now, I'm hung up on building15:54
zyga-ubuntucg_: are those things packaged in some way?15:54
zyga-ubuntucg_: snapcraft has a concept of "build packages"15:55
zyga-ubuntucg_: (with the usual meaning)15:55
cg_zyga-ubuntu: They are, but it feels sorta... hacky. Ignoring what they're actually called, Dependency 2 has the path to Dependency 1 hard-coded. I can feed it a path, I'm just lost RE: what that path should be in snapcraft world. Make sense?15:56
mvoChipaca: hm, hm, all the except tests are failing in debian-sid. I have a look in a bit15:57
Chipacamvo: expect*?15:58
cg_zyga-ubuntu: Normally, I can just point it at the repo that I've cloned to my home folder. With snapcraft handling it and each dependency broken into separate parts, I'm unsure of how to tell Dependency 2 how to find Dependency 1. It doesn't feel like a healthy practice but I'm unsure of how Snapcraft would prefer me to approach it.15:58
kyrofaHey there cg_, are we talking about https://forum.snapcraft.io/t/part-referencing-other-part/2929/3 ?15:59
mvoChipaca: eh, yes15:59
Chipacamvo: :)15:59
cg_kyrofa: Hello! Yessir15:59
mvoChipaca: anyway, just wanted to let you know, I need to take a break now15:59
Chipacamvo: np15:59
kalikianakyrofa: so this is with a LXD container and files served via sshfs/sftp, which means smylinks might work differently; the error I'm getting is at https://github.com/snapcore/snapcraft/blob/master/snapcraft/internal/sources/_local.py#L51 which uses https://github.com/snapcore/snapcraft/blob/master/snapcraft/file_utils.py#L86  -- it's giving me a shutil.Error with a list of files and [Errno 2] No such file or directory in the end16:00
kalikiana- all the given symlinks resolve  fine with ls or cat in a shell in the container, just the specific snapcraft code doesn't work16:00
kyrofacg_, I asked a question there for you16:00
cg_kyrofa: Thanks, on it16:00
zyga-ubuntu2PRs short of one page16:02
zyga-ubuntusome just wait for tests16:02
zyga-ubuntumvo: can you please look at 414016:02
zyga-ubuntumvo: it's green and has +1 from me16:02
zyga-ubuntumvo: with a quick look we can get down to 26 PRs16:02
mupPR snapd#4184 closed: tests: adding new test for uhid interface <Created by sergiocazzolato> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4184>16:02
pedronisChipaca: anyway firt pass at that issue is probably remembering who did what,  unless the store apis change radically16:03
Chipacapedronis: … which issue?16:04
* Chipaca is lost16:04
pedronisChipaca: us sending no auth with auto refreshes16:04
Chipacapedronis: ah16:05
zyga-ubuntupstolowski: 4218 needs a 2nd look from you16:06
pstolowskizyga-ubuntu, ok, looking16:07
pedronismvo: do we run autopkgtest daily?16:07
pstolowskicachio, I think you forgot to push your changes to #421816:17
mupPR #4218: tests: adding tests for time*-control interfaces <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/4218>16:17
cachiopstolowski, almost pushed16:18
cachio1 min please16:18
pstolowskicachio, sure, np16:18
zyga-ubuntucachio: comment son 407816:20
cachiopstolowski, push donedone16:21
pstolowskiok16:24
cachiozyga-ubuntu, done16:26
cachiozyga-ubuntu, wait16:26
cachiozyga-ubuntu, now :)16:26
mupPR snapd#4273 closed: timeutil: introduce helpers for weekdays and TimeOfDay <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4273>16:27
zyga-ubuntucachio: thank you!16:27
zyga-ubuntucachio: I'm really curious what that about16:27
cachiozyga-ubuntu, yaw16:27
cachiozyga-ubuntu, yes, it is really weird, but I could reproduce it even manually16:27
zyga-ubuntucachio: do you know if any snaps were installed after reboto?16:28
zyga-ubuntu*reboot16:28
cachiono, I just reproduces the test but manually16:29
cachiojust to make sure the test was working properlyu16:29
zyga-ubuntuinteresting16:29
zyga-ubuntuwell, we'll keep digging16:29
* ikey grins in advance of teaching niemeyer that rolling can be stable16:30
mupPR snapd#4275 closed: spread.yaml,tests: move most of project-wide prepare/restore to separate file <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4275>16:31
pstolowskiniemeyer, pedronis updated 4259 with new test16:31
zyga-ubuntuChipaca: if around, could you do 427616:31
mupPR snapd#4276 opened: tests: document and slightly refactor prepare/restore code <Created by zyga> <https://github.com/snapcore/snapd/pull/4276>16:32
zyga-ubuntucachio: can you also look please, there's one XXX thre I don't fully understand and I suspect you know16:32
Chipacazyga-ubuntu: ◯16:32
sergiusenszyga-ubuntu we do not use rocket anymore16:33
zyga-ubuntuChipaca: emoji don't show up in linux console16:33
zyga-ubuntusergiusens: oh, I didn't know thanks for sharing that16:33
zyga-ubuntuI wish forum and rocket could merge shomehow16:33
zyga-ubuntubut IRC is just so darn immortal16:33
niemeyerikey: I literally said "anyone publishing such snaps needs to understand and agree to preserve a stable API", to which you responded "that’s not gonna happen"16:33
Chipacazyga-ubuntu: 💩16:33
niemeyerikey: I never even touched the word "rolling"16:33
ikeywoah woah16:33
ikeyback up a bit there sham16:33
ikeyim poking fun16:33
ikeydidnt realise there was a bear on the end of it16:34
ikeythe way you worded it was "frozen forever"16:34
ikeyand thats not gonna happen16:34
ikeystable yes, locked, no16:34
ikeydistinction. :]16:34
niemeyerikey: I also didn't say "locked" either :-)16:34
niemeyerikey: Or "frozen"16:34
ikeysure - i was replying to my interpretation based on the facts provided to me by you. notice i still agreed to a call as it was clear not all facts are present on both sides ;)16:35
niemeyerikey: We just need it stable.. which means existing functionality cannot be removed or broken16:35
zyga-ubuntuikey: where there's honey, there's bear ;-)16:35
niemeyerIncluding both APIs and ABIs16:35
* zyga-ubuntu just makes up proverbs16:35
ikeyABIs *can* be changed16:35
ikeyThis is rolling, by design they need to16:35
ikeyAnd this isn't a derivable snap, it exists purely to satisfy LSI :P16:36
niemeyerSure.. then it can't be a base snap16:36
ikeywell then ill fuck off and build a flatpak16:36
ikeycya16:36
niemeyerikey: That's why a hangout is probably better :)16:36
ikeyat this point niemeyer you insult me after having kept me waiting over a week with this tiresome review only to tell me what can and cant be in a base snap16:37
ikeywithout understanding the fundamentals of the situation16:37
ikeyseriously i dont need snaps as much as snaps need external verification and technical acceptance16:37
ikeyi dont need the politics and stress of it16:37
kalikianasergiusens: did you see my email?16:38
niemeyerikey: I'd still prefer to have this conversation on a hangout.. the few sentences I wrote aren't really personal at all.. I'm politely trying to explain the issues we're trying to address, and looking for help16:39
ikeyas am - i cant word too good because im trying to stick a boot on at the same time16:40
ikeylaces are hard16:40
ikeyand fwiw im not personally insulted - there are levels :p16:40
ikeybut im not against a phone call16:40
niemeyerikey: https://hangouts.google.com/call/PwzjjN4oHDxFeAyGDiJ_AAEE16:40
ikeyyeah gizza sec genuinely fighting with a boot here16:40
sergiusenskalikiana the one I replied to?16:41
niemeyerWill grab a cuppa coffee meanwhile... HO still open16:41
mupPR snapd#4266 closed: snapstate: add new refresh-hints helper and use it <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4266>16:42
niemeyerIf anyone else closely involved with base snaps wants to join, that's welcome too16:42
niemeyermvo, jdstrand ^16:42
kalikianasergiusens: I don't see a reply... not on my phone either, in case this was tb being broken16:43
zyga-ubuntucachio: you have comments on 422716:45
zyga-ubuntucachio: looks like super simple ones16:45
cachiozyga-ubuntu, ok, finishing fedora resizing16:46
zyga-ubuntucachio: thank you16:46
sergiusenskalikiana check your spam and filters (look in AllMail)16:47
kalikianasergiusens: I don't have any spam filters, this is good old canonical imap16:47
ikeyo-o16:51
ikeycall closed16:51
zyga-ubuntuikey: what happened?16:53
ikeyfixed ^^16:54
sergiusenskyrofa elopio can you join me on a hangout right now?17:02
kyrofasergiusens, sure17:02
sergiusenskyrofa use the weekly17:03
kyrofasergiusens, I'm there17:04
elopiosergiusens: on my way17:04
zyga-ubuntu14.04 has something very very wrong17:20
zyga-ubuntusnapd starts randomly when it is supposed to be down17:20
zyga-ubuntucannot wait to find the culprit17:20
pedronisthat is interesting17:25
cachioniemeyer, I dont see dsingle cuotes use to install any package17:28
cachioniemeyer, while I try to see why the snap-info test failedf17:29
cachioniemeyer, do you have any log?17:29
* zyga-ubuntu breaks for some rest, will return to push more branches 17:41
=== cachio is now known as cachio_afk
zyga-ubuntuso, why is main never failing17:50
zyga-ubuntuI'm running main all the time, almost, for the past two days17:50
zyga-ubuntucould it be that one of the "lesserly interesting" tests in other suites is messing things up17:50
zyga-ubuntumvo: question, could we get a different entry in travis, one for running main and one for running all the things but main17:51
zyga-ubuntumvo: we'd use more machines but they would also run much more quickly17:51
zyga-ubuntumvo: and I suspect a pattern would emerge17:51
zyga-ubuntumvo: (maybe even run suites independently from each other)17:51
zyga-ubuntumvo: (like one status per suite)17:51
zyga-ubuntumvo: this could have 3 advantages: restarts would be per suite, we'd get data about relative rate of random errors in each suite17:52
zyga-ubuntumvo: and we could perhaps lower the number of workers17:52
zyga-ubuntu(or keep workers and get super-fast results)17:52
zyga-ubuntuif main is working on my "consumer" home network it should not fail any less on the fancy datacenter speedy network and CPUs17:53
zyga-ubuntuand meanwhile, I'll see what I get if I run other suites17:54
zyga-ubuntuI'd be really upset if it was like upgrade/basic killing our time by leaving junk17:54
mupPR snapd#4272 closed: snapstate: ensure RefreshSchedule() gives accurate results <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/4272>17:58
mupPR snapd#4277 opened: osutil/user: replace our uses of os/user and filepath.Glob("/home/*") <Created by chipaca> <https://github.com/snapcore/snapd/pull/4277>17:58
Chipaca12 37 files changed, 741 insertions(+), 309 deletions(-)17:58
Chipacas/^12//17:59
Chipaca:-/17:59
Chipacaanyway, EOD for me17:59
zyga-ubuntuChipaca: hohoho17:59
zyga-ubuntuChipaca: oooh17:59
zyga-ubuntuChipaca: please please please17:59
Chipacazyga-ubuntu: wut17:59
zyga-ubuntuChipaca: 427617:59
zyga-ubuntuChipaca: just a look17:59
* Chipaca justs a look17:59
zyga-ubuntuChipaca: per commit diff is easier to read18:00
Chipacazyga-ubuntu: nice18:03
Chipacazyga-ubuntu: http://gph.is/QUEGv318:04
* zyga-ubuntu types the URL on another computer18:04
zyga-ubuntuLOL18:05
zyga-ubuntuChipaca: thanks, enjoy your evening18:06
zyga-ubuntuChipaca: should we retry 504s from the store?18:11
zyga-ubuntusnap install --channel=beta core18:11
zyga-ubuntuthat just failed with received an unexpected http response code (504)18:11
ikeyzyga-ubuntu, qemu-static arm64 for /bin/sh - go!18:16
ikeydefinitely the most evil idea ive had all year.18:16
zyga-ubuntuikey: heh, that might actually work pretty well18:17
zyga-ubuntu*for some definition18:17
ikeyXD18:17
zyga-ubuntusingle threaded18:17
zyga-ubuntuand ... static18:17
ikeylol18:17
zyga-ubuntu(insert meme with dog and "LOL", "so static", "enterprise", "runs on RHEL6"18:17
ikeyyeah but if its not running on btrfs..18:18
zyga-ubuntuoh, why?18:18
ikeyidk you said lol and enterprise18:18
ikeyfelt relevant18:18
zyga-ubuntuikey: RHEL defines enterprise as RHEL and they define btrfs as xfs (or something)18:18
zyga-ubuntu;-)18:18
zyga-ubuntuI like the "runs on RHEL6" as a meme thing18:19
ikeylol18:19
* ikey used to live by reiserfs18:19
ikeyemphasis on used to18:19
niemeyercachio_afk: There's some other bug18:22
niemeyercachio_afk: You should be able to reproduce it by just running spread to run this one task: linode:ubuntu-16.04-64:tests/main/snap-info18:23
niemeyercachio_afk: The bogus command line, as cjwatson mentioned, is just a side effect of snapd not being properly built18:23
niemeyercachio_afk: The question is why it wasn't properly built18:23
niemeyerTaking a break.. back later to finish the images18:25
zyga-ubuntuniemeyer: o/18:26
zyga-ubuntuniemeyer: we're on one page now ^_^18:26
ikeyhttps://github.com/solus-project/runtime-snaps/commit/f91097d47fc1fce231110c87c2469a3f74df0a37 <- better.18:32
* zyga-ubuntu -> shopping18:35
zyga-ubuntujdstrand: hey19:51
zyga-ubuntujdstrand: not much updates today, I'm getting tea and I'll iterate on both interesting PRs19:51
zyga-ubuntujdstrand: I'm pushing towards finding why test suite is so unreliable19:51
=== cachio_afk is now known as cachio
niemeyercachio: We've got multiple issues in our suite apparently20:36
niemeyercachio: One of them is prepare-project.sh seems to be missing set -e, which means it's not stopping on errors20:38
cachioniemeyer, let me see20:38
niemeyerThe build procedure is also for some reason not building _build/snap, which is depended upon for building the man pages20:38
niemeyerThat's the error that makes the snapd_*.deb not be generated20:39
niemeyercachio: I got this sort of error by just trying to run the task mentioned above20:41
niemeyercachio: Possibly means I have a dirty tree.. I'll try again with a clean tree, but we should at least ensure all our scripts have -e so they fail on problems20:41
cachioniemeyer, ok, I jast reviewed the log and "set -e" was not removed from prepare-project20:42
cachioniemeyer, at least during the last 6 months20:42
niemeyercachio: Well, does that matter? :)20:43
cachioniemeyer, we should add it20:43
niemeyerYeah20:43
niemeyercachio: We can also take the chance to grep quickly and see if there are others missing20:43
cachioniemeyer, doing that20:44
cachioniemeyer, most of the scripts on tests/lib dont have "set -e"20:45
niemeyercachio: Some of them are used as libraries, so that's less of an issue I *think*20:46
niemeyercachio: Won't hurt to have it, though20:46
cachioniemeyer, agree20:47
cachioI'll create a PR with that20:47
niemeyercachio: Thanks20:47
cachioniemeyer, by the way, snapd-vendor is being sync20:47
niemeyercachio: Looking into Spread-46 now20:47
cachioniemeyer, ok, I am testing debian-920:47
cachioI'll push the changes once there are not errors anymore20:48
niemeyercachio: Spread-46 has *grown* since we last tried20:54
niemeyercachio: It's now at 2.2GB20:54
cachioI removed about 200 MB20:54
niemeyerDid you try the zero trick?20:54
cachioyes20:55
niemeyer(after that)20:55
cachioyes20:55
cachiothe last think I did20:55
cachiolet me check again20:55
niemeyerWell.. something curious is happening.. it's now larger20:56
niemeyercachio: I'm booting it back up.. should take a few seconds20:56
cachioniemeyer, I could remove some locales that are using more than 100MB21:06
cachioniemeyer, not sure if it could affect anything21:11
niemeyercachio: It's certainly less wasted space in the image21:13
niemeyercachio: But it still doesn't explain why removing data made the image larger21:13
niemeyercachio: Something else must have happened there21:13
niemeyercachio: Does it have auto-update on, maybe?21:13
cachioniemeyer, it just updates repo metadata21:15
cachioI could disable it but not sure if then it could cause any issue21:15
cachioniemeyer, well it is alreasy disabled21:16
cachioniemeyer, could you try again to build the image?21:21
niemeyercachio: Sure, trying it now21:21
cachioniemeyer, the only thing that it missing is to remove the locales21:22
niemeyercachio: It's back at 1.7GB21:25
niemeyercachio: 1.76, to be more precise21:25
niemeyercachio: What did you do there?21:25
cachiocleaned up again dnf and removed 1 pkg and the zyga magic21:26
zyga-ubuntutry e4defrag21:26
zyga-ubuntuthat may clear extra blocks for zero21:26
zyga-ubuntu(zero after)21:26
cachiook21:27
cachioniemeyer, could you please start the vm?21:27
niemeyerIt's coming up21:28
cachioniemeyer, could you please try againdf21:43
niemeyercachio: On it21:43
cachio1gb of data used21:43
cachiolocales removed21:44
niemeyercachio: 1.6G image21:46
cachioniemeyer, how do you create the image? it is a linode api?21:49
niemeyercachio: Using the console.. I don't think there's an API yet21:50
niemeyercachio: copy the disk, shutdown the machine, attempt to shrink the disk21:51
niemeyercachio: trash it, start over21:51
cachiothe shrink is not so powerfull :)21:52
niemeyercachio: It's just resize2fs22:02
niemeyercachio: We can try e4defrag22:04
cachioI already did in the vm22:05
cachioniemeyer, not sure if you can do it from the console22:05
niemeyercachio: Oh22:05
niemeyercachio: Ok.. so really have no idea about why it's not getting down to more reasonable sizes22:05
cachiodisk usage is less than 1.1 GB22:06
cachioniemeyer, I checked that at the end22:06
niemeyercachio: Well, that's logical size22:07
niemeyercachio: Image is block size22:07
niemeyercachio: A 1 byte file still takes one block22:07
niemeyerSort of.. file system pages vs. blocks..22:08
gsilvaptkyrofa, since you are around, could you please have a look PR 1746? The build failed but I don't think it is entirely related with poor software quality22:08
mupPR #1746: many: have AuthContext expose device store-id, serial and serial-proof signing to the store <Critical> <Reviewed> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/1746>22:08
niemeyercachio: Can we take more data out of it?22:09
kyrofagsilvapt, will do, working on something else at the moment but I'll take a look when I can22:09
gsilvaptkyrofa, of course, take your time! :-)22:09
cachioniemeyer, if you want I could create a new image from scratch22:10
cachioinstall deps and see the size22:10
niemeyercachio: Sounds good.. another approach would be doing what I suggested yesterday, listing packages ordered by size and taking low hanging fruits out22:13
niemeyercachio: Whatever you prefer22:13
cachioniemeyer, I already did that22:14
cachioI cleand 200MB doing this22:14
cachiocleaned22:14
niemeyercachio: Yeah, so more of it? :)22:14
cachioniemeyer, well, the problem is that the bigger ones seem to be needed, I can make another try22:15
cachioand remove more pkgs22:15
niemeyercachio: That's what I did when I got our images down to 600MB, but again any approach you prefer is fine by me22:17
cachioniemeyer, ok, I'll try it tomorrow morning22:18
niemeyercachio: Thanks again22:18
cachiozyga-ubuntu, https://travis-ci.org/snapcore/snapd/builds/305892636#L147322:21
cachiozyga-ubuntu, there it is the info for the "no interfaces found" issue22:22
zyga-ubuntucachio: I'll check it out tomorrow, I'm sleeping here almost :)22:30
cachiozyga-ubuntu, sure, just I wanted to leave you a message for tomorrow22:30
cachiozyga-ubuntu, enjoy your dreams :)22:31
sergiusenskyrofa elopio kalikiana https://insights.ubuntu.com/2017/11/22/announcing-snapcraft-2-35/22:39

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!