| cholcombe | any word on installing snappy in centos7? | 00:14 |
|---|---|---|
| cholcombe | i saw a few bug report notes but nothing to indicate i could use it | 00:14 |
| mwhudson | soo | 00:30 |
| mwhudson | i have a snap with a plugin | 00:30 |
| mwhudson | the plugin depends on pyelftools | 00:30 |
| mwhudson | i have python3-pyelftools in my snap's build-packages | 00:30 |
| mwhudson | if i build with the dpkg snapcraft, this works fine | 00:31 |
| mwhudson | but if i build with a snapped snapcraft, the plugin can't import the dependency | 00:31 |
| mwhudson | any ideas? | 00:31 |
| sergiusens | mwhudson yeah, does it use ctypes? If that is the case, we have a patched up library finder | 00:53 |
| mwhudson | sergiusens: no | 00:53 |
| mwhudson | sergiusens: the games this plugin is up to will stop being relevant when classic snap creation gets fixed properly though :) | 00:53 |
| sergiusens | mwhudson oh, this is like a venv ignoring system packages | 00:53 |
| mwhudson | sergiusens: yes, i guess so, i think the PYTHONPATH for the snapcraft process only includes things from the snapcraft snap, and the plugin runs in the same process so... | 00:54 |
| sergiusens | mwhudson yeah, we don't set any PYTHONPATH though, we just rely on the default sys.prefix setup by python itself | 00:55 |
| mwhudson | sergiusens: well ok | 00:59 |
| mwhudson | i guess the general case is "how do i write a plugin that has an external (python) dependency" | 00:59 |
| mwhudson | maybe the answer is "don't do that" | 00:59 |
| gsilvapt | kyrofa, I was taking a look at the issue and now my problem is something else. Is there a variable with the value Snapcraft I can get to pass in to %(prog)? | 01:33 |
| mborzecki | morning | 06:08 |
| === chihchun_afk is now known as chihchun | ||
| mup | PR snapd#4372 closed: snap: YAML and data structures for app before/after ordering <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4372> | 06:36 |
| mup | PR snapd#4352 closed: tests: increase amount of workers for ubuntu-16.04-64 by one <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/4352> | 06:38 |
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| mborzecki | mvo: morning | 07:40 |
| mvo | hey mborzecki | 07:41 |
| mborzecki | mvo: have you seen #4326 maybe? | 07:49 |
| mup | PR #4326: interfaces/builtin: blacklist zigbee dongle <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/4326> | 07:49 |
| mborzecki | i wonder if there's a way to ship extra udev rules with such quirks as separate files read at runtime rather than embedding them in snapd code | 07:51 |
| mvo | mborzecki: I have seen it but didn't pay close attention (yet) | 07:51 |
| mvo | mborzecki: right, thats a gustavo topic, we discussed this a long time ago and then the conclusion was that we want it centralized for now | 07:51 |
| mvo | mborzecki: but "now" maybe well be past now, especially when there is a compelling use-case | 07:52 |
| mborzecki | the thing fixed in the pr seems to be a workaround for a very specific hardware | 07:52 |
| mborzecki | wouldn't be surprised if that's even some engineering unit that reports bad vid/pid (not like i haven't seen things like such things in the past) | 07:53 |
| kalikiana | morning | 07:55 |
| * kalikiana coffee | 07:55 | |
| mup | PR snapd#4376 opened: tests: fix external backend for tests that need DEBUG output <Created by mvo5> <https://github.com/snapcore/snapd/pull/4376> | 07:58 |
| mvo | mborzecki: *nod* no disagreement, we need to discuss with gustavo | 07:58 |
| mborzecki | mvo: https://forum.snapcraft.io/t/refresh-time-should-next-conform-to-core-api-schedule/3088 weekday schedule is not supported right? | 07:58 |
| mvo | mborzecki: correct, the current snapd only supports settings inside the 24h window | 07:59 |
| mvo | mborzecki: your work will fix this :) | 08:00 |
| mvo | mborzecki: feel free to reply and pitch your branch | 08:00 |
| mvo | mborzecki: the fact that this it not rejected outright is a bug that I think we fixed in 2.30 | 08:00 |
| mborzecki | thanks :) | 08:09 |
| mborzecki | pstolowski: morning | 08:17 |
| pstolowski | mborzecki, hey! | 08:17 |
| mvo | hey pstolowski ! | 08:22 |
| mborzecki | hm we really should be doing `set -e` in all scripts | 08:27 |
| mborzecki | /home/gopath/src/github.com/snapcore/snapd/tests/lib/mkpinentry.sh: 3: /home/gopath/src/github.com/snapcore/snapd/tests/lib/mkpinentry.sh: MATCH: not found | 08:27 |
| mborzecki | this script is ran instead of being sourced in the tests | 08:27 |
| pstolowski | mborzecki, sounds sensible to me | 08:32 |
| mvo | mborzecki: +1 | 08:34 |
| mborzecki | or we could tweak spread to write MATCH to ~/.bashrc even if not runnig with -shell or -debug | 08:34 |
| mup | PR snapd#4377 opened: tests/main: source mkpinentry.sh <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4377> | 08:37 |
| mup | PR snapd#4378 opened: tests: do not disable refresh timer on external backend <Created by mvo5> <https://github.com/snapcore/snapd/pull/4378> | 08:37 |
| * mvo runs the full pi3 validation after fixing the known issues | 08:39 | |
| === __chip__ is now known as Chipaca | ||
| mup | PR snapd#4379 opened: client: send all snap related bool json fields <Created by mvo5> <https://github.com/snapcore/snapd/pull/4379> | 09:22 |
| Chipaca | pstolowski: ping | 09:56 |
| pstolowski | Chipaca, hey | 09:56 |
| Chipaca | pstolowski: hiya | 09:56 |
| Chipaca | pstolowski: what's required of a hook in order for a user to run it? unix permissions wise | 09:57 |
| Chipaca | pstolowski: are hooks run as root, or as the user? | 09:57 |
| pstolowski | Chipaca, they are run by snapd, so root | 09:58 |
| === chihchun is now known as chihchun_afk | ||
| Chipaca | pstolowski: pedronis: if you think of anything further we should do on https://forum.snapcraft.io/t/incorrect-permissions-in-meta-snap-yaml/1161/7 please raise it there | 10:01 |
| mvo | mborzecki: hey, mind if I write a tiny snap-mgmt test? its the perfect task while waiting for a pi3 execution of tests. or have you started already? | 10:09 |
| mborzecki | mvo: go ahead, i haven't started working on it yet | 10:10 |
| mvo | mborzecki: great, will push a PR in some minutes | 10:11 |
| pedronis | Chipaca: we should ping jdstrand to have checks like that in review-tools | 10:12 |
| pedronis | snapd is useful but very late here | 10:12 |
| pstolowski | mborzecki, #4357 looks very nice, but one question | 10:16 |
| mup | PR #4357: wrappers: autogenerate After/Before in systemd's service files for apps <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4357> | 10:16 |
| mborzecki | pstolowski: thanks for the review | 10:17 |
| mup | PR snapd#4380 opened: tests: add simple snap-mgmt test <Created by mvo5> <https://github.com/snapcore/snapd/pull/4380> | 10:26 |
| mborzecki | i'm adding those workarounds for /dev/random running out of entropy, but gpg called in snap create-key is smart, looks like it's using the real random device anyway | 10:31 |
| mvo | mborzecki: woah, annoying | 10:32 |
| Chipaca | pedronis: the whole stack should check, yes | 10:35 |
| mborzecki | mvo: right, so there's a gpg agent, and it seems that it's started while proper /dev/random is still around | 10:56 |
| pedronis | mborzecki: yes, if the distro is usigng gpg 2.x | 11:00 |
| pedronis | it can be restarted though (don't know the exact incantation) | 11:01 |
| mborzecki | pushed a fix with `pkill -e gpg-agent`, i tried `gpgconf --kill gpg-agent` but that wasn't reliable at all | 11:17 |
| popey | kyrofa: seen https://bugs.launchpad.net/snapcraft/+bug/1736963 ? | 11:41 |
| mup | Bug #1736963: "snapcraft enable-ci travis" won't accept my password <Snapcraft:New> <https://launchpad.net/bugs/1736963> | 11:41 |
| popey | kyrofa: i was writing some simple travis docs but fail because that command is broken | 11:41 |
| mvo | mborzecki: nice find! | 11:49 |
| * kalikiana need to take a short break | 12:32 | |
| jdstrand | pedronis: as it happens, the review-tools have a check for the config hook, but not the other hooks | 12:59 |
| * jdstrand adds a note to update them for the others | 12:59 | |
| * sergiusens waves from a holiday | 13:22 | |
| mup | Bug #1732555 changed: Installing bad snap has snapd crashing <Snappy:Fix Released by zyga> <https://launchpad.net/bugs/1732555> | 13:22 |
| sergiusens | elopio the register thing is broken now on the fakes | 13:22 |
| mup | PR snapd#4363 closed: cmd/snap-mgmt: add more directories for cleanup and refactor purge() code <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4363> | 13:27 |
| kalikiana | sergiusens: what are you doing here then, you should enjoy your day off :-P | 13:28 |
| mup | Bug #1723974 changed: snap client doesn't work with Croatian language/characters <Snappy:Fix Released> <https://launchpad.net/bugs/1723974> | 13:34 |
| pedronis | mvo: I was looking at this code: https://github.com/snapcore/snapd/blob/master/tests/main/auto-refresh/task.yaml#L21 the if doesn't make sense anymore, right? also refresh.disabled is not used either? | 13:34 |
| mup | Bug #1722882 changed: Ubuntu Core 16: Error: cannot refresh "pi2-kernel": snap "pi2-kernel" has changes in progress <Snappy:Fix Released> <https://launchpad.net/bugs/1722882> | 13:37 |
| pedronis | Chipaca: is architectures mandatory in snap.yaml? | 13:38 |
| mvo | pedronis: correct, the "if" can be killed and the disabled=false can also be killed. will you do that or shall I push a PR? | 13:39 |
| pedronis | mvo: I can do in my upcoming PR, I'm creating a auto-refresh-private test | 13:39 |
| pedronis | that will be similar | 13:39 |
| mvo | pedronis: thank you | 13:40 |
| mup | PR snapd#4368 closed: tests: fix security-device-cgroups-serial-port test for rpi and db <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4368> | 13:41 |
| mvo | jdstrand: re 4100> I'm inclined to merge it, gustavo is not around for a re-review but it looks like you addressed his comment. what is your feeling about it? good to go in ß | 13:43 |
| mvo | ? | 13:43 |
| mup | Bug #1717857 changed: UDisks2 interface restricts sending DBus.Properties.Get message from the client to udisksd service <Snappy:Fix Released by zyga> <snapd (Ubuntu):Fix Released> <https://launchpad.net/bugs/1717857> | 13:49 |
| mup | Bug #1717900 changed: Confined snap fail for user with homedir in /var/lib <Snappy:Triaged> <snapd (Ubuntu):Triaged> <https://launchpad.net/bugs/1717900> | 13:49 |
| mup | Bug #1718026 changed: Applications from installed snaps don't appear in activities overview <Snappy:Fix Released> <snapd (Ubuntu):Fix Released> <https://launchpad.net/bugs/1718026> | 13:52 |
| kennyloggins | How do I see the last changes on a snap (ie. paintsupreme-3d ) ? | 13:55 |
| mup | Bug #1717375 changed: snap find behaviour? <Snappy:Opinion> <https://launchpad.net/bugs/1717375> | 13:55 |
| mup | PR snapd#4377 closed: tests/main: source mkpinentry.sh <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4377> | 14:03 |
| * kalikiana lunch time | 14:07 | |
| mup | PR snapd#4381 opened: interfaces: add /proc/partitions to system-observe <Created by mvo5> <https://github.com/snapcore/snapd/pull/4381> | 14:10 |
| pedronis | jdstrand: have you seen this discussion: https://forum.snapcraft.io/t/snap-rejected-because-of-use-of-browser-support/3089/8 ? | 14:16 |
| mvo | jdstrand: fwiw, I work on fixing the failures in 4374 now | 14:23 |
| popey | elopio: is this still a bug, if so, can it please be made into a bug report? https://forum.snapcraft.io/t/go-homedir-reads-etc-passwd-not-home/2727 | 14:30 |
| elopio | segiusens: I'll update the fake | 14:32 |
| kennyloggins | popey, I need to find the log changes in this snap : https://uappexplorer.com/snap/ubuntu/paintsupreme-3d how do i do that ? | 14:32 |
| popey | Log changes? | 14:32 |
| kennyloggins | right - to see if its been updated. | 14:32 |
| elopio | popey: it depends very much on how to define a bug. I will report one | 14:33 |
| popey | elopio: lemme have the bug number pls | 14:33 |
| kennyloggins | all I see is this & I've forgotten how to see that yaml changes :( http://paste.ubuntu.com/26139743/ | 14:35 |
| popey | what changes are you expecting to see? | 14:35 |
| kennyloggins | well I asked the developer by email last month that it didn't work on xubuntu 17.10 & debian - just wondering if they'd worked on it since ? | 14:36 |
| popey | doesn't look like it. "snap info <snapname>" | 14:37 |
| popey | only two revisions in the store | 14:38 |
| kennyloggins | popey, thankyou for helping me track changes, popey :) | 14:46 |
| popey | np | 14:46 |
| mup | Bug #1707474 changed: FTBFS on i386: incompatibility with new xfsprogs <Snappy:Fix Released by zyga> <snapd (Ubuntu):Fix Released> <https://launchpad.net/bugs/1707474> | 14:46 |
| mup | Bug #1701510 changed: Unbind brcmfmac_sdio crashes netplan <Snappy:Fix Released> <https://launchpad.net/bugs/1701510> | 14:49 |
| * diddledan ninja-cuddles people as they walk by | 14:51 | |
| kalikiana | re | 15:00 |
| kalikiana | diddledan: :-o | 15:00 |
| mvo | some of the 2.30 targeted PRs need a second review, if someone could have a look, that would be great | 15:10 |
| mup | Bug #1705486 changed: SPI not working on Raspberry Pi with ubuntu core <snapd:Fix Released> <Snappy:Fix Released> <https://launchpad.net/bugs/1705486> | 15:13 |
| mup | PR snapcraft#1799 opened: tests: update the registered snap fake <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1799> | 15:14 |
| mvo | ogra_: 1689037 is assigned to you, are you still happy that this is assigned to you? | 15:16 |
| mup | Bug #1686852 changed: Can only run hello snap as root <Snappy:New> <https://launchpad.net/bugs/1686852> | 15:16 |
| mcphail | Hi. I'm struggling to see why a git repo isn't being cloned by snapcraft. My snapcraft.yaml is at http://paste.ubuntu.com/26139967/ and the output is at http://paste.ubuntu.com/26139961/. What have I done wrong? | 15:19 |
| mup | Bug #1684525 changed: panic: assignment to entry in nil map <Snappy:Fix Released by zyga> <https://launchpad.net/bugs/1684525> | 15:19 |
| mcphail | I don't know if it is anything to do with the "nil" plugin type but the same error happens if I change it to "make" | 15:21 |
| jdstrand | mvo: oh, I'm already doing that | 15:33 |
| jdstrand | mvo: shoot. did you do it already? | 15:33 |
| jdstrand | (that is why I didn't respond immediately) | 15:34 |
| kyrofa | popey, thanks for the ping, I'll take a look | 15:34 |
| mvo | jdstrand: meh, yes, all fixed already, sorry for the ocd, I still hope to push a new 2.30~rc3 tonight thats why I pushed hard on this | 15:35 |
| jdstrand | mvo: right, well, I was pushing hard to get all the stuff in too | 15:35 |
| mvo | :( | 15:35 |
| mvo | sorry | 15:35 |
| jdstrand | ok, well, let me sync and see what happens | 15:35 |
| jdstrand | mvo: no, thank you. sorry I didn't see the ping | 15:35 |
| mborzecki | mvo: restarted release/2.30 travis build, snap store returned 418 in tests/main/interfaces-snapd-control-with-manage | 15:40 |
| mvo | mborzecki: thank you | 15:40 |
| mborzecki | mvo: i'm also looing at #4100, https://github.com/snapcore/snapd/pull/4100/files#diff-67fc5f3eff966220ca21940106198de5R96 this is just for future reference, right? | 15:42 |
| mup | PR #4100: add ssh-keys, ssh-public-keys, gpg-keys and gpg-public keys interfaces <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4100> | 15:42 |
| elopio | popey: https://bugs.launchpad.net/snapd/+bug/1737197 | 15:44 |
| mup | Bug #1737197: Go HomeDir reads /etc/passwd, not $HOME <snapd:New> <https://launchpad.net/bugs/1737197> | 15:44 |
| popey | thanks | 15:45 |
| kyrofa | popey, I can't duplicate :( | 15:47 |
| mvo | mborzecki: I was not following this, not sure what the status of s.iface.AutoConnec() is currently | 15:48 |
| mvo | mborzecki: I think zyga knows | 15:48 |
| popey | kyrofa: wat, and you're logging in with your ubuntu one sso user/pass and 2fa? | 15:48 |
| kyrofa | Yeah | 15:48 |
| kyrofa | popey, can you try export-login instead? | 15:49 |
| kyrofa | It should use the same code path | 15:49 |
| popey | what's export-login? Is it documented? | 15:49 |
| kyrofa | `snapcraft export-login --snaps <snap you're enabling> --channels edge` | 15:49 |
| kyrofa | Not yet, it's how we're going to support circle CI | 15:49 |
| kyrofa | I mean, you can run --help of course | 15:49 |
| kyrofa | I'll be writing a tutorial on it | 15:49 |
| popey | so for travis I should use that too, instead of the enable-ci travis? | 15:49 |
| kyrofa | You can, but no, this is just a test | 15:50 |
| kyrofa | I'm curious if it fails the same way | 15:50 |
| popey | uh | 15:50 |
| kyrofa | Wow, I didn't even give you the right command :P . You need a file | 15:50 |
| popey | it fails asking for a file | 15:50 |
| ogra_ | mvo, i'm fine to keep it, doesnt look like there is any hurry to fix ... | 15:51 |
| kyrofa | Yeah, you're exporting the login to a file that you can then use to login with `snapcraft login --with <file>` | 15:51 |
| ogra_ | mvo, though if you have a quick fix, feel free to grab it | 15:51 |
| popey | kyrofa: whats the right command? | 15:51 |
| kyrofa | `snapcraft export-login --snaps <snap you're enabling> --channels edge foo` | 15:51 |
| kyrofa | Then your login will be in foo | 15:51 |
| ogra_ | mvo, oh, wait ... silly me ... we re-added lsb-release to the core snap tarball a while ago (together with locales) ... it can actually be closed ... /me does so | 15:52 |
| kyrofa | (which you can just delete. It's just the macaroons) | 15:52 |
| popey | kyrofa: fails | 15:52 |
| kyrofa | Same way? | 15:52 |
| popey | https://www.irccloud.com/pastebin/Sl1kCNFt/ | 15:53 |
| mup | Bug #1689037 changed: apt-add-repository in classic snap on core always adds artful repos <Snappy:Fix Released by ogra> <https://launchpad.net/bugs/1689037> | 15:53 |
| kyrofa | popey, can you try running that with debug enabled? `snapcraft -d export-login [...]` | 15:54 |
| kyrofa | You'll see a few API hits, maybe we can get some insight from that | 15:54 |
| popey | hahahahahahahaahahahahahaha | 15:55 |
| popey | I know what it is | 15:55 |
| popey | this is ace | 15:55 |
| popey | https://www.irccloud.com/pastebin/WRpBeKif/ | 15:55 |
| popey | I bet you a pound that api has moved | 15:55 |
| popey | bet it's not /dev anymore | 15:55 |
| kyrofa | 404... | 15:55 |
| kyrofa | Oh com eon | 15:55 |
| kyrofa | I JUST added support for that | 15:56 |
| kyrofa | But why did it work for me?! | 15:56 |
| pedronis | afaik it's where it always was | 15:56 |
| popey | if I had a shrug emoji, I'd likely use it here | 15:56 |
| kyrofa | Also, the fact that a 404 is turned into "invalid creds" is annoying | 15:56 |
| popey | I agree :) | 15:56 |
| popey | would you like a separate bug for that? :) | 15:57 |
| kyrofa | I had the same problem when I was posting with the wrong package format | 15:57 |
| kyrofa | Made it take forever to figure out what was happening. I've never typed my password so many times | 15:57 |
| kyrofa | popey, no, just put a royal whine in the bug | 15:57 |
| popey | ok | 15:58 |
| kyrofa | Hey cprov, any idea why this is a 404? https://www.irccloud.com/pastebin/WRpBeKif/ | 15:58 |
| Chipaca | popey: here, ¯\_(ツ)_/¯ | 16:01 |
| kalikiana | +1 | 16:04 |
| ogra_ | mvo, i linked all PRs to bug 1701018 | 16:05 |
| mup | Bug #1701018: Splash screen is not enabled in kernel <Snappy:In Progress> <https://launchpad.net/bugs/1701018> | 16:05 |
| kyrofa | popey, can you run enable-ci with -d as well? | 16:05 |
| ogra_ | (it is largely done ... just missing a dragonboard PR) | 16:05 |
| kyrofa | I'm not 100% sure it hits the acl API | 16:05 |
| popey | sure | 16:05 |
| kyrofa | I wonder if your login actually fails and then we malform the acl URL or something | 16:06 |
| popey | "POST /dev/api/acl/ HTTP/1.1" 404 None | 16:06 |
| diddledan | can I get someone who knows python combined with gtk/wayland to have a look at this person's snapcraft problem? https://forum.snapcraft.io/t/snap-to-test-gtk3-glibc-2-25-not-found/3073 | 16:06 |
| kyrofa | Ah okay good | 16:06 |
| diddledan | I can't figure out why it's segfaulting but I can replicate it locally | 16:06 |
| popey | kenvandine: might be up your street ^ | 16:06 |
| kyrofa | popey, I have to run for just a bit, but I'll look into this a bit more when I return | 16:07 |
| diddledan | thanks popey | 16:07 |
| kenvandine | diddledan, can you try building it with the gnome-3-26 ppa enabled? | 16:07 |
| diddledan | I'll give it a go | 16:08 |
| kenvandine | i'm not sure if libwayland in xenial works right | 16:08 |
| kenvandine | diddledan, i'd be very interested in the results :) | 16:08 |
| kenvandine | please let me know | 16:08 |
| kenvandine | diddledan, i've hit a separate issue today that made me worry about libwayland/gtk in xenial | 16:09 |
| mvo | ogra_: thanks | 16:10 |
| mup | Bug #1705486 opened: SPI not working on Raspberry Pi with ubuntu core <snapd:Fix Released> <Snappy:Fix Committed> <https://launchpad.net/bugs/1705486> | 16:11 |
| sparkiegeek | popey: you bet a pound you say? :) | 16:13 |
| sparkiegeek | popey: curl -d '{"permissions": ["package_access"]}' https://dashboard.snapcraft.io/dev/api/acl/ -H 'Content-Type: application/json' | 16:13 |
| sparkiegeek | works fine here | 16:14 |
| * popey blows the dust off his wallet | 16:14 | |
| sparkiegeek | popey: none of them round pounds either! ;) | 16:14 |
| diddledan | kenvandine: good instincts! using the ppa fixes it right up | 16:15 |
| kenvandine | diddledan, good to know | 16:16 |
| diddledan | I guess the xenial archive has a buggy libwayland or a buggy libgtk3 | 16:16 |
| kenvandine | diddledan, i think it might not be protocol compatible with artful | 16:17 |
| kenvandine | or really anything newer than xenial | 16:17 |
| kenvandine | but i fear updating libwayland might require more than just a rebuild of gtk | 16:18 |
| kenvandine | so hard to sru | 16:18 |
| diddledan | gah | 16:18 |
| kenvandine | nothing wrong with using the gnome-3-26 ppa though :) | 16:19 |
| kenvandine | it's just not obvious to developers to do that | 16:19 |
| kenvandine | i'd like snaps built against gtk3/wayland from xenial to actually work in wayland :/ | 16:19 |
| diddledan | yeah | 16:24 |
| mup | PR snapd#4382 opened: snap: show header/footer when `snap find` is used without arguments <Created by mvo5> <https://github.com/snapcore/snapd/pull/4382> | 16:27 |
| mvo | jdstrand: how do you feel about 4100? it looks good to me but gustavo is not around for a re-review for a couple of days. so we either need to merge without him or push it out into 2.31. wdyt? | 16:33 |
| jdstrand | mvo: I answered his questions and adjusted for the lock files. we have an ack on the the naming. the only thing technically outstanding is the 'w' random_seed, but it is needed by gpg for encryt/sign | 16:36 |
| jdstrand | mvo: I think it is safe to land. if Gustavo doesn't like the random_seed, we can do a followup PR | 16:37 |
| mvo | jdstrand: ok | 16:37 |
| jdstrand | mvo: I will prepare a PR for 2.30 for that then | 16:38 |
| jdstrand | mvo: I've also got extra tests for 4374 | 16:39 |
| jdstrand | mvo: I'll be updated pr 4375 too | 16:41 |
| mup | PR #4375: interfaces: interfaces: also add an app/hook-specific udev RUN rule for hotplugging for 2.30 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4375> | 16:41 |
| jdstrand | mvo: (the 2.30 PR) | 16:41 |
| mvo | jdstrand: aha, nice. thank you | 16:41 |
| mvo | jdstrand: its in | 16:42 |
| mup | PR snapd#4100 closed: add ssh-keys, ssh-public-keys, gpg-keys and gpg-public keys interfaces <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4100> | 16:42 |
| jdstrand | mvo: thanks fthanks! | 16:42 |
| mvo | jdstrand: :) thank you, looking forward to the 2.30 PR | 16:43 |
| mvo | jdstrand: do you have more pending for 2.30? just asking so that I can plan the 2.30~rc3 accordingly | 16:43 |
| mvo | (i.e. no pressure or anything) | 16:43 |
| jdstrand | mvo: fyi, this was the change for 4374: https://github.com/snapcore/snapd/pull/4374/commits/29c3619b2c217d0003013733c7d1c91328b2b341 | 16:44 |
| mup | PR #4374: interfaces: interfaces: also add an app/hook-specific udev RUN rule for hotplugging <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4374> | 16:44 |
| jdstrand | mvo: let me double check | 16:44 |
| jdstrand | biometrics is blocked but can be 2.31. screen-lock I was planning on doing today, but could be 2.31 if needed. layouts and xdg-settings were post 2.30. 4375 is 2.30, ssh/gpg upcoming PR is 2.30 | 16:46 |
| jdstrand | the policy update xxxiii was committed already | 16:47 |
| jdstrand | ah, jhenstridge's gnome-online-accounts would be nice to have in 2.30, but I don't think it is ready (I reviewed it hoping it would get in) | 16:47 |
| jdstrand | mvo: so, bottom line, from me, 4375 and new ssh/gpg | 16:48 |
| jdstrand | mvo: I'm going to work on screen-lock and if you respin/whatever and want to pull it in, cool, if not, fine | 16:48 |
| kalikiana | kyrofa: hey | 17:04 |
| mvo | jdstrand: thank you. screen-lock is probably fine for 2.30, I can do 2.30~rc3 monday morning, not much will happen over the weekend anyway (sergio is on vac so no QA today) :) | 17:05 |
| jdstrand | mvo: 4375 is messed up. let me get you the ssh/gpg for 2.30 and circle back | 17:10 |
| mvo | jdstrand: its ok, its targeted for master | 17:10 |
| mvo | jdstrand: to get travis results | 17:10 |
| mvo | jdstrand: but we need to re-target to 2.30 | 17:10 |
| jdstrand | I don't see where to do that in the ui | 17:11 |
| mvo | jdstrand: [edit] next to the title | 17:11 |
| mvo | jdstrand: its a bit confusing :) | 17:11 |
| mvo | jdstrand: just target to 2.30 and ignore the warning | 17:11 |
| jdstrand | ok | 17:11 |
| kalikiana | kyrofa: I'm about to eod soon... but wondering if I can ask you to have a look at snapcraft#1800 (perhaps easier to see just the changes: https://github.com/kalikiana/snapcraft/compare/to_statement...kalikiana:on_to) when you have some time, this would be the second piece of the spec, basically looking for some feedback on the approach before finishing this with tests etc. | 17:11 |
| mup | PR snapcraft#1800: grammar: on..to statement <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/1800> | 17:11 |
| jdstrand | that was not particularly discoverable | 17:11 |
| mvo | jdstrand: no disagreement :) | 17:12 |
| jdstrand | ok, back to no conflicts | 17:12 |
| mvo | jdstrand: yay | 17:12 |
| mvo | thanks jdstrand | 17:12 |
| mup | PR snapcraft#1800 opened: grammar: on..to statement <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/1800> | 17:12 |
| jdstrand | mvo: so travis doesn't run on non-master? | 17:12 |
| mborzecki | mvo: hmm, looks like we have no luck running the tests today | 17:20 |
| elopio | I'm relocating... afk for a while | 17:23 |
| mvo | mborzecki: all? or a particular PR? | 17:25 |
| mvo | mborzecki: I had some successes. but it sad that tests are unreliable | 17:25 |
| mvo | jdstrand: it should run on non-master, it did in the past, I'm not sure what changed | 17:25 |
| kalikiana | Now to call it a day/ week | 17:39 |
| kyrofa | kalikiana, I'll take a look in a bit | 17:43 |
| kalikiana | kyrofa: Grand, thanks. No particular rush. FYI also shared the notes of our brainstorming for the record | 17:46 |
| kyrofa | kalikiana, sounds good. Have a wonderful weekend! | 17:46 |
| mborzecki | mvo: had to restart release/2.30 job again, it failed with some dns resolution issues this time | 17:48 |
| kalikiana | Thanks! Have a nice last day of the week yourself! | 17:49 |
| mvo | mborzecki: thanks! and annoying | 17:55 |
| mvo | mborzecki: annoying that its so unreliable currently | 17:55 |
| jdstrand | mvo: fyi, ssh/gpg for 2.30 will be submitted in a few minutes. had to unravel the testsuite changes which took a little longer than expected | 18:01 |
| mup | PR snapd#4383 opened: add ssh-keys, ssh-public-keys, gpg-keys and gpg-public keys interfaces for 2.30 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4383> | 18:10 |
| om26er | Hey! can someone point me to an example that extends the dump plugin. | 18:18 |
| om26er | kyrofa: ^ | 18:22 |
| kyrofa | om26er, hmm... let me see | 18:22 |
| kyrofa | om26er, none that I know of off the top of my head, but there are several examples of local plugins if that's all you're looking for | 18:23 |
| kyrofa | (I have one that inherits from make, for example) | 18:23 |
| om26er | kyrofa: I am trying to do what you suggested here https://forum.snapcraft.io/t/dump-source-per-architecture/3069/2 | 18:24 |
| kyrofa | I thought that might be it | 18:24 |
| om26er | kyrofa: any example that inherits a plugin will help | 18:25 |
| kyrofa | om26er, here's one: https://github.com/nextcloud/nextcloud-snap/blob/master/snap/plugins/x-redis.py | 18:25 |
| kyrofa | There are a few in that repo | 18:25 |
| kyrofa | om26er, that particular example isn't necessary anymore with some new features the make plugin grew a while back, but it's still used | 18:25 |
| om26er | kyrofa: do you know which variable contains the 'source' ? | 18:26 |
| kyrofa | om26er, you see how I overwrote the `build` method there? You'll want to overwrite the `pull` method | 18:28 |
| kyrofa | om26er, you can refer to other plugins in the snapcraft tree for details of how they download stuff | 18:30 |
| om26er | kyrofa: alright looking | 18:30 |
| kyrofa | om26er, you can also look at the php plugin in nextcloud, which pulls extensions: https://github.com/nextcloud/nextcloud-snap/blob/master/snap/plugins/x-php.py | 18:30 |
| om26er | kyrofa: only in my case, I want to alter the `source` url based on arch. | 18:31 |
| om26er | that example seems to call the super() method, so its not exactly doing what I want to. But I'll try to figure that out | 18:31 |
| kyrofa | om26er, you won't be able to just set a variable and call it good, I'm afraid. You'll need to do the download | 18:32 |
| jdstrand | mvo: ok, PR 4374 passed. PR 4374 is in CI now. PR 4383 is in CI now. | 18:48 |
| mup | PR #4374: interfaces: interfaces: also add an app/hook-specific udev RUN rule for hotplugging <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4374> | 18:48 |
| mup | PR #4383: add ssh-keys, ssh-public-keys, gpg-keys and gpg-public keys interfaces for 2.30 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4383> | 18:48 |
| jdstrand | PR 4375 is in CI I meant to say | 18:48 |
| mup | PR #4375: interfaces: interfaces: also add an app/hook-specific udev RUN rule for hotplugging for 2.30 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4375> | 18:48 |
| ikey | hm, promising. | 19:05 |
| ikey | https://twitter.com/techieg33k/status/938840281646026753 | 19:05 |
| ikey | codeweavers retweeted it | 19:05 |
| mvo | jdstrand: great | 19:06 |
| jdstrand | ikey: nice :) | 19:10 |
| ikey | here's hoping :] | 19:10 |
| === Son_Goku is now known as Conan_Kudo | ||
| === Conan_Kudo is now known as Son_Goku | ||
| mup | PR snapcraft#1799 closed: tests: update the registered snap fake <Created by elopio> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1799> | 19:54 |
| mborzecki | mvo: 5 restarts later, the release/2.30 branch travis job finally completed successfuly | 20:20 |
| kyrofa | Agghhhh /me throws all raspberry pis out of his window | 20:34 |
| kyrofa | We have awesome moonshot ARM servers. I want a VM on one | 20:34 |
| mvo | mborzecki: yay! | 20:45 |
| mup | PR snapd#4383 closed: add ssh-keys, ssh-public-keys, gpg-keys and gpg-public keys interfaces for 2.30 <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4383> | 20:46 |
| jdstrand | mvo: thanks! | 20:47 |
| mvo | jdstrand: thank *you* | 20:48 |
| jdstrand | mvo: fyi, I keep restarting PR 4375 since it is failing in unrelated ways | 20:49 |
| mup | PR #4375: interfaces: interfaces: also add an app/hook-specific udev RUN rule for hotplugging for 2.30 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4375> | 20:49 |
| jdstrand | mvo: but PR 4374 passed | 20:49 |
| mup | PR #4374: interfaces: interfaces: also add an app/hook-specific udev RUN rule for hotplugging <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4374> | 20:49 |
| mup | PR snapd#4384 opened: interfaces/desktop,unity7: allow status/activate/lock of screensavers <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4384> | 20:51 |
| mup | PR snapd#4385 opened: interfaces/desktop,unity7: allow status/activate/lock of screensavers for 2.30 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4385> | 20:53 |
| jdstrand | mvo: fyi screenlock ^ for master and 2.30 | 20:55 |
| jdstrand | mvo: that's it for things I'm driving for 2.30 | 20:56 |
| mvo | jdstrand: cool, I have a look | 21:00 |
| gsilvapt | kyrofa, you around tonight? | 22:59 |
| kyrofa | gsilvapt, I am | 22:59 |
| gsilvapt | kyrofa, could we wrap up the string? I've tried a few combos but I'm still unable to get it right | 23:00 |
| kyrofa | gsilvapt, sure, where did you leave off? | 23:00 |
| gsilvapt | I understood I need to pass in the arguments to %(prog) and %(version). So I tried adding .format when the variable we defined is called and pass in "snapcraft", snapcraft.__version__ | 23:01 |
| gsilvapt | None of those works and the string literal is still printed to the console | 23:01 |
| kyrofa | gsilvapt, .format is the new format string method, you need to use the old one | 23:02 |
| kyrofa | I sent you a link yesterday, I think? | 23:02 |
| gsilvapt | You did. Lets see if I can try that | 23:02 |
| gsilvapt | kyrofa, but do I need to define a name placeholder too? Or that is not necessary for this? | 23:04 |
| kyrofa | gsilvapt, I'm not sure I understand what you're asking | 23:04 |
| gsilvapt | In the link: https://pyformat.info/ There's a section called Named Placeholders. | 23:05 |
| gsilvapt | I'm trying to figure out if I need to define a 'data' placeholder to pass into the string variable | 23:05 |
| kyrofa | gsilvapt, yeah you need to create a dict corresponding to the named placeholders you have in the string | 23:07 |
| gsilvapt | Hum, let's try that | 23:07 |
| kyrofa | print('test is a %(test)s' % {'test': 'foo'}) | 23:07 |
| kyrofa | >>> test is a foo | 23:07 |
| gsilvapt | Finally it worked, yey. | 23:10 |
| gsilvapt | kyrofa, yea, I tried that to avoid creating another variable. My issue now will be formatting. You guys will kill me :D | 23:10 |
| gsilvapt | Actually, now snapcraft --version is outputting something different. Weird, I'll have to review the command | 23:12 |
| gsilvapt | kyrofa, I might need to re-do the decorator. snapcraft --version is printing snapcraft, version snapcraft, version 2.34 | 23:15 |
| gsilvapt | It seems it is adding my message to a previous one defined somewhere else? | 23:16 |
| kyrofa | gsilvapt, I'll have to see code to know what's happening | 23:16 |
| gsilvapt | snapcraft version is printing the desired output though | 23:16 |
| gsilvapt | Perhaps I can push this to my fork and sent the link to you, kyrofa ? | 23:16 |
| kyrofa | gsilvapt, of course | 23:16 |
| gsilvapt | kyrofa, here's version.py https://github.com/gsilvapt/snapcraft/blob/update_version_command/snapcraft/cli/version.py | 23:31 |
| gsilvapt | and init: https://github.com/gsilvapt/snapcraft/blob/update_version_command/snapcraft/cli/__init__.py | 23:31 |
| kyrofa | gsilvapt, the variable needs to hold the template string, not the completed template | 23:36 |
| kyrofa | gsilvapt, click will complete it, and your command also needs to complete it | 23:36 |
| kyrofa | So instead of doing the % thing in the global, do it in the command | 23:36 |
| kyrofa | And just hand the template string to click | 23:36 |
| gsilvapt | kyrofa, I'm still unable to have snapcraft --version working right | 23:38 |
| kyrofa | gsilvapt, push again | 23:39 |
| gsilvapt | So I have the variable and pass in the % part in the click.echo command (in version.py). This is still working as expected | 23:39 |
| gsilvapt | The cli/__init__.py is still repeating itself | 23:39 |
| kyrofa | gsilvapt, I think that's a kwarg, it needs to be message=MESSAGE_SNAPCRAFT_VERSION | 23:40 |
| gsilvapt | this works: @click.version_option(message = MESSAGE_SNAPCRAFT_VERSION, | 23:41 |
| gsilvapt | version = snapcraft.__version__) | 23:41 |
| gsilvapt | Sorry for the weird formatting. | 23:41 |
| kyrofa | Yeah that looks more like it | 23:41 |
| gsilvapt | Ok, I'll try prepping this up before updating the PR. Thanks for your help! | 23:42 |
| kyrofa | Sure thing | 23:42 |
| gsilvapt | Hum, I'm not sure if I can squash the commit right now though. There has been so many pushes now. Is that okay? | 23:43 |
| gsilvapt | kyrofa, ^ | 23:44 |
| kyrofa | Yeah that's fine | 23:44 |
| gsilvapt | I really hope I'm not messing up the PR with this thing. | 23:51 |
| gsilvapt | kyrofa, Now we have another issue. The unit test is not passing again. The cli command outputs run, version 2.34 and the other prints snapcraft, version 2.34 | 23:52 |
| kyrofa | gsilvapt, which is why I suggested not using %(prog)s | 23:52 |
| gsilvapt | hardcoding snapcraft works, yes | 23:53 |
| cprov | kyrofa: dashboard.s.io/dev/api/acl seems to behave fine on empty payloads, https://pastebin.canonical.com/205119/ | 23:58 |
| cprov | let me check if it would 404 on bad payload, unknown snap name, for instance | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!