axw | wallyworld: FYI, https://github.com/google/metallb | 01:30 |
---|---|---|
axw | don't recall seeing that in discussions before | 01:30 |
wallyworld | no, interesting | 01:30 |
thumper | I'm back, and eating lunch carefully | 01:32 |
thumper | mouth is still numb | 01:32 |
thumper | but I'm hungry | 01:32 |
thumper | axw: for this relation status problem, and the missing status values, are they being added on migration import? | 01:58 |
axw | thumper: so I've just looked, and migration import is not guaranteed to create a relation status doc. only if there was a status in the description | 01:59 |
axw | we need another bug for that | 02:00 |
thumper | yeah | 02:00 |
thumper | when did it change from being optional to required? | 02:00 |
axw | thumper: it was only introduced with CMR. wallyworld thinks it may have morphed from being optional to required somewhere during development | 02:01 |
axw | I don't know | 02:01 |
thumper | FWIW, I don't think we should have optional statuses, it breaks expectations | 02:02 |
axw | thumper: I agree | 02:02 |
wallyworld | i can't recall when it changed, either | 02:02 |
axw | thumper: created https://bugs.launchpad.net/juju/+bug/1737456 | 02:03 |
mup | Bug #1737456: migration import doesn't always create relation status docs <juju:Triaged> <https://launchpad.net/bugs/1737456> | 02:03 |
thumper | axw: thanks | 02:04 |
thumper | wallyworld: I'm going to have to run out to collect my daughter around the time of our planning meeting in an hour | 03:16 |
thumper | wallyworld: so I'll be a little late | 03:16 |
thumper | but will be there | 03:16 |
=== frankban|afk is now known as frankban | ||
thumper | jam: ping | 09:08 |
jam | hi thumper | 09:08 |
thumper | jam: care to jump in the 1:1 hangout? | 09:09 |
jam | thumper: omw | 09:09 |
axw | wallyworld: are you still working on your PR? doesn't look like you pushed changes | 12:36 |
wallyworld | axw: the firewaller one? i meant to, i'm on the next thing now | 12:36 |
axw | wallyworld: yeah firewaller | 12:36 |
wallyworld | hmmm, i'll check | 12:37 |
wallyworld | axw: something messed up with the base branch. i had to create a new pr. the last commit has the recent changes. the other commits are as per the original pr https://github.com/juju/juju/pull/8202 | 12:45 |
axw | ok | 12:45 |
axw | wallyworld: so ExposeService and UnexposeService are already idempotent? | 12:49 |
=== frankban is now known as frankban|afk | ||
=== akhavr1 is now known as akhavr | ||
babbageclunk | thumper: sorry, my token expired | 20:36 |
thumper | I figured | 20:36 |
=== StoneTable is now known as aisrael | ||
=== mbarnett_ is now known as mbarnett | ||
babbageclunk | wallyworld: can you take another look at https://github.com/juju/juju/pull/8184? | 21:58 |
babbageclunk | I've made your changes, and moved it over to | 21:58 |
babbageclunk | 2.3 | 21:58 |
thumper | veebers: hey, have you got a few minutes? | 22:22 |
thumper | veebers: to discuss scale testing? | 22:22 |
veebers | thumper: just OTP will ping | 22:25 |
veebers | thumper: sweet, free now | 22:37 |
thumper | veebers: 1:1 ? | 22:37 |
veebers | thumper: sounds good, omw | 22:38 |
wallyworld | babbageclunk: sorry, been in meeting, looking | 22:53 |
babbageclunk | wallyworld: thanks! | 22:53 |
wallyworld | babbageclunk: i have a purely mechanical pr if you had a chance. rename some things https://github.com/juju/juju/pull/8199 | 22:54 |
babbageclunk | wallyworld: oh, it's like that is it? Quid pro quo? | 22:56 |
babbageclunk | looking now | 22:56 |
babbageclunk | :) | 22:56 |
wallyworld | babbageclunk: sorry :-( btw, lgtm for your with one small question | 23:13 |
wallyworld | babbageclunk: also, can you ensure we have trello cards for the todos, like getting config from agent conf etc | 23:13 |
babbageclunk | wallyworld: yup - I've been creating them when I add the TODO | 23:14 |
wallyworld | awesome, ty | 23:14 |
babbageclunk | I think we need the logging - the error response from the call will go to the caller, but the controller admin needs to know if audit logging is failing (preventing any user commands) | 23:16 |
babbageclunk | wallyworld: ^ | 23:16 |
babbageclunk | wallyworld: Not sure about the format - I guess we probably don't need the %T, I cargo-culted that from somewhere else. | 23:17 |
wallyworld | babbageclunk: ok, no worries | 23:18 |
babbageclunk | wallyworld: why Application.CharmConfig rather than Charm.Config? Can 2 applications with the same charm have different CharmConfig? | 23:27 |
wallyworld | yes | 23:27 |
wallyworld | each app configures their charm their own way | 23:27 |
babbageclunk | wallyworld: cool, I guess that's why then | 23:29 |
wallyworld | babbageclunk: so if i deploy mysql, i can alias that to "mysql1" and "mysql2". each of those separare, distinct apps can configure mysql however they like | 23:30 |
babbageclunk | yeah, that makes sense. | 23:30 |
babbageclunk | wallyworld: approved | 23:33 |
wallyworld | tyvm | 23:33 |
babbageclunk | wallyworld: really quick one before the meeting? ;) https://github.com/juju/juju/pull/8203 | 23:55 |
wallyworld | sure | 23:55 |
wallyworld | babbageclunk: lgtm | 23:59 |
babbageclunk | wallyworld: thanks, just in time! | 23:59 |
wallyworld | indeed | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!