| axw | veebers: any idea what's up in http://ci.jujucharms.com/job/github-merge-goose/56/console? /tmp/jenkins7796601857268642679.sh: line 23: /var/lib/jenkins/juju-ci-tools/git_gate.py: No such file or directory | 00:16 |
|---|---|---|
| axw | veebers: more to the point, what's the proper way to fix? | 00:16 |
| veebers | axw: hey I'll have a look now | 00:28 |
| veebers | axw: that node was aggressively cleaned up, a little too aggressively. I'm righting it now | 00:32 |
| veebers | axw: right, that's now running and succeeded. Sorry for the noise | 00:39 |
| wallyworld | axw: pr updated back to using map[string]string. verified with a float and a bool | 00:41 |
| axw | veebers: thanks | 01:07 |
| axw | veebers: is it a manual step to get the juju-ci-tools bits on there? | 01:08 |
| veebers | axw: for the initial setup yes, but then there is a script that keeps things up to date. This slave in particular had some manual intevention recently (and is a bit of a snow flake) | 01:14 |
| axw | veebers: okey dokey, thanks | 01:15 |
| wallyworld | axw: thanks for review. i wanted the "preserveType" value to, by default, retain existing beheaviour, ie the yaml unmarshalling. "preserveType" means do not mess with the values' types by unmarshalling | 01:32 |
| wallyworld | "setDecodedYAMLValues" would need to be explictly set to true for all the current use cases | 01:34 |
| axw | wallyworld: that seems to be the opposite of what hte doc comment says hto | 01:34 |
| wallyworld | the comment makes sense to me i guess. maybe i can reword it | 01:34 |
| wallyworld | i can explain what true/false means | 01:35 |
| axw | wallyworld: "... sets whether name values should be converted to a type that is inferred from their string value" <- they're inferred by default, so it's setting them to *not* be inferred | 01:35 |
| axw | wallyworld: perhaps "SetPreserveStringValue" | 01:35 |
| wallyworld | they are inferred by the default - the comment just says that the value of the attr will controll the behaviour of it. "SetPreserveStringValue" works for me | 01:36 |
| babbageclunk | wallyworld: take a look at https://github.com/juju/juju/pull/8210 please? | 02:26 |
| hml | wallyworld: you’re popular, though babbageclunk got there first, no rush, but if you could review please: https://github.com/juju/juju/pull/8211 | 02:30 |
| hml | g’night | 02:30 |
| wallyworld | babbageclunk: sure, looking | 03:54 |
| babbageclunk | wallyworld: thanks | 03:54 |
| wallyworld | sorry i missed the ping | 03:54 |
| wallyworld | axw: here's the next PR in the series https://github.com/juju/juju/pull/8212 | 03:54 |
| wallyworld | axw: lgtm. i can see we will be asked to allow this to be set on an existing controller. regardless, have you considered upgrade steps? will thingsbreak if we run edge on a 2.2.6 controller | 03:59 |
| wallyworld | i guess not because everything has a default | 04:00 |
| wallyworld | but worth checking | 04:00 |
| wallyworld | oops | 04:00 |
| wallyworld | babbageclunk: ^^^^^ | 04:00 |
| wallyworld | sorry, wrong person | 04:00 |
| babbageclunk | you mean me right/ | 04:00 |
| wallyworld | poor andrew, i didn't mean to insult him :-P | 04:00 |
| babbageclunk | ha | 04:01 |
| wallyworld | :-D | 04:01 |
| babbageclunk | I've thought through all of the new ones to make sure they work if there's no value, but I should try it too. | 04:01 |
| babbageclunk | wallyworld: time for a quick chat about the problem I've been talking to blahdeblah about? | 04:05 |
| babbageclunk | in 1:1? | 04:05 |
| wallyworld | sure, give me 1 minute | 04:05 |
| wallyworld | axw: thanks for review. about to test the final piece to make it all work, and then need to add more tests, but really close now | 06:48 |
| axw | wallyworld: cool :) | 06:49 |
| axw | balloons: in case you get a bunch of failures in CI, I just deleted all the resource groups. there were a bunch of old ones, and new jobs were failing because the resource quota was hit for public IPs | 06:49 |
| wallyworld | axw: there's a vspherebug that is confusing - it tries to connect to an <ipaddr>/sdk and the ip addr is something not sure of where it came from | 06:50 |
| axw | balloons: in case it helps for automated cleanups, I did this: az group list --query "[?starts_with(name, 'juju-')].name" -o tsv | xargs -L1 az group delete -y --no-wait --name | 06:50 |
| wallyworld | did you see that float past? have you see anything similar before? | 06:50 |
| axw | wallyworld: I haven't seen the bug | 06:50 |
| wallyworld | https://bugs.launchpad.net/bugs/1737868 | 06:51 |
| mup | Bug #1737868: Can't bootstrap with vsphere 6.0 <vmware> <juju:Triaged> <https://launchpad.net/bugs/1737868> | 06:51 |
| axw | wallyworld: I believe govmomi tacks "/sdk" on the end | 06:52 |
| axw | I'll take a look and see if anything jumps out | 06:52 |
| wallyworld | ok, ty | 06:52 |
| wallyworld | axw: here's the last bit if you had time https://github.com/juju/juju/pull/8214 i'm still going through manual testing, will doube check everything before landing | 08:04 |
| wallyworld | got to make dinner, bbiab | 08:04 |
| === frankban|afk is now known as frankban | ||
| === chrome0_ is now known as chrome0 | ||
| jam | anyone have ideas on how we could test https://github.com/juju/juju/pull/8216 ? | 11:39 |
| manadart | Is there a method somewhere that filters a host/port collection by network space subnets? | 14:08 |
| manadart | NVM network/address.go | 14:14 |
| balloons | axw, thanks for the cleanups | 14:27 |
| bdx | how's it going all | 17:09 |
| bdx | https://bugs.launchpad.net/juju/+bug/1736022 is killing me | 17:09 |
| mup | Bug #1736022: failed to bridge devices: bridge activaction error: bridge activation failed: Killed old client process <juju> <juju:Incomplete> <MAAS:Incomplete> <https://launchpad.net/bugs/1736022> | 17:09 |
| bdx | I'm willing to just hand over my maas to you guys so you can pound on it and get what you need to fix it | 17:10 |
| bdx | if anyone has a few extra minutes to look into this^ further with me it would be greatly appreciated | 17:12 |
| bdx | thx thx | 17:12 |
| bdx | oooh shoot | 17:22 |
| bdx | I think my bug #1736022 | 17:23 |
| mup | Bug #1736022: failed to bridge devices: bridge activaction error: bridge activation failed: Killed old client process <juju> <juju:Incomplete> <MAAS:Incomplete> <https://launchpad.net/bugs/1736022> | 17:23 |
| bdx | is really | 17:23 |
| bdx | https://bugs.launchpad.net/juju/+bug/1737640 | 17:23 |
| mup | Bug #1737640: /usr/sbin/fanctl: arithmetic expression: expecting primary | unconfigured interfaces cause ifup failures <cdo-qa> <cdo-qa-blocker> <cpe-onsite> <foundations-engine> <regression-update> <verification-done-xenial> <verification-needed> <juju:Triaged> <ubuntu-fan (Ubuntu):Confirmed for | 17:23 |
| mup | smb> <ubuntu-fan (Ubuntu Xenial):Fix Committed> <https://launchpad.net/bugs/1737640> | 17:23 |
| thumper | hml: I'm going to be a few minutes late, dropping kiddo in town | 19:53 |
| hml | thumper: ack | 19:53 |
| thumper | hml: here now | 20:05 |
| thumper | wallyworld: ping | 21:33 |
| wallyworld | thumper: hey | 21:50 |
| thumper | wallyworld: hey | 21:50 |
| thumper | quick chat? | 21:51 |
| wallyworld | sure, give me 2 minutes | 21:51 |
| rick_h | thumper: can we bail tonight? we're getting snowed in and I need to finish this round of shoveling | 21:53 |
| thumper | rick_h: sure | 21:53 |
| thumper | rick_h: have a good holiday break | 21:53 |
| wallyworld | thumper: 1:1? | 21:53 |
| rick_h | thumper: I don't have anything atm, just doing stuff as folks start to disappear for the year | 21:53 |
| thumper | rick_h: I'm off after tomorrow | 21:53 |
| rick_h | thumper: you too | 21:53 |
| thumper | wallyworld: ack | 21:53 |
| rick_h | thumper: yea, common these days :P | 21:53 |
| balloons | so wallyworld, shall we meet? I have just 2 things to ask about | 22:51 |
| wallyworld | balloons: sure, wanna do it now? | 22:52 |
| balloons | wallyworld, sure | 22:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!