| powersj | smoser: recall how pylint has started complaining about paramiko and simplestreams when I moved the code up to the super class? Well it turns out it is because the platform directories do not have an __init__.py | 01:28 |
|---|---|---|
| powersj | once I add a __init__.py into the nocloudkvm directory it finds other import errors, including paramiko | 01:28 |
| === shardy is now known as shardy_afk | ||
| === shardy_afk is now known as shardy | ||
| smoser | horay. i'm not really sure why but | 14:32 |
| smoser | https://jenkins.ubuntu.com/server/job/cloud-init-copr-test-7/145/console | 14:32 |
| smoser | is fixed now. | 14:33 |
| blackboxsw | smoser: 17.2 release merge proposal up for bionic https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335267 | 17:14 |
| smoser | blackboxsw: gar... | 17:39 |
| smoser | tip-pylint moved, and caught what seems to be some valid things | 17:39 |
| blackboxsw | sounds good. will run against tip to see | 17:39 |
| blackboxsw | and will propose a fix to master | 17:39 |
| smoser | well, 2 feelings | 17:40 |
| smoser | a.) we dont just chase pylint upstream just because | 17:40 |
| smoser | b.) but valid issues are good to fix. (it seems like the W0715 are valid) | 17:41 |
| smoser | i swear that i had seen complaints like the 'logging-not-lazy' before | 17:41 |
| blackboxsw | so we have the tip-* tox targets, when is a good time/process for us to check/validate/fix tip-* related issues? | 17:42 |
| smoser | very lazily. | 17:42 |
| blackboxsw | maybe post SRU/release we make a concerted effort to check and fix ? | 17:42 |
| smoser | we moved them out so that we could easily run them, to be aware of things | 17:42 |
| smoser | but they should not ideally fail your c-i | 17:43 |
| blackboxsw | I agree with that | 17:43 |
| powersj | how would there be any tip-* failures on master, given every merge goes through CI and we run tip-*? | 17:43 |
| smoser | as we didn't get a integration run because of that failure | 17:43 |
| blackboxsw | we shouldn't continue to have tip-* in our CI standard path. | 17:43 |
| smoser | powersj: new tip-pylint update | 17:43 |
| powersj | ah missed that | 17:43 |
| smoser | this is my "dude on the internet" | 17:43 |
| powersj | heh | 17:43 |
| smoser | he broke our c-i | 17:43 |
| smoser | powersj: can we remove pylint-tip from the merge proposal runs ? | 17:44 |
| smoser | i think i'd be happy to have it run on trunk nightly in a separate job entirely | 17:44 |
| powersj | sure it can still be a part of ci-nightly | 17:44 |
| powersj | I'll pull from merge reviews | 17:44 |
| blackboxsw | so every ci-run is racing against tip-pylint potential updates. nightly would be excellent | 17:44 |
| powersj | smoser: here is what we run today: https://paste.ubuntu.com/26189737/ | 17:45 |
| powersj | want me to remove line 4 only? | 17:45 |
| smoser | drop tip-* | 17:46 |
| smoser | they're all broken by dude on the internet | 17:46 |
| smoser | 'sh' 'tox' | 17:46 |
| smoser | that is funny | 17:46 |
| powersj | it's a jenkins pipeline syntax | 17:47 |
| smoser | really funny in that its wrong | 17:47 |
| smoser | ie, if you just read that | 17:47 |
| smoser | sh tox | 17:47 |
| smoser | should run sh on the file 'tox' | 17:47 |
| smoser | but what its doing is: sh -c tox | 17:47 |
| smoser | which is just pointless ;) | 17:47 |
| powersj | smoser: jenkins jobs updated and deployed | 17:47 |
| smoser | ok. can you re-run on blackboxsw's branch | 17:48 |
| smoser | as i was just going to ignore | 17:48 |
| smoser | but i'm happy to jsut re-visit with a happy c-i in 15 minutes | 17:48 |
| * powersj clicks rebuild | 17:49 | |
| blackboxsw | so, that aside, , we still want to fix a couple of these http://pastebin.ubuntu.com/26189753/ | 17:51 |
| blackboxsw | anyone care if I take a pass at a trivial there on master ^ | 17:51 |
| blackboxsw | s/care/object | 17:51 |
| blackboxsw | https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335271 pushed | 18:36 |
| blackboxsw | errand | 18:36 |
| powersj | smoser: thx for review | 19:10 |
| powersj | I just finished changing the VPC code to generate and delete on each run, however, as you pointed out there is a limit of 5. I still think making a new VPC each time is the preferred option. | 19:11 |
| powersj | But will have to catch the exception when we hit the limit | 19:11 |
| powersj | should we hit the limit, rather | 19:11 |
| smoser | powersj: i'm sorry | 19:19 |
| blackboxsw | powersj: what env (series) is ci running again? | 19:21 |
| blackboxsw | system packages on xenial are too old for boto3 w/ your branch. I'm switching to artful | 19:21 |
| blackboxsw | as boto3.Session() doesn't have a region_name attr defined | 19:22 |
| blackboxsw | in 1.2.2 | 19:22 |
| smoser | blackboxsw: i hate .format() | 19:22 |
| smoser | its so long | 19:22 |
| smoser | "my {0}".format("value") | 19:22 |
| smoser | "my %s" % value | 19:22 |
| blackboxsw | smoser: agreed, but it's explicit. if we want ot use %s' % everywhere I'm ok with that (though I wasn't sure if pylint was also trying to move away from iit | 19:22 |
| powersj | blackboxsw: if you use tox it will pull latest ;) | 19:23 |
| blackboxsw | I was under the impression that .format() was 'the future' but that's maybe a misconception | 19:23 |
| powersj | or the version you need | 19:23 |
| smoser | yeah i had gotten that vibe also | 19:23 |
| smoser | but that doesn't mean i can't hate the future. | 19:23 |
| smoser | what fun would it be to be old if you couldnt hate the stuff those kids are doing | 19:23 |
| blackboxsw | "get off my lawn" | 19:24 |
| blackboxsw | .. crazy kigs | 19:24 |
| blackboxsw | kids even | 19:24 |
| smoser | dont get me started on how kids are spelling these days | 19:24 |
| smoser | man | 19:24 |
| * blackboxsw sacrifices my boto3 system package to appease the tox venv 'gods' | 19:25 | |
| smoser | if you're going to use .format, then it just seems wrong to not use {name} and .format(name=value) | 19:26 |
| smoser | ie, the change is in the name of "explicit" or readability and {0}, {1}, i dont think make that. | 19:26 |
| blackboxsw | smoser: yeah, I know I also dislike all the additional characters.... format ++ the cost of named params eek | 19:32 |
| blackboxsw | but yeah I'll tweak it. it is better to be explicit | 19:33 |
| smoser | i approved | 19:33 |
| blackboxsw | will still fix it ;) | 19:33 |
| smoser | and grabbed your other now. the upload. | 19:33 |
| blackboxsw | powersj: boo. | 19:47 |
| powersj | blackboxsw: ? | 19:47 |
| blackboxsw | :/ data = self._decompressor.decompress(data, n) | 19:47 |
| blackboxsw | MemoryError | 19:47 |
| blackboxsw | time for me to buy a bigger computer | 19:47 |
| blackboxsw | got that running tox citest ;) | 19:47 |
| powersj | O.o | 19:47 |
| powersj | can I get full trace? | 19:48 |
| powersj | curious what caused that | 19:48 |
| blackboxsw | http://pastebin.ubuntu.com/26190389/ | 19:48 |
| powersj | why? "Enter passphrase for key '/home/csmith/.ssh/id_rsa': " | 19:49 |
| powersj | crazy that is only during the install | 19:50 |
| blackboxsw | ahh just recently added a check in bashrc check for ssh-agent to ssh-add my key to cache it which is used for accessing ec2 instances | 19:51 |
| blackboxsw | hrm 20G memory used on this machine (even after killing landscape and a number of containers) | 19:54 |
| blackboxsw | ahh ha. | 19:54 |
| blackboxsw | chrome Virt == 21G | 19:55 |
| rharper | firefox59 time | 19:59 |
| powersj | blackboxsw: you need to use Tab Wrangler and autoclose tabs after 24 hours ;) | 19:59 |
| dpb1 | powersj: does tab wrangler take more memory than chrome? :) | 20:02 |
| powersj | hah | 20:02 |
| rharper | blackboxsw: also The Great Suspender for chrome; that's been really nice | 20:03 |
| blackboxsw | powersj: hah! too true, this instance of chrome only had 4 tabs (as I don't use my desktop much) but it had been up for > 30 days | 20:11 |
| powersj | goodness | 20:11 |
| blackboxsw | ~30 mins powersj on your ec2 review. almost there, couple nits | 20:36 |
| powersj | blackboxsw: thanks got my list from rharper and smoser :) so getting yours will be nice | 20:37 |
| * blackboxsw wants 'coal' for xmas | 20:37 | |
| smoser | blackboxsw: i spent liek 3 hours. :) | 20:38 |
| blackboxsw | I'm only 1 hour in ;).... I'm going to be efficient (and cut-n-paste from ec2-launch) | 20:39 |
| blackboxsw | ... and it's easy to just leverage rharper and smoser's review comments ;) | 20:39 |
| rharper | lol | 20:57 |
| rharper | due to a recent | 20:58 |
| rharper | change in SRU bug verification policy fixes now have to be marked with | 20:58 |
| rharper | per-release tags (i.e. verification-done-$RELEASE). | 20:58 |
| blackboxsw | powersj: well a bit harder than I thought. review posted on your ec2 integration branch. great work | 21:41 |
| blackboxsw | rharper: yeah, cloud-init srus required as much. | 21:41 |
| rharper | blackboxsw: well, I just meant; it seems strange to email that now after it's already done | 21:42 |
| rharper | I'm happy with verification-$release | 21:42 |
| powersj | blackboxsw: thanks | 21:42 |
| * blackboxsw reworks the git-publish script to not depent on cloudinit utilities | 21:50 | |
| rharper | well, that was what smoser wrote | 21:57 |
| rharper | wrong channel | 21:57 |
| smoser | here comes a flood of bug comments. | 22:05 |
| powersj | blackboxsw: very confused, your email to me was on the tip-lint-fixes branch | 22:17 |
| powersj | https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335271 | 22:17 |
| blackboxsw | powersj: sorry, how did my auto-review against my own branch send you and email? | 22:18 |
| powersj | too many tabs open again? | 22:18 |
| blackboxsw | nah was running on the commandline | 22:18 |
| powersj | well you put a comment directed to me in that review | 22:18 |
| blackboxsw | ohhh above | 22:18 |
| blackboxsw | bummer | 22:18 |
| blackboxsw | hah, and yes too many tabs | 22:19 |
| blackboxsw | shoot | 22:19 |
| blackboxsw | did I even submit your comments on the right branch.... checking | 22:19 |
| blackboxsw | .... and i did not | 22:20 |
| blackboxsw | gah | 22:20 |
| * powersj is very confused | 22:20 | |
| blackboxsw | powersj: it's the person you work with, man. Fridays... | 22:21 |
| blackboxsw | ok posted your review comments for realsies powersj | 22:22 |
| blackboxsw | ... and yes it's friday again, and I just closed 15 tabs (still have > 15 remaining) | 22:22 |
| blackboxsw | <-- problems | 22:22 |
| blackboxsw | hopefully powersj you got the review comments | 22:23 |
| * blackboxsw reloads the proper MP again | 22:23 | |
| powersj | blackboxsw: thank you | 22:25 |
| powersj | smoser: any objection to me adding a few log debug statements while creating/deleting VPCs, launching instances, etc.? | 22:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!