| wallyworld | babbageclunk: here's that small migration fix https://github.com/juju/juju/pull/8227 | 01:08 |
|---|---|---|
| babbageclunk | wallyworld: looking now | 01:10 |
| wallyworld | \o/ | 01:10 |
| babbageclunk | wallyworld: approved | 01:15 |
| wallyworld | babbageclunk: tyvm | 01:24 |
| === thumper-away is now known as thumper | ||
| * thumper is traditionally terrible at changing nicks back | 01:44 | |
| thumper | https://github.com/juju/juju/pull/8228 anyone | 01:48 |
| wallyworld | thumper: looking | 01:58 |
| wallyworld | babbageclunk: one more really small one https://github.com/juju/juju/pull/8229 | 01:58 |
| wallyworld | thumper: what happens when we exclude a principal app with no units? | 01:59 |
| babbageclunk | wallyworld: sorry, went for a run and forgot to mention - looking now | 02:23 |
| wallyworld | no worries | 02:23 |
| babbageclunk | wallyworld: lgtm'd | 02:26 |
| wallyworld | yay | 02:26 |
| wallyworld | ty | 02:26 |
| thumper | wallyworld: it won't get the constraints for it, and if there are some defined in the bundle it will try and set them again | 02:30 |
| thumper | nothing bad, just extra work | 02:30 |
| thumper | but at least it works | 02:30 |
| wallyworld | thumper: but if there are none elsewhere in the bundle, we could actually miss out on using constraints right? | 02:32 |
| thumper | no | 02:32 |
| thumper | wallyworld: if the app isn't in the bundle, it doesn't matter | 02:32 |
| thumper | if the app is in the bundle but has no constraints, there is nothing to do | 02:33 |
| thumper | if the app is in the bundle but has constraints, it will try to set them | 02:33 |
| thumper | worst case, we set the constraints to what they are already | 02:33 |
| wallyworld | ok | 02:33 |
| wallyworld | i'm not overly familiar with the logic | 02:33 |
| wallyworld | i'll take your word it wil be ok :-) | 02:34 |
| thumper | it'll be ok | 02:34 |
| wallyworld | thumper: lgtm | 02:37 |
| thumper | wallyworld: another very small onehttps://github.com/juju/juju/pull/8231/files | 02:49 |
| wallyworld | ok | 02:49 |
| thumper | wallyworld: another very small one https://github.com/juju/juju/pull/8231/files | 02:49 |
| thumper | we can talk through the testing, or lack of it, if you like | 02:49 |
| thumper | the only way rog reproduced it was to hack the API calls | 02:50 |
| wallyworld | thumper: i think maybe at least a warning? tp pick up any typos or whatever | 02:52 |
| wallyworld | or at least tellpeople something is being ignored or might be amiss | 02:53 |
| wallyworld | but keep working | 02:53 |
| thumper | wallyworld: any warnings would be on the server, not the client | 03:23 |
| thumper | so they wouldn't see it anyway | 03:23 |
| wallyworld | ok | 03:23 |
| wallyworld | babbageclunk: sorry, another small one https://github.com/juju/description/pull/33 | 03:40 |
| babbageclunk | wallyworld: I'll accept it as penance for booting you | 03:41 |
| babbageclunk | wallyworld: Approved | 03:42 |
| wallyworld | babbageclunk: yay, ty | 03:51 |
| wallyworld | babbageclunk: last one for the year! I promise :-) https://github.com/juju/juju/pull/8232 | 03:58 |
| babbageclunk | wallyworld: yay, nice one! Done! | 04:07 |
| wallyworld | tyvm | 04:08 |
| wgrant | Huh, what is an application password? | 04:13 |
| wallyworld | wgrant: same as a unit and machine password | 05:05 |
| wgrant | Oh is this for CAAS? | 05:06 |
| wallyworld | used to authenticate api connections for that entity | 05:06 |
| wallyworld | yeah | 05:06 |
| wgrant | Since in IAAS an app never auths | 05:06 |
| wgrant | Right makes sense | 05:06 |
| wgrant | Thanks | 05:06 |
| wallyworld | np | 05:06 |
| wallyworld | wgrant: if you are interested i can share a "what can it do as of now" doc with you | 05:06 |
| wgrant | wallyworld: Ooh, enough works now that such a doc exists? | 05:07 |
| wallyworld | wgrant: you can deloy and scale and expose a charm :-) | 05:07 |
| wallyworld | and configure it | 05:07 |
| wallyworld | with k8s specific settings for service/ingress as well as charm workload ones | 05:08 |
| wallyworld | wgrant: shared with you. next major bit of work is to support relations. that will happen next year as today is my last for the year | 05:11 |
| wgrant | wallyworld: Nice, thanks. Good progress :) | 05:12 |
| wgrant | Have a good break! | 05:12 |
| wallyworld | will try, you too | 05:12 |
| === frankban|afk is now known as frankban | ||
| balloons | wpk, you about? | 14:21 |
| wpk | balloons: yep | 14:33 |
| wpk | balloons: sup? | 14:33 |
| balloons | wpk, hey, did you get a chance to look at that pr i sent along? | 14:46 |
| balloons | wpk, specifically, we aren't sure about how subnets should be created | 14:46 |
| balloons | hml, are you about? | 16:45 |
| hml | balloons: here | 16:48 |
| === frankban is now known as frankban|afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!