[01:08] babbageclunk: here's that small migration fix https://github.com/juju/juju/pull/8227 [01:10] wallyworld: looking now [01:10] \o/ [01:15] wallyworld: approved [01:24] babbageclunk: tyvm === thumper-away is now known as thumper [01:44] * thumper is traditionally terrible at changing nicks back [01:48] https://github.com/juju/juju/pull/8228 anyone [01:58] thumper: looking [01:58] babbageclunk: one more really small one https://github.com/juju/juju/pull/8229 [01:59] thumper: what happens when we exclude a principal app with no units? [02:23] wallyworld: sorry, went for a run and forgot to mention - looking now [02:23] no worries [02:26] wallyworld: lgtm'd [02:26] yay [02:26] ty [02:30] wallyworld: it won't get the constraints for it, and if there are some defined in the bundle it will try and set them again [02:30] nothing bad, just extra work [02:30] but at least it works [02:32] thumper: but if there are none elsewhere in the bundle, we could actually miss out on using constraints right? [02:32] no [02:32] wallyworld: if the app isn't in the bundle, it doesn't matter [02:33] if the app is in the bundle but has no constraints, there is nothing to do [02:33] if the app is in the bundle but has constraints, it will try to set them [02:33] worst case, we set the constraints to what they are already [02:33] ok [02:33] i'm not overly familiar with the logic [02:34] i'll take your word it wil be ok :-) [02:34] it'll be ok [02:37] thumper: lgtm [02:49] wallyworld: another very small onehttps://github.com/juju/juju/pull/8231/files [02:49] ok [02:49] wallyworld: another very small one https://github.com/juju/juju/pull/8231/files [02:49] we can talk through the testing, or lack of it, if you like [02:50] the only way rog reproduced it was to hack the API calls [02:52] thumper: i think maybe at least a warning? tp pick up any typos or whatever [02:53] or at least tellpeople something is being ignored or might be amiss [02:53] but keep working [03:23] wallyworld: any warnings would be on the server, not the client [03:23] so they wouldn't see it anyway [03:23] ok [03:40] babbageclunk: sorry, another small one https://github.com/juju/description/pull/33 [03:41] wallyworld: I'll accept it as penance for booting you [03:42] wallyworld: Approved [03:51] babbageclunk: yay, ty [03:58] babbageclunk: last one for the year! I promise :-) https://github.com/juju/juju/pull/8232 [04:07] wallyworld: yay, nice one! Done! [04:08] tyvm [04:13] Huh, what is an application password? [05:05] wgrant: same as a unit and machine password [05:06] Oh is this for CAAS? [05:06] used to authenticate api connections for that entity [05:06] yeah [05:06] Since in IAAS an app never auths [05:06] Right makes sense [05:06] Thanks [05:06] np [05:06] wgrant: if you are interested i can share a "what can it do as of now" doc with you [05:07] wallyworld: Ooh, enough works now that such a doc exists? [05:07] wgrant: you can deloy and scale and expose a charm :-) [05:07] and configure it [05:08] with k8s specific settings for service/ingress as well as charm workload ones [05:11] wgrant: shared with you. next major bit of work is to support relations. that will happen next year as today is my last for the year [05:12] wallyworld: Nice, thanks. Good progress :) [05:12] Have a good break! [05:12] will try, you too === frankban|afk is now known as frankban [14:21] wpk, you about? [14:33] balloons: yep [14:33] balloons: sup? [14:46] wpk, hey, did you get a chance to look at that pr i sent along? [14:46] wpk, specifically, we aren't sure about how subnets should be created [16:45] hml, are you about? [16:48] balloons: here === frankban is now known as frankban|afk