/srv/irclogs.ubuntu.com/2017/12/21/#ubuntu-google.txt

tsimonq2m4sk1n: I'll wait to merge your MP until you can claim the GCI task00:03
=== mallen_ is now known as mallen
=== davidcalle_ is now known as davidcalle
ivanfonwxl: I'm trying to sign the code of conduct but I'm getting this error when I paste the signed file into Launchpad: https://u.teknik.io/2NXkL.png02:54
ivanfonAny idea what it could be? I've already imported my PGP key into launchpad02:54
ivanfonoh, apparently it was because I had a newline at the bottom03:02
ivanfonSorry for bothering you, I guess I'll add a warning about that to the wiki or something03:03
m4sk1ntsimonq2: ok05:38
m4sk1nwxl: submitted the CoC task for review06:10
Championhi elopio, kyrofa, sergiusens and popey06:47
heesensergiusens,Can I add a unit test In def provision in line 41 for the  missing unit test task06:53
=== Parth is now known as Guest74515
parthpratimc7Hi elopia07:55
parthpratimc7Hi kyrofa07:55
parthpratimc7Hi sergiusens07:55
parthpratimc7Hi popey07:56
parthpratimc7Hi flexiondotorg07:56
daniellimwshi there07:57
FoxyHello08:25
konrad11901popey, please take a look at my submission if you have some spare time, it's been 36 hours since I completed the task :/08:25
Foxyanyone online i need help regarding the ruby snap creation08:25
Foxykonrad by any chance can you help me?08:25
Foxyplease?08:25
Foxyhttps://docs.snapcraft.io/build-snaps/ruby i am having difficulties here08:26
Foxyno one k08:27
AcceleratorFoxy: You just have to follow the steps :)08:27
FoxyAccelerator08:28
Foxyshould i start putting the commands in the terminal from TRAVIS08:28
Foxyor should i start from building a snap08:28
heesenelopio,could you please take a look at my task https://codein.withgoogle.com/dashboard/task-instances/5800996720607232/08:28
Foxyand should i download the snapcraft support tool in ubuntu08:29
Foxyor in the desktop08:29
AcceleratorRead the whole thing and start inputting the commands in the terminal08:29
Foxythese are the doubts i wish to clear Accelerator08:29
AcceleratorFor this task you don't have to download snapcraft08:29
AcceleratorOk sorry08:30
AcceleratorLet me clarify08:30
Foxyk08:30
AcceleratorYou have to download snapcraft from the terminal itself08:30
heesenjust follow the command starting from building the snap08:30
Foxyok08:31
heesencopy and paste each one in terminal08:31
Foxyso i have to ignore everything till building a snap right?08:31
AcceleratorRead the whole page and start following the commands from "Building the Snap"08:31
heesenyes08:31
Foxythnx08:31
heesenok no promblm08:31
Foxyand should i download the snapcraft suppor tool on ubuntu?08:31
heesenproblem08:31
heesenyes08:31
Foxyok thnx :)08:31
Foxy:D08:32
heesencopy the command in terminal08:32
Foxyhessen08:33
Foxysudo snap install --candidate --classic snapcraft should i type this command or download it from some snapcraft thingy08:33
Foxya hyper link right next to it on the page highlighted orange08:33
AcceleratorYou just have to copy and paste the command in the terminal08:34
Foxyk08:35
AcceleratorGood luck.08:35
Foxyits downloading some 80 mb file in the terminal thanks accelerator ;)08:36
AcceleratorYeah it's ok08:37
Foxynow should i type /snap/bin and the rest of the command shell?08:39
Foxyor should i remove the /snap/bin08:41
Foxygit clone https://github.com/snapcraft-docs/travis.rb cd travis.rb snapcraft08:41
AcceleratorAre you sure you are following the steps on this page? https://docs.snapcraft.io/build-snaps/ruby08:41
Foxyor this /snap/bin git clone https://github.com/snapcraft-docs/travis.rb cd travis.rb snapcraft08:41
Foxyyes08:41
AcceleratorWell i don't know if it's necessary...i skippped that part and it still worked for me08:42
Foxyk so i am gonna type it without that08:43
AcceleratorSure08:44
heesenit should be good08:47
Foxyaccelerator and hessen08:51
Foxyi ran into an eroor08:51
Foxyerror08:51
AcceleratorWhich error?08:51
Foxysudo snap install travis_*.snap --devmode --dangerous when i typed this08:52
Foxyit says cannot open travis_*.snap08:52
AcceleratorOh that.08:52
Foxy:C08:53
AcceleratorKeep trying the command "Snapcraft" until it snaps travis08:53
daniellimwslol i think a better solution would be to log an issue in github08:53
daniellimwsmay take some time but would be better to have more people looking into this problem08:54
Foxykeep typing snapcraft is not helping08:54
AcceleratorYes but it depends on luck i think08:55
Foxy:C ow crap08:55
AcceleratorBut yes i kept on inputting the command "Snapcraft" until it worked08:55
AcceleratorDon't lose hope...be patient08:56
Foxyalright sensei accelerator08:57
FoxyI WILL DO THIS FOR SENPAI08:57
AcceleratorI'm neither your teacher nor your senpai08:57
Foxyi think its showing the error08:58
Foxybecuz of the /setup/bin thingy i skipped08:58
AcceleratorSame error?08:59
Foxyi mean /snap/bin08:59
Foxyyeah same error08:59
AcceleratorI don't think it's because you skippped that part08:59
Foxywelp i will keep typing the command snapcraft09:00
Acceleratorlike i said..keep trying until it is finally fed up with you and snaps Travis :)09:00
Foxyalright.....09:01
daniellimwsum Foxy can you send over the full error log09:02
Foxyfor which09:02
Foxywhen i type snapcraft?09:02
Foxyor when i type sudo snap install travis_*.snap --devmode --dangerous09:02
Acceleratorwhen u type snapcraft09:03
daniellimwswhichever command that causes an error09:03
Foxyboth of em09:03
femilamptey_Hey09:03
Acceleratorok send both09:03
daniellimwshey09:03
Foxyk09:03
AcceleratorHi there09:03
Foxyi will leave and join on ubuntu brb09:03
Foxygimme at least 5 mins or 609:04
konrad11901Foxy: I'm sorry I wasn't able to help, my teacher has taken my phone :(09:04
AcceleratorOuch that's unfortunate...did you get it back?09:04
Foxyok09:05
Foxyi will be back in 5 mins now09:05
konrad11901Accelerator: yes, fortunately :)09:08
foxylemme type the two errors now09:08
AcceleratorI know that feel konrad1190109:08
foxywen i type snapcraft09:08
foxysnapTraceback (most recent call last):   File "/snap/snapcraft/793/lib/python3.6/site-packages/libnacl/__init__.py", line 62, in _get_nacl     return ctypes.cdll.LoadLibrary('tweetnacl.so')   File "/snap/snapcraft/793/usr/lib/python3.6/ctypes/__init__.py", line 422, in LoadLibrary     return self._dlltype(name)   File "/snap/snapcraft/793/usr/lib/python3.6/ctypes/__init__.py", line 344, in __init__     self._handle = _dlopen(self09:08
AcceleratorFoxy use this link and send the url09:09
xopt#join brlcad09:09
Acceleratorhttps://prnt.sc/09:09
xoptshit09:09
foxywhich url?09:10
Acceleratorhttps://prnt.sc/09:10
foxyno whcih url should i send?09:10
Acceleratorupload the screenshot of the errors u get on https://prnt.sc/09:11
Acceleratorthen send us the link09:11
foxyerm k it will take some time tho09:11
AcceleratorTake your time09:11
foxyk thnx09:12
foxylemme take screen shots09:12
Acceleratorkonrad11901: Could you help him until i get back? I'm going for lunch09:14
Acceleratoror daniellimws09:15
daniellimwsok09:15
Acceleratork thanks09:15
foxy_something happened my whole vm machines screen went black09:16
foxy_imma do the steps again after running it again09:16
dlwsfoxy: do you speak hindi09:16
foxy_yes09:16
foxy_i do09:16
foxy_but not fluently09:17
dlwsoh09:17
dlwswhat is your native language then09:17
foxy_Urdu,Kashmiri09:18
foxy_i know both and both of em are my mother tongues09:18
dlwswoah09:18
dlwsso you know 4 languages09:18
foxy_i know hindi/kashmiri/urdu/english/arabic09:19
foxy_and i am planning to learn japanese09:19
foxy_i also know some malyalam since most of the kids in my school speak malyalam09:19
foxy_i know some japanese since i watch a lot of anime09:19
m4sk1ndlws left the channel, foxy_09:21
daniellimwsum that was my friend09:21
foxy_oh k09:21
daniellimwsthat tried to use my name09:21
foxy_oh09:22
foxy_i give up09:30
foxy_:c09:30
heesenwhat happen10:07
heesen?10:07
heesenfoxy10:07
AcceleratorI think he forgot about coming back.....he is not online10:10
daniellimwsno he gave up10:12
daniellimwssuddenly just said I gave up and left10:12
* Accelerator facepalms10:13
* daniellimws does the same10:13
Acceleratordaniellimws: Do you know what the bots can do?10:14
daniellimwscurrently the bot in this channel can show information of a pull request10:14
daniellimwstry pasting a link to a pull request10:14
AcceleratorThat's all?10:14
daniellimwsthat's all I know of for now10:15
Acceleratori see..thanks anyways10:15
omairqazihi elopio , kyrofa ,  sergiusens ,  popey and flexiondotorg11:26
popeymorning11:26
omairqazipopey https://forum.snapcraft.io/t/call-for-testing-omairqazi-instantnews/327812:42
omairqazihi12:44
daniellimwshi12:46
omairqazihttps://forum.snapcraft.io/t/call-for-testing-omairqazi-instantnews/327812:47
daniellimwswhat does that do12:49
omairqaziit is a task12:51
omairqazielopio , kyrofa ,  sergiusens ,  popey and flexiondotorg https://forum.snapcraft.io/t/call-for-testing-omairqazi-instantnews/327812:52
daniellimwsyou can just put this in your task and submit12:53
daniellimwsdon't need to spam it here12:53
daniellimwsthe mentors may not be onlin yet12:53
daniellimwsheber, are you around?12:53
heberdaniellimws, Yes, I am.12:54
daniellimwsive managed to run the tests12:54
daniellimwsbut I'm getting an error when trying to run the existing deb package test12:54
daniellimwssomething about ampersands not encoded as & when calling from api.snapcraft.io12:55
heberdaniellimws, good! Which error are you getting=12:55
omairqazican you elaborate the error12:55
daniellimwsis that intended?12:55
omairqaziyes12:55
heberdaniellimws, can you share a log ?12:55
daniellimwsif I replace all '&' with '&' I get a working response12:55
daniellimwsok give me a moment12:55
daniellimwsmade a mistake (or maybe not) by saving the image in /tmp, now just rebooted my computer and need to redo it12:56
daniellimwsI'll ping you when its ready12:56
heberdaniellimws, sure no problem12:56
daniellimwsheber, one more thing, not sure what I did but I have a problem with the virtual environment every time I run12:58
daniellimwshttps://pastebin.ubuntu.com/26227077/12:58
daniellimwsit doesn't stop the tests but just wanna know if that's something I should be concerned about12:59
heberdaniellimws, that error shouldn't appear. What version of Ubuntu are you running in your machine?13:01
daniellimwsartful13:02
daniellimwsheber, well this is weird, after redoing the whole setup, the error is gone13:25
daniellimwsnot complaining13:25
daniellimwsheber, now I have another question, is there any documentation for the gnome-software13:26
daniellimwsbecause I don't know what BuilderNames are there13:27
heberdaniellimws, not sure about the documentation. But you don't need it to inspect the application. See https://wiki.gnome.org/Projects/GTK+/Inspector13:33
heberdaniellimws, with that and the tests cases description you should be ok to automate13:33
daniellimwsheber, ok thanks a lot for the help13:36
daniellimwsalso, the error regarding the venv is also gone, now that I redownloaded the branch13:36
daniellimws¯\_(ツ)_/¯13:37
heberdaniellimws, awesome. I recommend you to start with a small test (for example: no match results). If you don't know how to start or get stuck, we can make a hangout session13:42
daniellimwssure thanks again for all the help13:43
daniellimwsheber, sometimes when I run the same code that returns ok at the first time, it gives me failed at the second time14:37
daniellimwsalso, sometimes it takes forever to run a test case14:38
daniellimwsmay I know if there is something that I'm missing, like resetting it before every run?14:38
daniellimwsapart from that, may I clarify something in https://wiki.ubuntu.com/Process/Merges/TestPlans/gnome-software14:40
heberdaniellimws, you shouldn't have to do any manual step, it might be a test that is not stable enough14:41
daniellimwsoh, is there anything that I need to do about that14:41
daniellimwsI think this mainly happens when searching for a package14:41
daniellimwsin the test plan, "Existing application packaged as snap (installed)", the preequisite says that hello-unity must not be installed14:42
daniellimwsjust want to confirm, is there a typo?14:43
heberdaniellimws, correct. It must be installed14:45
daniellimwsok, in that case, how do I install?14:45
daniellimwsshould I access the qemu image and install it inside beforehand?14:45
heberdaniellimws, no. All the preconditions should be done as part of the test automatically14:46
heberdaniellimws, and removed as part of test teardown14:47
daniellimwsokay may I know how can I do that?14:47
daniellimwssame for changing the language to french14:47
heberdaniellimws, have a look on this MP https://code.launchpad.net/~heber013/ubuntu-system-tests/adding-snap-test/+merge/334762 it is regarding install snaps14:47
daniellimwsheber, should I place all the helper classes in cpo.py?15:01
heberdaniellimws, yes. Each application has its own cpo.py15:02
daniellimwsheber, oh what does it stand for? custom proxy object?15:03
heberdaniellimws, exactly15:03
daniellimwsheber, alright thanks15:03
daniellimwsheber, apart from snap installation, can you also point me to where can I change the system language?15:04
heberdaniellimws, see here https://askubuntu.com/questions/133318/how-do-i-change-the-language-via-a-terminal I would start with an easier one (like no matches results) but it is up to you to choose which one.15:08
daniellimwsyea I've got that done already15:08
heberdaniellimws, awesome15:11
m4sk1ntsimonq2: submitted for review15:48
wxlballoons: i know i've approved at least one qa test task but in reflecting more about the task description, i'm confused. is the intention that the student do ALL of the tests? and when you say you can "run the tests in a live session" i assume you mean a virtual machine? obviously you can't run an install test in a live system. XD15:54
m4sk1ndoesn’t he mean “livecd”?15:57
wxlthat's how i read it, but it doesn't make sense in context15:58
m4sk1nbtw, is it really impossible to install Ubuntu from Ubiquity from actual installation? I’ve installed Arch (from my current instance) on another partition with Calamares some time ago15:58
* wxl shrugs15:59
wxlnever tried, but it's completely incompatible with the way the testcases read15:59
wxl^^ maybe you know mallen ?16:02
Acceleratorwxl: Hi....do u know what the bots can do apart from showing information about pull requests?16:06
wxlwhich bots, Accelerator ?16:06
wxlthere's A LOT :)16:06
AcceleratorI want to know about ubot9316:07
wxlAccelerator: here's the long answer https://wiki.ubuntu.com/IRC/Bots16:08
wxlAccelerator: it's based off of supybot, as most of the bots are https://github.com/Supybot16:09
daniellimwsheber, is the star necessary? because for the snap not installed test, hugo doesnt have a star16:09
AcceleratorOK i understand now16:09
wxlballoons: well, i think i'm going to at least re-write the lubuntu one. it's confusing.16:10
daniellimwsheber, would you like it if I find a way to retrieve the search results more reliably? the current way of doing it is not very reliable, I believe. sometimes, it gives more than expected number of items, while sometimes it gives less16:17
daniellimwskyrofa: anything you've found regarding the problem I logged?16:20
wxlballoons: also did you intend to link to cadence testing and not iso testing? maybe that's the results of my confusion. when i see "iso test" i don't immediately think "package test"16:20
femilampteyHi16:23
daniellimwsHi16:23
AcceleratorHi16:23
femilampteyI’ve posted a call to test of my fixed snap at https://forum.snapcraft.io/t/call-for-testing-tably-snap/327016:23
femilampteyAnd also, is it possible that I could get an extension? I’m still having classes and I’m not sure how free I’ll be to complete the rest of my assignment16:24
femilampteyThank you16:24
AcceleratorUm you know you can ask for task extension when commenting on your task16:26
femilampteyI’ve made several comments over the past few days but I haven’t gotten a reply16:26
daniellimwswho's the mentor16:27
femilampteySergio, Schvezov, Kyle Fazzari Carla Sella elopio16:27
femilampteySergio Schvezov, Kyle Fazzari, Carla Sella, elopio16:28
wxlkyrofa: ^^16:28
AcceleratorUm yeah i'm still waiting most of them to review my work too but has 36 hours already passed?16:29
daniellimwsor popey16:29
wxlsorry to hear about the delays, folks16:29
wxli know elopio was on vacation.. carla's almost never on irc. i don't know schvezov.16:30
wxlwish i could help more :(16:30
Acceleratorwxl: It's ok....do you think you have access?16:30
femilampteyI’ve been waiting for over 3 days for a response from any of them16:30
wxli know i don't, Accelerator. :(16:30
wxl3 days O_O16:31
femilampteyYupp16:31
wxllet me see what i can do16:31
Acceleratorwxl: I waited 5 days... but yeah i can understand with christmas and new year on the horizon16:31
daniellimwssergiusens?16:31
wxloh sergiusens IS schvezov. i never knew his last name XD16:32
AcceleratorXD16:32
daniellimwshaha16:32
daniellimwsXD16:32
wxli'll see if i can catch them elsewhere16:33
daniellimwsperhaps in #snappy?16:33
sergiusensI am here16:33
kyrofaHey folks, I'm sorry, we've been on a "final work week of the year" rush. We need to go through our queue16:33
sergiusensbut I can only do reviews for code against snapcraft mostly16:33
femilampteyOkay16:33
AcceleratorWe understand16:33
sergiusensI am only a backup, backup, backup mentor for all other tasks16:33
femilampteyhope you’re all well16:34
sergiusensand given elopio mentioned he would be checking every day I didn't pay much attention to others16:34
popeyDid I miss a ping?16:34
popeydaniellimws: ?16:34
wxlsergiusens: elopio was doing great…  until he went on vacation :(16:34
wxlpopey: we have students that have been waiting 36+ hours for responses to their submissions16:35
kyrofaNext week should be better once GCI is all I'm doing16:35
femilampteyBut the deadline for my task is fast approaching.... do you guys think you can extend and check out my call for testing on the snapcraft forum?16:35
popeyOk. I am afk right now. Will check the queue when I am back home in an hour tganks16:35
popey*thanks16:36
femilampteyOkay16:36
wxlpopey: it's the snappy stuff i can't help with much, i'm sorry to say. :(16:36
kyrofafemilamptey, doesn't it pause when you submit?16:36
femilampteyThank you all so much16:36
Acceleratoryeah thanks everybody16:36
sergiusensAccelerator your answer on askubuntu needs some polishing16:36
femilampteyI haven’t submitted, I’m on a step in my task but I need some form of approval to move on16:36
wxlfor non snappy stuff i'm sure i could help XD16:36
Acceleratorsergiusens: Sorry but could you elaborate more please?16:37
kyrofafemilamptey, can you provide a link to your task?16:37
sergiusensAccelerator comment in the task and on the generated asset16:37
AcceleratorOk will do16:38
femilampteyAnd I’m supposed to ask one of the Snapcrafters admin to do some stuff to my github repo16:38
femilampteyThis is my task16:38
femilampteyhttps://codein.withgoogle.com/dashboard/task-instances/4576461547634688/16:38
daniellimwskenvandine: do you think it's ok to add heber as a mentor for my task on autopkgtests?16:38
femilampteyAnd this is my repo16:38
femilampteyhttps://github.com/fennecus-z/tably-snap16:38
femilampteyThe instructions are on the README.md16:39
femilampteyAnd I’m currently supposed to “Ask a Snapcrafters admin to fork your repo into github.com/snapcrafters, transfer the snap name from you to snapcrafters, and configure the repo for automatic publishing into edge on commit”16:39
kenvandinedaniellimws, sounds like a good idea16:39
daniellimwskenvandine: thanks, because I'll be on vacation next entire week. I really hope I can get this done latest by tomorrow.16:40
daniellimwskenvandine: are you able to add? or we need popey to do it?16:41
kyrofafemilamptey, I extended the deadline. However, all you need is the snap published and call for testing out in order to get approval from me anyway. Transferring to snapcrafters is the next step, but it's not really on you to wait for it to happen16:41
kenvandinedaniellimws, looks like i can't add mentors16:43
kenvandinepopey, can you please do that?16:43
kenvandineadd heber ?16:43
heberdaniellimws, yes feel free to make the steps more reliable16:43
popeykenvandine: I can, as can flexiondotorg16:44
kenvandinecool, please make it so :)16:44
popeyI am afk. Will look when at my desk in an hour16:44
kenvandineflexiondotorg, ^^ are you around?16:44
daniellimwsheber: this may be one factor affecting it https://pastebin.ubuntu.com/26228083/16:45
femilampteykyrofa, thank you so much for your assistance!16:45
daniellimwsI'll try my best16:45
daniellimwskenvandine, popey: it's ok thanks for all the help, no rush16:45
femilampteykyfora, I’ve called it out for testing at https://forum.snapcraft.io/t/call-for-testing-tably-snap/3270/416:46
femilampteyHi @popeym16:47
femilamptey*popey16:47
femilampteyDo you think you could transfer my repo to Snapcrafters?16:48
femilampteyThanks!16:48
popeyWill do16:49
popeyDoes it work now?16:50
femilampteyYes it does16:50
femilampteyThanks so much for informing me16:50
femilampteyI tested it out for a while before putting it back16:50
Acceleratorsergiusens: Just edited it...i would be grateful if you could review it today.17:01
popeyfemilamptey: you need to request transfer of the snap to the snapcrafters account in the forum17:13
* popey is back at his desk.17:17
popeyRight, what needs doing? :)17:17
popeyfemilamptey: heya, got a link to your task?17:19
wxl^^ Accelerator can popey help you?17:19
daniellimwspopey: add heber as a mentor to the autopkgtests for gnome software task please :_17:19
daniellimws:)17:19
popeyok17:19
femilampteypopey, here is the github link https://github.com/fennecus-z/tably-snap17:19
Acceleratorwxl: I don't know...he seems rather busy17:20
wxlAccelerator: only one way to find out i guess17:20
sergiusenswxl I already approved17:21
wxloh?17:21
wxlok nevermind17:21
sergiusenswxl Accelerator's task17:21
* wxl goes back to his regularly scheduled program17:21
Acceleratorthank u guys17:22
popeyfemilamptey: can you link to the task on codein?17:22
femilampteypopey here is the GCI task https://codein.withgoogle.com/dashboard/task-instances/4576461547634688/17:23
m4sk1nwho claimed the task to document ubuntu-dev-tools?17:24
popeythanks17:24
daniellimwspopey: this task https://codein.withgoogle.com/dashboard/task-instances/5831541185839104/17:25
m4sk1none of you?17:25
daniellimwsnot me17:26
daniellimwsI'm still on my task17:26
Acceleratorm4sk1n: Don't think anyone gonna answer that17:26
Acceleratorbut yeah it was not me too17:26
daniellimwswell technically you sent a pr already right? why not just get tsimonq2 to create another task with the same name17:26
tsimonq2daniellimws: Because the task can only be done once.17:27
Acceleratoryeah add a few like so that i can do some too 😀17:27
Acceleratortsimonq2: Can't you add a few like the ones that already disappeared?17:28
AcceleratorWe did not get the chance to try it17:29
wxlpopey: Lubuntu has now 3 images so I've split out the one ISO task into three. If you could publish the remaining two, that would be great: https://codein.withgoogle.com/dashboard/tasks/6033562992115712/ https://codein.withgoogle.com/dashboard/tasks/6058270328356864/ please also add tsimonq2 as mentor. you might also want to add balloons, mallen, and Carla, as they were all mentors on the original.17:29
tsimonq2Accelerator: I could but like I said, it's kinda a unique task :/17:29
tsimonq2In any case I'd like popey's or balloon's help in resolving this...17:30
daniellimwstsimonq2: can you check if it was abandoned17:30
tsimonq2+1 wxl17:30
Acceleratortsimonq2: i see so we lost our chance17:30
daniellimwslast week there was a task that was abandoned and somehow got off the taskboard17:30
heesen sergiusens: could you please review my task17:30
daniellimwsit was also a one instance task17:30
popeywxl: done17:31
popeykenvandine: can you help with https://codein.withgoogle.com/dashboard/task-instances/5831541185839104/ ?17:31
tsimonq2daniellimws: Sure, but I don't want to hurt the poor guy if he's already started putting a good amount of work into it :/17:31
tsimonq2Accelerator: There will be more tasks like it.17:32
wxlpopey: thank you very much :) hope you feeling better, btw. i'm not.17:32
daniellimwsI suppose that's one problem with doing a task before claiming it17:32
popeyi am.. awwww17:32
tsimonq2heesen: I don't think there's a need to ping if it's already submitted for review :)17:33
daniellimwspopey: kenvandine wasn't able to add heber to the task17:33
Acceleratortsimonq2: That's a relief17:33
tsimonq2+1 wxl17:33
kenvandinepopey, yeah, i can't add mentors17:33
popeybecause heber wasn't a mentor, i just invited him to be one17:33
tsimonq2daniellimws: Right :/17:33
wxltsimonq2: you're sick?17:33
popeysomeone need to poke heber to accept the invite :)17:33
tsimonq2wxl: No, I was hoping popey would get well :)17:34
kenvandinepopey, he's been poked :)17:34
popeyta17:34
tsimonq2Accelerator: right :D17:34
kenvandinepopey, even if he accepts i don't think i can add mentors17:34
kenvandinei don't see a way to edit that17:34
wxltsimonq2: well he already is apparently :)17:34
popeykenvandine: i can/will17:34
tsimonq2aah I'm on mobile with no spellcheck, you guys are too fast ;P17:34
tsimonq2wxl: good :)17:35
sergiusensheesen another mentor is looking at it and already added feedack, I won't be stepping on his toes ;-)17:35
heesenok17:37
heberpopey, kenvandine done17:47
heesen_kyrofa,what test  could I had to the test to add coverage17:48
heesen_?17:48
kyrofaheesen_, have you looked through the coverage of the code yet instead of through the tests themselves?17:48
heesen_kyrofa, where can i look throught the coverage of the code17:50
heesen_i only look on the site and choose a test with least %coverage17:51
kenvandinepopey, heber accepted it17:57
daniellimwswoah congrats m4sk1n, your snap is first on the list https://insights.ubuntu.com/2017/12/20/top-snaps-in-november18:04
kenvandinem4sk1n, that's awesome!18:05
m4sk1n:o18:05
popeykenvandine: added heber to https://codein.withgoogle.com/dashboard/tasks/5083213170999296/18:07
kenvandinepopey, thx!18:07
kenvandineheber, thanks for helping out!18:07
daniellimwsthanks!18:09
daniellimwsheesen_: do you mean module with least coverage?18:18
heesen_yes and what should i add to it18:26
heesen_?18:27
daniellimwscan you send a link to your pr? perhaps I can help18:29
daniellimwsheesen_18:30
heberkenvandine, no problem!18:35
heesen_https://bit.ly/ugciscover18:37
heesen_i have to select on test and add more coverage18:37
daniellimwsheesen: which module are you looking at?18:37
heesen_https://codecov.io/gh/elopio/snapcraft/src/master/snapcraft/internal/sources/_rpm.py18:39
Acceleratordaniellimws: I don't think you managed to ping him18:39
Acceleratoroh forget it18:39
heesendaniellimws,sorry for taking some time to respond18:41
daniellimwsheesen: ok, which line are you adding coverage to18:43
heesen_i dont know on which line can i add coverage18:43
daniellimwsheesen: the lines that are yellow and red are ones that are not covered yet18:44
daniellimwsgreen means already covered18:44
daniellimwsso you should add tests to the red and yellow lines18:44
heesen_ok18:44
daniellimwsor maybe not the yellow ones, but the red one18:44
daniellimwsor maybe not the yellow ones, but the red ones18:44
heesen_what could i add ?18:44
daniellimwsfor example line 32, you can add a test to ensure that error is triggered18:45
daniellimwswhen source_tag is true18:45
daniellimwshow to do it is left for you to figure out :)18:45
heesen_ok18:53
heesen_thanks for he help18:53
daniellimwsnp18:57
heesenkyrofa, when you are free could you please review my task20:00
konrad11901popey, can you check my submission please? It's been over 49 hours :(22:02
popeykonrad11901: oh dear, can you link to it?22:02
popeynvm, found it22:04
konrad11901ok, sorry, I had to go away from keyboard for a while22:05
popeySorry it wasn't approved earlier.22:05
konrad11901No problem :)22:07
tsimonq2m4sk1n: I approved your task ;)22:09
m4sk1nthanks :)22:09
tsimonq2m4sk1n: meh, don't think it's worth the extra loop... please add the "::" like mitya57 commented on the last one :)22:15
m4sk1nok22:16
* tsimonq2 will be AFK for the next 2-3 hours, lmk how things go22:21
m4sk1ndone22:27
mallen@popey Can you publish this please? https://codein.withgoogle.com/dashboard/tasks/4837947654275072/23:38
popeymallen: done23:40
mallentyvm23:40
popeynp23:40

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!