| wxl | popey: contacted every student who had claimed the 17.10 install and told them what's up so they don't get frustrated/waste time. | 02:24 |
|---|---|---|
| wxl | and on that note i'm going home! | 02:25 |
| parthpro | hiiiiiiii | 05:30 |
| parthpro | what i ahave to do it here | 05:30 |
| parthpro | i can't understand can u please explian me | 05:31 |
| vivaan | hi | 05:34 |
| wxl | oh hai | 05:34 |
| vivaan | give the question | 05:34 |
| vivaan | pls | 05:34 |
| wxl | parthpro: when you say "here," i assume you're referring to a specific task? | 05:34 |
| vivaan | here | 05:35 |
| wxl | here as in irc? | 05:35 |
| wxl | if you have a question, now's the time to ask..... | 05:37 |
| vivaan | according to google code in task u have to give me a question and i have answer it ...and my first task gets over, | 05:37 |
| wxl | please give a link to this task instance vivaan | 05:37 |
| vivaan | pk | 05:37 |
| vivaan | ok | 05:37 |
| vivaan | https://bit.ly/ugcichat | 05:38 |
| vivaan | is this fine? | 05:38 |
| wxl | vivaan: that's a link to the webchat, not to your task. | 05:39 |
| vivaan | https://codein.withgoogle.com/tasks/5637753310019584/?sp-categories=1 | 05:40 |
| vivaan | this? | 05:40 |
| wxl | yep | 05:40 |
| vivaan | :) | 05:40 |
| wxl | so here's the steps: | 05:40 |
| wxl | 1. come here (you did this) | 05:40 |
| vivaan | ok | 05:40 |
| wxl | 2. say hi to three specific individuals, who are your mentors (you said hi to someone, but not specifically them) | 05:41 |
| vivaan | ok understood | 05:41 |
| wxl | 3. go to askubuntu and find an open question tagged snap and answer it with the correct solution | 05:41 |
| vivaan | how to go to askbuntu | 05:41 |
| vivaan | ?? | 05:42 |
| wxl | you click the link | 05:42 |
| wxl | Find an open question in askubuntu: https://askubuntu.com/questions/tagged/snap | 05:42 |
| wxl | that link | 05:42 |
| vivaan | ok thats it?? | 05:42 |
| wxl | then find one you can answer | 05:42 |
| wxl | then provide the answer | 05:42 |
| vivaan | and then i complete my first task? | 05:42 |
| wxl | you don't provide the answer here | 05:42 |
| wxl | you provide the answer on askubuntu.com | 05:43 |
| wxl | then you can provide a link to the question you answered and submit your task for approval | 05:43 |
| vivaan | after writing the answer i complete my task | 05:43 |
| vivaan | after writing the answer i complete my task | 05:43 |
| vivaan | ??????? | 05:43 |
| wxl | after you provide the answer, you provide a link on code in and submit it. assuming the answer is correct and properly worded, your mentor will accept it | 05:44 |
| wxl | if your answer is incorrect, then more work will be requested | 05:44 |
| wxl | in other words, any answer is not acceptable | 05:44 |
| wxl | also, the task isn't considered complete until the mentor approves your submission | 05:45 |
| vivaan | ok so if my anwer is right so i gt to the next round | 05:45 |
| wxl | after the mentor approves it, yes | 05:45 |
| vivaan | there are how many rounds? sorry for asking so many questions im very urios | 05:46 |
| wxl | there's probably more tasks than you have the time/energy to do XD | 05:46 |
| wxl | the goal is to get as many as you can done | 05:46 |
| vivaan | ok thanks u were very helpful!!! so now i go to the link u provided answer qestions | 05:48 |
| wxl | on your task instance | 05:48 |
| vivaan | how to submit ur answer | 05:48 |
| vivaan | ?? | 05:48 |
| wxl | have you already claimed the task? because if you have it should be obvious. | 05:48 |
| wxl | there's a place to leave comments | 05:48 |
| vivaan | ok thank u :) | 05:49 |
| wxl | no problem | 05:49 |
| wxl | just a word of warning: it is a holiday in much of the english-speaking world, so there's not a lot of mentors around right now | 05:50 |
| wxl | if it takes a while to get a reply, just be patient. you can always find another task to start working on :) | 05:50 |
| FRANK_ | Hello | 07:02 |
| FRANK_ | Hola | 07:02 |
| m4sk1n | > the goal is to get as many as you can done | 08:02 |
| m4sk1n | quality > quantity… | 08:02 |
| Pradyumna | hi | 08:47 |
| m4sk1n | hi | 08:48 |
| Dolly | Hello Mentors! I am Dolly Sharma studying in grade XI from India. So, I am here cause I find it interesting. I like to surf net in my free time | 11:57 |
| Dolly | Well! Besides english, I do know German and will definitely try my best in doing the task:) | 11:59 |
| m4sk1n | good luck Dolly | 11:59 |
| Shantanu | someone there | 15:26 |
| Accelerator | Yes? | 15:26 |
| wxl | no | 15:27 |
| wxl | but somewhere's here | 15:27 |
| Shantanu | hey wait i am sharing something | 15:27 |
| Shantanu | This doesn't look like you've gone through the tutorial, but just downloaded and run freeplane? | 15:27 |
| Shantanu | this popey messaged me in task | 15:27 |
| Shantanu | now let me tell you | 15:27 |
| Accelerator | wxl: Hi there! | 15:28 |
| wxl | hey @Accelerator :) | 15:28 |
| wxl | Shantanu: popey has been idle here for about 16 hours. why not just reply to the task? | 15:28 |
| Shantanu | i gone thorught tutorial | 15:28 |
| Shantanu | then in terminal message came to install it | 15:28 |
| Shantanu | btw i did day before yesterday | 15:28 |
| Shantanu | when he didnt reply then i come here | 15:29 |
| Shantanu | i think u guys remembered me? | 15:29 |
| wxl | well you know it is a holiday in much of the native english speaking world, right? | 15:29 |
| Shantanu | yeah | 15:29 |
| wxl | also i've been told patience is a virtue……… XD | 15:29 |
| Shantanu | yeah but bro 2 days i waited na | 15:29 |
| wxl | so find something else to work on while you wait | 15:30 |
| Shantanu | pls gop through tutorial | 15:30 |
| Shantanu | pls help wxl | 15:30 |
| wxl | i'm not the mentor of that task and can probably provide very little help on it. you need to speak to your mentors, Shantanu. | 15:30 |
| Shantanu | pls go through tutorial | 15:30 |
| Accelerator | Could you give us a screenshot? | 15:31 |
| Shantanu | but he was not replying | 15:31 |
| Shantanu | of which | 15:31 |
| wxl | then wait until he does | 15:31 |
| Accelerator | Shantanu: Of your work | 15:31 |
| wxl | and maybe a link to the task... | 15:31 |
| Shantanu | ok | 15:32 |
| Accelerator | wxl: It's this task | 15:33 |
| Shantanu | http://prntscr.com/hrezro | 15:33 |
| Accelerator | https://codein.withgoogle.com/dashboard/task-instances/5793626825162752/ | 15:33 |
| Shantanu | http://prntscr.com/hrezvv | 15:33 |
| Shantanu | http://prntscr.com/hrf00p | 15:33 |
| wxl | yeah i'm looking for Shantanu's instance of the task Accelerator | 15:34 |
| Shantanu | http://prntscr.com/hrf05s | 15:34 |
| wxl | i cannot tell you what a hoarde of info there is to dig through as a mentor | 15:34 |
| Shantanu | http://prntscr.com/hrf08w | 15:34 |
| Accelerator | wxl: Oh haha...i thought you did not have access..sorry | 15:34 |
| Shantanu | pls check and tell me my mistake so that i can do my task | 15:35 |
| Shantanu | ?? | 15:36 |
| Shantanu | ?? | 15:36 |
| Accelerator | wait | 15:36 |
| wxl | Shantanu: i have to tell you that being patient is going to go a looooooooong way in getting you help. NOT being patient is most likely going to have the opposite effect. | 15:36 |
| Shantanu | :( | 15:37 |
| Shantanu | yaar i waited too much | 15:37 |
| Shantanu | now what you want | 15:37 |
| Accelerator | well mine is like this.....different from yours Shantanu | 15:37 |
| Accelerator | https://prnt.sc/hrf16m | 15:37 |
| Shantanu | actually mine one not loaded full and i took screenshot | 15:38 |
| Shantanu | can u call popey here | 15:38 |
| wxl | the way *I* read this tutorial (i'm not the mentor, again), the final result is uploading a snap. so it should be easily found in the snap store. no? | 15:38 |
| Shantanu | no we dont have to upload | 15:39 |
| wxl | that looks like the last part of the tutorial to me............ | 15:39 |
| konrad11901 | You should upload it Shantanu | 15:39 |
| konrad11901 | To the "edge" channel | 15:39 |
| wxl | and indeed that's what `--release=edge` refers to in the tutorial | 15:40 |
| konrad11901 | yes | 15:40 |
| Accelerator | Shantanu: You did not follow the complete tutorial...that's why you task was not approved | 15:40 |
| Accelerator | *your | 15:40 |
| Shantanu | oh pls tell | 15:41 |
| Shantanu | it means i dont have to install i have to upload?? | 15:41 |
| wxl | Shantanu: follow the last step. it's uploading. | 15:41 |
| Shantanu | am i right? | 15:41 |
| wxl | the section called "Upload your snap" | 15:41 |
| konrad11901 | Shantanu: installing it is also recommended, to check if the snap is working | 15:41 |
| Nissaar | you should go through every step of the tutorial | 15:42 |
| Shantanu | ohk | 15:42 |
| Nissaar | especially concerning snapcraft tasks | 15:42 |
| Nissaar | each step is very important | 15:42 |
| Shantanu | The goal of this task is to test-drive the following linked tutorial. Ensure the tutorial covers everything required to complete it, and file bugs (if found) at the external link. You will require an Ubuntu 16.04 machine or VM in which to run this task. https://docs.snapcraft.io/build-snaps/java | 15:43 |
| Shantanu | it didnt specify upload | 15:43 |
| wxl | test-drive the tutorial means complete the tutorial | 15:43 |
| wxl | since the tutorial includes uploading, yes, it does | 15:43 |
| Shantanu | ohk | 15:43 |
| Shantanu | tnx | 15:43 |
| Accelerator | Um the last part of the tutorial said to upload to be able to share | 15:43 |
| Shantanu | tnx | 15:44 |
| Shantanu | see but in ruby snap tutorial | 15:45 |
| Shantanu | i only installed then also i got approoved | 15:45 |
| wxl | http://31.media.tumblr.com/3bc2dd2bd334ee8dab3eef42429d3eff/tumblr_mjlbe1BsFB1rheqhwo1_500.gif | 15:46 |
| Shantanu | http://prntscr.com/hrf4rk | 15:46 |
| Shantanu | and popey accepted it | 15:46 |
| Accelerator | Well i can't help you in that one but maybe the task now involves uploading the snap? | 15:46 |
| Shantanu | https://docs.snapcraft.io/build-snaps/ruby | 15:47 |
| Nissaar | is popeye reviewing rn ? | 15:47 |
| Shantanu | it involvles? | 15:47 |
| wxl | Shantanu: that includes uploading your snap, yes | 15:47 |
| Accelerator | wxl: that gif though 😂 | 15:47 |
| Shantanu | it involves uploading even -_- | 15:47 |
| wxl | Accelerator: XD | 15:47 |
| Nissaar | which task are you talking about shantanu ? | 15:47 |
| Shantanu | http://prntscr.com/hrf5di | 15:48 |
| Shantanu | ruby snap | 15:48 |
| Nissaar | ruby, freeplane, offlineimap ? | 15:48 |
| Shantanu | see i sent this for review | 15:48 |
| Nissaar | actually they sometimes ask fir logs | 15:48 |
| Shantanu | http://prntscr.com/hrf5la | 15:48 |
| Accelerator | Shantanu: The task now involves uploading the snaps..that's why | 15:48 |
| Shantanu | didnt get yopu | 15:49 |
| wxl | Shantanu: i think if you spent a little more time uploading the snap, you'd probably get the task approved faster XD | 15:49 |
| Accelerator | Earlier on it was approved...now you have to upload the snaps | 15:49 |
| Shantanu | wxl : i dont know java | 15:49 |
| Nissaar | it would have been better if you had send screenshots of each input, error mesaages, and final outputs | 15:49 |
| wxl | but if you want to sit here and argue, you can do that, to............. | 15:49 |
| Shantanu | ok | 15:49 |
| Shantanu | not intrested in arguing -_- | 15:49 |
| wxl | then get uploading :) | 15:50 |
| Accelerator | Shantanu: Be patient...the mentors will get back to you once you submit a complete task | 15:50 |
| Shantanu | ok | 15:50 |
| Shantanu | now i will upload even | 15:50 |
| wxl | ok and on that note time for tea | 15:53 |
| konrad11901 | wxl: I'd like to do tasks related to testing Lubuntu daily builds. I see that on iso.qa.ubuntu.com there are a few testcases for Lubuntu (desktop/Next/Alternate), like installing it on entire disk or running Lubuntu in a live session. Should I test all these cases or one of them? | 15:59 |
| wxl | konrad11901: there are three tasks, one for each of the images (desktop/next/alternate). each of those tasks involve doing the entire testsuite, i.e. all of the testcases within those images | 16:01 |
| konrad11901 | wxl: ok, thanks a lot :) | 16:07 |
| SHantanu_ | sudo snap install freeplane_*.snap --devmode --dangerous | 16:08 |
| SHantanu_ | error: cannot open: "freeplane_*.snap" | 16:08 |
| wxl | konrad11901: no problem. feel free to ping if you have questions. #lubuntu-devel is bridged to matrix and so you can ping my matrix nick (wxl[m]) there and i'll get an alert on my phone | 16:08 |
| SHantanu_ | ?? | 16:09 |
| popey | Shantanu: did the previous step work? | 16:10 |
| SHantanu_ | ? | 16:10 |
| konrad11901 | Shantanu_: so such file doesn't exist, that's pretty obvious, check your snap's name and if you're in a correct directory... | 16:10 |
| popey | you know it works if there is a .snap file in the current directory | 16:10 |
| popey | if the previous step failed, then it won't have made a snap | 16:10 |
| SHantanu_ | i copiued directly | 16:11 |
| SHantanu_ | no spelling m,istake | 16:11 |
| SHantanu_ | finbally popey | 16:11 |
| SHantanu_ | popey there | 16:11 |
| Accelerator | Yeah running the "snapcraft" command should snap it | 16:11 |
| SHantanu_ | did | 16:11 |
| SHantanu_ | snapcraft "grade" property not specified: defaulting to "stable" Preparing to pull desktop-glib-only Hit http://in.archive.ubuntu.com/ubuntu artful InRelease Get:1 http://security.ubuntu.com/ubuntu artful-security InRelease [78.6 kB] Get:2 http://in.archive.ubuntu.com/ubuntu artful-updates InRelease [78.6 kB] Get:3 http://in.archive.ubuntu.com/ubuntu artful-backports InRelease [72.2 kB] Get:4 | 16:12 |
| SHantanu_ | after thjis lots of messgae | 16:12 |
| SHantanu_ | came | 16:12 |
| SHantanu_ | popey? | 16:12 |
| popey | yes, grab the last 100 lines or so, and paste them in http://paste.ubuntu.com/ | 16:12 |
| SHantanu_ | popey: there? | 16:12 |
| popey | so we can see them | 16:12 |
| wxl | artful? is this not supposed to be run on xenial??? | 16:13 |
| popey | it is! good spot | 16:13 |
| SHantanu_ | https://paste.ubuntu.com/26239426/ | 16:13 |
| SHantanu_ | popey:pls check | 16:14 |
| SHantanu_ | at last i got him XD | 16:14 |
| Nissaar | has your tasks been reviewed yet ? | 16:14 |
| wxl | Shantanu: see my comment above. you're running on the wrong version of ubuntu4 | 16:14 |
| popey | I need to edit all the tutorials and make it clear they should be run on 16.04 I think | 16:15 |
| wxl | popey: i think that's wise, but it is in the task description, no? | 16:15 |
| SHantanu_ | bro we installed 17.10 | 16:15 |
| Nissaar | im still waiting for mine to be reviewed and i submitted it on yesterday. have yours been reviewed ? | 16:15 |
| popey | yeah, it is in the description | 16:15 |
| SHantanu_ | so it wont run there? | 16:15 |
| popey | "You will require an Ubuntu 16.04 machine or VM in which to run this task." | 16:15 |
| Nissaar | it should have been 16.04 | 16:15 |
| popey | it says in the task :) | 16:15 |
| SHantanu_ | popey:pls update | 16:16 |
| Nissaar | it does not run on 17.10 | 16:16 |
| * wxl facepalms | 16:16 | |
| * Accelerator facepalms too | 16:16 | |
| Nissaar | it is mentionned in the descriptin | 16:16 |
| SHantanu_ | popey:in java it installs freeplane | 16:16 |
| popey | SHantanu_: you need to do the tutorial in Ubuntu 16.04, not 17.10 or 17.04 | 16:17 |
| Nissaar | i did the java and freeplane task | 16:17 |
| popey | (it says in the task) | 16:17 |
| Nissaar | and it has run well on 16.04 | 16:17 |
| Nissaar | it has been approved | 16:17 |
| SHantanu_ | popey:ok can u tell me how to install in vm | 16:17 |
| SHantanu_ | is there any tutorial | 16:17 |
| Nissaar | popey: have you reviewed all the tasks yet ? | 16:18 |
| Nissaar | try oracle virtual box | 16:18 |
| popey | Nissaar: i am right now | 16:19 |
| Shantanu | popey: pls review :) | 16:19 |
| Shantanu | nissaar:oracle virtual box is good? | 16:20 |
| Nissaar | i use it | 16:20 |
| Nissaar | SHantanu: it can be slow at times | 16:20 |
| Nissaar | but its god | 16:21 |
| Nissaar | to use | 16:21 |
| wxl | i wouldn't say vbox is any slower than any other vm | 16:21 |
| Shantanu | ok intsalling now to complete | 16:21 |
| popey | it's good enough for this task | 16:21 |
| wxl | assuming you have ample resources, it can run near natively | 16:21 |
| Nissaar | i havent used any other vm | 16:21 |
| Shantanu | tnx guys | 16:22 |
| popey | yeah, i use it all the time here, works well enough | 16:22 |
| wxl | kvm is nice on linux. built right into the kernel. | 16:22 |
| wxl | but i got started on vbox and i'm just used to it, so that's what i use. nearly every day, i might add. | 16:22 |
| Nissaar | dual booting is also nice xD | 16:22 |
| popey | Back an an hour... | 16:22 |
| Nissaar | i also started gci on virtual box xd | 16:22 |
| Shantanu | http://prntscr.com/hrfiyj | 16:22 |
| Shantanu | what is this | 16:23 |
| Accelerator | wxl: I dual booted mine XD | 16:23 |
| Nissaar | popey: review my taks when youre free. thx | 16:23 |
| popey | Nissaar: already did yours | 16:23 |
| wxl | dual boots are too much of a pain imho | 16:23 |
| Nissaar | i dual booted with ubuntu 16.04 too xD | 16:23 |
| Shantanu | popey:not mine | 16:23 |
| popey | am right now :) | 16:23 |
| Shantanu | popeye:http://prntscr.com/hrfiyj | 16:23 |
| Shantanu | what does this mean | 16:24 |
| Nissaar | popeye: thx very. was waitiing for the mail. | 16:24 |
| wxl | good job popeye XD | 16:24 |
| Accelerator | um guys..it's popey | 16:24 |
| Accelerator | XD | 16:24 |
| wxl | yes but admittedly popeye is much funnier | 16:24 |
| popey | * popeye glares at wzl | 16:24 |
| wxl | XD | 16:25 |
| Accelerator | popeye the sailor XD | 16:25 |
| wxl | actually wlx seems to be the most common miscommunication | 16:25 |
| popey | back soon! | 16:25 |
| * wxl resists the urge to stick popey's head on a popeye imange | 16:25 | |
| Ampgh | Hi elopio | 17:03 |
| Ampgh | Sergiusens Hi | 17:04 |
| * popey returns | 17:05 | |
| kyrofa | Hey everyone! Stopping by for a bit to review some tasks. Anyone need help while I'm here? | 18:53 |
| Nissaar | kyrofa: https://codein.withgoogle.com/dashboard/task-instances/6297389344227328/ | 18:55 |
| Nissaar | kyrofa: could you please review that if youre free ? | 18:56 |
| kyrofa | Nissaar, yeah I'm going through the tasks now | 18:57 |
| kyrofa | Nissaar, although I'm afraid I'm not a mentor for that one | 18:58 |
| kyrofa | Nissaar, oh, I can approve that one though, no problem | 18:58 |
| Nissaar | kyrofa: thought you could review it.... no problem ill just wait | 18:59 |
| Accelerator | Nissaar: who is your mentor ? | 18:59 |
| kyrofa | Nissaar, indeed I can, no worries | 18:59 |
| Nissaar | kyrofa: ohh thanks very much | 18:59 |
| Nissaar | Accelerator: alan pope and martin wimpress | 18:59 |
| Accelerator | Nissaar: It's ok now that another mentor is free to review your work | 19:00 |
| kyrofa | heesen_, are you around? | 19:04 |
| heesen_ | yes | 19:11 |
| heesen_ | kyrofa,yes | 19:12 |
| kyrofa | heesen_, have a minute to chat about the snapcraft testing task? | 19:12 |
| heesen_ | kyrofa,yes | 19:13 |
| kyrofa | heesen_, first of all, do you know how to run the suite of unit tests in snapcraft? | 19:14 |
| heesen_ | yes | 19:15 |
| heesen_ | kyrofa,yes | 19:16 |
| kyrofa | heesen_, have you run them recently? | 19:17 |
| heesen_ | kyrofa,yes | 19:17 |
| heesen_ | kyrofa,3 days ago | 19:17 |
| kyrofa | heesen_, in the snapcraft root directory, run `python3 -m coverage html` | 19:18 |
| kyrofa | heesen_, any luck? | 19:24 |
| heesen | i get this error /usr/bin/python3: No module named coverage | 19:25 |
| heesen | kyrofa, what should i do ? | 19:26 |
| kyrofa | heesen, ah, progress. How did you install snapcraft's dependencies? By following the hacking guide? | 19:27 |
| heesen | kyrofa,yes | 19:27 |
| kyrofa | heesen, so you're inside a venv right now? | 19:28 |
| heesen | no | 19:28 |
| heesen | kyrofa.no | 19:28 |
| kyrofa | heesen, ah, get in it then, I bet it's in there | 19:28 |
| kyrofa | Try running the command again once you are | 19:29 |
| heesen_ | no stil not good | 19:29 |
| heesen_ | same error | 19:29 |
| kyrofa | heesen_, you probably didn't do the "development" part of the hacking guide | 19:30 |
| kyrofa | Run this command: | 19:30 |
| kyrofa | pip install -r requirements.txt -r requirements-devel.txt --editable . | 19:30 |
| kyrofa | (the requirements-devel.txt is important) | 19:31 |
| heesen | with the . or not | 19:31 |
| kyrofa | Yeah, you're saying "install this" | 19:32 |
| kyrofa | (the dir with the setup.py) | 19:32 |
| kyrofa | (. is "where I am now") | 19:32 |
| heesen | getting this error Directory '.' is not installable. File 'setup.py' not found. | 19:34 |
| kyrofa | heesen, make sure you're in the snapcraft root directory, the one with the setup.py | 19:35 |
| heesen | ok it ran lines of code then got this error Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-Vb3KHt/mypy/ | 19:36 |
| Nissaar | try making a directory in the home folder and build the snap there | 19:36 |
| Nissaar | heesen: i have encountered the same error. remind me which task it is maybe i can see what the mentors have commented | 19:37 |
| kyrofa | heesen, can you copy the entire log and paste it into https://pastebin.ubuntu.com/ ? | 19:37 |
| kyrofa | Nissaar, heesen is hacking on snapcraft | 19:38 |
| kyrofa | heesen, we may just want to blow away the venv and start again | 19:38 |
| kyrofa | But let me see the log first | 19:38 |
| heesen | ok | 19:38 |
| heesen | done https://pastebin.ubuntu.com/26240777/ | 19:38 |
| heesen | nissaar it is the write a missing test unit for snapcraft task | 19:39 |
| kyrofa | heesen, it doesn't look like you were in your venv when you ran that, you needed to be | 19:39 |
| kyrofa | Is that true? | 19:39 |
| heesen | i wasnt in venv as the setup.py file is in snapcraft-master | 19:40 |
| kyrofa | heesen, sorry, what I mean when I say that is "your venv needs to be active" | 19:40 |
| kyrofa | heesen, let's start from scratch just to be sure things work. Where is your venv on disk? | 19:40 |
| heesen | in my home folder | 19:41 |
| kyrofa | heesen, so like ~/venv/snapcraft maybe? | 19:42 |
| kyrofa | Where the "snapcraft" folder is the venv? | 19:42 |
| kyrofa | (not snapcraft-master) | 19:42 |
| heesen | yes | 19:43 |
| Nissaar | heesen: it wasnt that one for me | 19:43 |
| heesen | venv/snapcraft | 19:43 |
| kyrofa | heesen, okay, make sure that venv is not active, and then blow ~/venv/snapcraft away | 19:44 |
| kyrofa | rm -rf ~/venv/snapcraft | 19:44 |
| kyrofa | Then cd into snapcraft master and let's start the hacking guide from scratch | 19:44 |
| heesen | ok done | 19:44 |
| kyrofa | Alright, you have the apt dependencies already installed, so let's re-create the venv | 19:45 |
| heesen | ok | 19:45 |
| kyrofa | mkdir -p ~/venv/snapcraft | 19:45 |
| kyrofa | python3 -m venv ~/venv/snapcraft | 19:45 |
| kyrofa | And then active the venv: | 19:46 |
| kyrofa | source ~/venv/snapcraft/bin/activate | 19:46 |
| kyrofa | heesen, then I want to pause there. Are you familiar with what we just did? Do you understand what's happening there? | 19:46 |
| heesen | i understand the first line but the other two no | 19:47 |
| kyrofa | heesen, before doing this tutorial, did you ever use pip? | 19:47 |
| heesen | it is creating a directory | 19:47 |
| kyrofa | Right | 19:48 |
| kyrofa | So Python has a set of directories that it uses for its packages | 19:48 |
| heesen | ok | 19:49 |
| kyrofa | By default, they're system-wide directories, in /usr/lib | 19:49 |
| heesen | ok | 19:49 |
| kyrofa | When you `sudo apt install python3-foo`, the `foo` package ends up installing stuff in those system-wide directories for everything to use | 19:49 |
| heesen | ok | 19:50 |
| kyrofa | Similarly, when you `sudo pip install foo` pip will install stuff in system-wide directories for everything to use | 19:50 |
| heesen | ok i understand | 19:50 |
| kyrofa | So let's imagine you're working on multiple projects. One requires version 1.1 of foo, another requires version 1.6 | 19:50 |
| kyrofa | You need to somehow have two versions of the same library installed (and its dependencies), without them fighting one another | 19:51 |
| heesen | e | 19:51 |
| kyrofa | That's really difficult to (read: impossible) if you're using system-wide directories. They have to go to the same place | 19:51 |
| kyrofa | This is why "virtual environments" were created. It allows you to install packages into a completely separate place per project instead of system-wide | 19:51 |
| kyrofa | Which is why you don't need sudo fo rit | 19:52 |
| kyrofa | for it* | 19:52 |
| kyrofa | With me so far? | 19:52 |
| heesen | yes | 19:52 |
| kyrofa | So the second line, `python3 -m venv ~/venv/snapcraft` says "take this directory I just created and make it a virtual environment" | 19:52 |
| kyrofa | After you run that command, python is setup in that directory | 19:53 |
| heesen | ok | 19:53 |
| kyrofa | But if you were to try installing packages, it would still go into the system-wide locations | 19:53 |
| kyrofa | The way Python determines where to put things is via several environment variables | 19:53 |
| heesen | ok i understand | 19:54 |
| kyrofa | When you run the third line, `source ~/venv/snapcraft/bin/activate`, you "activate" that virtual environment by running a script that redefines several environment variables, telling python "hey, everything I do now happens in this venv only" | 19:54 |
| kyrofa | Any packages you install with pip etc. go into that venv | 19:54 |
| heesen | ok i understood now | 19:54 |
| kyrofa | Which means you can have multiple venvs, with different packages installed. Even different versions of the same package | 19:54 |
| kyrofa | Alright. So activate that venv, and let's install Snapcraft's dependencies | 19:55 |
| heesen | thanks for the explantion | 19:55 |
| kyrofa | Of course! You're here to learn, and I appreciate the willingness to do so :) | 19:55 |
| kyrofa | Scroll down to the "Installing for development" section | 19:55 |
| heesen | thansk | 19:55 |
| kyrofa | You'll see the command you ran before | 19:55 |
| kyrofa | Run it again, but this time it'll work since you're in the virtual environment: | 19:56 |
| kyrofa | pip install -r requirements.txt -r requirements-devel.txt --editable . | 19:56 |
| heesen | yes it worked now | 19:57 |
| kyrofa | Excellent | 19:58 |
| kyrofa | And you should see `which snapcraft` show up as being inside the virtual environment | 19:58 |
| kyrofa | Right? | 19:58 |
| heesen | yes | 19:58 |
| kyrofa | Check this out: run `deactivate` | 19:58 |
| kyrofa | And run `which snapcraft` again | 19:58 |
| heesen | done | 19:59 |
| kyrofa | Did `which snapcraft` return anything? | 20:00 |
| heesen | yes '/snap/bin/snapcraft' | 20:00 |
| kyrofa | Ah, you have the snapcraft snap installed | 20:00 |
| kyrofa | Which is available system-wide | 20:00 |
| heesen | ok | 20:00 |
| kyrofa | Point is: it changed. That's because snapcraft, and all its dependencies, are only installed in the virtual environment, not system-wide. | 20:00 |
| kyrofa | (other than the snap, of course) | 20:01 |
| kyrofa | Okay: reactivate your virtual environment to get access to the from-source snapcraft again | 20:01 |
| kyrofa | source ~/venv/snapcraft/bin/activate | 20:01 |
| kyrofa | Now, inside the snapcraft root directory, run `python3 -m coverage html` again | 20:02 |
| kyrofa | It should work this time, since you installed it in the virtual env | 20:02 |
| heesen | yes it has | 20:02 |
| kyrofa | That took the coverage report from your last unit test run, and turned it into html | 20:03 |
| kyrofa | Open up htmlcov/index.html in your favorite browser | 20:03 |
| heesen | done | 20:05 |
| kyrofa | This is the snapcraft coverage report | 20:05 |
| kyrofa | Every file of snapcraft, and how well it's covered in tests | 20:05 |
| kyrofa | Select one that ISN'T 100%. I suggest snapcraft/cli/store.py | 20:06 |
| heesen | is this the document https://coverage.readthedocs.io/en/coverage-4.4.2/ | 20:06 |
| kyrofa | Yes, although you don't need to read that unless you want to | 20:06 |
| heesen | where do i find this I suggest snapcraft/cli/store.py | 20:07 |
| heesen | snapcraft/cli/store.py | 20:07 |
| kyrofa | Did you open up htmlcov/index.php in your browser? | 20:07 |
| kyrofa | Running `python3 -m coverage html` created the `htmlcov` directory in the snapcraft root | 20:08 |
| heesen | i ran this htmlcov/index.php | 20:09 |
| kyrofa | Nah, try running this: `firefox htmlcov/index.php` | 20:09 |
| heesen | i get a page saying servor not found | 20:10 |
| heesen | server | 20:10 |
| kyrofa | You're in the root directory of snapcraft? Do you see an htmlcov directory there? | 20:11 |
| heesen | the virtual environment is active should i deactivate it | 20:12 |
| kyrofa | No | 20:12 |
| kyrofa | You want it active the entire time you're touching the snapcraft code | 20:12 |
| heesen | i am in the root dir | 20:12 |
| heesen | ok | 20:12 |
| kyrofa | Do you see an `htmlcov/` directory? | 20:12 |
| heesen | yes htmlcov | 20:13 |
| kyrofa | What does `ls -l htmlcov/index.php` say? | 20:13 |
| kyrofa | Oh man | 20:13 |
| kyrofa | I've been hacking on nextcloud too much | 20:13 |
| kyrofa | My mistake, try this command: `firefox htmlcov/index.html` | 20:13 |
| heesen | ok it worked | 20:14 |
| kyrofa | Excellent. So you see a bunch of files, some have 100% coverage, others don't | 20:14 |
| kyrofa | Scroll down a little until you find snapcraft/cli/store.py | 20:14 |
| kyrofa | You'll see it's not 100% | 20:14 |
| heesen | got it | 20:15 |
| kyrofa | Click on it, and look through there | 20:15 |
| kyrofa | You'll see some red lines. Those are uncovered by tests | 20:15 |
| kyrofa | Adding a test that covers them would up the coverage of the entire project | 20:16 |
| heesen | ok | 20:16 |
| heesen | thanks for the help :) | 20:17 |
| kyrofa | heesen, do you see that _human_readable_acls() function? | 20:17 |
| heesen | what line is it ? | 20:17 |
| kyrofa | heesen, 65 | 20:17 |
| kyrofa | You should see two lines completely uncovered there | 20:18 |
| heesen | yes two blanks lines | 20:18 |
| kyrofa | heesen, no, two red lines | 20:19 |
| kyrofa | Lines 69-70 on my coverage | 20:19 |
| kyrofa | heesen, you can get those lines covered by adding a new test in snapcraft/tests/unit/commands/test_export_login.py | 20:19 |
| kyrofa | Run `snapcraft export-login --help` and you'll see it accepts a number of parameters | 20:20 |
| kyrofa | One of those parameters is `--snaps`, but there isn't a test in there that makes sure it works | 20:20 |
| kyrofa | Add one | 20:20 |
| kyrofa | Alright, I have to run for now, but I'll check back later! Bang your head against that for a little bit :) | 20:21 |
| heesen | these are the red line | 20:21 |
| heesen | for snap_id in acl['snap_ids']: snap_names.append(store.get_snap_name_for_id(snap_id)) | 20:21 |
| kyrofa | heesen, yep, exactly those | 20:21 |
| kyrofa | heesen, if you scroll down to the export_login() function you'll see even more | 20:21 |
| kyrofa | Cover any/all of them and you've met your task! | 20:21 |
| kyrofa | Alright, back soon | 20:22 |
| heesen | line ? | 20:22 |
| kyrofa | Scroll down, you'll find it | 20:22 |
| kyrofa | (my lines are different than yours) | 20:22 |
| heesen | ok thanks | 20:22 |
| heesen | ok | 20:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
