wgrantcjwatson: Huh, I thought pocketlint caught all the double equals05:18
cjwatsonwgrant: As far as I can tell it has no double-equals handling05:54
wgrantcjwatson: Also what's with the new assertDictEqual that requires rSP? Do we need to exempt some new attrs from checks, or is it just type-checking?05:55
cjwatsonwgrant: What branch is this in, sorry?05:56
wgrantcjwatson: https://code.launchpad.net/~cjwatson/launchpad/upgrade-testtools/+merge/335395 sorry05:56
cjwatsonwgrant: Looking harder I'm actually somewhat confused as to how it worked before.  unittest.TestCase.assertDictEqual does explicit isinstance checks.06:01
* cjwatson pdbs06:02
wgrantWe didn't monkeypatch in zope_isinstance, did we?06:03
wgrantDoesn't look like it.06:04
cjwatsonI think it has something to do with our own TestCase.assertIsInstance, but checking why that's no longer used.06:05
cjwatsonOh, right06:07
cjwatsontesttools now prefers unittest2, and that does self.assert_(isinstance(...)) rather than self.assertIsInstance()06:08
cjwatsonWhich is kind of a regression from plain unittest IMO, but at least the impact is small06:08
wgrantAh, fair enough.06:09
cjwatsonAh, but it's fixed in newer unittest206:10
cjwatsonSo maybe the right answer is to upgrade that instead06:10
cjwatsonwgrant: Upgrading unittest2 and reverting that change passes the relevant tests; I'll do a full test run, though06:17
wgrantcjwatson: Excellent, thanks.06:19
cjwatsonhttps://hg.python.org/unittest2/rev/2ce0bdfa3bff may mean we actually have to fix some legacy cruft mind you, but we'll see06:21
cjwatsonThat'll be an unfun diff if so06:21
wgrantIf they've actually been removed since, we should probably just add compat methods to our TestCase06:22
wgrantWe have a LOT of callsites.06:23
wgrantOh only about 800, not too bad.06:23
wgrantOh they actually removed assertEquals and co, oh dear06:24
wgrantThat's another 1500 or so06:25
cjwatsonBeen mildly annoying me for about six years, so I might just fix in bulk ...06:26
cjwatsonI mean completely unreviewable, but06:26
wgrantIndeed, a fine idea.06:27
cjwatsonNo obvious DeprecationWarnings showing up yet, so it may just be general cleanup rather than required for this upgrade06:50
cjwatsonwgrant: Do you have a non-prod Swift setup?  I recall that the last time I tried to set one up I ended up rabbit-holing on it for the better part of a day, and eventually giving up and using Canonistack.07:58
wgrantcjwatson: I do. I can give it a run through07:59
wgrantMine's mitaka but the API isn't completely different so should be good enough07:59
cjwatsonThat'd be very welcome, thanks07:59
cjwatsonHave we done similar staging adjustments before?  I guess we must have done when deploying this in the first place08:01
wgrantNot since then.08:01
wgrantI've been putting it off for years but I guess we should probably fix it up.08:02
cjwatsonOh, in fact unittest2 1.1.0 must be fine - I upgraded it in my twisted-16.5.0 branch.08:21
=== Guest9392 is now known as skay
=== necrose99_ is now known as necrose99

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!