=== AmarokNelg_ is now known as AmarokNelg
zygagood morning everyone07:22
mborzeckizyga: hey07:23
kalikianamorning, zyga07:59
zygahey pawel08:07
zygasorry for being absent earlier, my son is ill and I'm trying to get him ready for a visit at the doctor's08:08
zygaso 2.30 is out, any hiccups on your machines?08:08
zygamborzecki, pstolowski: can you check snap changes for any failures?08:08
pstolowskizyga, looks sane here08:09
mupPR snapd#4432 opened: cmd/snap,  tests/main/classic-confinement: fix snap-exec path when running under classic confinement <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4432>08:09
zygathank you mborzecki, looking :)08:12
mborzeckizyga: also reenabled one of the classic confinements tests on fedora now ;)08:12
zygamborzecki: approved08:15
zygamborzecki: I was thinking about the fedora symlink, perhaps we could enable that in prepare.sh globally08:15
zyganot a big deal and perhaps a risk in itsel08:15
zygalet's see if more tests start to need that08:16
mborzeckihm better talk to Son_Goku first08:16
mborzeckiuhh, you're talking about tests08:16
zygayes, just tests08:16
zygapstolowski: can you please review https://github.com/snapcore/snapd/pull/431508:21
mupPR #4315:  cmd/snap-update-ns: add execWritableMimic <Created by zyga> <https://github.com/snapcore/snapd/pull/4315>08:21
zygait has one +1 and I want to land it08:21
zygait's from november :'(08:21
mborzeckilooks like there's just a handfull of 'classic' confiment tests, we could enable fedora in those explicitly08:21
zygamborzecki, pstolowski: in case you need to do it, this is how to release the core snap: https://new.zygoon.pl/post/core-snap-release-mechanics/08:23
mborzeckizyga: good i'm not the only one finding arch/revision combination confusing08:25
mborzeckianyone wants to take a look at #4313? it's already been approved by niemeyer and needs a second review and perhaps comments on the syntax08:27
mupPR #4313: timeutil: refresh timer take 2 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4313>08:27
zygamborzecki: I'll do it next, looking at error in 442608:29
pstolowskizyga, will review. is mvo off today?08:29
zygapstolowski: I don't think he is but perhaps he feels worse than yesterday and is just not around yet08:30
zygamborzecki: reviewing now08:31
mborzeckibtw. any ide what's the status of fedora 27 in spread?08:45
zygamborzecki: no, is it broken?08:49
mborzeckizyga: see #4336, there's a comment from niemeyer about rawhide, and it has been addressed already08:56
mupPR #4336: spread.yaml: add fedora 27 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/4336>08:56
pstolowskizyga, reviewed 4315, mostly a few questions09:02
mborzeckimvo: hey, feeling better today?09:02
zygapstolowski: thanks, I'll check soon09:02
mvomborzecki: hey, good morning! yeah, still a bit weak but better09:03
mvoand good morning pstolowski  and zyga !09:03
pstolowskihey mvo! how are you feeling today?09:03
zygawelcome back mvo!09:03
kalikianamvo: o/09:04
mvohey kalikiana09:04
* mvo makes a cup of tea and starts looking at open PRs after that09:05
mupPR snapd#4432 closed: cmd/snap,  tests/main/classic-confinement: fix snap-exec path when running under classic confinement <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4432>09:24
zygamborzecki: booted my arch system, wish we had the binary package for snapd :/09:46
mborzeckizyga: pacaur and makepkg are your friends :)09:48
mupPR snapd#4433 opened: interfaces: allow socket "shutdown" syscall in default profile <Created by mvo5> <https://github.com/snapcore/snapd/pull/4433>09:48
zygamborzecki: while that's probably very arch of it it's not very snapd of it :)09:48
zygamborzecki: I wish we could fix the package in the archive09:48
=== d_ed is now known as d__ed
mborzeckione more classic confinement tests that can be enabled on fedora now09:58
mupPR snapd#4434 opened: tests/main/confinement-classic: enable the test on Fedora <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4434>09:58
zygamborzecki: hmm09:59
zygamborzecki: that test is special-ish09:59
zygamborzecki: think about what happens09:59
zygamborzecki: to really properly test that you need to use fedora base snap09:59
zygamborzecki: NAK unless you want to take it to the store and enable a pure binary built test (execution) on fedora09:59
zygamborzecki: sent more feedback in the PR10:02
mborzecki zyga: doesn't that apply to all distros?10:02
zygaand small break10:02
zygamborzecki: tests don't build C programs (most of the time)10:02
zygasee my feedback and let's talk here10:02
Chipacamvo: mborzecki: dunno if you saw my Q yesterday about #439410:10
mupPR #4394: snap: give the snap.Container interface a Walk method <Created by chipaca> <https://github.com/snapcore/snapd/pull/4394>10:10
mborzeckizyga: i'm looking at the makefile, looks like it's a least pain path without involving the store10:11
pedronisChipaca: hi, did you see my asking for reviews yesterday? :)10:12
Chipacapedronis: i did not10:12
Chipacapedronis: 'appropriate creds'?10:12
pedronisand #4389 (which is small)10:12
mupPR #4389: overlord/snapstate: override Snapstate.UserID in refresh if the installing user is gone <Created by pedronis> <https://github.com/snapcore/snapd/pull/4389>10:12
pstolowskizyga, ?10:18
zygaone sec10:18
mvoChipaca: oh, yes, I saw and forgot, I open the pR now10:18
mvoChipaca: so that I don't forget again10:19
zygathe bug is just in my branch10:21
zygafire over10:21
zygaand now it should work :)10:21
mvozyga: heh10:23
* mvo hugs zyga 10:23
zygaI fixed the base snap stale thing10:23
Chipacazyga: I love bugs that are only in your branches :-D10:24
mvozyga: neato!10:25
* kalikiana coffee break10:27
zygamvo: I was checking if I'm on classic on the inside of the mount ns :'-((10:28
zygapushed, I'll let travis deal with it now10:30
mborzeckizyga: about that test, it tries very hard to make sure that the binary works with ld.so and libs from the core snap, not sure why it should not run on non-ubuntu (btw. it's already enabled for suse and debian)10:31
zygamborzecki: it should be only built on ubuntu and should run everywhere10:34
zygamborzecki: suse is a bug here, it's equally meaningless10:34
zygamborzecki: the point is that it must match the core snap, not the distro10:35
zygamborzecki: to illustrate that any distro with the core snap can run correctly built classic snaps10:35
zygapstolowski: updated 4315 and responded to your feedback, thanks10:49
pstolowskizyga, thanks, looking10:49
mborzeckizyga: ok, i'll try to rework the test to have the snap installed from the store, probably will need some help in the process :)10:50
zygamborzecki: thank you, I'll gladly help10:50
mupPR snapd#4431 closed: snap: make `snap info invalid-snap` output more user friendly <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4431>10:56
mupPR snapd#4435 opened: snap: do not leak internal network errors to the user <Created by mvo5> <https://github.com/snapcore/snapd/pull/4435>11:12
zygamvo: +111:16
mvozyga: heh, nice one!11:17
pedronisChipaca: thanks11:20
Son_Gokumborzecki: yeah, no symlink is going into the real stuff11:47
Son_Gokuand the only way I'm accepting classic confinement for real is when you guys finally fix the /snap thing11:48
Son_Gokuso that /snap isn't the barrier to classic confinement11:48
zygaSon_Goku: that's impossible11:49
Son_Gokuno it isn't11:49
zygaSon_Goku: you know it, I know it11:49
Son_GokuI've actually talked to niemeyer about it before11:49
Son_Gokuthere is a way... it's just very difficult11:49
zygaSon_Goku: such as?11:49
Son_GokuI'd have to dig out old chat logs for that11:49
Son_Gokuwhich I don't have on hand atm11:49
zygaSon_Goku: when you have a moment please share, I'm curiou11:50
Son_Gokuwill do11:50
* Chipaca -> lunchmaking11:50
Chipacaogra_: ondra: are you both on holidays still?11:52
mborzeckiSon_Goku: https://github.com/snapcore/snapd/commit/563795fd8d628c64da4019aee3f5c6a845eb0fe7 might be worth cherry picking to Fedora package as it addresses an issue that broke running classic snaps (should the user do a /snap symlink first of course)11:53
Son_Gokumborzecki won't work11:53
Son_Gokure-exec is disabled in Fedora11:53
zygaSon_Goku: that's unrelated11:53
mborzeckiSon_Goku: it's not related to reexec11:53
Son_Gokuoh snapexec11:53
zygaSon_Goku: it's a correct bugfix11:53
mborzeckiwe were using the icnorrect path to snap-exec11:53
Son_Gokuyeah, I'll cherry pick it11:53
ogra_Chipaca, back tomorrow11:54
mborzeckiSon_Goku: great, thanks11:54
mupPR snapd#4436 opened:  snap: do not leak internal errors on install/refresh etc  <Created by mvo5> <https://github.com/snapcore/snapd/pull/4436>11:54
zygaSon_Goku: I updated my f27 yesterday11:54
Son_Gokuit's not in 2.30 either, so I'll pull it when I rebase to 2.3011:54
zygaSon_Goku: oddly it picked the updates in gnome-software but not in dnf? maybe I was still sleepy11:54
Son_Gokutry "dnf --refresh upgrade"11:54
zygaSon_Goku: I'll try next time, it's up-to-date now11:55
Son_Gokuzyga, kalikiana: I just got DNF into OpenSUSE Leap 15.012:14
zygaSon_Goku: will it replace zypper?12:15
zygaSon_Goku: what's the use case?12:15
Son_Gokufor snapcraft12:16
Son_Gokualso, kiwi can produce images for Fedora/CentOS with it12:16
kalikianaSon_Goku: woot, awesome12:16
Son_Gokuthe goal here is to have a single backend for rpm stuff12:16
Son_Gokuand pretty much all distributions that aren't SUSE are gradually converging on DNF12:17
Son_GokuSUSE has Zypper, which for all practical purposes works identically to DNF12:17
Son_Gokusince they use the same resolver12:17
mborzeckifwiw, even yocto also integrated dnf some time ago12:20
Son_GokuI helped out kanavin with that last year12:22
zygamborzecki: https://github.com/snapcore/snapd/pull/4337/files12:25
mupPR #4337: cmd/snap: use snap-exec from core with a classic snap when reexecing <Created by mwhudson> <https://github.com/snapcore/snapd/pull/4337>12:25
zygamborzecki: ^_^ i forgot about this12:26
zygamborzecki: maybe you want to review it12:28
mborzeckii've added a comment there12:28
zygaI have green :)12:33
zygaeveryone: please review this and let's have it in 2.3112:34
mupPR #4329:  cmd/snap-confine: discard stale mount namespaces (v2) <Created by zyga> <https://github.com/snapcore/snapd/pull/4329>12:34
mupPR snapd#4315 closed:  cmd/snap-update-ns: add execWritableMimic <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4315>12:34
zygamvo: 2.29 and 2.30 milestones on GH have no due date and are open12:34
zygamvo: (thank you for opening 2.31)12:34
zygajdstrand: ^12:36
pedronisgiven that 2.30 is stable now we can close 2.2912:37
zygaI agree12:37
mborzeckihmm i'm trying `snapcraft cleanbuild` with the test snap, but it fails both on arch (running from snaps) and on xenial (installed from repos)12:39
mborzeckion arch it's trying to push an assert file to the container, looks like it's confused about the path where the assert file is, maybe something with snap mount dir being different than /snap12:40
mupPR snapd#4437 opened: tests: add test that ensures we never parse versions as numbers <Created by mvo5> <https://github.com/snapcore/snapd/pull/4437>12:40
zygamborzecki: just build it manually12:40
zygamborzecki: upload to the store12:40
ondraChipaca no back working12:40
zygamborzecki: and share it with mvo12:40
ondraChipaca what's up?12:40
zygamborzecki: it's a special test IMO12:41
mborzeckion xenial, the container is started, i see it gets updated, but then i get `Temporary failure resolving 'archive.ubuntu.com'` when trying to install gcc as build-package12:41
zygamborzecki: request: please use test-snapd- prefix12:41
Chipacaondra: https://forum.snapcraft.io/t/best-practice-for-reporting-ubuntu-core-system-kernel-issues/338212:41
zygamborzecki: the dns issue you see is interesting and probably worth looking into, could be lxd specific, could be general /etc mess bug12:41
Chipacaondra: i thought maybe you had input there (otherwise ogra_ will get to it tomorrow i guess :-) )12:41
mborzeckizyga: i added --debug to cleanbuld, it dropped me to the shell and i can apt-get install gcc just fine :/12:42
zygagood then12:42
zygamborzecki: really just build it and push to the store12:42
ondraChipaca let me check12:44
ogra_"rainbow" (in the bug) sounds wrong all over ...12:49
ogra_would be somethig to verify ...12:50
ogra_regarding the bug filing i think using "Snappy" for image issues is fine as a catch all project12:50
Chipacaogra_: agreed. now get out of here.12:51
mupPR snapcraft#1842 opened: lxd: Change "Terminating" message to debug level <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/1842>12:55
mborzeckizyga: just to be sure, snapcraft register test-snapd-hello-classic && snapcraft push --release=edge test-snapd-hello-classic_*.snap ?13:01
zygamborzecki: looks right (I think)13:02
mborzeckimvo: pushed it to the store, the name is test-snapd-hello-classic13:05
kalikianasergiusens: good morning!13:16
sergiusenskalikiana hey, mind looking at what mborzecki is talking about?13:17
sergiusenszyga I m not sure, but it would be nice to have an API to retrieve the snap-declaration/revision assertion from snapd :-)13:17
kalikianamborzecki: can you paste your log somewhere?13:20
mborzeckikalikiana: https://paste.ubuntu.com/26312927/ snapcraft from snaps, trying cleanbuild on arch, lxd seems to work just fine13:22
kalikianamborzecki: I notice `error: open /var/lib/snapd/hostfs/` are you using the lxd snap from edge?13:26
pedronismvo: this is the PR I mentioned: #439213:26
mupPR #4392: many: refresh with appropriate creds <Created by pedronis> <https://github.com/snapcore/snapd/pull/4392>13:26
kalikianamborzecki: the snap broke just before xmas13:26
zygasergiusens: I think you can already, via the snap known API13:27
zygasergiusens: or are you talking about getting them from the store for snaps snapd doesn't know about?13:27
mborzeckikalikiana: https://paste.ubuntu.com/26312943/ and this is snapcraft on xenial, from packages, when i get dropped to debug shell i can successfuly install required packages, not sure why it's hitting a timeout there :/13:28
mvopedronis: thanks13:29
mborzeckimvo: the PR with the snap is #443413:31
mupPR #4434: tests/main/confinement-classic: enable the test on Fedora <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4434>13:31
kalikianamborzecki: Broken DNS would be my guess. It seems to work and then fails later on. Did you do `lxd init`and go through the terminal UX to set up the network?13:31
zygakalikiana, mborzecki: look at /etc/nsswitch.conf please, see if it's fishy13:32
zygawe could use a DNS-test-snap (spread test)13:32
zygathat exercises glibc API and maybe systemd-specific new API13:32
mborzeckikalikiana: cleanbuild --debug drops me to the shell in the container right?13:33
kalikianamborzecki: Yes13:33
sergiusenszyga for snaps installed, kalikiana are you using that?13:34
mvomborzecki: please run "snapcraft release test-snapd-hello-classic 1 edge"13:34
mvomborzecki: and your snap should be availabe, then we need to transfer your snap13:34
mborzeckikalikiana: when i'm dropped to the shell, i can install gcc just fine13:35
mborzeckimvo: done13:36
kalikianasergiusens: zyga for locally installed snaps, we have code in snapcraft to get assertions via the snaps endpoint (https://github.com/snapcore/snapd/wiki/REST-API#get-v2snapsname) . If that's what you're looking for, checkout this code https://github.com/snapcore/snapcraft/blob/master/snapcraft/internal/lxd/_containerbuild.py#L23613:37
kalikianamborzecki: I can believe that. And unfortunately it doesn't contradict what I said13:37
kalikianathat's what broken DNS does13:38
mvomborzecki: cool, now fire away, your test hopefully works now13:38
zygamy keyboard seems to have issues when I do backups over wifi :/13:38
zygasergiusens: I mean whatever fuels "snap known", not sure what that is13:39
mborzeckimvo: thx, started the test just now :)13:39
mborzeckizyga: tried switching the wifi to 5ghz band?13:39
zygamborzecki: I am using it13:39
zygamborzecki: (ah, no)13:39
zygaperhaps it's not13:39
kalikianamborzecki: You can also check `ifconfig` and `/etc/resolv.conf` if there's a proper IP and ns respectively13:40
zygamy backup is to a "home" network that uses a mixture of 2.4 and 513:40
mborzeckikalikiana: fyi, it's also runnign in a vm :), so it's qemu -> xenial -> lxd in this case :)13:41
kalikianamborzecki: that's generally fine. I'd try `sudo dpkg-reconfigure lxd` suspecting you didn't configure it before13:43
kalikianain the xenial running in the vm13:44
kalikianamborzecki: I'm heading out for lunch now. If that doesn't do the trick I'll try to think of what else to debug there13:46
mborzeckikalikiana: thanks, i've reconfigured lxd and trying a cleanbuild now13:46
mborzeckikalikiana: seems to work now :) thanks again13:47
kalikianamborzecki: Sweet! Glad it worked!13:49
* kalikiana now trying to leave the house without being blown away by the wind13:49
mborzeckistill got some spread tests running, but i'm wrapping it up for today14:15
pedronismvo: seems we changed something about test-snapd-toosl release status, and now test snap-info failes14:33
pedronistest-snapd-tools.channels.beta expected '↑', got '2.10      (7) 12kB -'14:33
pedronisbeta was closed and now it has a different release14:34
mvopedronis: uh, I can fix this14:35
mvopedronis: fixed, sorry for the trouble14:36
pedronismvo: is the new version needed for some work in progress?14:37
mvopedronis: yes for my latest PR but I can use a different snap or adjust the tests in my PR, I don't want to break the world with that14:39
pedronisok, thank you14:39
elopiogood morning! :D14:55
kalikianahey elopio15:05
kalikianaelopio: whilst preparing snapcraft#1842 I noticed we seem to have no way to test if log messages use the expected level (debug, info). might be nice to consider what we could do about it in the future15:08
mupPR snapcraft#1842: lxd: Change "Terminating" message to debug level <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/1842>15:08
elopiokalikiana: yeah, we have pending a complete redesign of logs, info messages and errors. Currently we have a mix of prints, logs and exceptions15:09
kalikianaelopio: I'm referring to existing uses of `logger`. There's no way to test that they use the correct level15:10
kyrofakalikiana, you can make a fake logger that grabs a specific level15:12
kalikianakyrofa: Hmmm do we have an example of this?15:16
kyrofaYeah let me find one15:16
kyrofakalikiana, look at test_yaml_missing_confinement_must_log in unit/project_loader/test_config.py15:21
kyrofaIt's the FakeLogger fixture. It grabs whatever logging level you define as well as more critical levels15:21
kyrofaPerhaps that latter point makes it less useful for your case, I'm not sure15:22
kalikianakyrofa: Hm... I think I need sort of the opposite. Assuming info would be 'more critical' I'd get the message, whether it's info or debug15:24
kyrofakalikiana, are you trying to verify a message is debug, or info?15:25
kalikianakyrofa: I'm changing the message from info to debug. I'd like to verify it's debug only.15:25
kyrofakalikiana, you can change the log format in that fixture to include the log level15:28
kyrofaKinda hacky, but then you could match the log level15:28
kalikianaHmmm I'll give that a go. Thanks!15:33
mupPR snapcraft#1843 opened: elf: warn if primed files will not work with the base's linker <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/1843>15:56
sergiusenskyrofa elopio ^15:59
* sergiusens is not a fan of checking for existence or lack of messages logged in tests16:00
kalikianasergiusens: kyrofa: elopio This is what I came up with https://github.com/snapcore/snapcraft/pull/1842/commits/535cefbabbdb69481a4a6cc73ed3998e551d1f82 I'm not checking existence here, but rather that the level is correct16:03
mupPR snapcraft#1842: lxd: Change "Terminating" message to debug level <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/1842>16:03
elopiosergiusens: checking...16:13
elopiokalikiana: I don't think that test is really necessary, mainly because as I said, we need to rethink our logger. I'm happy with tests that set the fake logger to debug, and check if the debug message is there16:17
elopioeven if that will miss the specific level of the message. But your test looks correct too, I don't see a problem to land it.16:18
=== Tribaal is now known as tribaal
kalikianaelopio: A test that checks if the message is there won't fail without my change16:24
elopioI know, I'm saying I don't mind that that line is not fully covered. But it's ok if you care about it, of course.16:26
mupPR snapcraft#1832 closed: cmake plugin: update plugin details <codein> <Created by konrad11901> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1832>16:35
kalikianasergiusens: FYI I was certain there was a bug for this but couldn't find it... so I filed a new one in any case https://bugs.launchpad.net/snapcraft/+bug/1741082 This is for the permission issues with staged packages in conjunction with sshfs16:37
mupBug #1741082: sshfs breaks with serving user files to root in LXD <Snapcraft:Confirmed for kalikiana> <https://launchpad.net/bugs/1741082>16:37
kalikianaelopio: I can also back it out and we plan for a better solution. This was a pretty quick hack anyway. I just feel a bit... uneasy committing untested code16:50
* kalikiana wrapping up for the day shortly - will have to push the sshfs PR in the morning since the tests aren't ready16:51
mupPR snapcraft#1844 opened: Included fix for error messages <Created by Tanesh1701> <https://github.com/snapcore/snapcraft/pull/1844>16:59
sparkiegeekhi snappy-devs! I'm a bit green when it comes to Golang coding, but am trying to just run the tests before making any changes and am hitting https://paste.ubuntu.com/26313885/17:04
sparkiegeekany clues?17:05
Chipacasparkiegeek: your vet is newer or older than ours :-)17:06
sparkiegeekChipaca: ⟫ go version17:06
sparkiegeekgo version go1.8.3 linux/amd6417:06
sparkiegeekChipaca: which one do I want?17:06
Chipacasparkiegeek: actually, i just checked and 1.6 and 1.9 are both happy with that file17:07
pedronisChipaca: it's interesting though that afaict Plug and Slot don't have a String17:07
pedronisso that might be ok but not ideal17:07
pedronismaybe pstolowski should look at that17:08
mupPR snapd#4438 opened:  snap: add new `snap advice-command` skeleton <Created by mvo5> <https://github.com/snapcore/snapd/pull/4438>17:08
sparkiegeekok, so in the meantime... should I just ignore it? or should i use a different go version?17:09
sparkiegeekI can't see anything in HACKING.md about what the supported Go version is17:09
mvosparkiegeek: just ignore the bet errors while we investigate, just run ./run-checks --unit in the meantime17:09
mvosparkiegeek: we support *all* (kidding, we should add go1.6+)17:10
mvosparkiegeek: a PR with the fix for the HACKING.md would be welcome :-D go1.6+ is what we support17:11
pstolowskisparkiegeek, pedronis, will fix the code17:12
pedronisChipaca: afaict %s doesn't produce anything sane with a struct without String that doesn't have all fields that are strings17:13
pstolowskiPlugInfo and SlotInfo do have String()17:14
sparkiegeekmvo: on it17:14
* zyga is more awake now, sorry for being absent earlier17:14
pstolowskiah, it's Plug/Slot17:14
zygaI was writing (but not code)17:14
zygaabout sanpd17:14
mvosparkiegeek: \o/17:15
pedronisChipaca: otoh golang.org at the moment doesn't let me share my example17:15
sparkiegeekmvo: https://github.com/snapcore/snapd/pull/443917:17
mupPR #4439: Add documentation for supported Go versions <Created by sparkiegeek> <https://github.com/snapcore/snapd/pull/4439>17:17
pstolowskipedronis, is it possible vet got confused? i'm looking at these lines and they are dealing with PlugInfo and SlotInfo (and these have String()), not interfaces.Plug/Slot as indicated by vet17:17
mupPR snapd#4439 opened: Add documentation for supported Go versions <Created by sparkiegeek> <https://github.com/snapcore/snapd/pull/4439>17:17
pedronispstolowski: ah17:17
pedronisinteresting or sparkiegeek doesn't have master ??17:17
pstolowskior that...17:18
zygapstolowski: I looked at that once and it looks like vet bug17:19
zygapstolowski: it's meaningless (the error)17:19
sparkiegeekI'm running 55648cb8358825a18c6f926c38416703b48edd1f afaics17:19
sparkiegeekbut I'd definitely suspect PEBKAC if it's not reproducible? I'm just using Go from Artful17:21
pstolowskisparkiegeek, ok, that's the latest17:21
pstolowskisparkiegeek, looks more like a vet bug as zyga says. the error mentions wrong type, it's not the one used in the code17:22
sparkiegeekpstolowski: I mean, I might well have screwed things up, I find myself battling $GOPATH quite often :)17:22
mupPR snapd#4426 closed: snap: print friendly message if `snap keys` is empty <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4426>17:55
mupPR snapd#4433 closed: interfaces: allow socket "shutdown" syscall in default profile <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4433>17:55
sparkiegeekweird, now I've made my changes I don't get the vet complaint :/17:58
sparkiegeekof course, now I have a newer version of shellcheck complaining about other things!17:59
mborzeckiiirc vet (and some other static analysis tools) may depend on whether the package archive files (*.a) are up to date with the code18:01
sparkiegeekmborzecki: ah, that might explain it. Last time I built snapd was many months ago18:02
pmatulis'snap search' outputs a short list of snaps. why?18:03
zygapmatulis: those are 'curated chices' to show some snaps, akin to "browse the store"18:03
zygapmatulis: just very early version of that concept18:03
mvopmatulis: quite a few people are confused by this, we have https://github.com/snapcore/snapd/pull/4382 to help with that18:04
mupPR #4382: snap: show header/footer when `snap find` is used without arguments <Created by mvo5> <https://github.com/snapcore/snapd/pull/4382>18:04
sparkiegeekright see #170056018:05
mupBug #1700560: “snap find” returns confusing results <Snappy:In Progress> <Snap Store:Invalid> <https://launchpad.net/bugs/1700560>18:05
mborzeckisparkiegeek: more info about vet - https://github.com/golang/go/issues/20514 and https://github.com/golang/go/issues/1608618:15
mupPR snapcraft#1845 opened: cli: implement help <command> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/1845>18:26
sergiusenselopio kyrofa ^18:26
mvopedronis: you have a review for the private refresh PR, I love the level of testing, great work!18:39
pmatuliszyga, thanks. it's true that it's incredibly confusing. it can lead people to believe those are the *only* snaps available18:44
sparkiegeeksergiusens: 😍 @ snapcraft help <command>18:46
mvopmatulis: *cough* thanks for the feedback, we aim the fix for 2.3118:49
sergiusenssparkiegeek oh yeah18:51
sparkiegeeksergiusens: best Xmas 🎁 yet :)18:52
noise][sergiusens: what's the timeline for next stable release?19:10
sergiusenselopio fixed19:18
sergiusensnoise][ as a snap, during CPT; as a deb, I'll need to do some bribing to avoid backporting new dependencies19:19
noise][sergiusens: cool, i'm just eager to get the metadata editing stuff out the door, thanks!19:20
sergiusensnoise][ it sort of is already, most of are users are running from `edge`19:20
noise][~ 1/4-ish from stats19:21
sergiusensooh, they have changed. I'll need to take a look again19:22
sergiusensnoise][ so, elopio will be doing sanity checking of what is in beta and with that data we will have early data to promote to stable. These numbers make me want to have the current beta (2.38) in candidate sooner to have it go to stable even19:23
elopiosergiusens: you didn't update the docstring.19:31
sergiusenselopio done now19:34
pedronismvo: thanks, will look in my morning19:38
mupPR snapd#4389 closed: overlord/snapstate: override Snapstate.UserID in refresh if the installing user is gone <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/4389>19:58
mupPR snapd#4337 closed: cmd/snap: use snap-exec from core with a classic snap when reexecing <Created by mwhudson> <Closed by mwhudson> <https://github.com/snapcore/snapd/pull/4337>20:10
* zyga waves at mwhudson 20:10
mwhudsonzyga: morning20:10
sergiusenskyrofa pushed fixes20:17
mupPR snapcraft#1840 closed: docker: instructions to build from the snap <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1840>21:06
pmatulismvo, ty21:27
mupIssue snapcraft#1699 closed: snapcraft <help> command <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/issue/1699>22:00
mupPR snapcraft#1845 closed: cli: implement help <command> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1845>22:00
mupIssue snapcraft#1700 closed: snapcraft help <plugin>|<sources> <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/issue/1700>22:03

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!