villyam | hi elopio | 01:45 |
---|---|---|
elopio | villyam: helo | 01:46 |
villyam | hi kyrofa | 01:46 |
villyam | hi serguisens | 01:46 |
villyam | hi popey | 01:46 |
villyam | hi | 01:46 |
tsimonq2 | hey hey hey | 01:47 |
villyam | hi flexiondotorg | 01:47 |
daniellimws | tsimonq2 just got ignored | 01:48 |
tsimonq2 | :( | 01:48 |
coolpolygons | hey tsimonq2 can u check my task? https://codein.withgoogle.com/dashboard/task-instances/4613563035418624/ | 05:49 |
tsimonq2 | coolpolygons: It's not the end of the day yet here and I'm close to it on my todo list | 05:50 |
coolpolygons | oh srry i dont know the utf -6 time :P | 05:50 |
coolpolygons | i thought a day has already passed :( | 05:51 |
tsimonq2 | coolpolygons: Approved. | 05:54 |
coolpolygons | thank you :D | 05:54 |
tsimonq2 | yw | 05:55 |
Accelerator | hi | 06:45 |
m4sk1n | elopio: but it would require running the whole build in lxd, is it what we want to do? | 07:03 |
m4sk1n | maybe there is any way to run `npm run dist` with skipping snap test? | 07:04 |
didrocks | daniellimws[m]: hey! I'm probably have some rendering issue on the graphic card, under the video editing tab, the blender renderer is just plain black | 08:31 |
didrocks | I'm still unsure why I have this title though | 08:31 |
didrocks | moving the cursor gives me some artefacts, so there is clearly something not rendering well… | 08:32 |
daniellimws | didrocks, the title should be expected | 08:33 |
didrocks | why? shouldn't it be something in English? | 08:33 |
daniellimws | as it is at the start of the screencast | 08:33 |
daniellimws | I'm not sure I think it just randomly picks one language | 08:34 |
didrocks | interesting ;) | 08:34 |
didrocks | well, I'll let you render with a low res | 08:34 |
daniellimws | but when it is built it will correspond to the correct language | 08:34 |
daniellimws | yea ok sure | 08:34 |
didrocks | to give a first feedback | 08:34 |
daniellimws | I hope I don't have to make any changes because that'll just be another 20 mins of rendering time :( | 08:35 |
didrocks | daniellimws: yeah, let's see, the day we'll generate the real one, I'll switch laptop or ask someone else to deal with this | 08:36 |
daniellimws | I thought we'll be generating the video via the package? | 08:37 |
daniellimws | anyways I'm using a scrappy intel integrated graphics card so I'll just have to deal with it | 08:38 |
daniellimws | s/package/package build | 08:46 |
didrocks | daniellimws: yeah, if possible. Now that I see those artefacts… Unsure the builders suit it | 08:47 |
didrocks | daniellimws: so, I think some modifications should be done | 09:04 |
didrocks | daniellimws: like, first, clicking on an app displayed in the dock | 09:04 |
didrocks | then, clicking on the application icon to show more apps and starting another app which isn't in the dock | 09:05 |
didrocks | making sense? | 09:05 |
daniellimws | yea | 09:05 |
didrocks | the rest looks good :) | 09:05 |
daniellimws | regarding the webm videos, as mentioned last time "make" wont generate them, but you said ideally we generate them during package building, how do we achieve that? | 09:07 |
daniellimws | or rather generating the webm videos in general, say I want to do it now | 09:08 |
didrocks | daniellimws: I think it's a question of running blender with the correct options, hooking them up in debian/rules under the dh_auto_build target | 09:10 |
didrocks | as my current laptop doesn't seem to work well with blender, I can't really experiment the correct options unfortunately… | 09:10 |
didrocks | once I switch to another one, will be better | 09:10 |
didrocks | but don't sweat too much on it, the task doesn't require to do that and I'll achieve it myself as needed | 09:10 |
daniellimws | ok, sure thing | 09:11 |
daniellimws | with that said, shall I just give you the .blend files and .page files with the updated transcripts? | 09:13 |
didrocks | daniellimws: sure! just ensure once all the videos are done to have a quick rendering so that I can give finale feedbacks, but for completing the task, just give the .blend and .page files and I'll do what's needed | 09:14 |
konrad11901 | didrocks: hi! I'd like to to this appstream metadata task (https://codein.withgoogle.com/tasks/6215052078088192), but actually, the description is pretty general and doesn't provide many details. Could you describe this task a little bit more (like, where should we change the metadata, also some sort of example would be useful)? | 09:22 |
konrad11901 | s/to to/to do | 09:23 |
didrocks | konrad11901: I'm asking a friend to join, he's an appstream metadata specialist! :) | 09:26 |
konrad11901 | ok, thanks! :) | 09:27 |
didrocks | konrad11901: sending you his emails, he will be off for a little bit and back later on | 09:29 |
konrad11901 | didrocks: thanks! :) | 09:33 |
omairqazi | hi | 10:52 |
konrad11901 | hi | 10:52 |
pranavgade20 | hi guys | 12:17 |
omairqazi | hi guys | 13:06 |
konrad11901 | sergiusens: could you check my submission please? :) | 13:43 |
omairqazi | any idea when tsimonq2 will come here | 13:47 |
tsimonq2 | I'm spontaneous, you can't predict me /o/ \o\ /o/ | 13:49 |
tsimonq2 | And empty pings solve nothing btw ;) | 13:49 |
omairqazi | tsimonq2: hi! please take a look at my submission https://codein.withgoogle.com/dashboard/task-instances/6047433035350016/ | 13:54 |
tsimonq2 | omairqazi: Have fun :) | 13:58 |
tsimonq2 | (approved) | 13:58 |
omairqazi | tsimonq2: thanks | 13:58 |
elopio | m4sk1n: if you skip running snapcraft, then the snap won't be generated. | 15:01 |
sergiusens | konrad11901 your PR fails | 15:17 |
Villyam12 | Hi elopio, kyrofa, sergiusens, popey and flexiondotorg | 15:18 |
elopio | hello Villyam12 | 15:18 |
daniellimws | sergiusens, hi can you help approve the tasks related to my recent 2 PRs? | 15:39 |
Villyam12_ | Hey elopio How am I supposed to select the project | 15:41 |
Villyam12_ | I've gone to the github upstream candidate snaps | 15:42 |
Villyam12_ | I think I'll go with the mps-youtube snap | 15:43 |
Villyam12_ | Oh I'm supposed to select a python snap....... | 15:44 |
Villyam12_ | Wait that is a python snap, sorry | 15:45 |
m4sk1n | elopio: I know | 15:57 |
konrad11901 | sergiusens: hmm, I don't know why it fails, any advice? :/ | 16:04 |
konrad11901 | elopio, you there? | 16:10 |
elopio | konrad11901: I'm her | 16:11 |
elopio | e | 16:11 |
konrad11901 | could you take a look at my PR and see why the integration tests fail? | 16:11 |
konrad11901 | s/see/check | 16:11 |
elopio | konrad11901: it ran too long. It's not caused by your changes, maybe by the slow down of the world because of the big bugs recently found. | 16:12 |
elopio | When a suite takes too long we split it, so I will take a look at the other branches to see if this was an unfortunate situation, or a thing that I need to fix. | 16:13 |
sergiusens | daniellimws can you add a link to the PR in the task? | 16:13 |
konrad11901 | yeah, I also thought that it's not my fault :/ | 16:13 |
elopio | konrad11901: pleae rebase your branch with master and push again. | 16:13 |
konrad11901 | ok | 16:13 |
konrad11901 | done, the tests are running | 16:14 |
elopio | thanks konrad11901 | 16:15 |
Nissaar | popey: hi | 16:50 |
daniellimws[m] | elopio, hi can you approve my add unit tests task? | 16:50 |
elopio | daniellimws[m]: I don't see any tasks for review. | 16:53 |
Nissaar | elopio: hi i need help with ,y task | 16:53 |
Nissaar | https://codein.withgoogle.com/dashboard/task-instances/5373896733753344/ | 16:53 |
Nissaar | im packaging superpowers app | 16:53 |
Nissaar | https://gist.github.com/popey/7803cfbda9b337fab792c403e50e4709 | 16:53 |
Nissaar | ollowing this tutorial | 16:53 |
elopio | Nissaar: how can I help? | 16:53 |
Nissaar | when it comes to snap run dist | 16:54 |
Nissaar | error: cannot find current revision for snap dist: readlink /snap/dist/current: no such file or directory | 16:54 |
Nissaar | this is the output. and there is no script section in the package.json file | 16:54 |
daniellimws[m] | elopio, sorry just submitted, maybe a network issue just now | 16:55 |
wxl | a little less than 30 more completed tasks and we'll be in 6 place | 16:56 |
wxl | https://gci-leaders.netlify.com/ | 16:56 |
Nissaar | elopio: what should i do ? | 16:58 |
elopio | Nissaar: please push your changes to the repo, and I will try to reproduce. | 16:58 |
Nissaar | push it to my forked repo ? | 16:59 |
Nissaar | elopio:ush it to my forked repo ? | 17:00 |
elopio | Nissaar: yes. Then I can pull it and try the same commands that you are trying | 17:01 |
Nissaar | ok im on it | 17:01 |
Nissaar | elopio: https://github.com/Nissaar/superpowers-app | 17:04 |
Nissaar | elopio: is it good ? | 17:04 |
elopio | Nissaar: no, you need to commit and push your branch | 17:04 |
Nissaar | elopio: can you please check it now ? | 17:06 |
elopio | now I see it Nissaar | 17:06 |
Nissaar | yay thx. ill wait for you | 17:07 |
Nissaar | elopio: i have uploaded creeshots of the terminal in the following link | 17:10 |
Nissaar | https://codein.withgoogle.com/dashboard/task-instances/5373896733753344/ | 17:10 |
elopio | Nissaar: that's not how you use electron-builder. The "linux" key must go inside a "build" key. You can learn more about it here: https://www.electron.build/ | 17:13 |
elopio | but I would recommend you to start with an app that it's already building for linux, so you just add the "snap" builder. | 17:14 |
elopio | otherwise you might find many unexpected problems, and that wouldn't be a good task to start learning. | 17:14 |
Nissaar | can you suggest an app ? | 17:14 |
Nissaar | you mean the linux key should be in the build key in the scripts section ? | 17:15 |
Nissaar | elopio: do you think ndm would be better for me ? | 17:19 |
elopio | Nissaar: you can try. It looks nice. | 17:20 |
Nissaar | ok im on it | 17:20 |
Nissaar | WARN engine hawk@6.0.2: wanted: {"node":">=4.5.0"} (current: {"node":"4.2.6","npnpm WARN deprecated gulp-clean-css@2.4.0: breaking changes from clean-css 4.x. Please install gulp-clean-css 3.x | 17:24 |
Nissaar | elopio: when it says these things, shoould i modify the package.json file to suit these ? | 17:25 |
elopio | Nissaar: did it fail? It sounds like a warning, not an error | 17:26 |
elopio | and doesn't sound like something you introduced | 17:26 |
Nissaar | its a warning. im running npm install right now | 17:27 |
Nissaar | and it has said these things. just wanna know if i should change the package.json file | 17:27 |
Nissaar | elopio: can you please check this ? https://imgur.com/a/SYNcE | 17:33 |
elopio | Nissaar: try npm run linux instead of npm run dist | 17:36 |
Nissaar | elopio: it has opened the application ndm. i think thats right ? | 17:37 |
Nissaar | https://imgur.com/a/dBS7D | 17:38 |
elopio | Nissaar: that looks like the file browser, not ndm | 17:39 |
Nissaar | which one should i take as the snapname to install it with dangerous ? | 17:39 |
Nissaar | yes thats file browser. im searching the application name.snap to install with dangerous | 17:40 |
Nissaar | this is ndm https://imgur.com/a/ZsWsF | 17:40 |
elopio | yeah, that one looks good. I'm not sure why you have so many .snap files. | 17:42 |
Nissaar | yes. its confusing to know which one is the snap to be installed | 17:42 |
elopio | Nissaar: well, non of the ones in the screenshot looks like the ndm snap | 17:44 |
Nissaar | elopio: uhhmmm what should i do now ? | 17:45 |
elopio | Nissaar: commit and push your branch, so we can give it a try. | 17:46 |
Nissaar | im on it | 17:47 |
Nissaar | done | 17:52 |
Nissaar | i had a problem while git commit -m "Add...." tho. | 17:52 |
Nissaar | elopio:https://imgur.com/a/0Ksdz | 17:53 |
elopio | Nissaar: that doesn't look like something git would run. | 17:57 |
elopio | that's the output of an npm command most likely | 17:57 |
Nissaar | https://imgur.com/a/G8eD0 | 17:58 |
Nissaar | elopio: take a look at this | 17:58 |
elopio | Nissaar: so you have found an upstream bug :) | 18:01 |
elopio | in this line | 18:01 |
Nissaar | i think so | 18:01 |
elopio | https://github.com/720kb/ndm/blob/master/lib/js/npm/npm-api.js#L221 | 18:01 |
elopio | it should be !== | 18:01 |
elopio | you can propose a pull request upstream with that change | 18:02 |
Nissaar | elopio: https://github.com/720kb/ndm/pull/238 | 18:04 |
ubot93 | Pull 238 in 720kb/ndm "upstream bug" [Open] | 18:04 |
Nissaar | here it is | 18:04 |
elopio | Nissaar: the title of the bug should be more useful than that | 18:05 |
elopio | something like: fix lint error: replace != with !== | 18:06 |
elopio | Nissaar: also, your imgurs are not very nice for sharing terminal snippets. It's better to use paste.ubuntu.com | 18:07 |
Nissaar | ill use it next time. thx | 18:08 |
Nissaar | elopio: https://github.com/720kb/ndm/pull/239 | 18:08 |
ubot93 | Pull 239 in 720kb/ndm "fix lint error: replace != with !==" [Open] | 18:08 |
Nissaar | after this pull request has been done, should i fork, clone again and start all over with npm install etc... ? | 18:09 |
elopio | Nissaar: you can rebase your snapcraft branch with this patch-2 branch | 18:13 |
elopio | and then commit, push, and I can take a look. No need to fork and clone. | 18:14 |
Nissaar | i dnt know how to use that rebase command | 18:15 |
Nissaar | :( | 18:15 |
elopio | Nissaar: On your cloned directory run git fetch | 18:19 |
elopio | then git checkout add-snap-support | 18:19 |
elopio | then git rebase patch-2 | 18:19 |
Nissaar | im getting this error | 18:21 |
Nissaar | elopio:atal: Needed a single revision invalid upstream patch-2 | 18:21 |
elopio | hum, hum, please paste all the git commands and outputs you tried | 18:23 |
Nissaar | git fetch remote: Counting objects: 7, done. remote: Compressing objects: 100% (7/7), done. remote: Total 7 (delta 0), reused 0 (delta 0), pack-reused 0 Unpacking objects: 100% (7/7), done. From https://github.com/Nissaar/ndm * [new branch] add-snap-support -> origin/add-snap-support * [new branch] patch-1 -> origin/patch-1 * [new branch] patch-2 -> origin/patch-2 nissaar@nissaar-CX62-7QL:~/ndm$ git | 18:24 |
Nissaar | nissaar@nissaar-CX62-7QL:~/ndm$ git checkout -b add-snap-support fatal: A branch named 'add-snap-support' already exists. nissaar@nissaar-CX62-7QL:~/ndm$ git rebase patch-2 fatal: Needed a single revision invalid upstream patch-2 nissaar@nissaar-CX62-7QL:~/ndm$ git checkout add-snap-support Already on 'add-snap-support' nissaar@nissaar-CX62-7QL:~/ndm$ git rebase patch-2 fatal: Needed a single revision invalid upstream patch- | 18:25 |
elopio | Nissaar: not here, in paste.ubuntu.com, next time :) | 18:26 |
Nissaar | elopio:https://paste.ubuntu.com/26361644/ | 18:27 |
elopio | Nissaar: try git rebase origin/patch-2 | 18:29 |
Nissaar | elopio: already pushed | 18:30 |
elopio | Nissaar: I need to have food now. I will keep looking at it later. You can also start a topic in the forum, and then more people can help and you don't have to wait for me. | 18:33 |
Nissaar | ok no problem. | 18:34 |
Nissaar | elopio: enjoy your meal | 18:34 |
konrad11901 | sergiusens: all the tests pass :) | 21:13 |
=== Ubuntu is now known as Guest36287 | ||
Guest36287 | Hello Documentation Team! | 22:32 |
DoubleDee | hello | 23:32 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!