[01:45] hi elopio [01:46] villyam: helo [01:46] hi kyrofa [01:46] hi serguisens [01:46] hi popey [01:46] hi [01:47] hey hey hey [01:47] hi flexiondotorg [01:48] tsimonq2 just got ignored [01:48] :( [05:49] hey tsimonq2 can u check my task? https://codein.withgoogle.com/dashboard/task-instances/4613563035418624/ [05:50] coolpolygons: It's not the end of the day yet here and I'm close to it on my todo list [05:50] oh srry i dont know the utf -6 time :P [05:51] i thought a day has already passed :( [05:54] coolpolygons: Approved. [05:54] thank you :D [05:55] yw [06:45] hi [07:03] elopio: but it would require running the whole build in lxd, is it what we want to do? [07:04] maybe there is any way to run `npm run dist` with skipping snap test? [08:31] daniellimws[m]: hey! I'm probably have some rendering issue on the graphic card, under the video editing tab, the blender renderer is just plain black [08:31] I'm still unsure why I have this title though [08:32] moving the cursor gives me some artefacts, so there is clearly something not rendering well… [08:33] didrocks, the title should be expected [08:33] why? shouldn't it be something in English? [08:33] as it is at the start of the screencast [08:34] I'm not sure I think it just randomly picks one language [08:34] interesting ;) [08:34] well, I'll let you render with a low res [08:34] but when it is built it will correspond to the correct language [08:34] yea ok sure [08:34] to give a first feedback [08:35] I hope I don't have to make any changes because that'll just be another 20 mins of rendering time :( [08:36] daniellimws: yeah, let's see, the day we'll generate the real one, I'll switch laptop or ask someone else to deal with this [08:37] I thought we'll be generating the video via the package? [08:38] anyways I'm using a scrappy intel integrated graphics card so I'll just have to deal with it [08:46] s/package/package build [08:47] daniellimws: yeah, if possible. Now that I see those artefacts… Unsure the builders suit it [09:04] daniellimws: so, I think some modifications should be done [09:04] daniellimws: like, first, clicking on an app displayed in the dock [09:05] then, clicking on the application icon to show more apps and starting another app which isn't in the dock [09:05] making sense? [09:05] yea [09:05] the rest looks good :) [09:07] regarding the webm videos, as mentioned last time "make" wont generate them, but you said ideally we generate them during package building, how do we achieve that? [09:08] or rather generating the webm videos in general, say I want to do it now [09:10] daniellimws: I think it's a question of running blender with the correct options, hooking them up in debian/rules under the dh_auto_build target [09:10] as my current laptop doesn't seem to work well with blender, I can't really experiment the correct options unfortunately… [09:10] once I switch to another one, will be better [09:10] but don't sweat too much on it, the task doesn't require to do that and I'll achieve it myself as needed [09:11] ok, sure thing [09:13] with that said, shall I just give you the .blend files and .page files with the updated transcripts? [09:14] daniellimws: sure! just ensure once all the videos are done to have a quick rendering so that I can give finale feedbacks, but for completing the task, just give the .blend and .page files and I'll do what's needed [09:22] didrocks: hi! I'd like to to this appstream metadata task (https://codein.withgoogle.com/tasks/6215052078088192), but actually, the description is pretty general and doesn't provide many details. Could you describe this task a little bit more (like, where should we change the metadata, also some sort of example would be useful)? [09:23] s/to to/to do [09:26] konrad11901: I'm asking a friend to join, he's an appstream metadata specialist! :) [09:27] ok, thanks! :) [09:29] konrad11901: sending you his emails, he will be off for a little bit and back later on [09:33] didrocks: thanks! :) [10:52] hi [10:52] hi [12:17] hi guys [13:06] hi guys [13:43] sergiusens: could you check my submission please? :) [13:47] any idea when tsimonq2 will come here [13:49] I'm spontaneous, you can't predict me /o/ \o\ /o/ [13:49] And empty pings solve nothing btw ;) [13:54] tsimonq2: hi! please take a look at my submission https://codein.withgoogle.com/dashboard/task-instances/6047433035350016/ [13:58] omairqazi: Have fun :) [13:58] (approved) [13:58] tsimonq2: thanks [15:01] m4sk1n: if you skip running snapcraft, then the snap won't be generated. [15:17] konrad11901 your PR fails [15:18] Hi elopio, kyrofa, sergiusens, popey and flexiondotorg [15:18] hello Villyam12 [15:39] sergiusens, hi can you help approve the tasks related to my recent 2 PRs? [15:41] Hey elopio How am I supposed to select the project [15:42] I've gone to the github upstream candidate snaps [15:43] I think I'll go with the mps-youtube snap [15:44] Oh I'm supposed to select a python snap....... [15:45] Wait that is a python snap, sorry [15:57] elopio: I know [16:04] sergiusens: hmm, I don't know why it fails, any advice? :/ [16:10] elopio, you there? [16:11] konrad11901: I'm her [16:11] e [16:11] could you take a look at my PR and see why the integration tests fail? [16:11] s/see/check [16:12] konrad11901: it ran too long. It's not caused by your changes, maybe by the slow down of the world because of the big bugs recently found. [16:13] When a suite takes too long we split it, so I will take a look at the other branches to see if this was an unfortunate situation, or a thing that I need to fix. [16:13] daniellimws can you add a link to the PR in the task? [16:13] yeah, I also thought that it's not my fault :/ [16:13] konrad11901: pleae rebase your branch with master and push again. [16:13] ok [16:14] done, the tests are running [16:15] thanks konrad11901 [16:50] popey: hi [16:50] elopio, hi can you approve my add unit tests task? [16:53] daniellimws[m]: I don't see any tasks for review. [16:53] elopio: hi i need help with ,y task [16:53] https://codein.withgoogle.com/dashboard/task-instances/5373896733753344/ [16:53] im packaging superpowers app [16:53] https://gist.github.com/popey/7803cfbda9b337fab792c403e50e4709 [16:53] ollowing this tutorial [16:53] Nissaar: how can I help? [16:54] when it comes to snap run dist [16:54] error: cannot find current revision for snap dist: readlink /snap/dist/current: no such file or directory [16:54] this is the output. and there is no script section in the package.json file [16:55] elopio, sorry just submitted, maybe a network issue just now [16:56] a little less than 30 more completed tasks and we'll be in 6 place [16:56] https://gci-leaders.netlify.com/ [16:58] elopio: what should i do ? [16:58] Nissaar: please push your changes to the repo, and I will try to reproduce. [16:59] push it to my forked repo ? [17:00] elopio:ush it to my forked repo ? [17:01] Nissaar: yes. Then I can pull it and try the same commands that you are trying [17:01] ok im on it [17:04] elopio: https://github.com/Nissaar/superpowers-app [17:04] elopio: is it good ? [17:04] Nissaar: no, you need to commit and push your branch [17:06] elopio: can you please check it now ? [17:06] now I see it Nissaar [17:07] yay thx. ill wait for you [17:10] elopio: i have uploaded creeshots of the terminal in the following link [17:10] https://codein.withgoogle.com/dashboard/task-instances/5373896733753344/ [17:13] Nissaar: that's not how you use electron-builder. The "linux" key must go inside a "build" key. You can learn more about it here: https://www.electron.build/ [17:14] but I would recommend you to start with an app that it's already building for linux, so you just add the "snap" builder. [17:14] otherwise you might find many unexpected problems, and that wouldn't be a good task to start learning. [17:14] can you suggest an app ? [17:15] you mean the linux key should be in the build key in the scripts section ? [17:19] elopio: do you think ndm would be better for me ? [17:20] Nissaar: you can try. It looks nice. [17:20] ok im on it [17:24] WARN engine hawk@6.0.2: wanted: {"node":">=4.5.0"} (current: {"node":"4.2.6","npnpm WARN deprecated gulp-clean-css@2.4.0: breaking changes from clean-css 4.x. Please install gulp-clean-css 3.x [17:25] elopio: when it says these things, shoould i modify the package.json file to suit these ? [17:26] Nissaar: did it fail? It sounds like a warning, not an error [17:26] and doesn't sound like something you introduced [17:27] its a warning. im running npm install right now [17:27] and it has said these things. just wanna know if i should change the package.json file [17:33] elopio: can you please check this ? https://imgur.com/a/SYNcE [17:36] Nissaar: try npm run linux instead of npm run dist [17:37] elopio: it has opened the application ndm. i think thats right ? [17:38] https://imgur.com/a/dBS7D [17:39] Nissaar: that looks like the file browser, not ndm [17:39] which one should i take as the snapname to install it with dangerous ? [17:40] yes thats file browser. im searching the application name.snap to install with dangerous [17:40] this is ndm https://imgur.com/a/ZsWsF [17:42] yeah, that one looks good. I'm not sure why you have so many .snap files. [17:42] yes. its confusing to know which one is the snap to be installed [17:44] Nissaar: well, non of the ones in the screenshot looks like the ndm snap [17:45] elopio: uhhmmm what should i do now ? [17:46] Nissaar: commit and push your branch, so we can give it a try. [17:47] im on it [17:52] done [17:52] i had a problem while git commit -m "Add...." tho. [17:53] elopio:https://imgur.com/a/0Ksdz [17:57] Nissaar: that doesn't look like something git would run. [17:57] that's the output of an npm command most likely [17:58] https://imgur.com/a/G8eD0 [17:58] elopio: take a look at this [18:01] Nissaar: so you have found an upstream bug :) [18:01] in this line [18:01] i think so [18:01] https://github.com/720kb/ndm/blob/master/lib/js/npm/npm-api.js#L221 [18:01] it should be !== [18:02] you can propose a pull request upstream with that change [18:04] elopio: https://github.com/720kb/ndm/pull/238 [18:04] Pull 238 in 720kb/ndm "upstream bug" [Open] [18:04] here it is [18:05] Nissaar: the title of the bug should be more useful than that [18:06] something like: fix lint error: replace != with !== [18:07] Nissaar: also, your imgurs are not very nice for sharing terminal snippets. It's better to use paste.ubuntu.com [18:08] ill use it next time. thx [18:08] elopio: https://github.com/720kb/ndm/pull/239 [18:08] Pull 239 in 720kb/ndm "fix lint error: replace != with !==" [Open] [18:09] after this pull request has been done, should i fork, clone again and start all over with npm install etc... ? [18:13] Nissaar: you can rebase your snapcraft branch with this patch-2 branch [18:14] and then commit, push, and I can take a look. No need to fork and clone. [18:15] i dnt know how to use that rebase command [18:15] :( [18:19] Nissaar: On your cloned directory run git fetch [18:19] then git checkout add-snap-support [18:19] then git rebase patch-2 [18:21] im getting this error [18:21] elopio:atal: Needed a single revision invalid upstream patch-2 [18:23] hum, hum, please paste all the git commands and outputs you tried [18:24] git fetch remote: Counting objects: 7, done. remote: Compressing objects: 100% (7/7), done. remote: Total 7 (delta 0), reused 0 (delta 0), pack-reused 0 Unpacking objects: 100% (7/7), done. From https://github.com/Nissaar/ndm * [new branch] add-snap-support -> origin/add-snap-support * [new branch] patch-1 -> origin/patch-1 * [new branch] patch-2 -> origin/patch-2 nissaar@nissaar-CX62-7QL:~/ndm$ git [18:25] nissaar@nissaar-CX62-7QL:~/ndm$ git checkout -b add-snap-support fatal: A branch named 'add-snap-support' already exists. nissaar@nissaar-CX62-7QL:~/ndm$ git rebase patch-2 fatal: Needed a single revision invalid upstream patch-2 nissaar@nissaar-CX62-7QL:~/ndm$ git checkout add-snap-support Already on 'add-snap-support' nissaar@nissaar-CX62-7QL:~/ndm$ git rebase patch-2 fatal: Needed a single revision invalid upstream patch- [18:26] Nissaar: not here, in paste.ubuntu.com, next time :) [18:27] elopio:https://paste.ubuntu.com/26361644/ [18:29] Nissaar: try git rebase origin/patch-2 [18:30] elopio: already pushed [18:33] Nissaar: I need to have food now. I will keep looking at it later. You can also start a topic in the forum, and then more people can help and you don't have to wait for me. [18:34] ok no problem. [18:34] elopio: enjoy your meal [21:13] sergiusens: all the tests pass :) === Ubuntu is now known as Guest36287 [22:32] Hello Documentation Team! [23:32] hello