| babbageclunk | wallyworld: Please could you take a look at https://github.com/juju/juju/pull/8285? | 05:20 |
|---|---|---|
| wallyworld | sure | 05:20 |
| wallyworld | babbageclunk: should the default exclude list contain several more read only methods out of the box? | 05:22 |
| wallyworld | babbageclunk: left some comments, happy to discuss | 05:38 |
| babbageclunk | wallyworld: no, I don't think it should - I had a pretty big discussion with John about that in the last change. See discussion here: https://github.com/juju/juju/pull/8242#issuecomment-352670932 | 06:04 |
| babbageclunk | (sorry, off doing dinner and bath time - will look at the comment s in a bit.) | 06:04 |
| wallyworld | ok | 06:06 |
| wallyworld | babbageclunk: his point was to audit all write methods by default and filter out read methods. but i don't think an opinion was offered as to the value in logging lots of read only methods which really don't reflect changes to the system | 06:08 |
| wallyworld | i can't see any point in recording that someone ran ListModels | 06:09 |
| wallyworld | why is that any more interesting that Status | 06:09 |
| wallyworld | do we have field input on this? | 06:09 |
| wallyworld | babbageclunk: i'll be in and out - got to start packing, so if i don't respnd straight away, it's not that i'm ignoring you :-) | 06:11 |
| === frankban|afk is now known as frankban | ||
| tasdomas | morning | 09:19 |
| tasdomas | could I get a review of https://github.com/juju/juju/pull/8262 ? | 09:19 |
| babbageclunk | wallyworld_: The thinking isn't that ListModels is interesting, rather that it's pretty unlikely someone is running it so often that it would swamp the log (say, running it under watch). | 10:35 |
| === frankban is now known as frankban|afk | ||
| === agprado is now known as agprado|afk | ||
| === agprado_ is now known as agprado | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!