[00:01] babbageclunk: standup? it's just us tho [00:03] axw: I thought it wasn't for another hour? I'm happy to skip if you are - still just working on audit logging + and making controller config updatable. [00:03] babbageclunk: oh what, indeed [00:03] (hope you didn't get up specially!) [00:04] babbageclunk: a little bit, but I'll survive [00:04] babbageclunk: let's skip. I just worked on resource leak investigation, dqlite stuff today [00:05] ok cool - the dqlite stuff sounds pretty neat, was reading a bit about it [00:30] * babbageclunk goes for a run in that case [07:28] morning, juju, could I please get a review? [07:28] https://github.com/juju/juju/pull/8262 [08:15] tasdomas: i've looked at it the other day :) [08:15] tasdomas: cannot comment on pythn and acceptance tests [08:16] tasdomas: go code looks ok [08:16] anastasiamac, thanks [08:16] tasdomas: but either way, u already have couple of approvals... [08:16] tasdomas: i was going to ask chris when he is back from holidays to look [08:16] anastasiamac, yeah I thought I'd give somebody from core a chance to take a look at this [08:16] tasdomas: at acceptance tests side but i *think* u r good to go.. [08:17] anastasiamac, thanks [08:17] tasdomas: k, could we leave til APAC tomorrow? [08:17] tasdomas: i'll ask in our morning ;) [08:17] anastasiamac, sure [08:17] anastasiamac, thank you [08:17] tasdomas: tyvm for ur patience!!! [08:17] np ;-] [08:18] tasdomas: just to confirm.. develop is heading for 2.4-b1.. r u k with that timeline? [08:18] oh do u need newer version of romulus earlier?.. [08:18] s/oh/or [08:19] anastasiamac, it would be great for this change to go out with the next release [08:19] anastasiamac, when is that:? [08:21] tasdomas: next release is a point one - 2.3.2 [08:21] tasdomas: it's a point release... [08:22] tasdomas: so dunno if u really want ur changes in point release.. it will come out as soon as build farms r back on, so mayb this week or next the latest [08:23] tasdomas: if u really really really want it in point release, i.e. in 2.3.2, u'd need to re-target ur PR to 2.3 branch; land it there once u'd get a +1 from Chris; and then forward-port to develop ;) [08:23] tasdomas: (sounds daunting but m happy to help if u need it) [08:29] tasdomas: u might want to get a +1 from Tim to get this into 2.3.2 as well... [08:31] anastasiamac, thanks, I think I'll do that [08:31] tasdomas: \o/ [08:31] * anastasiamac eods === salmankhan1 is now known as salmankhan