babbageclunk | axw: do you think I need approval on a merge? If I do could you review this? https://github.com/juju/juju/pull/8300 | 03:44 |
---|---|---|
axw | babbageclunk: only if there were non-trivial merge conflicts IMO | 03:44 |
axw | babbageclunk: you said you had to fix a merge issue? | 03:45 |
babbageclunk | axw: yeah - there were some audit log pieces that had been missed moving it from the machine agent to the apiserver worker | 03:46 |
babbageclunk | axw: definitely non-trivial conflicts. | 03:46 |
axw | I'll take a glance over it | 03:47 |
babbageclunk | Thanks! | 03:47 |
axw | babbageclunk: LGTM | 03:51 |
babbageclunk | Cheers! | 03:52 |
kjackal_bot | Hello, we are behind a proxy and when doing juju deploy ssl authentication is failing | 11:55 |
kjackal_bot | is there a way to bypass this? | 11:55 |
hml | in our testing packages - is there an unordered version of DeepEquals? | 22:13 |
hml | i found jc.SameContents - but it doesn’t work on maps | 22:21 |
anastasiamac | hml: there is a SamceContent | 22:21 |
hml | :-) | 22:21 |
anastasiamac | :) | 22:21 |
hml | is there a map version of SameContent? | 22:22 |
anastasiamac | hml: i don't think so... off memory, u might need to compare length and then pull indiv keys and elements by hand to compare... | 22:23 |
hml | anastasiamac okay - i was hoping there might be an easy way. :-) | 22:23 |
anastasiamac | hml: most of the time, when map comparison is needed, u might b k in unit test to just have a map with one element?.. | 22:23 |
* anastasiamac looking | 22:24 | |
admcleod | who can help with this? "can't get info for image 'juju/bionic/s390x': not found" | 22:27 |
anastasiamac | hml: yeah, cannot find anything unless u want to compare by hand... | 22:30 |
hml | anastasiamac: thx for looking - i need to do this a few times, time to write something. :-) | 22:31 |
anastasiamac | admcleod: we'd need more info than that - what substrate u r using, what is bootstrap command, etc.. mayb file a bug and someone will have a look? | 22:34 |
admcleod | anastasiamac: well i could do, i think its just a builder for that specific image though | 22:34 |
anastasiamac | admcleod: sure, but what version of juju, etc... also means of reproducing, like steps, would help | 22:38 |
admcleod | anastasiamac: ok - first ill make sure theres no image, if there is ill file a bug | 22:39 |
babbageclunk | hml: I think DeepEquals works on maps? | 23:27 |
babbageclunk | (Sorry, this is very late info, just happened to be reading.) | 23:28 |
hml | babbageclunk: it does - but my map order keeps changing - DeepEquals doesn’t like that | 23:29 |
hml | :-/ | 23:29 |
babbageclunk | hml: ? I don't understand - you should be able to hand DeepEquals two maps and if they have the same set of k/v pairs it will pass. | 23:30 |
babbageclunk | The ordering shouldn't matter. | 23:30 |
hml | babbageclunk: double checking | 23:31 |
hml | babbageclunk: order matters with DeepEquals, but not with SameContents - the trouble is that SameContents doesn’t work with maps | 23:33 |
hml | only slices | 23:33 |
babbageclunk | I might be mistaken - I don't think order matters with DeepEquals if you pass it maps. The reason I say that is that SameContents is implemented by converting the values into maps and then using reflect.DeepEqual on the maps. | 23:35 |
babbageclunk | hml: ^ | 23:36 |
hml | babbageclunk: getting out my magnifying glass. :-) | 23:40 |
babbageclunk | I'm doubting myself now - running a toy example to check. | 23:43 |
hml | babbageclunk: i think i’ve been asking the wrong question then… so DeepEquals is matching out of order. However one of the map values is a slice, which has the same contents but different order - so failing to match that | 23:43 |
babbageclunk | Ohhhhh. | 23:43 |
hml | babbageclunk: https://pastebin.canonical.com/207917/ <— my eye killing match trying | 23:44 |
hml | babbageclunk: or eye crossings | 23:44 |
babbageclunk | Stink - you want a DeepEquals-alike that does SameContents on the children. | 23:44 |
babbageclunk | let's talk after team meeting! | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!