smoser | blackboxsw: do you have an mp coming? | 02:45 |
---|---|---|
blackboxsw | ahh yes, better late than never https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/336582 | 03:18 |
blackboxsw | thx for landing it | 03:18 |
=== shardy_afk is now known as shardy | ||
smoser | blackboxsw: or rharper | 18:32 |
smoser | pretty please | 18:32 |
smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336498 | 18:32 |
blackboxsw | yeah smoser feature creep wishlist for me on the hotplug stuff | 18:32 |
blackboxsw | looking | 18:32 |
smoser | blackboxsw: rharper approved so i'm merging. | 19:01 |
smoser | unless you object quick | 19:01 |
smoser | ;) | 19:01 |
blackboxsw | smoser: merging now | 19:27 |
blackboxsw | well awaiting tox and it'll land | 19:27 |
blackboxsw | landed | 19:35 |
* blackboxsw needs to writeup a cool whoami ubuntu contributor page like rharper/powersj have to see if I can get per-pkg commit writes for cloud-init curtin | 19:36 | |
smoser | yes | 19:36 |
powersj | feel free to use mine as a template | 19:37 |
blackboxsw | cut-n-paste s/powersj/blackboxsw/g | 19:37 |
blackboxsw | .... and done | 19:37 |
* blackboxsw thinks claiming the work of others is frowned upon. | 19:38 | |
blackboxsw | but yeah will base it off what you guys have | 19:38 |
powersj | :) | 19:39 |
* blackboxsw dumped a couple of branches up for review: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/336635 and https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/336453 | 22:13 | |
blackboxsw | the first one is just docs on CLI subcommands | 22:13 |
blackboxsw | adding some cross-references to the pre-existing analyze stuff ryan added. But adding a bit of context on some of the cloud-init cmdline options as well. | 22:14 |
blackboxsw | dojordan, just saw cloud-init updates with your changes made it into azure | 22:22 |
blackboxsw | apt-cache policy cloud-init | 22:22 |
blackboxsw | cloud-init: | 22:22 |
blackboxsw | Installed: 17.2-13-gf4b8fa6d-1~bddeb | 22:22 |
blackboxsw | Candidate: 17.2-25-gc03bdd3d-0ubuntu1 | 22:22 |
blackboxsw | Version table: | 22:22 |
blackboxsw | 17.2-25-gc03bdd3d-0ubuntu1 500 | 22:22 |
blackboxsw | 500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages | 22:22 |
blackboxsw | *** 17.2-13-gf4b8fa6d-1~bddeb 100 | 22:22 |
blackboxsw | 100 /var/lib/dpkg/status | 22:22 |
blackboxsw | root@b5:~# | 22:22 |
blackboxsw | well into cloud image | 22:22 |
blackboxsw | well into cloud images. I mean. deploying azure to check | 22:22 |
blackboxsw | yep fresh azure instance is up with your changes... though I'm seeing a delta, like what I merged in from your branch was stale and didn't contain dojordan's last commit. | 22:45 |
blackboxsw | it's a minor change, but I'll proposed a trivial now and we can discuss how best to merge, publish that change | 22:45 |
blackboxsw | n/m I was on my own stale branch | 22:48 |
blackboxsw | powersj: for shame lgtm.com doesn't scrub testing directories. /me was wondering how all your contributions only got logged as 300 lines | 22:58 |
blackboxsw | https://lgtm.com/people/1801127304/project:1884170995/lang:python | 22:58 |
powersj | blackboxsw: heh I wondered the same thing | 22:59 |
powersj | I was like what happened to all my work?! | 22:59 |
blackboxsw | yeah definitely "It's not fair" ™ | 23:00 |
powersj | haha | 23:01 |
* blackboxsw sees if we can tweak settings as I'd like to have that review at least on cloud_tests directories | 23:02 | |
powersj | looks like you could create a lgtm.yaml with what dirs it tests | 23:02 |
blackboxsw | https://lgtm.com/docs/lgtm/file-classification | 23:10 |
blackboxsw | yeah | 23:10 |
blackboxsw | yeah it'd probably be worth minimally a path_classifiers:\n test:\n - exclude: tests/cloud_tests lgtm.yaml | 23:16 |
blackboxsw | I'll put up a sample cloud-init mirror to see if it blows up anything | 23:17 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!