[01:03] <handsome_feng> tsimonq2: I added a "modified by" line in util/ukui-menus-ls.py, Is that ok?
[01:08] <tsimonq2> handsome_feng: irt copyright?
[01:09] <handsome_feng> sorry, what does 'irt' mean?
[01:10] <tsimonq2> "in respect to", sorry
[01:10] <tsimonq2> (meaning "referring to")
[01:11] <handsome_feng> yes, I fond that the ukui-menus have been rejected, because the authors in ukui-menus-ls.py
[01:12] <tsimonq2> Right, one sec please :)
[01:14] <tsimonq2> handsome_feng: So I talked with an AA privately, he also mentioned that there's a spot where it says "Copyright: *No copyright*" and that it's better to omit the lines than say there's no copyright on it, and there's also a typo with "GNU Genaral Public License" or similar
[01:14] <tsimonq2> I'm really bad at copyright, so you'll have to bear with me here, but that's what I was told :)
[01:16] <handsome_feng> ok, I will check that now
[01:18] <tsimonq2> handsome_feng: Also, while you're here, I think that the majority of the flavors plan on skipping Alpha 2
[01:18] <tsimonq2> And especially with this, I'm not sure it would get processed in time :)
[01:20] <handsome_feng> Got it. Thanks
[01:22] <tsimonq2> Although there was talk about a testing day so I'd be interested to see if in mid-February sometime if Kylin would be willing to participate in an all-flavor effort :)
[01:22] <tsimonq2> Of course it's just a thought at the moment, nothing is really planned out, but it's an idea :)
[01:27] <handsome_feng> we'd love to :)
[01:27] <tsimonq2> Great :)
[01:28] <handsome_feng> Just inform us when the meeting planned out
[01:36] <tsimonq2> Ok
[01:36] <tsimonq2> As long as you're subscribed to the ubuntu-release mailing list, you should be informed :)
[01:42] <handsome_feng> fine
=== jzmkrwepahmnlhcc is now known as yhcahsnhwjujutru
=== yhcahsnhwjujutru is now known as LordOfBikes
[01:50] <handsome_feng> tsimonq2: I have updated the ukui-menus and the PPA, could you upload it first? I will check the other packages today
[01:53] <tsimonq2> handsome_feng: Sure, I'll look now.
[01:53] <handsome_feng> Thank you
[01:54] <tsimonq2> You're welcome, always glad to help :)
[01:54] <tsimonq2> Now my question for you is when you'll become a MOTU :P
[01:57] <handsome_feng> I hope the sooner the better, haha
[01:57] <tsimonq2> :D
[01:58] <tsimonq2> handsome_feng: Trivial thing, you should override spelling-error-in-copyright on the next upload, Nam seems to be a surname :)
[01:58] <tsimonq2> Otherwise, uploading now :)
[02:00] <handsome_feng> \(^o^)/
[02:00] <tsimonq2> :D
[02:01] <tsimonq2> handsome_feng: Which package would you like me to review next?
[02:03] <handsome_feng> tsimonq2: ukwm
[02:03] <tsimonq2> Grabbing now.
[02:06] <tsimonq2> handsome_feng: One thing that should be looked at from an upstream perspective (and perhaps for all the packages) is the fact that some of the copyright notices use an incorrect FSF address. Here's the list I got from licensecheck for ukwm: http://paste.ubuntu.com/26481335/
[02:07] <tsimonq2> I don't *think* that's blocking, but something that should be corrected.
[02:08] <handsome_feng> ok, I will have a check now, and to save your time, I will ping you when I have checked all the packages
[02:08] <tsimonq2> Ok
[02:10] <tsimonq2> handsome_feng: I'm NACK on uploading this, the d/copyright file is incomplete and only lists GPL-2+. I recommend using a tool like licensecheck. Here's what I got from `licensecheck -r . | grep -v "UNKNOWN"`: http://paste.ubuntu.com/26481355/
[02:11] <tsimonq2> I see some MIT/X11 (BSD like) and some LGPL.
[02:12] <tsimonq2> Also, in debian/rules, dh_install in override_dh_install should be dh_missing
[02:13] <tsimonq2> Let me run it through sbuild real quick to see if there's anything else I can recommend, so you can fix it all in one go :)
[02:14] <handsome_feng> thanks, I always check the copyright with my eyes ...
[02:14] <tsimonq2> no problem :)
[02:23] <tsimonq2> handsome_feng: Lintian looks good, so just those things I think.
[02:25] <handsome_feng> Ok!