| === frankban|afk is now known as frankban | ||
| balloons | vern, were you able to get the spaces test job created on jenkins? | 16:11 |
|---|---|---|
| === agprado_ is now known as agprado | ||
| === frankban is now known as frankban|afk | ||
| thumper | morning people | 19:09 |
| hml | morning thumper | 19:15 |
| rick_h | howdy thumper, thuoght you were away this week? | 19:15 |
| thumper | rick_h: hi there | 19:16 |
| thumper | morning hml | 19:16 |
| thumper | rick_h: nope, just until today | 19:16 |
| thumper | back into it | 19:16 |
| thumper | short week for me | 19:16 |
| rick_h | gotcha, cool | 19:16 |
| babbageclunk | hi thumper | 19:52 |
| thumper | babbageclunk: morning | 20:13 |
| thumper | babbageclunk: how goes the sprint? | 20:13 |
| vern | balloons or veebers, quick review? https://github.com/juju/juju/pull/8333 | 20:14 |
| veebers | vern: LGTM with one comment (not a blocker) | 20:28 |
| vern | veebers: I assume your comment meant to reference .set_region? I think that's clearer... I'll update that real quick | 20:32 |
| veebers | vern: so sorry, copy and paste error and I didn't even check it :-( | 20:33 |
| veebers | vern: yes I meant to add .set_region(...) to the end of that. Sorry for the additional overhead | 20:33 |
| vern | all checks pass. merge requested :) https://github.com/juju/juju/pull/8333 | 21:29 |
| vern | grr... in ci the machines have ens3, not eth0... guess I need to improve the logic of that part of the network spaces test | 22:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!