/srv/irclogs.ubuntu.com/2018/02/09/#snappy.txt

mwhudsonwill you guys be trying to get snapcraft 2.39 into bionic RELEASE?01:29
zygamaaan06:00
zygaits Friday and we are deep in golang build issues06:00
=== Guest23352 is now known as ogasawara
zyga_hello07:31
=== zyga_ is now known as zyga
* zyga rebuilds systemd due to CVEs, meh07:31
zygaI made that branch we talked about07:31
zygahttps://github.com/snapcore/snapd/pull/464107:31
mupPR #4641: many: move mount code to osutil <Created by zyga> <https://github.com/snapcore/snapd/pull/4641>07:31
zygaand on top of that: https://github.com/snapcore/snapd/pull/464207:31
mupPR #4642: many: add nfs-home flag to system-key <Created by zyga> <https://github.com/snapcore/snapd/pull/4642>07:31
mvozyga: nice, thanks07:31
zygaboth of those are red because of golang07:31
* mvo looks07:32
zygaafter 4641 we could remove some duplicate code that parsed mountinfo in osutil07:32
mvozyga: that sounds good, let me check07:38
mvozyga: fwiw, it fails because of undefine FindUID07:42
zygait fails in cgo07:42
mvozyga: and undefined FindGID07:42
zygathis is a cgo issue07:42
mvozyga: it is?07:42
zygait passes in normal go07:43
zyga(I didn't push this without testing007:43
mvozyga: did this also break with the latest go update?07:43
zygahmm, not sure, I didn't push anything else07:43
zygahmm07:43
zygabut FindUID was always in that spot07:43
zygammm07:44
zygaah07:44
zygasnap-update-ns had some exception to build with cgo, right?07:44
zygaso07:45
zygaquick fix07:45
zygawe don't need username lookup in mountentry.go07:45
zygawe just need the number07:46
zygalet me remove that code07:46
mvozyga: \o/07:46
mvozyga: thanks07:46
mvozyga: this is for the static build of snap-exec07:46
mvozyga: so that things work even without a glibc in the core07:46
zygaok, almost done07:49
zygamvo, while I'm testing07:50
zygaquick experiment07:50
zygarun htop or similar in one terminal07:50
zygago to root of snapd and run: time go test ./...07:50
zygait seems that we have a part that scales well and a part when CPU is not really busy07:50
zygafor me it totals at around 1 minute 30 seconds07:51
mvozyga: let me try with "time ./run-checks --unit"07:52
zygano07:52
zygathat's idfferent07:52
zygaand faaaaar slower07:52
zygait does sequential test for each package07:52
zygathe command I used does it in parallel07:52
mvozyga: aha, go test in the new go skips vendor/ right? iirc 1.6 does not07:52
zyga(PR updated)07:52
mvozyga: thanks for the update07:53
zygacorrect07:53
zygaif 4641 passes I will push the same patch ot 464207:53
mvozyga: go test starts with low cpu for me and then speeds up07:55
mvozyga: for me real is about 0m58, user 2m9 and sys 0m1407:56
zygahmmm, interesting07:57
zygaon artful?07:58
mvobionic, go1.907:58
pstolowskimorning!07:58
zygaah, I'm on 1.807:58
zygahey pawel07:58
mvohey pstolowski07:58
mvozyga: that might be it, I can try on an artful machine in a bit07:58
zygalooking at the output it did run vendor tests here07:58
zygabut in any case, did you see a drop in CPU usage during that period?07:59
zygafor me it starts high, then drops to sequential07:59
zygafor instance cmd is super slow07:59
zyga(nothing happens there)07:59
zygaer, sorry, the one *after* cmd07:59
zygacmd/snap07:59
zyga25 seconds07:59
zygaclient takes 10 seconds07:59
mvozyga: yeah, cmd/snap, daemon, overlord are all slow for me, client too08:00
mvodevicestate and snapstaet too, might be worthwhile to look at the reasons at some point08:00
zygahttp://paste.ubuntu.com/26545336/08:03
zygasnap-seccomp08:03
zyga85 seconds08:03
zygaI think those are those tests that run gcc, right?08:03
zygaI wonder if there's some golang testing trick that would let us spawn those as parallel, indepentend tests08:04
zygamaybe even using go() itself08:04
niemeyerHello all08:11
zygahey08:14
zygayou're up early :)08:14
pstolowskimorning!08:15
niemeyerMoin! Yeah.. will try to do an early Friday today08:16
mvozyga: yeah, snap-seccomp runs a lot of gcc, might be worth looking at too08:18
mvohey niemeyer, good moooorining08:18
mvoand we have the new logo in the forum, looks really nice08:19
mupPR snapd#4641 closed: many: move mount code to osutil <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4641>08:20
kalikianagood morning, snappy08:20
mvozyga: please update the other PR as well (the system-key one)08:21
mvozyga: nevermind, I pushed it08:22
niemeyermvo: Nice, isn't it? Really enjoyed it too08:23
niemeyermvo: The whole design for the new site (not deployed yet) looks really sweet08:23
zygamvo, re08:24
zygathanks !08:24
mvolooking forward to see it :)08:24
mvozyga: thank *you*08:24
mvozyga: lets hope tests are happy08:24
mvozyga: also: great that we have this test, it saved our bacon08:24
mvo(or tofu)08:24
zygaindeed :-)08:24
zygaoh, the new logo!08:24
zygaI like the subtle separation of snap from craft08:25
zygamvo thank you for initializing nfs home :)08:37
zygaI didn't think about that last night08:38
zygamvo can we land 4049?08:38
mvozyga: yes, I thnk so08:45
pedronispstolowski: there is still a comment I made that seem unadressed in #440108:46
mupPR #4401: snapstate/ifacestate: auto-connect tasks <Created by stolowski> <https://github.com/snapcore/snapd/pull/4401>08:46
pedronispstolowski: I recommented on it08:46
pstolowskipedronis, oh,i'm sorry about that, missed that somehow. thanks, will look at this08:47
pedronisnp, thanks for working through this08:48
mvozyga: hm, a peculiar error in the system-key nfs PR, snap-cofine didn't refuse to run08:57
zygaoh08:58
zygalooking08:58
zygaweird08:58
zygajust on the three systems?08:58
mvozyga: yeah, really strange, I have not tried to reproduce yet08:59
zygamvo actually, other systems are disabled there08:59
zygahmm09:00
zygahmm hmm09:00
zygamy only idea is that something loads that profile09:01
zygaand that's probably one of the changes in the PR09:01
* zyga reviews diff09:01
zygamvo maybe we are killing the profile in the helper test scripts09:05
zygaI mean, system key, not the profile09:05
zygamvo actually09:06
zygaso09:06
zygaI think I see what's going on09:07
zygaapparmor initialize starts up09:07
zygathen we get into regenerate all security profiles09:07
zygathat doesn't do anything09:07
zygahmm, no wait wrong file09:08
* zyga gets back to square one :/09:08
mvozyga: oh, so we need to keep the current core snap revision in the system-key?09:08
mvozyga: to ensure we always re-generate for the snap-confine on the core snap09:08
mvozyga: woah, our system key needs a lot of input :/09:08
zygawell, that's another perhaps09:09
zygaI don't know yet09:09
zygaI wonder why it clearly regenerated the profile09:09
zyganot why it wouldn't generate a profile09:09
zygalet me get a coffee and have a deeper look09:09
zygaI think system key is long overdue and I cannot wait to see it in production :)09:09
mvozyga: heh, more thorny than anticipated09:10
mvozyga: I will add the core revision and see if that helps09:10
mvozyga: its needed anyway09:10
zygayeah, ok09:10
zygathat's actually true anyway because core revision determines apparmor templates09:10
zygaso +1 on that09:10
* zyga got some coffee09:16
Chipacaniemeyer: go to be-e-e-ed09:16
Chipacaniemeyer: (thank you for the review though)09:16
Chipacagood morning all09:16
niemeyerChipaca: Moin :)09:16
niemeyerChipaca: Should have another section of it soon09:17
* kalikiana will copy zyga and also get coffee09:17
* Chipaca loves the new branding09:17
Chipacaniemeyer: about homes vs users, thinking about it some more09:18
Chipacaniemeyer: the tars are already encoding the uids/gids09:18
Chipacaniemeyer: should i just go with the uids, internally, and the username->uid translation on the fly?09:18
niemeyerChipaca: On which side?  I think the API should take the username.. internally we probably need to translate into a home at some point09:19
niemeyerChipaca: It wouldn't hurt to keep the uid as well, though, at least in the metadata09:20
Chipacaniemeyer: to be able to alert when things change and restore would mess things up?09:20
Chipacasgtm09:20
Chipacaapi being username sounds a'ight (although it will mean having to do user lookups, which seems to kill spread on 14.04)09:22
niemeyerChipaca: One more round on your way.. cmd/snap this time09:50
Chipacaniemeyer: just seen it09:50
Chipacaniemeyer: is the 'internal spacing' about the space in '2m ago', and in 'yyy-mm-dd hh:mm:ss'?09:50
Chipacaniemeyer: yes i can make the latter use T instead of space09:51
Chipacaniemeyer: for the former, i don't know how to drop the space without it losing meaning09:51
niemeyerChipaca: Yeah, exactly09:51
mvozyga: I added the core rev now but the security-setuid-root will not be fixed with this :/09:51
niemeyerChipaca: 2mins09:51
Chipaca(i could cheat and use something that looks like a space but isn't! that'd help machine parsing)09:51
zygayeah, I suspect it's something else09:51
Chipacaniemeyer: i mean, i can drop the 'ago' if you think it's obvious09:52
zygaI'm really puzzled, it must be something obvious but I cannot see what would cause this from the diff09:52
Chipacai added it because it seemed wrong without09:52
niemeyerChipaca: Right, I think it's fine.. it's implicit from context09:52
Chipacaok09:52
niemeyerChipaca: Thinking about it now, it's probably nicer either way, even if we didn't care about the spacing09:53
niemeyerChipaca: The "ago" will get boring quickly on a long listing09:53
Chipacatrue09:53
Chipacaoops i forgot to change 'lost to the ages' back :-)09:57
Chipaca… and the "is probably *fine*" one!09:57
Chipacaheh09:57
mvozyga: I have a debug shell now, I see that the apparmor profile for the snap-confine for the core rev is loaded (but not on disk)10:03
zygais it possible that10:03
zyga1) the profile is gone because of the test scripts and how they restore state10:03
zyga2) the profile is in memory because prior test loaded it and we don't unload them in test restore scripts10:04
* Chipaca waiting for spread to finish so he can fire off another spread, but really should leave for physio10:05
mvozyga: yeah, I think its something like this, the details are still a bit blurry to me, I ran the the test standalone and got no error10:06
mvozyga: eh, got *an* error10:06
zygaoh10:06
zygawell, that's possible too10:06
zygathe prepare for suite would load snapd10:06
zygaand that would keep the profile loaded10:06
zygaI don't think we actually unload anything in tests, right?10:06
zygaoh drat10:24
zygaI made the coffee and never picked it up10:24
mvozyga: I think I have an idea, testing it now10:28
zygamvo yeah? let me know once you have the result, I'm curious :)10:29
alexlarssonjamesh: Are you around? Or anyone else involved in snappy on the desktop? I would like someone to take a spin with https://github.com/flatpak/xdg-desktop-portal/pull/15510:30
mupPR flatpak/xdg-desktop-portal#155: Support snap <Created by alexlarsson> <https://github.com/flatpak/xdg-desktop-portal/pull/155>10:30
zygahey10:30
zygahey alexlarsson :)10:30
alexlarssonhey10:31
jameshalexlarsson: hi.  I'll give it a spin10:31
zygaoh excellent, jamesh is still up :)10:31
alexlarssonIt depends on https://github.com/flatpak/xdg-desktop-portal/pull/15410:31
mupPR flatpak/xdg-desktop-portal#154: Add application info abstraction <Created by alexlarsson> <https://github.com/flatpak/xdg-desktop-portal/pull/154>10:31
alexlarssonWhich would be good if it could get separate reviews, but all the commits from that is in the other pr too10:31
alexlarssonjamesh: i don't really have a snappy setup so i kinda coded the apparmor stuff blindly10:32
alexlarssonjamesh: also, there are some todos that you might want to look at10:32
ikeyoh shiny10:32
alexlarssonI'm hoping we can release a xdg-desktop-portal with the document portal and snappy support next week10:33
alexlarssonThen i can do complementary flatpak releases with it removed10:33
* Chipaca -> physio, finally10:33
jameshalexlarsson: we don't yet have the portal support ready in master yet, so it isn't exactly trivial to test out at the moment10:33
alexlarssonjamesh: you can test with gdbus from a snap10:34
alexlarssonjamesh: In fact, maybe you can just put https://github.com/matthiasclasen/portal-test in a snap?10:34
alexlarssonjamesh: I guess you need dbus aa rules to grant access to org.freedesktop.portal.*10:35
jameshalexlarsson: that's what I used when I was working on a prototype for this last year: https://github.com/jhenstridge/portal-test/blob/snap-pkg/snap/snapcraft.yaml10:36
alexlarssonjamesh: But, at the very least you could add some debug printfs in the portal and see if it gets the right app id10:36
jameshI probably need to change that packaging a bit though10:36
alexlarssonjamesh: also, i *think* i got the app id validation right by looking at the glob for snap package names, but please verify that10:37
alexlarssongdbus call --session --dest org.freedesktop.portal.Desktop --object-path /org/freedesktop/portal/desktop --method org.freedesktop.portal.OpenURI.OpenURI "" "https://gnome.org" {}10:37
alexlarssonis a simple thing to test10:37
alexlarssonWell, that actually doesn't really check the app id, so maybe not the best test...10:38
alexlarssonBut if you combine it with some added printfs to your xdg-desktop-portal you should get some basic validation10:38
zygaalexlarsson thank you :-)10:39
alexlarssonnp10:39
alexlarssonI really don't want app developers to have to target multiple apis10:39
alexlarssonwe need to share this shit10:39
ikeynot sure anyone was planning anything different, no..?10:40
zygayeah, that's very much true10:40
jameshalexlarsson: agreed.  I don't want to repeat all the work that's been done for GTK and Qt integration.10:40
alexlarssonikey: no, that was always the idea, but it need to also get done10:40
ikeyah gotcha10:40
ikeyset a stable baseline now..10:40
mvozyga: quick question> kernel version as part of system-key: yes/no?10:57
zygaok, I think I got the validation right now10:57
zygaoh10:57
zygaactually10:57
zygaversion is not of much use10:57
zygaI'd say no unless you have a clear need10:57
zygamvo we could keep bugs: []10:58
zyga;-)10:58
zygaif kernel bugs are bugging us10:58
mvozyga: aha, thats good, yeah, we can create: bugs: [foo] when we need it10:59
mvozyga: cool, thank you10:59
* ogra_ wonder what the new bird logo on the forum is meant to represent11:05
sparkiegeekogra_: it's the snapcraft logo... it represents snappy  :)11:23
ogra_haha11:23
ikeypretty banging logo though11:26
zygait could animate11:26
ikeyalso it hidpis on the site favicon11:26
* ikey is happy11:26
zygait's nicely hidpi11:27
zygayeah11:27
ikeylol11:27
zygait scales all the way11:27
ikey"snappy takes flight" ™11:27
* ikey also cringes11:27
ikeywait does this make solus (budgie) and snappy birds of a feather? :P11:27
zygatwin engine bird11:27
ikeylol11:27
ogra_hey ... https://docs.ubuntu.com/core/en/reference/interfaces/shows a "network-status" interface but snap interfaces in 2.30 does not ... did we lose something since 2.25 ?11:28
ogra_mvo, ^^^11:28
ogra_(or zyga )11:28
zygaI think I know11:28
zygajust checking11:28
zygayeah11:29
zygait's not implicit11:29
zygait's just there but you need an snap to carry it11:29
* ikey unsubs from mir notifications on github11:29
ogra_Trevinho, ^^^11:29
ikeyjust reminds me how little im doing myself..11:29
* zyga rethinks that validation11:44
zygacan be done faster and much more easily than now11:44
zygaby tracking source and target constraints separately11:45
niemeyerpedronis: Reviewed most of #449711:56
mupPR #4497: many: make rebooting of core on refresh immediate, refactor logic around it <Created by pedronis> <https://github.com/snapcore/snapd/pull/4497>11:57
niemeyerpedronis: Please have a look and let me know if you like the proposal11:57
niemeyerpedronis: Will take a coffee break and will review the server end11:57
pstolowskipedronis, do you have a moment?12:19
Chipacaso many non-powered-off-servers12:27
pedronispstolowski: now, I was having lunch12:32
pstolowskipedronis, ok, i need to run to school now, will be back in ~10 min12:33
pstolowskipedronis, will ping you for a quick HO before the standup if thats ok12:34
pedronisok12:34
pedronisniemeyer: from quick look proposal seems reasonable, it means the client becomes stateful though, will take me a bit to get back to that PR though12:36
zygawoot12:44
zygait works :)12:44
pstolowskipedronis, can you join standup HO?12:53
=== ikey is now known as ikey|afk
mvozyga: fwiw, 4642 is green now12:59
zygaoh13:00
zygaoh standup13:00
zygamvo so it was the test setup!13:00
zygacool13:00
zygamvo shall we merge it?13:01
zygajdstrand hey13:01
mvozyga: maybe we can look over it again just in case13:01
zygaI think pawel or chipaca could look13:02
mvozyga: one independent review would be cool, maybe Chipaca or pstolowski13:02
mvozyga: heh13:02
zyga:D13:02
Chipacasure13:02
zygait's funny, no?13:02
Trevinhoogra_: oh ok... It was my guess too after re-reading13:28
TrevinhoNetwork observer should be enough though13:29
ogra_Trevinho, yeah13:29
TrevinhoBut what we'd need is a connection status one13:29
TrevinhoWith auto connection13:29
TrevinhoAlthough qt also needs to be fixed not to require too many infos13:29
* kalikiana going out for lunch, back later13:31
jdstrandzyga: hey13:49
zygajdstrand hey, I added the validation we spoke about last night and I will add some more (about things we didn't talk about)13:49
zygawell, at least not yesterday13:49
zygaI think we mentioned this long ago but we didn't black-list /proc and other similar places13:50
zygaI will do that13:50
jdstrandzyga: more in that pr or more in a future pr?13:50
zygaI also merged master into jamesh branch13:50
zygajdstrand it can be separate, it's not related to that PR directly13:50
zygaI will look at one function that was meant to validate if a mount operation worked13:51
jdstrandzyga: so, technically /proc isn't a security issue (since they are just putting something they already have read/write access to in there. it isn't going to fakeout the actual kernel), but it is going to be an error13:52
jdstrandin the snap if it is doing that13:52
=== ikey|afk is now known as ikey
jdstrandzyga: so +1 on filtering /proc, /sys, /lost+found, and /dev13:53
zygaI agree but I think it's sensible to be conservative13:53
zygaoh13:53
zygalost and found13:53
zygagood one13:53
zyganoted13:53
jdstrand /boot and /run probably also make sense13:53
zygajdstrand as for 3963, I might look at splitting it to help13:53
jdstrandbut, eh13:53
jdstrandwe can always open it up more later, so seems safe to block these weird ones13:54
zygayes, that's the principle I think13:54
zygaphase 1, conservative approach13:54
* jdstrand nods13:54
jdstrandas for 3963, thank you13:54
jdstrandit is *so* close13:55
* zyga looks at `snap/validate.go:276:20: "compatiblity" is a misspelling of "compatibility"` and sighs13:55
niemeyerpedronis: Yeah, we'd update it on every request, whether "maintenance" was set or not13:55
niemeyerpedronis: I think that reflects well the semantics on the server end13:56
zygajdstrand the new validation logic resulting from last night's discussion is: https://github.com/snapcore/snapd/pull/4640/files#diff-b76be54ad28535ed9b0ac36a2851516eR24013:57
mupPR #4640: snap,interfaces: allow using bind-file layouts <Created by zyga> <https://github.com/snapcore/snapd/pull/4640>13:57
jdstrandzyga: so, I'm seeing things like this:13:57
jdstrandif layout.Bind != "" {13:57
jdstrandif layout.BineFile != "" {13:58
jdstrandand I wonder why that isn't if/else if13:58
zygano reason, but it doesn't change anything13:58
jdstrandwhich makes my wonder if this is not caught:13:58
pstolowskizyga, reviewed 464213:58
jdstrand /foo:13:58
jdstrand   bind: ...13:58
jdstrand   bind-file: ...13:59
zygathis is caught by existing validation that's older than this pr13:59
zygayou can barely see it ...13:59
jdstrandzyga: are there tests for it?13:59
zygahttps://github.com/snapcore/snapd/pull/4640/files#diff-b76be54ad28535ed9b0ac36a2851516eR56013:59
mupPR #4640: snap,interfaces: allow using bind-file layouts <Created by zyga> <https://github.com/snapcore/snapd/pull/4640>13:59
cachio_pedronis, results on staing https://paste.ubuntu.com/26546594/13:59
cachio_still 6 tests failing13:59
zygayes, though not for every possible combination14:00
zygaI can add more :)14:00
zygait's been a learning exercise so far14:00
zygahttps://github.com/snapcore/snapd/pull/4640/files#diff-0c50c794f66e17a6bf61861029a83e21R53314:00
zygaactually I did, sorry,14:00
zygaI just see it in the diff now14:00
jdstrandzyga: right, so that isn't going to catch this:14:00
jdstrand /foo:14:00
jdstrand   bind: ...14:00
jdstrand   symlink: ...14:00
zygano, it does14:00
zygait catches it14:00
zygayou must use exactly one of the kind definers14:01
jdstrandoh nused14:01
jdstrandI was looking at something different14:01
zygayeah, number of things used14:01
jdstrandif you can add a test for that, it would be great14:01
zygayeah, I did for that exact case14:01
jdstrandI <3 negative tests14:01
jdstrandok14:02
zygahttps://github.com/snapcore/snapd/pull/4640/files#diff-0c50c794f66e17a6bf61861029a83e21R53314:02
mupPR #4640: snap,interfaces: allow using bind-file layouts <Created by zyga> <https://github.com/snapcore/snapd/pull/4640>14:02
zygaI'm sure there are some things I didn't cover, I will go over it again14:02
jdstrandI'm looking only at a particular commit. I'll look at the whole thing again14:02
zygaI was thinking how to do the source validation and I was thinking about various options14:02
zygaI like one test14:02
zygaI'm sure you will love it14:02
zygahttps://github.com/snapcore/snapd/pull/4640/files#diff-0c50c794f66e17a6bf61861029a83e21R74414:02
zygabtw, what _is_ norf and corge?14:03
jdstrandI think it is too early for me to review the mind-bending '// Validate mutual compatiblity between otherwise valid layout elements.'14:03
zygahehe14:03
zygathat means I can do something about lunch :)14:04
jdstrandzyga: extra meta vars beyond foo, bar, baz, qux, quux14:04
zygajdstrand but are those dog naems?14:04
zyga*names14:04
pedroniscachio_: snap info seems to need some upload,  searching might need uploads and store admin to set featured/sections in staging14:04
jdstrandnorf certainly isn't14:04
jdstrandcorge I've wondered on the pronunciation14:04
jdstrandlooks like corg-y14:04
jdstrandI always pronounced it corj14:05
pedroniscachio_: create user is not finding mvo on staging, might have other issues as well, not sure14:05
zygaoh14:05
zygawait, you found some dead code14:05
pedroniscachio_: I don't understand the refresh-amend error, it seems a test vs code mismatch14:05
zygathat mutual compatibility thing is supposed to be gone14:05
* zyga yanks it14:05
jdstrandthank goodness14:05
pedroniscachio_: I mean, it seems like an error message has changed14:05
jdstrand:)14:05
cachio_pedronis, yes, it changed recently14:06
cachio_I saw the same error on bionic14:06
mvopedronis: uhh, why are we not seeing the error in other spread runs if its a real error due to code change?14:07
pedroniscachio_: probably we need to upload a newer core?14:07
pedronisother issues look like core is old14:08
pedronisI mean tests take core and change snapd etc in it14:08
mvoaha, ok14:08
mvoold core makes sense14:08
mvosorry for the noise14:08
pedronismvo: well, the amend one is not clear14:09
pedronisthat is not related to pieces in core14:09
pedronisis a bit strange14:09
pedronisbut I didn't get it either14:09
pedronisheere14:09
pedronisbut xdg-* stuff looks like old core14:09
cachio_pedronis, I'll run with the latests changes14:12
pedroniscachio_: I mean, it seems like we need to copy over a recent edge core to staging core edge14:13
pedroniscachio_: and we need some uploads/reuploads for snap-info14:13
pedroniscachio_: searching needs vlc  and to talk with store people about setting some section/featured stuff in staging14:13
cachio_pedronis, ah, ok, I'll update the core in staging14:14
cachio_pedronis, is it ok if I just update for amd64?14:14
cachio_do we need it on other archs?14:14
pedronisno just amd6414:14
pedronisis fine14:14
Chipacazyga: mvo: you now have too many reviews of #464214:15
mupPR #4642: many: add nfs-home flag to system-key <Created by zyga> <https://github.com/snapcore/snapd/pull/4642>14:15
mvoChipaca: thanks, looking14:18
kalikianare14:27
jdstrandzyga: hey, in case you didn't see, I commented on 464015:06
zygayes, I'm responding now, thanks! :)15:07
zygadone15:07
jdstrandroadmr: hi! thanks for syncing r1000. to be clear, you will also update the list of packages to install?15:07
roadmrjdstrand: yes, that means the merge is a bit more involved than usual. I need to first land the dependency change and ensure it doesn't break staging, then merge the tools bump and test thoroughly15:08
zygajdstrand so I think 4640 is good now, I will work on a new branch that makes special filesystem mount points off limits15:09
zygapstolowski, Chipaca - thank you for the feedback15:11
pstolowskizyga, yw15:11
SaviqTrevinho: hey, should clicking on links in telegram-desktop work?15:13
Saviqseems to be NOOP here15:13
Saviqthat's GNOME@Wayland@bionic15:14
jdstrandroadmr: right. I thought I remembered you saying something to that effect in cape town. thanks!15:14
roadmrjdstrand: np! no worries, we'll make this happen15:14
jdstrandroadmr: which is also why I went the more formal bug route :)15:15
jdstrandzyga: yep, approved. thanks!15:15
zygawooot15:15
zygathank you!15:15
jdstrandzyga: it's so close!15:15
jdstrandthat and user mounts are going to rock15:15
zygayeah, I need to jump onto user mounts15:16
zygabut I want to ensure we don't leak the poorly confined snap-update-ns15:16
zygaI need to finish that too15:16
zygathough it's super close, I have code for most of that now15:16
zygajust chopping and reviews15:16
seb128Saviq, https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1742687 maybe15:30
mupBug #1742687: Launching URLs in snapped applications no longer works in 18.04 <AppArmor:New> <D-Bus:New> <snapd (Ubuntu):In Progress> <https://launchpad.net/bugs/1742687>15:30
seb128Saviq, what snapd version do you use? the fix is in proposed only15:31
TrevinhoSaviq: mh,they work here.... let me check15:31
TrevinhoSaviq: what channel?15:31
Trevinhoor revision, better15:31
SaviqTrevinho, seb128: http://paste.ubuntu.com/26546844/15:32
seb128Saviq, and snapd?15:32
TrevinhoSaviq: you get anything on terminal? Also have you snapd-xdg-open or how it was called or not (I don't)15:33
Saviq2.29.4.2+18.0415:33
seb128right, that doesn't include the fix15:33
seb128see what I copied before15:33
seb128try the snapd from bionic-proposed15:33
Saviqack, tx15:33
* Saviq tries15:34
seb128yw15:34
seb128let we know if it fixes it15:34
Trevinhoseb128: about that...15:34
Trevinhoseb128: is there any reason why we don't want file:// ... protocol to work when the target is a directroy?15:34
Trevinhodirectory*15:34
Trevinhoand then opening it with the file-manager?15:35
Trevinhoas telegram requires that sometimes, and so other apps15:35
SaviqError org.freedesktop.DBus.Error.AccessDenied: An AppArmor policy prevents this sender from sending this message to this recipient; type="method_call", sender=":1.1572" (uid=1000 pid=29767 comm="dbus-send --print-reply --session --dest=io.snapcr" label="snap.telegram-desktop.telegram-desktop (enforce)") interface="io.snapcraft.Launcher" member="OpenURL" error name="(unset)" requested_reply="0" destination="io.snapcraft.Launcher" (bus)15:35
SaviqError org.freedesktop.DBus.Error.ServiceUnknown: The name com.canonical.SafeLauncher was not provided by any .service files15:35
Saviqsry15:35
SaviqTrevinho: I don't see snapd-xdg-open, only xdg-open, and when ran inside `snap run --shell...` it does print ↑, as does Telegram itself15:37
seb128Saviq, dunno what you needs to reload for the snapd update to work, maybe try rebooting?15:37
Saviqprolly apparmor profiles or something, will reboot in a mo15:37
seb128Trevinho, that would be to check with the security team, I didn't give much thinking of the implications15:38
Trevinhomdeslaur: something is popping up in your mind? ^15:38
mupPR snapd#4640 closed: snap,interfaces: allow using bind-file layouts <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4640>15:38
Trevinhomight be the case to ask to jdstrand too when back15:38
mupPR snapd#4643 opened: snap: disallow layouts in various special directories <Created by zyga> <https://github.com/snapcore/snapd/pull/4643>15:39
zygajdstrand https://github.com/snapcore/snapd/pull/4643/files15:40
mupPR #4643: snap: disallow layouts in various special directories <Created by zyga> <https://github.com/snapcore/snapd/pull/4643>15:40
zygathat's the quick list15:40
zyganow I realized that mountedTree and mountedFile are exactly the same, I'll simplify them15:40
mdeslaurTrevinho: sorry, jdstrand would be best to answer that question15:40
kalikianaDamn my greedy organism, need to fetch more water. Don't want to take a break...15:41
jdstrandSaviq: the apparmor denial is because the service isn't started yet and the service file doesn't have the magic directive to make it work15:44
zygajdstrand and https://github.com/snapcore/snapd/pull/464415:44
mupPR #4644: tests: add a spread test for layouts <Created by zyga> <https://github.com/snapcore/snapd/pull/4644>15:44
zyga:-)15:44
jdstrandSaviq: I didn't read all of backscroll, but you need the dbus service file coming from an updated snapd *deb*. an updated core is not enough15:44
mupPR snapd#4644 opened: tests: add a spread test for layouts <Created by zyga> <https://github.com/snapcore/snapd/pull/4644>15:44
zygajdstrand both are pretty obvious +1's :)15:44
jdstrandzyga: ack15:45
zygaand with that I'm done on the quick branches15:46
Saviqjdstrand: I got snapd from proposed, do I need non-stable core?15:47
jdstrandSaviq: this is the pr: https://github.com/snapcore/snapd/pull/4495/files15:48
mupPR #4495: data/dbus: add AssumedAppArmorLabel=unconfined <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4495>15:48
jdstrandSaviq: no, you shouldn't15:48
Saviqack15:48
* zyga takes an extended break15:50
jdstrandSaviq: you have AssumedAppArmorLabel=unconfined in the service files? grep AssumedAppArmorLabel=unconfined /usr/share/dbus-1/services/io.snapcraft.*15:50
jdstrandSaviq: did you restart your session?15:50
Saviqnot yet, doing that now15:51
jdstrandSaviq: I think you'll need to restart the session for it to take effect15:52
Saviqjdstrand: I rebooted, same problem15:59
Saviqand yes I do have this ↑↑ in the service files15:59
jdstrandSaviq: that's weird. mvo, iirc, you tested this ^16:04
jdstrandSaviq: are there any apparmor denials in the logs?16:04
Saviqjdstrand: not in dmesg, yes on the console16:04
Saviqexactly what's mentioned in the bug16:05
jdstrandSaviq: don't look at dmesg, look at journalctl (dbus denial for the session bus are logged through syslog, not the audit system)16:05
* jdstrand fires up a vm16:06
Saviqlut 09 17:07:23 michal-laptop dbus-daemon[6341]: apparmor="DENIED" operation="dbus_method_call"  bus="session" path="/io/snapcraft/Launcher" interface="io.snapcraft.Launcher" member="OpenURL" mask="send" name="io.snapcraft.Launcher" pid=216:07
Saviq1423 label="snap.telegram-desktop.telegram-desktop"16:07
Saviqjdstrand: ↑16:07
jdstrandTrevinho: https://forum.snapcraft.io/t/allowing-xdg-open-to-open-files/3789/116:07
Saviq(among a guanoload of gnome shell stack traces...)16:08
jdstrandSaviq: can you paste /var/lib/snapd/profiles/snap.telegram-desktop.telegram-desktop ?16:08
Saviqjdstrand: https://paste.ubuntu.com/26546956/16:09
Trevinhojdstrand: ok, fair... I just was wondering if there some explication on file + directory path though. As I can see that  a single file might be different,but a trusted file-manager could be a different thing16:09
Trevinhoor just always opening file:// with the file-manager so that it only selects the file, then it's up to the user to open it16:09
Trevinhoas an interim solution to portals16:10
jdstrandTrevinho: feel free to add a comment about opening a directory. I suspect that is a bit trickier since userd is launching the file manager, not the snap, so the filemanager would somehow need to pass on open fd or the security policy would need to be adjusted to allow the open if only the filename is passed back16:12
jdstrandTrevinho: which is what portals aims to address16:13
jdstrandTrevinho: if you have details on how it could work with existing confinment, please share. note that portals is closer than you might think16:13
Trevinhojdstrand: wait, I'm not talking of opening a dir... but showing a file in a dir, does it need to send bak anything?16:13
Trevinhojdstrand: I just would like something like the xdg-open does for a browser, but doing it using the file-manager instead16:14
jdstrandTrevinho: a snap calls xdg-open on a dir. userd opens nautilus. how does the snap get access to the file the user chooses?16:14
TrevinhoNo, it has not to choose16:14
Trevinholike in telegram, when you download a file... It says: "show it on folder" and it would open the filemanager at that position16:15
Trevinholike firefox does when you do "open on dir".. or similra16:15
Trevinhocontaining dir I mean16:15
jdstrandisn't that when people normally call xdg-open with a dir? this came up in another forum post where a snap was doing precisely this (a poor man's file chooser)16:15
jdstrandTrevinho: that specific case would be fine imo16:15
jdstrandTrevinho: please comment in the topic. (we want to allow file:// for userd, there is just some work to be done to make sure it is sane. perhaps dir is the first use case)16:16
Trevinhowe can just redirect all the file://path/foo to call org.freedesktop.filemanager to only show content16:16
Trevinhoso it won't be any dangerous16:16
Trevinhothere's a ShowItems call which does it..16:17
jdstrandopening a dir so the user can choose the file to open with whatever mime handler is available is totaly fine imo16:17
Trevinhook16:17
Trevinhocool16:17
Trevinhojdstrand: I could also contribute if you guide me, or... I can leave things to you guys happylier too :D16:18
jdstrandI mean, there are phishing attacks where a bad snap could present a directory it controls with malicious stuff and try to get the user to click stuff16:18
jdstrandTrevinho: present your ideas in the forum and once there is general agreement, I think pursuing a PR is fine. /me isn't tasked with implementing this, but would review the PR16:19
Trevinhojdstrand: mh, right... that's indeed a different thing. However, it's also true that this might happen with a browser too16:20
jdstrandvery much so16:21
jdstrandwe'll want to think about that case so that we make an active decision about it16:21
jdstrandas in, we ignore that or we try to do something about it16:21
jdstrandit is fun to think about pointing a url at a snap's httpd if the user goes to say, bank of america16:22
jdstrandthe browser has protections on that though-- like, you clearly see the url, EV certs, https verification, etc16:24
jdstrandwe might be able to rationalize doing nothing if the file browser is clear16:24
Trevinhoit's beauty of it... Break the system, but your container is the system :D16:36
cachio_mvo, is it ok if I register your suer in staging store?16:42
mvocachio_: sure16:42
cachio_tx16:42
cachio_mvo, perhasps you need to do it16:43
cachio_is it requesting ubuntu one authentication16:43
mvocachio_: in a meeting right now, lets talk in 10min16:44
cachio_mvo, we need the user with email: mvo@ubuntu.com16:44
cachio_mvo, np16:44
mvocachio_: whats the store url? where do  I need to register16:44
cachio_mvo, https://login.staging.ubuntu.com/BERkIKYcyn847YYR/+login16:45
mvocachio_: or, the next silly question, what is the staging store url?16:53
mvocachio_: https://dashboard.staging.snapcraft.io/snaps/ - I guess?16:53
pstolowskipedronis, i've just addressed the missing bit in autoconnect-tasks PR16:54
mvocachio_: ok, I should be registered now16:54
cachio_mvo, tx16:55
* kalikiana wrapping up for EOD/ EOW17:05
cachio_mvo, https://paste.ubuntu.com/26547147/}Getting this error in staging17:17
cachio_mvo, creating your user17:17
cachio_mvo, any idea why it did not work after you registered it?17:17
pstolowskieow o/17:20
mvocachio_: hm, no idea, also error 500 sounds strange, probably worth talking to the store people about it17:25
mupPR snapd#4645 opened: snapctl: allow `snapctl get` from any uid <Created by mvo5> <https://github.com/snapcore/snapd/pull/4645>17:26
jdstrandSaviq (cc seb128): I was wrong. so, the snapd deb only adds the magic to the Settings service file. if you install the core snap from candidate, it has the updates for both Settings and Launcher, and snapd puts it into place in /usr/share/dbus-1/services17:30
jdstrandSaviq: put another way: snap refresh --candidate core, restart your session and it should work17:30
jdstrandSaviq: I just verified with the spotify snap17:30
SaviqAck!17:40
* diddledan makes his presence known by pretending to be a zombie17:47
* ikey sets fire to ctrl+z17:57
diddledanikey: that sounds like you made a booboo18:01
diddledan?18:01
ikeyno i was protecting against future zombies18:01
diddledanI refuse to use nano because it encourages me to remember ctrl+w as the "find" feature, and then I close random windows when I'm trying to find in other apps18:02
ikeylol18:02
* ikey only uses nano for CLI editing18:02
ikeywell that and "echo blah >>"18:02
=== alan_g is now known as alan_g|EOW
jdstrandmvo: you might be interested in what I mentioned to Sav iq ^. basically, what is in bionic-proposed doesn't have the full fix for the launcher not launching. core from candidate does fix things up though18:05
mvojdstrand: oh, that is good to know, thank you18:20
mvojdstrand: hm, i downloaded the bionic-proposed deb and checked io.snapcraft.{Launcher,Settings}.service in gdebi and they have the AssumedApparmorLabel=unconfined18:28
Chipacaikey: CLI editing, as in "oh this command is getting too long, ^X^E"?18:31
ikeyoh i dont vim18:33
ikeyor emacs18:33
ikeyalso in my head emacs is a hair removal cream18:33
ikeyso im totally avoiding it18:33
jdstrandmreed: that... is weird. I specifically uploaded to snapd in bionic-proposed and only saw it in settings (this was in a vm). I'm confused18:37
jdstrandupdated*18:37
jdstrandmreed: nvm18:38
Pharaoh_Atem:P18:41
mupBug #1748510 opened: shell's test gives false positive on readability of files <Snappy:New> <https://launchpad.net/bugs/1748510>18:46
=== ikey is now known as ikey|afk
Chipacaikey|afk: ^X^E on bash opens $EDITOR on current commandline19:13
Chipacaikey|afk: completely unrelated question: is solus' encrypted home a LUKS thing, or is it something more weird?19:13
ikey|afkluks19:14
ikey|afkwe dont do encrypted home, only FDE19:14
ikey|afkin future we'll support more specific schems19:14
ikey|afk*scherms19:14
Chipacaright, encrypted home partition19:14
ikey|afk..19:14
ikey|afk*schemes19:14
ikey|afkno i mean the entire thing is encrypted19:14
ikey|afkits only supported in full disk mode on our installer right now19:14
ikey|afkcuz laziness19:14
ikey|afkbut yeah its just normal LUKS19:15
Chipacacool19:15
ikey|afkok im gonna dash, gotta go make myself look hooman for tonight19:15
ikey|afkmight take a while ...19:15
cachio_pedronis, all the tests passing in staging now19:39
=== ryebot is now known as ^
=== ^ is now known as Guest51007
=== Guest51007 is now known as ryebot
mupPR snapcraft#1904 closed: lxd: raw.idmap expects host and container id respectively <Created by kalikiana> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1904>21:23
mupPR snapcraft#1913 closed: elf: pyelftools to parse ELF files rather than readelf <Created by jhenstridge> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1913>21:23
pedroniscachio_: thank you21:44

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!