| hml | babbageclunk: i updated the tests based on the merge build failures… do you want to take another look before i squash the commits? :-D | 00:35 |
|---|---|---|
| babbageclunk | hml: sure | 00:37 |
| hml | babbageclunk: you’re awesome! | 00:38 |
| babbageclunk | hml: Still looks good to me! | 00:41 |
| hml | babbageclunk: ty | 00:41 |
| babbageclunk | wallyworld: I'm looking at your PR now - can you look at mine? :) https://github.com/juju/juju/pull/8380 | 02:20 |
| wallyworld | sure, after tim meeting | 02:21 |
| babbageclunk | wallyworld: oh, looks like hml beat me to it - do I still need to look at it too? | 02:21 |
| wallyworld | babbageclunk: looks like some fixes were asked for so i'll do those and then ping | 02:25 |
| wallyworld | lunch first | 02:25 |
| babbageclunk | okies | 02:25 |
| babbageclunk | bon appetit! | 02:25 |
| * babbageclunk feels bad for momentarily forgetting how to type a é | 02:26 | |
| babbageclunk | *an | 02:26 |
| blahdeblah | é | 02:26 |
| blahdeblah | ^ like that | 02:26 |
| babbageclunk | You just cut'n'pasted my one though, be honest! | 02:27 |
| blahdeblah | babbageclunk: compose, ', e | 02:27 |
| * babbageclunk is chastened | 02:27 | |
| blahdeblah | á é í ó ú | 02:27 |
| blahdeblah | :-P | 02:27 |
| babbageclunk | ☃ | 02:28 |
| blahdeblah | Apparently, ẃ ŕ ý ṕ ś ǵ ḱ ĺ ź ć ń ḿ all work, too | 02:28 |
| babbageclunk | probably useful in wpk-land. | 02:29 |
| blahdeblah | possibly - I never realised non-vowels could have accents | 02:29 |
| mup | Bug #1749763 opened: remove an application not in bundle should be ignored <juju-core:New> <https://launchpad.net/bugs/1749763> | 18:00 |
| wpk | Could someone look at https://github.com/juju/juju/pull/8375 (and at #1 comment in bugreport, as it gives the background) and state if that solution makes sense to them? (it works) | 22:49 |
| wallyworld | wpk: i think i agree with roger's comment | 22:51 |
| wallyworld | hml: did we need to make a fix to the update series tool to fix the symlink? | 22:52 |
| wpk | wallyworld: refresh | 22:52 |
| hml | wallyworld: right now it’d be part of the update series how to guide in the docs | 22:52 |
| wpk | wallyworld: I forgot to remove it. | 22:52 |
| hml | wallyworld: trying to understand if there way a change… and if that’s the only gotcha | 22:53 |
| hml | wallyworld: don’t remember having to do that at all before | 22:53 |
| wpk | wallyworld: the big change is in MongoInfo actually | 22:53 |
| wallyworld | hml: ok. i do think we need a fix to the tool ultimately. good that we have a workaround for now. i am surprised we didn't hit the issue before given that agent symlink is tied to series | 22:54 |
| hml | wallyworld: that’s what’s bugging me | 22:54 |
| wallyworld | wpk: the "isController" flag - that means is the connection for *this* controller or *any* controller? I assume *this* controller? | 22:56 |
| wpk | wallyworld: isController flag means that we're a controller, and then - as a controller we should connect to self only. | 22:57 |
| wallyworld | wpk: makes sense. could you expand the comment a little to make it very clear and that we are deliberately only returning api info with local host for that reason | 22:58 |
| wpk | wallyworld: and the MongoInfo stuff? That's a 'hack' (as it assumes that mongos are on the same IPs as controllers). | 22:59 |
| wallyworld | still digesting that bit, reading bug | 23:00 |
| wallyworld | wpk: so with the patch we try local mongo first but will fail over to connect to a mongo on a different controller if needed. but i'm not sure that we shouldn't just be waiting until out own mongo becomes available. ie controller and mongo tied together. if mongo not available on a controller yet, wait for it. maybe need a second opinion | 23:04 |
| wpk | wallyworld: "waiting until out own mongo becomes available" <- that could never happen (see my comment on the bug) | 23:05 |
| wallyworld | right, we have a problem. but maybe the solution lies elsewhere. i'm not sure we're fixing the correct root cause. i am not sure it makes sense for a controller to talk to anything other than it's own mongo. but i may be wrong. i'd like to see what john thinks | 23:07 |
| wallyworld | it's not super critical to land this right away as 2.3.3 has gone out | 23:07 |
| wpk | wallyworld: we've had a discussion today and that was one of the proposals | 23:08 |
| wallyworld | oh, i see. john was happy with the approach taken? | 23:08 |
| thumper | anyone.. https://github.com/juju/juju/pull/8388 | 23:08 |
| wpk | wallyworld: (and the controller talks to mongo master, not only own mongo - it just has to know where the other mongos are and we're giving only localhost, then mongo itself tells about all other peers) | 23:09 |
| wallyworld | wpk: i guess it will be temporary and will correct itself and then the controller will stil use local host | 23:09 |
| thumper | wpk: this may be what jam and I discussed the other day | 23:09 |
| wpk | wallyworld: the other approach would be to limit connections to localhost only after the controller is really a controller (hasVote) | 23:09 |
| wallyworld | right, i would have maybe preferred that but if john is happy | 23:10 |
| wpk | I'm gathering opinions :) | 23:10 |
| wallyworld | i am just wary about hw doign this current approach may affect HA | 23:10 |
| wpk | Democracy and stuff | 23:10 |
| wallyworld | i am not an expert here, just have an opinion | 23:11 |
| thumper | wpk: I don't agree with wallyworld and roger | 23:11 |
| thumper | just saying | 23:11 |
| thumper | wpk: if we are going to filter differently based on controller or not controller | 23:11 |
| thumper | I'd rather do that in the connection space, rather than the writing config space | 23:11 |
| thumper | we need a filter either way | 23:11 |
| thumper | and I'd rather it was closer to the connect | 23:11 |
| wallyworld | thumper: my point was that i disagree with the implicit assumption that localhost was always first | 23:12 |
| wpk | thumper: My first approach was the way Roger wanted (in config space), but it didn't worked so I moved it to connect code, it worked, but then I realized I have a race and it's just random | 23:12 |
| wallyworld | unless that is made very clear that's part of the contract | 23:12 |
| wpk | thumper: So here I agree with Roger and Ian | 23:12 |
| thumper | I was talking about api connect | 23:12 |
| thumper | are you talking about mongo connect? | 23:13 |
| wpk | API | 23:15 |
| wpk | mongo is a separate thing, that came out of comment/1 on this bug. | 23:15 |
| thumper | I like what we have, where we explicitly say []string{localAPIAddr} | 23:16 |
| thumper | and just that | 23:16 |
| thumper | don't assume localhost first | 23:16 |
| thumper | wpk: how did it work before? | 23:18 |
| thumper | wpk: if we only ever returned localhost before, how did HA work? | 23:20 |
| wpk | thumper: we returned localhost and all other addresses | 23:22 |
| wpk | thumper: (localhost first) | 23:22 |
| thumper | not in the MongoInfo function on the left | 23:22 |
| wpk | thumper: but connecting to other addresses during upgrade caused problems (that we've never reproduced, but we had consistent reports of them) | 23:23 |
| wpk | thumper: ah, for Mongo it worked because apicaller could connect to other controllers | 23:23 |
| thumper | I'm not sure we are talking about the same thing | 23:23 |
| thumper | ah... | 23:24 |
| wpk | thumper: and then machiner started, reported to other controller that this machine is alive, the other controller told mongo to connect 'this' mongo to replicaset | 23:24 |
| thumper | If we put localhost at the start of the Mongo info, does it happen to choose that first? | 23:24 |
| wpk | thumper: that's what in the code, but then it'll connect to master eventually | 23:24 |
| thumper | that happens at the driver level right? | 23:25 |
| wpk | thumper: even if we set MongoInfo to 'localhost' only it'll connect to master as it'll get it from local mongo, so it's not 'info', it's just 'seed' | 23:25 |
| * thumper nods | 23:25 | |
| thumper | wpk: I'm adding a comment | 23:27 |
| thumper | wpk: actually, no comment, this makes sense to me now | 23:28 |
| wpk | OK, I'll fix the tests tomorrow and ask for acceptance. | 23:40 |
| anastasiamac | thumper: babbageclunk: team meet?.. | 23:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!