[01:12] <wallyworld> babbageclunk: would be awesome to get the caas containers PR looked at before your EOD if you get a chance
[01:14] <babbageclunk> wallyworld: ok, pushing this and looking now
[01:15] <wallyworld> awesome sauce
[01:33] <babbageclunk> wallyworld: do you want to look at https://github.com/juju/juju/pull/8380 again before I try to merge it?
[01:33] <wallyworld> babbageclunk: doing interview, should be ok though?
[01:33] <babbageclunk> ok cool - I'm gonna kick it off now then.
[02:09] <babbageclunk> wallyworld: approved
[02:10] <wallyworld> yay, ty
[02:19] <babbageclunk> wallyworld: yay, finally landed!
[02:19]  * babbageclunk goes for a celebratory run
[02:19] <wallyworld> whoohoo
[09:15] <chrome0> Heya folks, do you have any ETA for a juju 1.25.14 release? Eagerly waiting for a release for bug #1729930
[09:15] <mup> Bug #1729930: juju.state.leadership manager.go:72 stopping leadership manager with error: state changing too quickly; try again soon <sts> <juju-core:Fix Committed by axwalk> <https://launchpad.net/bugs/1729930>
[14:02] <jam> anyone up for reviewing a patch that cleans up peergrouper logging: https://github.com/juju/juju/pull/8410
[14:38] <jam> and the same patch into 2.4 https://github.com/juju/juju/pull/8411
[14:38] <jam> well, bringing in Tim's work on 2.3 that actually fixes the intermittent test, and combining it with my cleanups to peergrouper, and resolving conflicts with manadart's network changes
[14:38] <jam> manadart: ^^
[14:43] <manadart> jam: I can look at #8411
[14:44] <jam> manadart: 8410 has a bunch of "why am I changing this comments" that I made, so it might be easier to start there.
[14:45] <manadart> jam: Ack.
[15:31] <manadart> jam: Reviewed.
[21:52] <veebers> Hi All, anyone have a juju/juju PR ready for merge? I want to make a fix to the merge job and want to monitor the run
[22:47] <wallyworld> rogpeppe: looks like there's a jimm change needed. juju core itself is fine
[22:48] <rogpeppe> wallyworld: what change is needed?
[22:48] <rogpeppe> wallyworld: i'm a bit surprised because i'd've thought it was still serving the same API
[22:48] <wallyworld> the api facade clients in core have been updated to fill in "iaas" where the ModelInfo structs returned from the api have an empty ModelType field
[22:49] <wallyworld> i could also accept an empty model type further downstream and fill in iaas
[22:50] <rogpeppe> wallyworld: i don't understand why the facade clients aren't filling in the empty model types received from jimm
[22:50] <wallyworld> different code base
[22:51] <wallyworld> doesn't jimm have it's own client facades?
[22:51] <wallyworld> the api layer i mean
[22:52] <rogpeppe> wallyworld: it does, but i don't see why the juju client isn't doing this
[22:52] <wallyworld> it is for core
[22:52] <rogpeppe> wallyworld: the juju client used with jimm is the same as for any juju server
[22:53] <wallyworld> that doesn't make sense then, as core CLI works fine
[22:53] <rogpeppe> wallyworld: it doesn't behave fine when it's talking to a jimm controller
[22:53] <wallyworld> an older controller will return empty type value and the api client fills it in
[22:54] <rogpeppe> wallyworld: isn't that what jimm is doing?
[22:54] <wallyworld> there's3 places in the api layer that were changed
[22:54] <rogpeppe> wallyworld: not filling it in, i mean, but returning an empty type value
[22:54] <wallyworld> yes, and the api layer should be filling it in. core CLI works fine
[22:54] <wallyworld> so i'm confused
[22:55] <rogpeppe> wallyworld: it's the core CLI that i'm using
[22:55] <rogpeppe> wallyworld: and i've pasted the full API interaction in the bug
[22:55] <wallyworld> hmm, i tested with core CLI too
[22:56] <wallyworld> against an old 2.3.3 controller
[22:56] <wallyworld> worked fine
[22:56] <rogpeppe> wallyworld: yes, but you didn't test with jimm
[22:56] <rogpeppe> wallyworld: i.e. with a jimm controller
[22:56] <wallyworld> what's the difference?
[22:56] <rogpeppe> wallyworld: it fails to work :)
[22:56] <rogpeppe> wallyworld: did you try my repo instructions?
[22:56] <wallyworld> a jimm controller will return the ame thing - an empty type
[22:56] <rogpeppe> repro
[22:56] <rogpeppe> wallyworld: yup, but it fails
[22:57] <rogpeppe> wallyworld: i don't understand the difference either
[22:57] <wallyworld> right and it makes no sense why - an empty field is an empty field
[22:57] <rogpeppe> wallyworld: well, first see if you can reproduce
[22:57] <rogpeppe> wallyworld: then you can debug to see what's going on
[22:57] <wallyworld> ok, guess i'll need to make a jaas account :-)
[22:58] <rogpeppe> wallyworld: you don't need a jaas account
[22:58] <rogpeppe> wallyworld: you just need to log in with usso
[22:58] <rogpeppe> wallyworld: which you'll be prompted to do
[23:00] <rogpeppe> wallyworld: what's your USSO id? i'll make sure you're granted access to a model
[23:00] <wallyworld> rogpeppe: i found it - there is old legacy code that i missed when adding in the missing value
[23:00] <wallyworld> it's a quick 3 line fix
[23:01] <wallyworld> sigh, sorry
[23:01] <rogpeppe> wallyworld: ok, thanks
[23:01] <wallyworld> makes sens now
[23:01] <rogpeppe> wallyworld: np
[23:01] <rogpeppe> wallyworld: BTW you should use jaas - it's useful :) :)
[23:01] <wallyworld> if i had a need to i would :-)
[23:02] <wallyworld> but for development i need to run up bespoke cloud deployments
[23:26] <babbageclunk> veebers: did you find a candidate for your job test?
[23:26] <babbageclunk> cause there's one here: https://github.com/juju/juju/pull/8413
[23:26] <babbageclunk> Feel free to approve it if you look at it. ;)
[23:27] <veebers> babbageclunk: I haven't yet, I may have now :-)
[23:28] <veebers> babbageclunk: Sweet, LGTM I'll update the job and $$merge$$ it
[23:29] <babbageclunk> veebers: ta
[23:32] <veebers> cool, I had to repeat myself but the merge process is in motion. I'll monitor it in case the change needs reverted :-\