[00:19] nacc, go nacc go! =) [00:31] xnox: heh [00:50] xnox: Now I have to import your qtbase upload into VCS manually :/ [00:51] xnox: Also, block-proposed still belongs on bug 1749472 because mesa migrating will break Kubuntu and Lubuntu Next completely, so imho "because it's blocked by other things" isn't good enough :/ [00:51] bug 1749472 in qtbase-opensource-src (Ubuntu Bionic) "mesa 18.0.0 will cause rendering errors in Qt applications" [Undecided,New] https://launchpad.net/bugs/1749472 [00:53] tsimonq2, i was meant to put the tag back in, post qtbase migrating [00:54] tsimonq2, unfortunately we do not have block-proposed tags that block only some packages =/ [00:54] tsimonq2, thanks for puttin ghte tag back it. [00:54] *in [00:55] xnox: I wonder if there's a way for me to implement syntax like block-proposed-qtbase-opensource-src [00:55] xnox: In fact, I'll look into that now and see if it's as simple as adding a few lines of code [00:57] xnox: Either way I'd appreciate if you could throw me a PR here merging your upload in: https://salsa.debian.org/qt-kde-team/qt/qtbase/tree/ubuntu+1 [00:57] tsimonq2, well.... one could have two bugs; one bug per source package; with tags and say "blocks bug #" whatever in description...... [00:57] lovely [00:57] i'm yet to do a PR on salsa /O\ [00:58] xnox: Right but I think that's far from ideal :) [00:58] xnox: I did my first PR on Salsa yesterday, there should be a fork button somewhere on https://salsa.debian.org/qt-kde-team/qt/qtbase [00:59] xnox: To be precise: https://salsa.debian.org/qt-kde-team/qt/qtbase/forks/new [01:08] xnox: I believe all you have to do is mark a specific package as Fix Released for block-proposed to no longer apply to it [01:12] jbicha: But it *isn't* Fix Released [01:12] jbicha: imho that's *super* hacky [01:16] xnox: xevious: ok, just uploaded the last two php-horde*. I need to be afk tonight, but will retry what i see tmrw morning [01:18] xnox: hi! from nacc I understood you are maybe the one buidling the janus package ? [01:23] xnox: I have some issues with stopping the service, killing does not work and restarting has pidfile issues and never writes one on bionic [01:24] rizonz, literarly no idea what janus is [01:25] rizonz, i did a no change rebuild of it; as part of openssl1.1 transition, but that was 100% automated mechanical bot upload. [01:25] rizonz, file a bug about it? [01:25] rizonz, on launchpad, and maybe on Debian BTS too. [01:25] xnox: https://launchpad.net/ubuntu/+source/janus/0.2.6-1build1 [01:25] ah ok! [01:25] rizonz, as, I said, that was a blind upload. the source package is unmodified from debian. [01:25] your name was there [01:25] okay! [01:26] then I ask them [01:26] xnox: sorry to bother you :) [01:26] no problem [01:27] heh, you make me hungry btw, you remind me about unox [06:29] Hi, in bug #1749790 a bigger autopkgtest-VM is needed to move the ganeti package from bionic-proposed to release (pass the test). Is there someone willing to set a bigger VM? [06:29] bug 1749790 in ganeti (Ubuntu) "ganeti: bionic proposed to release: bigger autopkgtest-VM" [Undecided,Confirmed] https://launchpad.net/bugs/1749790 === ubott2 is now known as ubottu === led2 is now known as led1 [09:08] nmap (7.60-1ubuntu4) bionic; urgency=medium [09:08] * debian/control: Add dependency menu for zenmap. (LP #126331) [09:08] Launchpad bug 126331 in Jupiter "Instalation / Upgrade problem" [Undecided,New] https://launchpad.net/bugs/126331 [09:08] Not exactly ideal.. [09:46] rbasak: hey! Just so you know, I will be doing and approving some uploads to xenial today as part of preparations for the point-release - just letting you know so that you don't get confused that I'm doing an SRU shift today [09:46] I will not get in your way with normal SRUs [09:56] sil2100: OK. Thank you for syncing with me! [11:26] jamespage: in bug 1724622, shouldn't there be a test output summary attached to the bug? [11:26] bug 1724622 in openvswitch (Ubuntu Artful) "[SRU] openvswitch 2.8.1" [High,Fix committed] https://launchpad.net/bugs/1724622 [11:27] rbasak: uh yes you are quite correct - juggling to many things [11:27] lemme dig those out [11:54] bdmurray: should ubuntu-release-upgrader in the Xenial SRU queue have a bug reference? Or is it special somehow? === Cyrus is now known as Guest9258 === alan_g is now known as alan_g|lunch === alan_g|lunch is now known as alan_g [14:10] Laney: do you remember me, asking for a bigger autopkgtest-VM for package ganeti? It seems ganeti just got default 1536MB RAM. In the mean time I opened bug #1749790. Could you please have a look at it? [14:10] bug 1749790 in ganeti (Ubuntu) "ganeti: bionic proposed to release: bigger autopkgtest-VM" [Undecided,Confirmed] https://launchpad.net/bugs/1749790 [14:18] xnox: Did you get a chance to look at proposing a PR to qtbase on Salsa quite yet? [14:18] let's do this now. [14:19] OK [14:22] tsimonq2, ehhhm that repository is crazy [14:24] tsimonq2, it appears to be missing 5.9.3+dfsg-0ubuntu1 5.9.3+dfsg-0ubuntu2 5.9.3+dfsg-0ubuntu3 5.9.3+dfsg-0ubuntu4 uploads. [14:24] tsimonq2, what would you like me to do? rebase the ssl patch against ubuntu+1 branch, aka 5.9.4 tree? [14:24] Please [14:25] tsimonq2, but what about other changes? =/ [14:26] Merge those in if possible please [14:26] tsimonq2, but it's like your upload =/ did you not push latest to salsa? [14:32] tsimonq2, that repository is very weird usage of git. [14:34] rbasak: pasted my test results as you pasted or IRC conversation :-) [14:37] coolfish: I messed up and didn't put it in one of the required files, fixing now [14:39] tsimonq2, test building [14:39] jamespage: :) [14:39] * rbasak looks [14:48] coolfish: See if the next lot of tests for 2.16.0~rc2-1 are any better [14:55] xnox: message from tsimonq2 via Telegram. He apologises, but he had to "abruptly leave for class". [14:59] acheronuk, tsimonq2 - no worries, i should have something proposed on salsa soon. [15:01] tsimonq2, https://salsa.debian.org/qt-kde-team/qt/qtbase/merge_requests/1 [15:01] no idea if this is right, or wrong. [15:01] it builds [15:16] xnox: tsimonq2 wrote me in Telegram: “Please pass on to xnox that I had to abruptly leave for class” [15:16] oh, acheronuk already told the same :P [15:16] * mitya57 is slow [15:17] I can look at your merge request though [15:17] :) [15:18] Boy oh boy I want to graduate already [15:20] xnox, acheronuk, mitya57: Thanks, [15:20] tsimonq2: sadly, won't the 1st time you wish that. high school -> college -> more quals :P [15:20] *last time [15:21] * mitya57 commented on xnox's merge request [15:26] * xnox struggles to find notification of any sort from salsa [15:26] * acheronuk suggests tsimonq2 does a few circuits to relax [15:26] nacc: Updated the gist a little while ago... https://gist.github.com/iammattcoleman/88013cb5f92105b15a66ee2ada442a16#file-2018-02-19_124034_php-defaults-txt-L171 [15:26] nacc: Whenever you're ready, let's split up the remaining work. [15:31] grr acheronuk :P [15:34] Laney: thanks a lot, I'll watch the autopkgtest status. [15:39] Laney: regarding the version: our understanding is, that ubuntu syncs with debain-testing/buster (ganeti-2.15), ganeti-2.16rc2 is in debian-unstable/sid and AFAIK has open regressions. [15:41] rbasak: Its special because the mirror file is just being updated. See https://launchpad.net/ubuntu/+source/python-apt/1.1.0~beta1ubuntu0.16.04.1 Maybe we should document that. [15:44] Ah. I had assumed that there's always a tracking bug, but looking at tzdata that isn't always the case. [15:45] bdmurray: how should I approach reviewing this? [15:45] Just a sanity check and accept? [15:45] And does sru-review work as normal? [15:46] * rbasak goes afk for a bit [15:50] rbasak: I'd check with sil2100 since he's leading the 16.04 point release [15:52] rbasak: yeah, leave that one for me, I'm not including tracking bugs for releasey things (if it doesn't make sense at least) [15:52] rbasak: I checked all the ADT failures and will be taking care of releasing it before the candidates are being created [15:52] After some sanity checking [15:53] There will be a few other uploads like that [16:05] ack [16:12] xevious: i'm back now [16:12] nacc: Good morning! [16:13] nacc: Which packages are you working on? I'll take a handful that you're not currently looking at and add them to LP#1750041. [16:14] ...and, ya know, work on them. [16:15] Or, is there one in particular you'd like me to work on? [16:15] xevious: the ones i don't know how to fix are php-horde-kolab-storage, php-horde-kronolith, php-horde-sessionhandler, [16:16] xevious: all regressed because of php7.2 changes in how session works, i think [16:16] xevious: it's the 'headers sent after...' messages [16:16] xevious: it seems like in php <7.2, it was silently doing nothing [16:16] now it is noisily warning [16:19] xevious: i'll retry the others now [16:32] xevious: would you be able to investigate those? or even a few of them (maybe just sessionhandler to start, as that is the root cause of the regression in kronolith, iirc) [16:32] xevious: i need to do some MIR work today, but can pivot back to php in a few hours, i think [16:33] well, that's a new one (running an autopkgtest.u.c retrigger): "A server error occurred. Please contact the administrator." [16:33] Laney: --^ would that be you? [16:35] nacc: Yeah, I'll start with sessionhandler. [16:35] xevious: thanks! [16:35] xevious: iirc, the tests actually aren't failing [16:36] but since php emits a warning, and stderr messages aren't allowed by default, the tests fail [16:36] so there are two solutions, 1) silence the warnings or 2) fix the warnings :) [16:36] i'd prefer the latter, but i couldn't figure them out [16:39] slangasek: would you know who the administrator of autopkgtest.ubuntu.com is? [16:42] nacc: present [16:42] nacc: (Laney and myself) [16:43] coolfish: We sync from unstable [16:43] nacc: link? [16:44] slangasek: Laney: https://autopkgtest.ubuntu.com/request.cgi?release=bionic&arch=amd64&package=php-horde-serialize&trigger=php-defaults%2F60ubuntu1&all-proposed=1 [16:45] i've not tried any others, since i don't want to just hammer the server with failures :) [16:45] it was working fine for the first 3 or 4 packages I ran against [16:45] (i'm working through the php-defaults queue that i fixed last night) [16:45] hmph [16:45] Laney: I'm on calls right now; do you have time to dig into this? [16:48] yeah [16:49] can't connect to the amqp server seems to be the problem [16:49] :( [16:51] nacc: Do you already make an LP issue for sessionhandler? [16:51] *Did [16:52] nacc: seems to be some maintenance going slightly awry [16:52] xevious: no, you can just add tasks to the php-defaults bug, i think, if you want [16:53] Laney: ok, thanks -- I'll hold off on further triggers for now, but others will probably hit it :) [16:54] nacc: not a lot we can do, and it won't really cause a problem other than irritating you [16:54] assuming britney is doing something sane like not thinking it has submitted requests ... [16:55] Laney: ack -- do you have any idea when I should retry again? I know these will all pass once retriggered, just need to through them so we can get php migrated [16:55] crashing [16:55] that'll do [16:55] heh [16:56] nacc: dunno, I'm watching IS people try to fix it [16:56] Laney: ah ok :) [16:56] ah [16:56] works now I think [16:56] nacc: just clicked that link for you, feel free to run others [16:56] Laney: thanks! [16:57] Laney: yep, working again [16:57] networking is useful, it turns out [17:05] Laney: slangasek: thank you to both [17:07] xevious: fwiw, i was reading other upstream code's changes to deal with the same messages with php7.2 [17:08] xevious: one of them had a commit message like 'do not call ini_set before session_start' [17:09] Laney: hrm, i submitting a bunch of retriggers now, and none have showed up in http://autopkgtest.ubuntu.com/running .. usually they show up relatively quickly [17:09] even if in the backlog [17:09] "a bunch" = 30-40 [17:18] nacc: I can see a handful of tests being run by you there [17:19] are there some missing? if so, which package/arch? [17:23] (probably the /running page got a bit confused when its amqp connection went away) [17:27] Laney: Which AMQP server are you using? [17:29] rabbitmq === Guest9258 is now known as Cyrus [17:56] Laney: sorry, let me see [17:59] nacc: I've got https://paste.ubuntu.com/p/srVp6vtxg5/ [18:00] Laney: ok, that looks fine [18:00] Laney: i think I was just impatient :) [18:05] bdmurray: can you tell why LP: #1750842 was marked private? [18:05] Error: Launchpad bug 1750842 could not be found [18:05] (the submitting user is asking) [18:05] xevious: any luck? [18:06] Still debugging. This is a doozy. [18:06] xevious: yeah [18:06] xevious: i got fairly deep into the package code and hte upstream bug reports about this change [18:06] nacc: I can't see it with my lp account. Can you give me some more details? [18:06] and then decided i really didn't know how to fix it :) [18:14] bdmurray: i can subscribe you if that would help (the user subscribed me) [18:14] bdmurray: apport filed it for them [18:14] bdmurray: but they don't know why it's marked private [18:15] nacc: is it tagged needs-amd64-retrace? [18:15] bdmurray: it was, but is no longer [18:15] bdmurray: does that make it private? [18:17] nacc: It starts of as private w/ only the retracer subscribed, then after retracing the retracer leaves it private and subscribes ubuntu-bugcontrol. Its stays private because the Stacktrace might have sensitive information. [18:17] nacc: Or maybe not bugcontrol but some intermediate team. [18:19] nacc: yeah - crash bug triagers for universe or main should be subscribed by apport [18:20] Well its really only one team but still named ubuntu-crashes-universe [19:24] bdmurray: ah ok [19:25] bdmurray: thanks for the explanation [19:39] bdmurray: in this particular case, i don't see any team subscription being added after the retracer tag was removed? [19:52] nacc: PHPUnit's output is breaking the test. `headers_sent()` returns FALSE before this line and TRUE after it: https://github.com/sebastianbergmann/phpunit/blob/master/src/TextUI/TestRunner.php#L283-L285 [19:53] Still working on a fix, but I at least tracked down the line where we go from working to broken. [19:54] xevious: weird, but is that really a header send to PHP? [19:54] As soon as any output occurs, PHP considers the headers sent. [19:54] ...since you can't change HTTP headers after you start sending the page content. [19:55] xevious: ah interesting [19:55] xevious: but PHPUnit has always done this, afaict [19:56] xevious: or, i guess i would think phpunit would be exec'ing php to run the test, so it'd be a new session? [19:57] dunno exactly waht i mean, but it's weird to me that the runner's env would affect the runnee's [19:58] Yeah, I agree. Still trying to figure out *why* that's breaking the test now. [19:58] xevious: if you are able to get sessionhandler working, i hav ethe kronolith fixes for phpunit6 locallyu, and i can test against your updated version [20:04] nacc: well subscribe me and I'll have alook [20:24] bdmurray: done [20:25] nacc: Oh, I think there was an LP issue overnight [20:28] bdmurray: ah ok [20:29] nacc: That doesn't seem to be it though so I'll look into more [20:31] bdmurray: thanks, i'll let them know [20:31] xevious: any luck? [20:32] xevious: i wonder if this is related? https://github.com/yiisoft/yii2/pull/14959 [20:33] I think I found the fix [20:33] Give me a few... [20:33] xevious: per the comment there, do we need to add an output buffer? [20:33] xevious: ok cool! [20:35] xevious: it seems like a bunch of projects have added freeze/unfreeze logic upstream? [20:49] nacc: output buffering didn't help. I got it passing but it's still complaining about the headers being sent. [20:50] All its assertions pass, though. [20:52] nacc: Which LP issue should I upload the patch to? [20:53] n/m found it [20:54] nacc: This issue is about removing packages unused, is there a separate issue about PHP 7.2 compatibility? https://bugs.launchpad.net/ubuntu/+source/php-phpdocumentor-reflection/+bug/1749783 [20:54] Launchpad bug 1749783 in php-sabre-xml (Ubuntu) "php-defaults stuck in bionic-proposed" [Undecided,Fix released] [20:59] xevious: it's about anythiing blocking php-defaults (per the title) [20:59] xevious: so it's fine to attach there [20:59] Ok [21:04] I've built up a strong distaste for Horde users. [21:07] xevious: :) [21:07] xevious: fwiw, a bunch of stuff should start migrating from proposed after i retriggered something like 400 tests :) [21:11] Splendid [21:12] xevious: and a bunch more are wedged because there are still some horde packages i need to hit [21:12] i'm d/ling those now [21:21] xevious: i don't have my mail open right now (having to build 20 or so more horde packages). let me know when you attach the patch and i'll take a look [21:22] Will do. I got the tests to pass while inside the adt shell after one of the failures. However, when I applied those changes to the package and retested, a new issue cropped up: dealing with it now. [21:23] xevious: thanks [21:48] Woops [21:50] nacc: https://bugs.launchpad.net/ubuntu/+source/php-horde-sessionhandler/+bug/1749783/comments/16 [21:50] Launchpad bug 1749783 in php-horde-sessionhandler (Ubuntu) "php-defaults stuck in bionic-proposed" [Undecided,New] [21:51] nacc: I don't feel great about that patch because I supressed a few warnings to eliminate stderr output, but all of the assertions in the unit tests pass. [22:02] xevious: do you want to ping the upstream about it? i know it's just in the tests, so the underlying code is unchanged, i just wonder if they would take it [22:06] A large part of the fix came from them. [22:06] Hold on though [22:06] I think I might have figured out how to avoid supressing the warnings. [22:09] nacc: Here's the majority of the fix: https://github.com/horde/SessionHandler/commit/d1a72d266117894be11f10645486cb13c7b1b40e [22:10] xevious: oh great! [22:10] xevious: can you add dep3 headers for that? [22:10] (cf what `dpkg-source --commit` does) [22:10] Some of my changes are definitely upstreamed. [22:11] ..and some of the other changes are upstreamable. [22:11] Let me try out this change, then we'll circle back to dep3 headers. [22:15] xevious: thanks! it just lets us track where things come from and such [22:51] nacc: Ok, I have a better patch that doesn't require supressing warnings. [22:51] How do I do the dep3 stuff? [22:54] xevious: so i'm looking for something like [22:54] http://dep.debian.net/deps/dep3/ [22:54] specifically the Description, Origin, Author fields [22:55] xevious: you can then use dep3changelog to genrate the changelog entry using that data :) [23:03] xevious: let me know if you need more [23:03] I'm splitting it up into two patches: one to pull in the file from upstream, and one with my changes to that file. [23:04] xevious: ah great, that's a good way of doing it [23:04] After reading the Debian documentation, it seemed like the right thing to do. [23:05] Should I put myself or the upstream committer as the author for the first patch? [23:05] xevious: if it's fully from upstream, i tend to use the upstream commitere/author [23:15] xevious: is that working ok for you? [23:16] Yeah, just making the debdiff now [23:16] My local test has to finish, too. [23:17] xevious: nice [23:23] nacc: I've been keeping track of all my changes and plan on at least attempting to upstream them all. Some of the projects specifically say they're a PHP5 library, so I don't know if they'll accept PRs that make them PHP7-only. [23:25] xevious: yeah, it's worth doing still, even then [23:26] nacc: Here you go: https://bugs.launchpad.net/ubuntu/+source/php-horde-sessionhandler/+bug/1749783/comments/17 [23:26] Launchpad bug 1749783 in php-horde-sessionhandler (Ubuntu) "php-defaults stuck in bionic-proposed" [Undecided,New] [23:26] xevious: reviewing now [23:27] Thanks. I've got to head out to dinner soon, but I'd like to make sure it's good before I leave. [23:28] xevious: yep, pulling it down now the patch looks good, i'll make sure it builds and passes locally [23:29] and i'll test and push the dependent packages if it does [23:29] xevious: fixed the LP entry (it needs to be LP: to be seen) [23:31] Oops! Thanks for pointing that out. [23:33] xevious: np [23:34] xevious: looks good [23:34] xevious: i'll test the dependent packages and then upload [23:34] Excellent. [23:35] I'm heading out for the night. We'll see what's left, if anything, tomorrow. [23:36] xevious: thanks again for all your help! [23:40] xevious: ok, that didnt' solve the two related packages (afaict) [23:40] xevious: definitely kronolith is related [23:40] https://paste.ubuntu.com/p/CvSQBvRVf6/ [23:41] and for php-horde-kolab-storage with my local changes, i get: https://paste.ubuntu.com/p/ztZpBqrPbW/ [23:42] xevious: i'll update the bug, because it hink sessionhandler itself needs changes in order to work [23:45] xevious: the reason i think the kolab-storage stuff is related, is that synchronizeList uses the session, i believe