| jbicha | ricotz: does this commit look ok to you? https://github.com/linuxmint/slick-greeter/commit/3959b22a | 10:17 |
|---|---|---|
| jbicha | because arctica-greeter and unity-greeter both need commits to build with new vala | 10:18 |
| ricotz | jbicha, why is this "hack" needed? hmm, looks like a regression | 10:19 |
| jbicha | https://launchpad.net/~jbicha/+archive/ubuntu/vala40/+packages?batch=185 | 10:20 |
| ricotz | jbicha, I mean the configure.ac change | 10:20 |
| jbicha | https://launchpad.net/~jbicha/+archive/ubuntu/vala40/+build/14327340 | 10:20 |
| jbicha | I don't know | 10:21 |
| ricotz | jbicha, what was the error you were getting which made this needed? | 10:21 |
| jbicha | ^ | 10:21 |
| ricotz | this is not related | 10:22 |
| jbicha | I didn't make that commit, I don't know if the configure.ac change is needed | 10:22 |
| ricotz | I see | 10:22 |
| ricotz | the source changes look fine | 10:22 |
| ricotz | but the hack indicates a lost header attribute in gtk+-3.0.vapi | 10:23 |
| jbicha | ok | 10:23 |
| ricotz | https://git.gnome.org/browse/vala/commit/vapi/gtk+-3.0.vapi?id=272b41781d028ecd8e6b90bcb7eb2f6aa4b0f512 | 10:26 |
| ricotz | so this "hack" is not needed with 0.39.6+ | 10:27 |
| jbicha | reported: https://github.com/linuxmint/slick-greeter/issues/96 | 10:30 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!