| wallyworld | babbageclunk: a few small comments | 01:37 |
|---|---|---|
| babbageclunk | wallyworld: thanks | 01:38 |
| === frankban|afk is now known as frankban | ||
| frankban | wallyworld: hey, do you have time for taking a look at https://github.com/juju/juju/pull/8427 ?\ | 07:50 |
| wallyworld | frankban: sure, but it's not an area i know much about | 07:52 |
| frankban | wallyworld: ty I already got suggestions from roger in the apiserver area | 07:53 |
| wallyworld | i need to make dinner etc first but will look as soon as ai can | 07:53 |
| frankban | wallyworld: ty! | 07:57 |
| rogpeppe | anyone know what Go version is being used for Juju CI tests? | 10:11 |
| externalreality | Question: I am using go version 1.9.4 - I pulled develop - gofmt was beside itself with grief (or just sad) when I ran it. What version of Go is Juju being built with now (Github says 1.9)? | 10:42 |
| rogpeppe | externalreality: are you using a recent version of gofmt? | 10:43 |
| externalreality | rogpeppe: which gofmt yields '/snap/bin/gofmt' | 11:19 |
| rogpeppe | externalreality: what does "which go" print? | 11:20 |
| externalreality | rogpeppe: the snap - it yields /snap/bin/go | 11:20 |
| rogpeppe | externalreality: hmm, so they *should* be consistent :) | 11:21 |
| externalreality | I get: | 11:23 |
| externalreality | gofmt is sad: | 11:23 |
| externalreality | cmd/juju/commands/helptool.go | 11:23 |
| externalreality | error: failed to push some refs to | 11:23 |
| externalreality | rogpeppe so it is just the one file | 11:23 |
| rogpeppe | externalreality: looks like that file is just wrong | 11:25 |
| rogpeppe | externalreality: it's got an extra newline at the end | 11:26 |
| rogpeppe | externalreality: i wonder how that got through CI | 11:26 |
| rogpeppe | externalreality: looks like https://github.com/juju/juju/pull/8428 is at fault | 11:28 |
| rogpeppe | externalreality: maybe CI is no longer checking for gofmt exact output | 11:28 |
| rogpeppe | externalreality: (which would be sensible, tbh, as the output can vary between go releases) | 11:28 |
| rogpeppe | externalreality: it's changed a fair number of files in go1.10 for example | 11:28 |
| rogpeppe | externalreality: BTW the -l (list files that would be changed) and the -d (show diffs) flags to gofmt can be useful | 11:29 |
| externalreality | Wondeful! Thank you rogpeppe. | 11:30 |
| rogpeppe | externalreality: np :) | 11:30 |
| rogpeppe | externalreality: will see you at the budapest sprint, i hope :) | 11:31 |
| rogpeppe | assuming my airport hasn't closed from all the snow... | 11:31 |
| externalreality | rogpeppe, :-D | 11:36 |
| === salmankhan1 is now known as salmankhan | ||
| === salmankhan1 is now known as salmankhan | ||
| === salmankhan1 is now known as salmankhan | ||
| === gsamfira_ is now known as gsamfira | ||
| kwmonroe | hey anastasiamac, do we have a point-person for the juju vsphere provider? i'm looking for a triage on bug 1751858. | 17:01 |
| mup | Bug #1751858: support vsphere disk.enableUUID model config <juju:New> <https://launchpad.net/bugs/1751858> | 17:01 |
| mup | Bug #1752662 opened: ssh-proxy does not work as expected on AWS <juju-core:New> <https://launchpad.net/bugs/1752662> | 17:35 |
| mup | Bug #1752662 changed: ssh-proxy does not work as expected on AWS <juju-core:New> <https://launchpad.net/bugs/1752662> | 17:41 |
| mup | Bug #1752662 opened: ssh-proxy does not work as expected on AWS <juju-core:New> <https://launchpad.net/bugs/1752662> | 17:50 |
| anastasiamac | kwmonroe: afaik, no (sorry for delay in answering - was 3am my time) but m following it up to ensure u get answers re vsphere :D | 23:10 |
| kwmonroe | np anastasiamac - thanks for the followup! | 23:11 |
| hml | exit | 23:19 |
| hml | :-) wrong window | 23:19 |
| wallyworld | babbageclunk: sometime today if i could land this would be most awesome. a bit of boilerplate as is usual when adding a facade https://github.com/juju/juju/pull/8441 | 23:35 |
| babbageclunk | wallyworld: ok, will take a look after the meeting | 23:41 |
| wallyworld | yay | 23:42 |
| rick_h | thumper: how did the webinar go? | 23:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!