[01:37] babbageclunk: a few small comments [01:38] wallyworld: thanks === frankban|afk is now known as frankban [07:50] wallyworld: hey, do you have time for taking a look at https://github.com/juju/juju/pull/8427 ?\ [07:52] frankban: sure, but it's not an area i know much about [07:53] wallyworld: ty I already got suggestions from roger in the apiserver area [07:53] i need to make dinner etc first but will look as soon as ai can [07:57] wallyworld: ty! [10:11] anyone know what Go version is being used for Juju CI tests? [10:42] Question: I am using go version 1.9.4 - I pulled develop - gofmt was beside itself with grief (or just sad) when I ran it. What version of Go is Juju being built with now (Github says 1.9)? [10:43] externalreality: are you using a recent version of gofmt? [11:19] rogpeppe: which gofmt yields '/snap/bin/gofmt' [11:20] externalreality: what does "which go" print? [11:20] rogpeppe: the snap - it yields /snap/bin/go [11:21] externalreality: hmm, so they *should* be consistent :) [11:23] I get: [11:23] gofmt is sad: [11:23] cmd/juju/commands/helptool.go [11:23] error: failed to push some refs to [11:23] rogpeppe so it is just the one file [11:25] externalreality: looks like that file is just wrong [11:26] externalreality: it's got an extra newline at the end [11:26] externalreality: i wonder how that got through CI [11:28] externalreality: looks like https://github.com/juju/juju/pull/8428 is at fault [11:28] externalreality: maybe CI is no longer checking for gofmt exact output [11:28] externalreality: (which would be sensible, tbh, as the output can vary between go releases) [11:28] externalreality: it's changed a fair number of files in go1.10 for example [11:29] externalreality: BTW the -l (list files that would be changed) and the -d (show diffs) flags to gofmt can be useful [11:30] Wondeful! Thank you rogpeppe. [11:30] externalreality: np :) [11:31] externalreality: will see you at the budapest sprint, i hope :) [11:31] assuming my airport hasn't closed from all the snow... [11:36] rogpeppe, :-D === salmankhan1 is now known as salmankhan === salmankhan1 is now known as salmankhan === salmankhan1 is now known as salmankhan === gsamfira_ is now known as gsamfira [17:01] hey anastasiamac, do we have a point-person for the juju vsphere provider? i'm looking for a triage on bug 1751858. [17:01] Bug #1751858: support vsphere disk.enableUUID model config [17:35] Bug #1752662 opened: ssh-proxy does not work as expected on AWS [17:41] Bug #1752662 changed: ssh-proxy does not work as expected on AWS [17:50] Bug #1752662 opened: ssh-proxy does not work as expected on AWS [23:10] kwmonroe: afaik, no (sorry for delay in answering - was 3am my time) but m following it up to ensure u get answers re vsphere :D [23:11] np anastasiamac - thanks for the followup! [23:19] exit [23:19] :-) wrong window [23:35] babbageclunk: sometime today if i could land this would be most awesome. a bit of boilerplate as is usual when adding a facade https://github.com/juju/juju/pull/8441 [23:41] wallyworld: ok, will take a look after the meeting [23:42] yay [23:47] thumper: how did the webinar go?