[01:01] <handsome_feng> tsimonq2: Hi, by any chance, could you help upload the ukwm? I have updated the package and the PPA. :)
[01:04] <tsimonq2> handsome_feng: Got a link?
[01:04] <handsome_feng> https://launchpad.net/~ubuntukylin-members/+archive/ubuntu/newpackages
[01:05] <tsimonq2> handsome_feng: You've checked Lintian, copyright, etc.?
[01:05] <handsome_feng> Yes
[01:05] <tsimonq2> Alright, cool.
[01:06] <handsome_feng> lintian -i -I --pedantic and licensecheck -r . | grep -v "KNOWN"
[01:06] <tsimonq2> I'll run it through my usual checks but in the meantime, please update bug 1740252 with a Feature Freeze Exception, just in case it's decided that it does break Feature Freeze.
[01:06] <ubottu> bug 1740252 in Ubuntu Kylin "[FFe] ukwm" [Critical,In progress] https://launchpad.net/bugs/1740252
[01:06] <tsimonq2> Oh
[01:06] <tsimonq2> I see that you did that :)
[01:07] <tsimonq2> Well, so the bug title was updated, but in the bug description, please provide a short description for why the Release Team should let it in.
[01:07] <tsimonq2> (Not that there are any problems with it, but still :) )
[01:08] <handsome_feng> fine, I will do it now
[01:10] <tsimonq2> Awesome.
[01:11] <tsimonq2> slangasek: If you're around, does the Release Team object to me uploading ukwm? (It'll sit in the NEW queue anyways, but it'd be good to get your thoughts.)
[01:23] <tsimonq2> handsome_feng: One very minor Lintian thing you might want to either look into or override is this:
[01:23] <tsimonq2> libukwm-1-0: shlib-calls-exit usr/lib/x86_64-linux-gnu/libukwm-1.so.0.0.0
[01:23] <tsimonq2> Otherwise, lgtm
[01:24] <tsimonq2> handsome_feng: Oh, and I would also see if you should continue to disable s390x testing or if that no longer applies (see debian/control)
[01:24] <tsimonq2> s/control/rules/
[01:27] <handsome_feng> emmm, I think we don't need it anymore
[01:32] <tsimonq2> OK cool.
[01:32] <tsimonq2> handsome_feng: Anything else?
[01:32] <handsome_feng> tsimonq2: Hi, How did you get the info of "libukwm-1-0: shlib-calls-exit usr/lib/xxxx", I run lintian but didn't get that
[01:33] <tsimonq2> handsome_feng: Here are my Lintian args: -i -EvIL +pedantic --verbose
[01:34] <tsimonq2> I got it using those.
[01:35] <handsome_feng> Got it! Thanks! :) and BTW, Is it possible to help upload the other kylin packages during the following days? :P
[01:35] <tsimonq2> I can upload them now. :)
[01:37] <handsome_feng> Oh, Fantastic!
[01:37] <tsimonq2> handsome_feng: Which ones?
[01:37] <tsimonq2> And do you have FFe bugs for them?
[01:38] <handsome_feng> Yes, LP: #1740465
[01:38] <ubottu> Launchpad bug 1740465 in Ubuntu Kylin "[FFe] peony-extensions" [High,In progress] https://launchpad.net/bugs/1740465
[01:38] <handsome_feng> LP: #1741209 , LP: #1738680 , LP: #1743554
[01:38] <ubottu> Launchpad bug 1741209 in Ubuntu Kylin "[FFe] ukui-window-switch" [High,In progress] https://launchpad.net/bugs/1741209
[01:39] <ubottu> Launchpad bug 1738680 in Ubuntu Kylin "[FFe] kylin-video" [High,In progress] https://launchpad.net/bugs/1738680
[01:39] <ubottu> Launchpad bug 1743554 in Ubuntu Kylin "[FFe] kylin-burner" [High,In progress] https://launchpad.net/bugs/1743554
[01:39] <tsimonq2> Sure, I'll do a review on each, just be sure to put in the bug description why the Release Team should let these in :)
[01:39] <handsome_feng> And all this packages have uploaded the the PPA: https://launchpad.net/~ubuntukylin-members/+archive/ubuntu/newpackages
[01:40] <tsimonq2> Right
[01:43] <tsimonq2> handsome_feng: I don't consider this a blocker, but in peony-extensions's debian/copyright, the spacing is off
[01:43] <tsimonq2> In some places, tabs are used instead of spaces
[01:43] <tsimonq2> Please fix the formatting on the next upload
[01:44] <handsome_feng> oh, I will
[01:44] <tsimonq2> You also don't need DHFLAGS=--parallel in debian/rules because that's the default from debhelper 10 (I think?) and beyond.
[01:44] <Unit193> 10+, yeah.
[01:45] <tsimonq2> Ah, right. I knew it was either 10 or 11.
[01:47] <handsome_feng> Ok, I have update this in the github, but didn't update to the ppa, should I update it now?
[01:48] <tsimonq2> It's no problem, I'll upload this as it is, just upload an ubuntu2 revision once it's accepted with the changes :)
[01:49] <tsimonq2> A couple non-blocking Lintian things to look at:
[01:49] <tsimonq2> peony-extensions source: autotools-pkg-config-macro-not-cross-compilation-safe configure.ac (line 30)
[01:49] <tsimonq2> peony-extensions source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
[01:50] <tsimonq2> Otherwise, this is good. Uploading now.
[01:50] <handsome_feng> Thanks, I will fix that in next version
[01:51] <tsimonq2> Cool :)
[01:52] <tsimonq2> Standards-version on ukui-window-switch is outdated.
[01:53] <tsimonq2> Some comments in the debian/rules file aren't needed, you might want to clean that up.
[01:55] <tsimonq2> Hm, so ukui-window-switch is depwait on libukwm-1-dev:amd64 (>= 1.1.0) -- so I guess I'll have to wait to upload this until ukwm has been accepted.
[01:56] <handsome_feng> Fine, and I will update the ukwm during the time
[01:57] <tsimonq2> OK cool :)
[01:58] <tsimonq2> handsome_feng: On kylin-burner, I would check if some of these build dependencies are needed. Maybe gnome-common is needed, but if you haven't done a review of these, on next upload it might be good to remove what isn't needed. :)
[01:58] <tsimonq2> Otherwise, Standards-version is outdated.
[02:00] <tsimonq2> I would also be careful that none of these binary package names conflict with anything else. They don't seem to, but it might be good to be explicit :)
[02:01] <handsome_feng> Thanks, I will pay attention next time
[02:02] <tsimonq2> OK, no problem :)
[02:03] <tsimonq2> I have to go eat dinner, but when I get back, I'll finish reviewing these.
[02:05] <handsome_feng> OK, :)
[02:13] <tsimonq2> OK, back.
[02:17] <handsome_feng> Oh, So fast
[02:17] <tsimonq2> :)
[02:18] <tsimonq2> handsome_feng: kylin-burner is actually FTBFS, here's the log: http://paste.ubuntu.com/p/5XHVXhZZtg/
[02:18] <tsimonq2> So you're missing a build dependency there I think.
[02:19] <tsimonq2> I'll review kylin-video while that's fixed.
[02:20] <handsome_feng> emmmm, thanks, I will info you when it fixed
[02:21] <tsimonq2> OK
[02:27] <tsimonq2> kylin-video looks good, uploading.
[02:27] <tsimonq2> handsome_feng: One thing I would recommend is to add Vcs-* headers in debian/control on the next upload for all of these packages
[02:28] <handsome_feng> Ok, got it!
[02:29] <tsimonq2> Cool :D
[06:55] <slangasek> tsimonq2: release team doesn't care about new packages in the queue
[06:55] <tsimonq2> slangasek: ok cool
[22:57] <tsimonq2> Unit193: Dibs.
[22:58] <Unit193> Stop subbing to mail! :P
[22:58] <tsimonq2> :P
[22:58] <Unit193> tsimonq2: Was just about to file a sync for ophcrack too, switching to Qt5 might be of interest.  You want that too or should I file?
[22:59] <tsimonq2> Unit193: I'll take care of that.
[22:59] <Unit193> \o/
[22:59] <tsimonq2> Unit193: Get upload access already. :P
[22:59] <Unit193> Now I'm just waiting for xserver-xorg-video-ati.
[23:00] <tsimonq2> Unit193: For future ref, please build yer stuff against -proposed.
[23:02] <tsimonq2> Unit193: Should ophcrack have an FFe bug?
[23:03] <tsimonq2> Unit193: It isn't seeded, and Qt 5 is Cool And All, but also, you know, Feature Freeze is a thing. :P
[23:04] <tsimonq2> Unit193: xca> Make sure to send to Debian.
[23:10] <tsimonq2> Unit193: https://launchpad.net/ubuntu/+source/xca/1.4.1-0ubuntu1
[23:18] <Unit193> Yeah, though with qt5 migrated and openssl1.1 not in -proposed... :P  Yeah that's more why I was going to go the bug route, FFes are usually pretty easy for unseeded.
[23:18] <Unit193> Also yes, but the meetings are at awful times. :/
[23:19] <tsimonq2> Then do it over email.
[23:20] <Unit193> Thanks for the upload, pre-releases aren't great for LTSes!