/srv/irclogs.ubuntu.com/2018/03/12/#snappy.txt

Son_GokuTingPing, you might want to try with the 2.31.1 snapd00:41
Son_Gokuit is in testing for Fedora00:41
Son_Gokuhttps://bodhi.fedoraproject.org/updates/?packages=snapd00:41
TingPingSon_Goku, i tested on ubuntu 16.04, which honestly is the only version i particularly care about00:41
Son_Gokuah00:42
Son_GokuI thought you were a Fedora user...00:42
TingPingi am00:42
Son_Gokuapologies for assuming00:42
Son_Gokusnapd in Ubuntu 16.04 has had a tumultuous time getting updated00:43
Son_Gokuso they've been lagging behind Fedora on updates00:44
TingPingfunny01:05
Son_Gokuwell, I try to keep things fresh ;)01:06
Son_GokuFedora also beat Ubuntu to getting an updated Mir, too ;)01:07
Son_Gokudespite all the issues caused by gcc801:07
Son_Gokuand fweimer's change to the distro compiler flags01:07
TingPingsounds masochistic01:07
TingPingwhile i'm here are there any download "badges" for snap?01:08
Son_Gokubadges?01:08
Son_Gokuwhat do you mean?01:08
TingPinglike a standardize logo to indicate a snap download01:08
Son_Gokuah01:08
Son_Gokuyou mean like the things Apple/Google do?01:09
TingPingyea01:09
Son_Gokuyeah01:10
Son_Gokuthere's a "snap|built and released" button01:10
Son_Gokuyou can get it through build.snapcraft.io when you connect your GitHub account to the build system01:10
Son_Gokubut a regular button? I don't think so01:11
Son_Gokuan example badge: https://github.com/snapcrafters/atom/blob/master/README.md01:11
* TingPing is working on this https://i.imgur.com/XP2i53v.png01:11
Son_Gokusnaps have an official logo01:12
Son_Gokuand generally speaking, the usage of the ubuntu logo isn't permitted in association with snaps, jfyi01:12
TingPinglink to their logo?01:13
Son_GokuTingPing, yep, trying to find it01:14
Son_Gokuone sec01:14
Son_GokuTingPing: https://assets.ubuntu.com/v1/d24ea71e-10.+SNAPCRAFT_LOGO_AW.zip01:15
Son_Gokuyou'll want {PNG,SVG}_stacked/snapcraft_green-red_st_hex.{png,svg}01:16
Son_Gokuhmm01:16
Son_GokuTIL that cloud-init has a logo01:16
TingPingbit annoyingly sized01:18
mborzeckimorning05:46
* mborzecki is afk for ~1h06:31
=== akash_ is now known as akash
=== oh4__ is now known as oh4_
=== davdunc_ is now known as davdunc
=== lfaraone_ is now known as lfaraone
=== doko_ is now known as doko
zyga-ubuntugood morning07:18
mborzeckiaand i'm back07:38
mborzeckizyga-ubuntu: morning07:38
zyga-ubuntuhey07:38
zyga-ubuntuit's good to be home :-)07:38
mborzeckiyay ;)07:38
mvohey zyga-ubuntu and mborzecki !07:41
zyga-ubuntuhey mvo! :)07:41
mborzeckimvo: hey07:41
* zyga-ubuntu updates his fedora system07:43
mborzeckizyga-ubuntu: some intersting fedora work coming up?07:44
zyga-ubuntuI wanted to fix a build issue on newer gcc's07:47
zyga-ubuntuand since I have ubuntu on my laptop now I could play on fedora on my desktop for some time07:47
mborzeckizyga-ubuntu: what build issue on newer gcc? i have 7.3 here and rebuilt the package yesterday07:56
zyga-ubuntuI don't remember; Neal said there are some issues07:56
zyga-ubuntuI just rebooted and I'll make a rawhide chroot07:56
mborzeckizyga-ubuntu: maybe that's the media-sharing interace thing?07:58
mborzeckizyga-ubuntu: /media vs /run/media07:59
zyga-ubuntuI'll find out soon07:59
zyga-ubuntuthat one was supported for long time now07:59
zyga-ubuntubut maybe it regressed07:59
mborzeckizyga-ubuntu: ok, ping me if you need help08:00
mborzeckihah, had to do blood tests in the morning, now i can make up for the lost blood with some chocolate :P08:01
zyga-ubuntuyum yum08:07
=== pstolowski|afk is now known as pstolowski
pstolowskimorning!08:11
mvohey pstolowski ! good morning08:13
mborzeckipstolowski: hey08:20
zyga-ubuntumvo: hey, did you try the tea by any chance? :-)08:27
user9445hello everyone! I am not a linux expert and I have a question. Can I turn any program into a snap package if I can get its source code? I was thinking about virtualbox.08:28
user9445the official tutorial looks quite easy08:28
zyga-ubuntuuser9445: hey,08:28
zyga-ubuntuuser9445: virtual box may be a bit harder to snap unless you want to make the kernel modules optional08:29
zyga-ubuntuuser9445: but in general, with enough persistence, yes you can snap anything, it's just a format for packaging08:29
zyga-ubuntumborzecki: do you know how to get a fedora chroot?08:29
zyga-ubuntuI'd rather have a chroot with rawhide than a VM with one08:30
mborzeckisystemd-nspawn is probably the easiest way, but you'll probably need dnf to install everything, maybe they still publis the raw rootfs images, so this might be a second way to try08:31
zyga-ubuntuoh, I didn't think about that08:32
zyga-ubuntuthe host if F2708:32
mvozyga-ubuntu: yeah, its interessting. pretty strong flavor, not what I am used to but I will drink it a bit and see if it clicks :)08:32
mborzeckizyga-ubuntu: https://download.fedoraproject.org/pub/fedora/linux/releases/27/CloudImages/x86_64/images/Fedora-Cloud-Base-27-1.6.x86_64.raw.xz raw image08:32
mvozyga-ubuntu: I will definitely get you some for the next sprint as well :)08:32
zyga-ubuntumvo: not sure how many leaves did you use, I usually use a few for a sizable mug (~1L)08:33
kalikianao/08:40
pstolowskihow was your travel back home guys?08:47
mborzeckipstolowski: short :P08:47
mborzeckipstolowski: and we got a chance to do some sightseeing on Saturday morning (at least me, zyga-ubuntu and koza, the rest were leaving earlier)08:49
mvozyga-ubuntu: ok, I try a smaller one then :)08:52
pstolowskimborzecki: nice!08:54
morphismvo: zyga-ubuntu: any idea about https://forum.snapcraft.io/t/nvidia-gl-libs-access-broken-on-ubuntu-18-04/4440 ?08:56
zyga-ubuntumorphis: ah, interesting09:05
zyga-ubuntuI will respond on the forum09:05
zyga-ubuntumorphis: done09:08
morphiszyga-ubuntu: thanks!09:09
=== __chip__ is now known as Chipaca
Chipacamoin moin09:21
Chipacamborzecki: would you mind doing the fuzzing thing again on the puritan pr?09:22
Chipacamborzecki: I lopped a bunch of checks off09:22
Chipacawhich should be fine, given they were unreachable :-)09:22
mborzeckiChipaca: ok, will try in a couple of minutes09:23
Chipacamborzecki: thanks!09:23
mvoChipaca: hey, good morning! do you think 4805 can be merged? or because of it being api we need a gustavo review?09:30
Chipacamvo: I don't think rob addressed my concerns09:30
Chipacalet me check09:30
Chipacamvo: "the correct behaviour is if the field is omitted to assume that classic is supported." <- that's not what we do for eveyr other boolean09:32
mvoChipaca: please mark as "request change" then, just to ensure it does not get merged accidently09:32
pstolowskimvo: is https://github.com/pilebones/go-udev the udev implementation you found last week?09:34
mvopstolowski: yes09:35
mupPR snapd#4811 opened:  tests/main/media-sharing: improve the test to cover /media and /run/media <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4811>09:35
mborzeckinice & easy PR ^^09:35
pstolowskimborzecki: commented09:42
pstolowskihey Chipaca!09:44
Chipacapstolowski: hi!09:45
mborzeckipstolowski: cmd/snap-confine/spread-tests/main/media-visible-in-devmode this test?09:45
pstolowskimborzecki: yes09:45
mborzeckipstolowski: i don't think these are run at all09:46
pstolowskimborzecki: nb I misread the systems clause there, it's run everywhere but debian it seems; what makes you think it's not executed?09:46
mborzeckipstolowski: cmd/snap-confine/spread-tests is not referenced in the top level spread test file09:50
zyga-ubuntumborzecki: it's not used09:53
zyga-ubuntuman, we should drop most of those tetsts09:53
zyga-ubuntuthose are from when snap-confine was in a separate repository by itself09:53
Chipacamborzecki: it's left there by zyga to catch the unwary09:53
pstolowskimborzecki: allright09:53
pstolowski+109:54
mborzeckihaha,  are those kept for reference or shall we make them go away then? :)09:54
zyga-ubuntuone by one either enable and port or drop09:55
Chipacazyga-ubuntu: every seen this?09:58
Chipacaexecl failed: Permission denied09:58
Chipacachild exited with status 1: File exists09:58
Chipacazyga-ubuntu: https://api.travis-ci.org/v3/job/352240343/log.txt09:58
zyga-ubuntuChipaca: yes, on Friday09:59
zyga-ubuntuis this against master or release?09:59
Chipacazyga-ubuntu: master09:59
zyga-ubuntuhmmm09:59
Chipacazyga-ubuntu: not a new master though, it's probably a few commits behind09:59
zyga-ubuntuperfect, 14.04, no logs10:00
zyga-ubuntuso what we saw in the release branch on Friday is that apparently something mixes old profile and new profile on disk10:01
mvozyga-ubuntu: can you remind me again why 2.32 is broken and also why it seems not to be broken when I run an isolated 2.32 test in qemu?10:01
zyga-ubuntugreat question mvo, still investigating that10:01
zyga-ubuntuso I don't really know yet10:02
mvozyga-ubuntu: aha, great. can you reproduce it somehow?10:02
zyga-ubuntuyes10:02
mvozyga-ubuntu: how?10:02
zyga-ubuntuI mean, I just ran it in qemu10:02
zyga-ubuntuwas I just lucky?10:02
mvozyga-ubuntu: I don't know :) did you run just a single failing test or the full ting? I just did the former and do the later now10:02
zyga-ubuntuI ran tests/main10:03
zyga-ubuntumy goals today are to fix that, fix the bug that manifests itself as /etc and get back to the bigger bug of /etc being writable10:04
mvozyga-ubuntu: ok10:05
Chipacazyga-ubuntu: should I just restart this particular test?10:05
zyga-ubuntuhmm hmm10:06
zyga-ubuntuthere's nothing in the debug log there10:06
zyga-ubuntuyeah, restart it for now10:06
zyga-ubuntuI need to get this under control10:06
mborzeckiChipaca: got some panics10:18
Chipacamborzecki: woo10:18
Chipacamborzecki: show me :-)10:18
mborzeckiChipaca: i can let it run for a bit and then upload the corpus10:18
Chipacamborzecki: ok10:19
mvozyga-ubuntu: as a data point - tests seem to be ok if run in isolation so something is bleeding into it10:22
zyga-ubuntuyeah, I'm mid way and nothing failed now10:22
zyga-ubuntu:-(10:23
mborzeckiChipaca: https://paste.ubuntu.com/p/v45xJKWvSY/10:23
zyga-ubuntudo you have the seed with a failure by any chance?10:23
mvomborzecki: one of the errors in 4811 looks real10:26
Chipacamborzecki: can i see the fuzz function?10:26
Chipacamborzecki: (i suspect you're calling marshal directly :-) )10:26
mborzeckiChipaca: yes i do10:27
Chipaca*unmarshal10:27
mvozyga-ubuntu: maybe, let me try10:27
Chipacamborzecki: ah, yes that won't work, now -- it's called on things that json already knows is valid json10:27
zyga-ubuntumvo: I'm looping through this on my laptop10:27
zyga-ubuntuit did fail on Friday10:27
mvozyga-ubuntu: 1520606008 is what travis was using10:28
zyga-ubuntuthanks, I will try that with another backend10:28
zyga-ubuntunot sure if this is reliable10:29
mborzeckiChipaca: https://paste.ubuntu.com/p/ngFTQqvD4Y/ corpus https://send.firefox.com/download/d3fc9b236a/#CmR2CZR9_Ej7kx3qLjX_JQ10:29
Chipacamborzecki: ah! hm! oh!10:31
Chipacamborzecki: thanks10:32
mborzeckiChipaca: that's the tool(ing) https://github.com/dvyukov/go-fuzz10:32
Chipacamborzecki: so maybe I should put those checks back in; the bad data needs to be fed to UnmarshalJSON directly, but that's a public function so why wouldn't it10:34
* Chipaca feels dumber and wiser at the same time10:34
mborzeckihaha :) anyways, the fuzzer is a nice thing to play with10:36
Chipacamborzecki: on the next run I got two of them: https://api.travis-ci.org/v3/job/352240343/log.txt10:36
Chipacaum10:36
Chipacazyga-ubuntu: you ^10:37
Chipacazyga-ubuntu: one on 16.0410:37
zyga-ubuntuwow10:37
zyga-ubuntuthat's master + stuff right?10:37
mborzeckihm device cgroups stopped working or what?10:37
Chipacazyga-ubuntu: master up to 275d1cac4a774fe784f764c0788a689e60cc9d0a10:38
zyga-ubuntuman10:38
Chipacazyga-ubuntu: then it's jsonutil/puritan and using it from store; at the opposite end from cgroups :-)10:38
mvothis might be a race, I saw those failing sometimes (just saying)10:38
zyga-ubuntuit would be way better if spread would say which machine is running a given test10:38
zyga-ubuntuto show a trace of failure on a given machine10:39
mvo(I mean, we need to look into this but I wonder if its consistent)10:39
zyga-ubuntureproducing this takes tons of time :/10:39
mborzeckicatching --strace='--raw' would be useful10:39
zyga-ubuntuI mean10:40
zyga-ubuntuI know what happens10:40
zyga-ubuntunot sure why it happens10:40
zyga-ubuntuwhat happens is that snap-confine doesn't have permission to run snap-update-ns10:40
mborzeckizyga-ubuntu: shouldn't the denial be logged?10:41
zyga-ubuntuyes10:41
zyga-ubuntuit should10:41
zyga-ubuntuand it's not10:41
* Chipaca -> physio gym thing10:51
mborzeckimvo: i'll into tests/main/snap-service-refresh-mode as it's still failing randomly10:52
mborzeckilook into10:52
=== pstolowski is now known as pstolowski|lunch
* Chipaca -> really leaves10:57
mvomborzecki: \o/ thank you10:59
mvomborzecki: maybe its a real issue :(10:59
mvo(even though its hard for me to see from the code how this could be)11:00
mvozyga-ubuntu: slightly frustrating, I have no luck reproducing the 2.32 failure in qemu so far, I did two runs, one with random seed and one with seed from a failing PR against qemu:ubuntu-16.04-64 but no failures so far (and almost finished)11:02
zyga-ubuntucould it be, perhaps, caused, by any changes in core that landed since?11:03
* zyga-ubuntu looks at the logic in prepare code11:03
pedronis#4789 needs a 2nd review11:03
zyga-ubuntufor me it's not failing anymore either11:03
mupPR #4789: many: support holding refreshes by setting refresh.hold <Critical> <Created by pedronis> <https://github.com/snapcore/snapd/pull/4789>11:03
zyga-ubuntumvo: are you running all of it or just some11:08
zyga-ubuntumaybe the update test leaks something into the system?11:08
mvoall of main11:08
cachiomvo, hey11:09
mvocachio: hey11:09
mvocachio: hope you are well!11:09
=== BlackDex_ is now known as BlackDex
mvozyga-ubuntu: *cough* 2.32 is green again11:33
zyga-ubuntu:/ yeah same here11:33
zyga-ubuntuit's driving me nuts11:33
zyga-ubuntuso what changed since friday11:33
zyga-ubuntuis it just bad luck11:34
zyga-ubuntuwhat's the real problem we're not seeing11:34
mvozyga-ubuntu: also green in travis11:34
zyga-ubuntu1st world problems, tests are green but WHY :)11:34
mvozyga-ubuntu: indeed, very peculiar11:36
zyga-ubuntuok, I'll keep running and look at our prepare/restore code11:37
zyga-ubuntuand maybe, just maybe, something will come up11:37
zyga-ubuntuhow come there's no shellcheck snap yet11:40
zyga-ubuntumvo: I found a small bug in spread.yaml11:58
zyga-ubuntumvo: the tests/completion suite's restore  code doesn't remove snap-confine11:58
zyga-ubuntuit's not a big deal (maybe)11:58
zyga-ubuntuI've patched it locally now11:59
zyga-ubuntusnap-confine is supposed to be just transitional now11:59
mvozyga-ubuntu: ta11:59
mupPR snapd#4639 closed: store: enable deltas for core devices too <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4639>11:59
zyga-ubuntusame with the regression suite12:00
zyga-ubuntumvo: I just got a failure on the 2.32 branch12:00
zyga-ubuntu[Mon Mar 12 12:57:05 2018] audit: type=1400 audit(1520855826.802:795346): apparmor="DENIED" operation="exec" profile="/snap/core/4224/usr/lib/snapd/snap-confine" name="/usr/lib/snapd/snap-device-helper" pid=31151 comm="snap-confine" requested_mask="x" denied_mask="x" fsuid=0 ouid=012:01
zyga-ubuntuI have a debug shell12:01
mvozyga-ubuntu: what test is that?12:01
zyga-ubuntuhttps://www.irccloud.com/pastebin/47FjVl3F/12:02
zyga-ubuntusecurity-device-cgroups12:02
zyga-ubuntuwith the uinput sub-test12:02
zyga-ubuntuthe previous one was validate-container12:02
zyga-ubuntuthis is on a single-machine qemu12:02
mvozyga-ubuntu: thanks, looking12:03
zyga-ubuntuthe profile on disk is: http://paste.ubuntu.com/p/BNBk4526cC/12:03
zyga-ubuntuthis is /etc/apparmor.d/snap.core.4224.usr.lib.snapd.snap-confine12:03
zyga-ubuntuthere is no snap-device-helper here12:04
mvozyga-ubuntu: hm, yeah12:04
zyga-ubuntulooking at the core snap12:04
zyga-ubuntumaybe the core snap got repackaged12:04
zyga-ubuntuwith some broken stuff inside12:04
mvozyga-ubuntu: oh, I think this is the snapd that uses the symlink, so looks like one more thing to cherry pick12:05
zyga-ubuntuthis is the profile in the core snap there: http://paste.ubuntu.com/p/tcQ42chRQK/12:05
zyga-ubuntu    /usr/lib/snapd/snap-device-helper ixr, # drop12:05
zyga-ubuntuit _has_ permission to run this12:05
zyga-ubuntuso this is clearly broken12:06
* zyga-ubuntu diffs the two files12:06
mvozyga-ubuntu: meh, how can this happen? this looks like test prepare is broken12:06
zyga-ubuntuhttps://www.irccloud.com/pastebin/KmbgETkf/12:06
zyga-ubuntuhum12:07
zyga-ubuntuthis makes no sense12:07
zyga-ubuntu-    /usr/lib/snapd/snap-device-helper ixr, # drop12:07
zyga-ubuntu+    /lib/udev/snappy-app-dev ixr, # drop12:07
zyga-ubuntuhow did we go from - snap-device-helper (from the core snap) to + snappy-app-dev from the apparmor.d dir?12:08
* zyga-ubuntu looks at the preserved test tarball helper thing12:08
zyga-ubuntumvo: I bet you this will show the prepare/restore is wrong12:08
mvozyga-ubuntu: yeah, I need to get lunch now, biab12:08
mborzeckizyga-ubuntu: are you running just this test or the whole bunch?12:10
zyga-ubuntumvo: confirmed, the tarball has junk inside12:10
zyga-ubuntumborzecki: all of main each time12:10
zyga-ubuntulet me give you the seed12:11
zyga-ubuntuthis is on top of release/2.3212:11
zyga-ubuntuzyga@t470:~/snapd$ spread -debug -v qemu:ubuntu-16.04-64:tests/main/12:11
zyga-ubuntu2018-03-12 12:07:55 Found /home/zyga/snapd/spread.yaml.12:11
zyga-ubuntu2018-03-12 12:07:58 Project content is packed for delivery (3.88MB).12:11
zyga-ubuntu2018-03-12 12:07:58 Sequence of jobs produced with -seed=152085287812:11
zyga-ubuntumborzecki: can you please run that and see if you get the exact same bug?12:11
zyga-ubuntuI will look at why this happens12:11
zyga-ubuntuI have an idea now12:11
zyga-ubuntuand man12:11
zyga-ubuntumborzecki: I can send you my spread binary if that is a factor12:13
zyga-ubuntu2018-03-12 12:16:21 Preparing qemu:ubuntu-16.04-64:tests/main/interfaces-many...12:18
zyga-ubuntu# ls -ld $SPREAD_PATH/snapd-state.tar.gz12:18
zyga-ubuntu-rw-r--r-- 1 root root 366991360 Mar 12 12:16 /home/gopath/src/github.com/snapcore/snapd/snapd-state.tar.gz12:18
zyga-ubuntuso at around the time when we ran interfaces-many test, the state tarball was made12:18
zyga-ubuntuand it wasn't touched since12:18
zyga-ubuntuand it contains _wrong_ code12:18
zyga-ubuntuas in, it captures a state that is wrong12:19
zyga-ubuntuand much much later12:19
zyga-ubuntu2018-03-12 12:57:06 Error executing qemu:ubuntu-16.04-64:tests/main/security-device-cgroups:uinput :12:19
zyga-ubuntuthis test failed because of that12:19
zyga-ubuntuthat test doesn't fiddle with snapd12:20
zyga-ubuntunow12:20
zyga-ubuntuwe have code that detects this and writes a correct profile12:20
zyga-ubuntubut when I inspected the system it wasn't apparent it ran12:21
=== pstolowski|lunch is now known as pstolowski
zyga-ubuntuaha12:22
zyga-ubuntubut this code only runs when we install core12:22
zyga-ubuntuand if none of the preceeding tests tired to run snap-devce-helper / snappy-app-whatever it was12:22
zyga-ubuntuit would not trigger12:22
zyga-ubuntumvo: so we still have an issue that may need addressing12:23
zyga-ubuntuapart from 1) how did we get there we have the problem that on startup we 2) may run with stale profile for snap-confine because it is only remade when we install "core"12:23
zyga-ubuntuI also looked at the backend initialize function and I doubt it is loading the stale profile  because it would only do so on system-key like events (nfs or overlay)12:26
zyga-ubuntuthe system-key file also looks sensible12:26
zyga-ubuntuI added some debug and I will try to reproduce that with the same seed ( -seed=1520852878)12:27
zyga-ubuntumvo: one thing that _may_ be related is that /var/cache/apparmor is full of things12:29
zyga-ubuntuas is /etc/apparmor.d/cache12:31
zyga-ubuntuthe biggest question is if the seed will reproduce the issue12:31
cachioniemeyer, hey, when you have a time12:32
cachiohttps://github.com/snapcore/spread/pull/5212:32
mupPR spread#52: Add storage option for google <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/52>12:32
cachiothat shoul fix the issue that savic was reporting about out of space12:33
cachiotx12:33
mupPR snapd#4812 opened: tests/main/snap-service-refresh-mode: refactor the test to rely on comparing PIDs <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4812>12:46
zyga-ubuntuso, I wonder about an idea12:48
zyga-ubuntulet's say I get a failure again, and that -seed works12:48
zyga-ubuntuhow can we make spread bisect the test suite to find what breaks12:48
zyga-ubuntuthat is, run the failing test after running half of the preceding tests, etc12:49
cachiomvo, niemeyer I am waiting for a doctor at home, perhaps I'll be starting later the standup12:54
zyga-ubuntuexcellent, I can reproduce the issue reliably now mvo13:19
mborzeckizyga-ubuntu: my test run is still in progress, should i abort?13:25
zyga-ubuntuno sure, why?13:25
mborzeckizyga-ubuntu: thought that maybe reuse the seed, and only use those 2 tests that you mentioned13:26
zyga-ubuntuaga13:26
zyga-ubuntuaha13:26
zyga-ubuntuwell, which test are you on now?13:26
* kalikiana will go try and have lunch without being too soaked in the rain13:26
mborzecki(143/234)13:26
zyga-ubuntuno, please wait then13:26
zyga-ubuntuit's on 155 AFAIR13:26
zyga-ubuntuso "soon"13:26
mborzeckitaking ages :/13:26
zyga-ubuntumborzecki: when did you start it?13:28
mborzecki12:40, but then it got stuck in a debug shell in a test i was working on, and took a while before i noticed13:29
zyga-ubuntuah13:29
zyga-ubuntufor me it's ~30 minutes13:29
zyga-ubuntu+/- 15 minutes13:30
mvozyga-ubuntu: part of the problem is that edge is not really edge13:30
mvozyga-ubuntu: I just pushed a pr13:30
zyga-ubuntuoh?13:30
zyga-ubuntumvo: can you explain please13:30
zyga-ubuntuI see13:30
mupPR snapd#4813 opened: release: snapd 2.31.2 <Created by mvo5> <https://github.com/snapcore/snapd/pull/4813>13:30
mvozyga-ubuntu: snap info core :/ its on 2.31.2 in edge right now13:30
zyga-ubuntumvo: but how would it be a factor13:30
zyga-ubuntumvo: since we change the version to leet13:31
mvozyga-ubuntu: 2.31 is still using snappy-app-dev13:31
zyga-ubuntuI mean, is it a factor?13:31
mvozyga-ubuntu: so that explains why the profiles are strange13:31
zyga-ubuntuyes but whatever is in whatever channel we start with13:31
zyga-ubuntuwe are repackaging core, no?13:31
mvoyes13:32
Son_Gokumvo, can we get this merged so I can rebase? https://github.com/snapcore/snapd/pull/481113:32
mupPR #4811:  tests/main/media-sharing: improve the test to cover /media and /run/media <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4811>13:32
mborzeckiSon_Goku: merged13:33
mupPR snapd#4811 closed:  tests/main/media-sharing: improve the test to cover /media and /run/media <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/4811>13:33
mupPR snapcraft#1985 closed: tests: document arm testing setup <Created by elopio> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1985>13:39
zyga-ubuntumborzecki: did it fail?13:42
mborzeckizyga-ubuntu: nope, (214/234)13:42
zyga-ubuntuso it's past that test13:42
zyga-ubuntuwere you on release/2.3213:42
mborzeckizyga-ubuntu: i used the same seed as you13:42
mborzeckiyes13:42
zyga-ubuntuand on qemu of xenial?13:42
zyga-ubuntuthat's not great then :/13:42
zyga-ubuntuthank you, I wonder what this says then13:43
mborzeckiyes, tip of release/2.32 branch13:43
pstolowskiniemeyer: so, the interface is named "dummy" atm, with a description saying "snapd dummy test interface"13:51
niemeyerpstolowski: What's the PR?13:52
niemeyerpstolowski: After the conversation we just had, that's not too bad actually.. perhaps "snapd-dummy".. I'd just like to have a look at the code first13:54
pstolowskiniemeyer: #435813:54
mupPR #4358: interfaces: interface hooks implementation <Created by stolowski> <https://github.com/snapcore/snapd/pull/4358>13:54
pstolowskiniemeyer: look for dummy.go13:54
niemeyerThanks13:54
zyga-ubuntuniemeyer: no-op interface?13:55
mborzeckiChipaca: #4800 is the same as #4799 and the title suggests it ought to be a different thing13:59
mupPR #4800: cmd/snap: in changes and tasks, default to human-friendly times <Created by chipaca> <https://github.com/snapcore/snapd/pull/4800>13:59
mupPR #4799: cmd/snap: use timeutil.Human to show times in `snap refresh --time` <Created by chipaca> <https://github.com/snapcore/snapd/pull/4799>13:59
* Chipaca looks14:00
Chipacawtf14:00
mborzeckiChipaca: bad rebase?14:01
Chipacamborzecki: thanks, i'll take a look14:01
Chipacamborzecki: shouldn't be, but maybe? 'tis a mystery14:01
Chipaca:-)14:02
Chipacamborzecki: probably fat fingers of some sort14:02
mborzeckiChipaca: hopefully nothing that cannot be fixed with the reflog :P14:03
mborzeckizyga-ubuntu: sorry to disappoint you, found this in my shell history 'git checkout -b release/2.32', i'm restarting the tests14:04
zyga-ubuntu:D14:04
mborzeckiif i use the same -seed=.. and list jus 2 tests, will they be run in the same order as if i used tests/main/ ?14:06
zyga-ubuntumborzecki: I don't think so14:06
zyga-ubuntunot sure14:06
zyga-ubuntuniemeyer: ^14:06
niemeyerpstolowski: This is not a dummy interface, because it actually has expectations in its logic14:07
niemeyerpstolowski: People in general will expect "dummy" or "nil" or "no-op" or anything similar to actually not do anything14:07
niemeyerSo we need a name to represent that14:07
zyga-ubuntusunshine14:17
pstolowskiniemeyer: it's dummy in a sense that it doesn't provide any functionality; it's only useful to test against14:24
* Chipaca brb14:28
niemeyerpstolowski: Yeah, maybe that's fine, and then we can expose this as a general dummy interface that any snap can use.. I'm adding some comments to the PR14:30
mvozyga-ubuntu: *maybe* I found the issue with the 2.32 tests, its tests only, I'm running a test now14:30
zyga-ubuntumvo: I'm all ears14:34
zyga-ubuntuI'm iterating on narrowing down the set of tests that causes it14:34
pstolowskiniemeyer: thanks14:35
kalikianare14:37
niemeyerpstolowski: Please have a look14:41
mupPR snapd#4814 opened: tests: fix re-exec profile generation in tests on classic <Created by mvo5> <https://github.com/snapcore/snapd/pull/4814>14:41
mvozyga-ubuntu: just pushed a PR that hopefully explains it (for 2.32) and will also push one for master14:41
zyga-ubuntuack14:41
mvozyga-ubuntu: its essentially a race14:42
zyga-ubuntuwhat's racing?14:42
mvozyga-ubuntu: between us modifying the core and the auto-generated snap-profiles for the core. because we have the system key now we need to make sure to re-generate them14:42
mvozyga-ubuntu: so your idea about ensure-dir-state was correct, its just that the system-key now prevents security profile generation if nothing has changed14:43
mvozyga-ubuntu: (nothing in the inputs)14:43
pstolowskiniemeyer: looking, thanks14:43
zyga-ubuntuI see14:45
zyga-ubuntumvo: any ideas why this would explain why I can reproduce the problem with a given seed?14:45
mupPR snapd#4815 opened: tests: fix re-exec profile generation in tests on classic <Created by mvo5> <https://github.com/snapcore/snapd/pull/4815>14:45
cachiojdstrand, hey, I see this denial executing the security-device-cgroups:uinput14:46
cachiohttps://paste.ubuntu.com/p/gDqTw7JPrp/14:46
zyga-ubuntucachio: jamie is off this week14:46
zyga-ubuntucachio: and this is the issue we are discussing with mvo now14:47
cachiozyga-ubuntu, ah, ok, good to know, thanks14:47
mvozyga-ubuntu: maybe, its a mystery why it is not reproducible with the seed. however the race is that for some tests the profile is close enough, so if for whatever reason we force re-generation of security profiles in any test and that happens before the failing test things are good14:48
zyga-ubuntumvo: I managed to reproduce it by running one test now14:49
zyga-ubuntumvo: maybe it depends on my CPU speed or something like that?14:49
zyga-ubuntuI'll try your patch on my system, thank you for pushing the fix and finding the problem14:51
mupPR snapd#4816 opened: Tests move xenial i386 to google <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/4816>14:53
mvozyga-ubuntu: thank you!15:04
zyga-ubuntuI will try -resend next15:20
zyga-ubuntunow that I can essentially iterate on one test15:20
mupPR snapd#4812 closed: tests/main/snap-service-refresh-mode: refactor the test to rely on comparing PIDs <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/4812>15:23
mvoChipaca: how do you feel about 4486? it will run `snap advise` when `snap run not-installed-command` is used. but given our command-not-found work I think we can kill this. wdyt?15:24
mupPR snapd#4799 closed: cmd/snap: use timeutil.Human to show times in `snap refresh --time` <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4799>15:28
mvoChipaca: and one more silly question, why does https://github.com/snapcore/snapd/pull/4800/files#diff-dbcb08a7fd2e809c90019780f0ae6cf6R562 change the format in the tests?15:29
mupPR #4800: cmd/snap: in changes and tasks, default to human-friendly times <Created by chipaca> <https://github.com/snapcore/snapd/pull/4800>15:29
mupPR snapd#4817 opened: overlord:  implement policy of holding refreshes for up to 6h since seeding on classic <Created by pedronis> <https://github.com/snapcore/snapd/pull/4817>15:29
mupPR snapd#4486 closed: snap: make `snap run not-install` output advise for not installed commands <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/4486>15:32
Chipacamvo: kill it :-)15:33
Chipacamvo: i mean, #448615:33
mupPR #4486: snap: make `snap run not-install` output advise for not installed commands <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/4486>15:33
Chipacamvo: i messed up a rebase and need to fix it15:34
pedronisChipaca: seems you landed something that conflicts with 478915:34
pedronisbit of a mess given that we probably want to cherry pick the latter15:34
Chipaca#478915:34
mupPR #4789: many: support holding refreshes by setting refresh.hold <Critical> <Created by pedronis> <https://github.com/snapcore/snapd/pull/4789>15:34
pedronisfor 2.3215:34
Chipacain my defense, it was mvo that landed it :-)15:34
Chipacamvo: the rebase I messed up was the 'changes' one, fwiw15:35
pedronismvo: ^^^15:35
* zyga-ubuntu feels he's getting sick :/15:35
zyga-ubuntuthis sucks15:35
Chipacadigging in the reflog as i type15:35
Chipacawell, not as i type15:35
mvoChipaca: uuhhh, what pr was that?15:35
pedronismvo: it's a bit of a mess if we land cosmetics over things we want for 2.3215:35
Chipacamvo: #480015:35
mupPR #4800: cmd/snap: in changes and tasks, default to human-friendly times <Created by chipaca> <https://github.com/snapcore/snapd/pull/4800>15:35
mvopedronis: yes, sorry for that15:36
pedronisI'm quite sure we already we will have fun with the changes to store tests15:36
Chipacamvo: I'd recommend removing #4799 from master15:36
mupPR #4799: cmd/snap: use timeutil.Human to show times in `snap refresh --time` <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4799>15:36
Chipacamvo: make your life easier15:36
Chipaca(and by removing i mean 'git revert --hard && git push --force' :-)15:36
mvoChipaca: not sure we can do that, but an old fashioned revert seems to be ok15:37
Chipacamvo: we can (we just need to untick the --force protection around it)15:37
Chipaca(bah, that might involve niemeyer)15:37
mvozyga-ubuntu: it looks like spread is disagreeing with my fix :(15:38
pedronisanyway a 2nd review for #4789 so it can land would also help15:39
mupPR #4789: many: support holding refreshes by setting refresh.hold <Critical> <Created by pedronis> <https://github.com/snapcore/snapd/pull/4789>15:39
zyga-ubuntumvo: my results will come up soon,15:39
zyga-ubuntumvo: I'm still looking15:39
mvozyga-ubuntu: its very annoying, it all made sense. I hope to get a debug shell soon15:40
zyga-ubuntuThank you15:40
mvozyga-ubuntu: maybe its something silly and I can cling on to my theory15:40
zyga-ubuntuI hope the tea will help you on the way :)15:40
zyga-ubuntuadded more debug, with your patch and restarted15:43
mupPR snapd#4818 opened: Revert "cmd/snap: use timeutil.Human to show times in `snap refresh -…-time`" <Created by mvo5> <https://github.com/snapcore/snapd/pull/4818>15:51
Chipacamvo: about changing the format in the tests, which one do you mean? I presume it's something in https://github.com/snapcore/snapd/pull/4799/files15:52
mupPR #4799: cmd/snap: use timeutil.Human to show times in `snap refresh --time` <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4799>15:52
Chipacamvo: (i changed a few formats for different reasons...)15:53
mvoChipaca: let me just ask in the PR that is easier15:53
Chipacamvo: ok :-)15:53
Chipacamvo: but I _think_ the one you're asking about is because before it just blatted whatever came in the json, and the json in the test was not kosher15:53
pedronismvo: did you just review #4789 ?15:54
mupPR #4789: many: support holding refreshes by setting refresh.hold <Critical> <Created by pedronis> <https://github.com/snapcore/snapd/pull/4789>15:54
Chipacapedronis: yes he did15:54
pedronisthx15:54
mvoChipaca: aha, ok. that was my question - i.e. if the json was incorrect or something changed15:55
mvopedronis: yes, sorry that it took so long15:55
Chipacamvo: the json was fanciful15:55
Chipaca:-)15:55
pedronismvo: np,   was confused by the fix reference,  is that about the last change there?15:55
MuraveyHi15:55
ChipacaMuravey: hi15:56
zyga-ubuntuhey hey15:56
mvopedronis: the fix reference to zyga-ubuntu ? that was about the test failures on master and 2.32. I thought I had found the issue (race with the core profile rewrite)15:56
mvopedronis: but then spread failed in a similar way so there must be more to it15:57
MuraveyCan anyone help me? I tring to make snap package for cataclysm dda game15:57
pedronismvo: no, the fix in your +1 comment to 478915:57
* zyga-ubuntu is still looking15:57
mvopedronis: oh, I mean, thanks for fixing this issue, i.e. thanks for this new feature :)15:58
ChipacaMuravey: sure (but if it gets long we might ask you to take it to the forum instead)15:58
MuraveyAfter install package i cant run game and it's crashed with file not found15:59
pedronismvo: ah16:00
pedronis:)16:00
zyga-ubuntuMuravey: run snap run --shell yoursnapname16:00
zyga-ubuntuand explore the environment16:00
zyga-ubuntuthat may explain some things to you16:00
zyga-ubuntumvo: it didn't fail with your patch now ://16:02
Muraveyzyga-ubuntu: sorry for my english16:02
zyga-ubuntuI'll try again with all of main16:03
zyga-ubuntuand the same seed as before16:03
Muraveyzyga-ubuntu: what environments i need see? PATH?16:03
zyga-ubuntuMuravey: no, I mean more than that, the whole filesystem16:03
ChipacaMuravey: tell us more about your snap16:03
zyga-ubuntuyour snap is mounted at /snap/yoursnapname/somenumber/16:03
zyga-ubuntuand if you open a file, say from /usr/share/yourapp/foo16:03
zyga-ubuntuthat won't work16:04
ChipacaMuravey: for example, show us your snapcraft.yaml, and your snap.yaml (use pastebin.ubuntu.com)16:04
zyga-ubuntuit's a typical problem in snapping software16:04
Muraveyzyga-ubuntu: will you here in an hour? I'm driving.16:07
zyga-ubuntuMuravey: probably not16:08
zyga-ubuntuI need to leave soon16:08
mvozyga-ubuntu: yeah, my patch seems to be not sufficient16:08
zyga-ubuntuI'll look at what exactly happens on restore in this test16:08
cachiomvo, hey16:15
cachioI ran some tests for 2.32.2 today in my dragonboard and I see an error16:15
mupPR snapd#4819 opened: interfaces/serial: change pattern not to exclude valid devices <Created by bergotorino> <https://github.com/snapcore/snapd/pull/4819>16:15
cachiohttps://paste.ubuntu.com/p/zwRWvmx4GZ/16:15
cachiomvo, it is strange because I did not see that error when I executed the tests in testflinger devices for beta validation16:16
Chipacamborzecki: mvo: fwiw #4800 is now what it should've been (probably)16:16
mupPR #4800: cmd/snap: in changes and tasks, default to human-friendly times <Created by chipaca> <https://github.com/snapcore/snapd/pull/4800>16:16
cachioany idea what be causing that?16:16
Chipacacachio: you don't have policykit installed16:17
Chipacacachio: try again with sudo16:17
mvocachio: what Chipaca said, the error is quite confusing though, it should indicate that it is systemd not the unit that has the problem16:17
Chipacacachio: is tht 14.04?16:18
cachiocore-16-arm-6416:18
niemeyermvo, Chipaca: Anything I can help with or is it sorted?16:19
Chipacacachio: do we ship policykit in core?16:20
cachioChipaca, with sudo is working16:20
cachiothe test suite is failing to save the state16:21
cachiothe snapd service is not running16:21
Chipacacachio: AFAICT we don't ship policykit in core, but I don't know how to improve that error message16:21
cachiobut I can't see why16:21
Chipacacachio: what happens if you run: SNAPD_DEBUG=1 /usr/lib/snapd/snapd16:22
mvoChipaca: that is coming from systemctl/systemd, right?16:22
Chipacacachio: (as root)16:22
Chipacamvo: yes16:22
mupPR snapcraft#1866 closed: lxd: setup LXD remote for multipass <Created by kalikiana> <Closed by kalikiana> <https://github.com/snapcore/snapcraft/pull/1866>16:22
cachioChipaca, mvo https://paste.ubuntu.com/p/yM5Tz2qFMw/16:23
cachioI found that16:23
cachioit is causing snapd doesn't start16:23
Chipacacachio: where is that coming from?16:24
Chipacacachio: and what snapd are you running?16:24
Chipacathat change _just_ landed on master16:24
cachio+ systemctl stop snapd.refresh.timer16:24
cachioFailed to stop snapd.refresh.timer: Unit snapd.refresh.timer not loaded.16:24
cachiosorry, this was the real proble16:24
cachiom16:24
Chipacathe abs-time change is on master only16:25
mvocachio: oh? I thought we fixed that everywhere, what branch are you on?16:25
Chipacathe snapd.refresh.timer, i thought that was fixed16:25
cachio2.32.216:25
Chipacayeah something is awry16:25
Chipacacachio: where did the abs-time message come from?16:25
cachioChipaca, sorry, that was from another tests executed on master16:26
cachiothis is what I see in 2.32.216:26
cachioFailed to stop snapd.refresh.timer: Unit snapd.refresh.timer not loaded.16:26
cachioon my device16:26
Chipacacachio: and that is stopping snapd from starting?16:27
cachioChipaca, no, it is making fail the step to create the initial state16:27
cachioChipaca, then the suite fails because the initial state was not created16:29
mvocachio: could you please pastebin "git status" and "git rev-parse HEAD"?16:31
mvocachio: I really though we fixed this timer issue :/16:32
cachiomvo, you are right16:33
cachiowas my fault16:33
mvocachio: no worries16:34
cachiomvo, I used 2.32.2 instead of 2.31.216:34
cachiothat's why all the tests passed on testflinger16:34
mvocachio: yeah, that is confusing16:34
cachioand failed on my device16:34
cachioChipaca, mvo sorry16:34
cachiomvo, that happens when I don't sleep well :(16:36
Chipacamvo: speaking of sleeping well, when're you swapping16:36
Chipaca?16:36
mvocachio: with release/2.32:bb05e2fe9539b8728b9d219858125e5f98aed2d5 things should be good in there. 2.31 should be ok as well16:37
mvoChipaca: friday16:37
Chipacamvo: ok16:37
cachioChipaca, my dauther is seek so I could not sleep last night16:40
mvocachio: I hope she gets well soon16:40
cachioChipaca, I planned to rest :(16:40
cachiomvo, yes, she is better today16:40
mvocachio: double hard with jetlag I suppose :(16:40
cachiomvo, yes, I think I'm not buying chacolates anymore during the sprints16:41
pedronisChipaca: mvo: I'll very likely swap Wed16:41
mupPR snapd#4818 closed: Revert "cmd/snap: use timeutil.Human to show times in `snap refresh -…-time`" <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4818>16:45
* Chipaca hugs cachio 16:47
Chipacacachio: take care dude16:47
cachioChipaca, :) tx16:49
cachiomvo, last thing today for you16:49
Chipacamvo: pedronis: any reason not to merge #4789?16:49
mupPR #4789: many: support holding refreshes by setting refresh.hold <Critical> <Created by pedronis> <https://github.com/snapcore/snapd/pull/4789>16:49
cachiomvo, we need the user assertion16:50
cachioto run again in nightly the core revert test16:50
Muraveyzyga-ubuntu: i thought that app in snap package after installing get it's own mount name space.16:52
pedronisChipaca: no, was waiting for ther revert16:59
Chipacapedronis: already there16:59
mupPR snapd#4789 closed: many: support holding refreshes by setting refresh.hold <Critical> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/4789>17:00
pedronissaw that now, merged17:00
Chipacawho was it I chatted with about shipping an empty squashfs? zyga-ubuntu and mvo? or was niemeyer also involved17:05
niemeyerChipaca: Not me17:05
ChipacaFYI, https://people.canonical.com/~john/bare.squashfs <- 4k, including a README17:05
Chipacaniemeyer: ok17:05
Chipacaniemeyer: FWIW it's about not having a good way of detecting / pulling in squashfs support in some situations17:06
Chipacaeasiest way being to just try to mount something17:06
niemeyerChipaca: Not sure I understand what's the advantage vs. trying to actually mount the thing you indeed want to mount17:07
Chipacaniemeyer: 'snap install foo -> download core -> cryptic message because mount failed' vs 'snap install foo' -> 'no squashfs support lolz'17:08
Chipacamaking it easy and cheap to detect before downloading stuff17:09
Chipaca(especially as the error is currently cryptic, but even fixing that knowing in advance the install isn't going to work has value)17:09
niemeyerChipaca: Yes, I understand that part. The question is why is it easier to have a good message when mounting something empty fails, vs. when mounting the real thing you in fact want to mount. In both cases we're mounting a filesystem, and can introspect the result.17:10
niemeyerChipaca: Also, when do we do that?  Every time we're trying to install anything?  Everytime we start?  What if the kernel changes and squashfs stops being supported?17:11
niemeyerChipaca: My gut feeling is to introspect the system and have good feedback on the real operation, instead of the fake one preceding it17:11
Chipacaniemeyer: that would still come after the download (and is a rather large amount of work)17:12
Chipacai mean, it's not just looking errno codes up in the manpage17:12
Chipacait's looking at 'systemd show', probably17:13
Chipaca('systemctl show' i meant -- 'systemctl status's machine-friendly cousin)17:13
Chipaca- Mount snap "core" (4110) ([start var-lib-snapd-snap-core-4110.mount] failed with exit status 1: Job for var-lib-snapd-snap-core-4110.mount failed.17:15
ChipacaSee "systemctl status var-lib-snapd-snap-core-4110.mount" and "journalctl -xe" for details.17:15
Chipaca)17:15
Chipaca^ that's what's there now17:15
niemeyerChipaca: [niemeyer@nomad ~]% sudo mount -t squashfs /tmp /tmp17:16
niemeyermount:  /tmp is not a block device17:16
niemeyer[niemeyer@nomad ~]% sudo mount -t blah /tmp /tmp17:16
niemeyermount: unknown filesystem type 'blah17:16
Chipacaniemeyer: we don't call mount ourselves17:17
Chipacaniemeyer: if we were doing so, getting the error reason would be easier17:17
niemeyerChipaca: The point is that it seems rather simple to tell whether the system supports it or not17:17
Chipacaniemeyer: 'exit status 1' is a lot less information than checking errno == ENODEV17:18
Chipacaniemeyer: I'm assuming there is more information somewhere in the guts of systemctl, such that 'systemctl show' with the appropriate --property would let us figure out that it's ENODEV17:20
Chipacaniemeyer: if not, then ¯\_(ツ)_/¯17:20
niemeyerChipaca: Sorry.. I don't really understand what the goal is anymore..17:20
Chipacaniemeyer: did you see the error we're currently giving users when their system doesn't support squashfs17:21
niemeyerChipaca: Are you saying that shipping a dummy squashfs and performing real system calls ot mount it and checking the result is simpler than calling a function and checking its result?17:21
Chipacaniemeyer: which function?17:21
niemeyermount("/tmp", "/tmp", "squashfs", MS_MGC_VAL, NULL) = -1 ENOTBLK (Block device required)17:22
Chipacawhere would we do that?17:22
niemeyerChipaca: Wherever you want?17:22
niemeyerChipaca: release.SupportsSquashfs?17:22
Chipacaniemeyer: on the snap itself, once downloaded? to be umounted immediately after?17:23
niemeyerChipaca: Which snap? Download what? I'm lost...17:23
niemeyerChipaca: Isn't the goal to check if squashfs is supported?17:24
Chipacaniemeyer: what are you mounting?17:24
niemeyerChipaca: Nothing... /tmp17:24
niemeyerChipaca: /not-something-relevant-or-dangerous17:24
Chipacaniemeyer: but it's not going to be a squashfs17:24
niemeyerChipaca: It does not matter what it is.. this is checking whether squashfs is supported17:25
niemeyerChipaca: The result when it is supported is different from when it is not supported17:25
niemeyerIf that's the goal, that's a handful of lines in a function17:26
zyga-ubunture (briefly)17:27
niemeyerChipaca: Or so I assume.. I haven't tested this on a system that does not in fact support squashfs.. I assume the metadata that describes how to mount the filesystem lives in its module.17:28
Chipacaniemeyer: so, there's a more minor issue, and that's that this won't tell you if it supports xz17:29
Chipacaniemeyer: but you're right that this would work if that's good enough17:29
Chipaca(we've had people not enabling xz, but it's probably an order of magnitude less than people without squashfs)17:29
niemeyerChipaca: For that I'd indeed resort to checking the result of the operation instead of preempting what the operation supposedly looks like ahead of itme17:30
Chipacaniemeyer: I'm not sure what you mean, there17:30
niemeyerChipaca: If we change the compression format (or more likely, support many), we don't want to have an empty squash per compression format17:30
niemeyerChipaca: Or per whatever feature17:30
pedroniswhat about /proc/filesystems17:30
Chipacapedronis: not there if the module exists but isn't loaded17:30
niemeyerpedronis: !!!17:31
pedronisChipaca: well if nobody loads it we fail anyway, no?17:31
pedronismount() would have the same problem I suppose17:31
Chipacapedronis: mount knows to load modules, if you specify the type17:31
niemeyerAh17:32
pedronismount the syscall?17:32
Chipacayes17:32
ChipacaI think it's via an alias (metadata in the .ko) to "fs-<the argument to -t>", but i'm not 100% on that17:33
Chipacaa bit like how pci modules have aliases to some gibberish 'pci:v00001180d00000822sv*sd*bc*sc*i*' so they get picked up automatically17:34
pedronisChipaca: I think basically it seems we can use mount to detect if squashfs is there, but if the compression is not right17:34
pedroniswe still need to dig into the systemd job errors17:34
niemeyerChipaca, pedronis: Still sounds nice to go through the actual method:17:34
ChipacaI need to see if that still works with the module-exists-but-not-loaded17:34
niemeyer1. Does it exist in /proc/filesystems => do nothing, works17:34
Chipacabut sounds good17:35
niemeyer2. insmod squashfs => works? okay17:35
niemeyer3. unsupported17:35
Chipacaeh.. i wouldn't have snapd doing insmod, no (but i'm fine with triggering it via mount)17:35
niemeyermodprobe actually, not insmod, sorry17:36
niemeyerChipaca: Yeah, that's likely cleaner17:37
mupPR snapcraft#2000 opened: elf: remove dead code <bug> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2000>17:37
muravey_omskzyga-ubuntu: My snapcraft.yaml https://pastebin.com/sKkUBwDd17:37
muravey_omskwhat about add "organize" key to snapcraft.yaml with replace /usr/share/game to $SNAP/usr/share ?17:38
zyga-ubunture, sorry, my system crashed on kernel bug17:38
zyga-ubuntumuravey_omsk: can that game be modified to load things from a config file, variable of some kind?17:39
=== pstolowski is now known as pstolowski|afk
zyga-ubuntumuravey_omsk: if not we will have a new feature in snapd 2.32 that you can use to put those files in /usr/share/game17:41
muravey_omskzyga-ubuntu: i don't know. It's need to read man or Compiling.md17:41
zyga-ubuntumuravey_omsk: you can read about it here: https://forum.snapcraft.io/t/layouts-re-mapping-snap-directories/147117:41
zyga-ubuntumuravey_omsk: today edge is "busy" with release process but you can use it in edge soon17:42
zyga-ubuntumvo: I will be home soon, my system crashed and took all the debug state along with it17:43
zyga-ubuntumvo: darn kernel :-(17:43
zyga-ubuntuChipaca: remember about the container use case17:49
zyga-ubuntuChipaca: where squashfs is present but we cannot use it17:49
zyga-ubuntuChipaca: and we must use the internal fuse helper17:49
Chipacazyga-ubuntu: I've forgotten already17:49
cachiozyga-ubuntu, selinux is showing denials for the fakestore in the google instace of fedora 2717:49
zyga-ubuntucachio: are those breaking or just warning?17:49
cachiozyga-ubuntu, should add a rule to allow it in data/selinux?17:49
cachiozyga-ubuntu, giving permission denied17:50
zyga-ubuntucachio: I don't know really, someone needs to sit down and see what the warnings are about17:50
cachiotype=AVC msg=audit(1520876348.249:536): avc:  denied  { execute } for  pid=31385 comm="(akestore)" name="fakestore" dev="sda1" ino=23835 scontext=system_u:system_r:init_t:s0 tcontext=unconfined_u:object_r:user_tmp_t:s0 tclass=file permissive=017:50
zyga-ubuntucachio: yes but we have some special things that make all the denials into warnings17:50
zyga-ubuntuI don't really know the details17:50
zyga-ubuntucachio: is this a new thing?17:50
cachiozyga-ubuntu, yes17:50
cachioit is the new image we have in google backend17:51
* kalikiana heading out o/17:51
Chipacazyga-ubuntu: what container does this? so i can play with it17:51
cachiothe config is the same that the one in linode17:51
zyga-ubuntudo we know how is this different from the old image?17:51
zyga-ubuntuChipaca: just LXD is fine17:51
Chipacazyga-ubuntu: ah, not fedora-cloud-in-lxc-trusty? :-)17:51
zyga-ubuntucachio: something about it is wrong but not sure what17:51
zyga-ubuntuwell17:51
zyga-ubuntunot wrong, just different17:51
zyga-ubuntuChipaca: no I mean just xenial+xenial is fine to show this17:52
zyga-ubuntuthe fedora cloud issue was different17:52
cachiothe image in linode is created upgrading an old one17:52
zyga-ubuntuwe just had no module for the kernel we booted on17:52
ChipacaIll need to write this down17:52
Chipaca… tomorrow17:52
zyga-ubuntuChipaca: :-)17:52
cachiozyga-ubuntu, the one in google was downloded17:52
* zyga-ubuntu resumes debugging17:52
* Chipaca is wrapping up for the day17:52
cachioso I think could be many differences17:52
zyga-ubuntucachio: sure I'm saying I don't know what's the real problem and this needs some investigation17:53
zyga-ubuntuperhaps in the old image the fake store ran unconfined17:53
zyga-ubuntuno idea17:53
cachiozyga-ubuntu, ok, I'll take a look in that case, it is only only one issue remaining for fedora17:53
zyga-ubuntucachio: ack, I'm sorry I'm not of much help17:54
cachiozyga-ubuntu, np17:54
zyga-ubuntucachio: perhaps Pharaoh_Atem can help you faster, he wrote all of the selinux support code17:54
Pharaoh_Atemwut?17:55
zyga-ubuntuPharaoh_Atem: selinux denial from fakestore (go implementation of trivial store for tests)17:55
Pharaoh_Atemwhat's the denial?17:56
zyga-ubuntuPharaoh_Atem: they stated showing up when we switched away from linode to google cloud17:56
zyga-ubuntu type=AVC msg=audit(1520876348.249:536): avc:  denied  { execute } for  pid=31385 comm="(akestore)" name="fakestore" dev="sda1" ino=23835 scontext=system_u:system_r:init_t:s0 tcontext=unconfined_u:object_r:user_tmp_t:s0 tclass=file permissive=017:56
zyga-ubuntucachio knows the details17:56
mupPR snapcraft#1998 closed: pluginhandler: add {pre,post}-build scriptlets <Created by kyrofa> <Closed by kyrofa> <https://github.com/snapcore/snapcraft/pull/1998>17:58
cachioPharaoh_Atem, hey17:59
cachioPharaoh_Atem, https://paste.ubuntu.com/p/Gby6tcmsQn/18:01
cachioPharaoh_Atem, sorry, it is the denial https://paste.ubuntu.com/p/dvBtrhvbKj/18:01
cachioit happens running in a google mashine18:02
cachiowhich I recently created downloading from here https://alt.fedoraproject.org/cloud/18:02
zyga-ubuntuI suspect it's a config difference18:03
zyga-ubuntubut we should check if the kernel is the same as before as well (apart from things like micro release updates)18:03
cachiozyga-ubuntu, both configs are identical18:03
zyga-ubuntukernel configs?18:03
cachioSELINUX=enforcing SELINUXTYPE=targeted18:03
zyga-ubuntudid you compare all of the kernel config of the two running kernels?18:04
cachiozyga-ubuntu, sorryselinux configs18:04
zyga-ubuntuah18:04
zyga-ubuntuwell18:04
zyga-ubuntumaybe some other changes then18:04
cachioI could do that18:04
zyga-ubuntuyeah18:04
zyga-ubuntuessentially try to guess what is different now18:04
zyga-ubuntumaybe the build config is different18:05
zyga-ubuntumaybe some selinux policy is custom18:05
zyga-ubuntuit's a cloud image after all18:05
zyga-ubuntubut really no idea18:05
cachiozyga-ubuntu, selinux configuration in kernel config is the same18:09
cachio:(18:09
cachiozyga-ubuntu, I know18:11
cachiowhich is the diff18:11
cachiolinode:fedora-27-64 .../tests/main/interfaces-snapd-control-with-manage# sestatus -v18:11
cachioSELinux status:                 disabled18:11
cachiogoogle:fedora-27-64 .../tests/main/interfaces-snapd-control-with-manage# sestatus -v18:11
cachioSELinux status:                 enabled18:11
cachio:s18:11
cachiozyga-ubuntu, is it on porpouse?18:12
zyga-ubuntumvo: this issue is driving me crazy18:15
Pharaoh_Atemcachio: it's because of this: https://pagure.io/Fedora-Council/tickets/issue/9918:16
Pharaoh_Atemour images are based on the version of the image with no SELinux support18:17
cachioPharaoh_Atem, ok18:20
cachioPharaoh_Atem, so is it possible to add a rule to make the fakestore run unconfined?18:21
Pharaoh_Atemso this means that for the first time ever, we're going to see failures consistent with users18:21
Pharaoh_Atemis fakestore a snap or something else?18:21
cachioit is a systremd service18:21
Pharaoh_AtemI mean, how is it getting on there?18:22
cachioit is not a snap18:22
Pharaoh_Atemah18:22
Pharaoh_Atemis the code somewhere?18:22
cachioexactly18:22
cachioin the snapd project18:22
Pharaoh_Atemguh18:22
Pharaoh_Atemit's not part of snapd itself, is it?18:23
cachiohttps://github.com/snapcore/snapd/tree/master/tests/lib/fakestore18:23
cachioPharaoh_Atem, no18:23
cachioPharaoh_Atem, we setup it for each test when it is required18:25
cachiohttps://github.com/snapcore/snapd/blob/master/tests/lib/store.sh#L5018:25
Pharaoh_Atemthe systemd service needs the following added18:25
Pharaoh_AtemSELinuxContext=unconfined_t18:26
cachioPharaoh_Atem, great, I'll try with that18:27
Pharaoh_Atemah sorry18:27
Pharaoh_Atemit needs fully qualified context18:27
Pharaoh_Atemthat's "system_u:system_r:unconfined_t:s0", I believe18:29
Pharaoh_Atemcachio: if "unconfined_t" doesn't work, try the above18:29
cachioSELinuxContext=system_u:system_r:unconfined_t:s018:30
Pharaoh_Atemthe documentation isn't clear if just declaring the type is enough18:30
cachioPharaoh_Atem, I'll try one by one in that case18:30
Pharaoh_Atemthanks18:31
om26erpopey: could you please merge this https://github.com/snapcrafters/sublime-text/pull/8 -- flexiondotorg seems away.18:31
mupPR snapcrafters/sublime-text#8: Remove '3' from snap name <Created by om26er> <https://github.com/snapcrafters/sublime-text/pull/8>18:31
Pharaoh_Atemnormally, just defining the type is enough, because everything else is inherited18:31
muravey_omskhey, how to debug or find a problem with fonts at my snap app?18:32
* zyga-ubuntu looks at sublime-text-3 PR18:36
popeyom26er: is that really desired? I mean, we already have sublime-text-3, why not just create sublime-text-2?18:36
om26erpopey: the suggestion from zyga-ubuntu (and others) was to use a single name  and make use of 'tracks'18:37
zyga-ubuntuyes18:38
popeyNot sure it's worth it, given how few updates there are. Having two snaps also means you can have both installed should you want to18:38
zyga-ubuntupopey: that will be available too18:38
zyga-ubuntuthough I doubt that is something that people really want in _this_ case18:38
zyga-ubuntupopey: I think it's better to use 2.x track for the old sublime-text and the latest track for what's out there now18:39
popeyI am unconvinced.18:39
zyga-ubuntu(especially since we could use edge for the dev builds)18:39
zyga-ubuntupopey: I think this also shows the nice features of snap design18:39
zyga-ubuntuwhere developers can release multiple tracks nicely18:40
popeyflexiondotorg: ^ what do you think?18:40
om26er(side question: is there no change needed to snapcraft.yaml for a track ?)18:40
popeyif we use build.snapcraft.io we can only push to edge, and then release to tracks/channels18:41
om26erpopey: in case of sublime, we have two separate download urls, so how do we upload the _old_ version (aka 2.X) ?18:42
zyga-ubuntuom26er: just release to other track18:42
zyga-ubuntuom26er: snap info mysql (the same way)18:42
om26ercool but how do I update a version 2 snap ? Do I change my yaml file manually, create a build and upload it with snapcraft cli ?18:44
om26ers/update/upload18:44
popeyyou can have two projects in github18:44
popeyone for 3, one for 218:44
popeyboth push to the same edge channel though18:44
zyga-ubunture19:15
zyga-ubuntumy kernel crashed again :/19:15
zyga-ubuntubionic is not happy19:15
mupPR snapd#4820 opened: cmd/snap: use timeutil.Human to show times in `snap refresh --time` <Created by chipaca> <https://github.com/snapcore/snapd/pull/4820>19:30
mupPR snapd#4817 closed: overlord:  implement policy of holding refreshes for up to 6h since seeding on classic <Critical> <Created by pedronis> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/4817>19:52
=== __chip__ is now known as Chipaca
Chipacaslangasek: question about today's live cd19:55
Chipacazyga-ubuntu: you still around?19:55
zyga-ubuntuYes20:05
zyga-ubuntuChipaca: how can I help20:06
Chipacazyga-ubuntu: ah drat, i just closed it, give me a bit to start it up again20:07
Chipacazyga-ubuntu: snap-confine error on today's live cd, about it not running to prevent escalation attacks or sth20:08
pedronisChipaca: which snapd version is on that?20:09
Chipaca2.31.sth iirc20:09
zyga-ubuntuHmmmm20:09
Chipacabooting still20:09
muravey_omskhey, could you help me, again?20:09
pedronisthere were some fixes for livecd but I don't know if they are related/when then landed20:09
muravey_omsksmirnovav@techadm03:/home/smirnovav/snap/cataclysm-dda$ locale20:09
muravey_omsklocale: Cannot set LC_CTYPE to default locale: No such file or directory20:09
muravey_omsklocale: Cannot set LC_MESSAGES to default locale: No such file or directory20:09
zyga-ubuntuI think that doesn’t have the fix yet20:09
muravey_omsklocale: Cannot set LC_ALL to default locale: No such file or directory20:09
zyga-ubuntuOnly master has that fix Chipaca20:10
Chipacazyga-ubuntu: ah ok20:10
pedronisChipaca: in other news I should have squashed #4789 when merging and didn't :/20:10
mupPR #4789: many: support holding refreshes by setting refresh.hold <Critical> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/4789>20:10
* muravey_omsk interesting in how to paste small command output? Pastebin?20:11
Chipacapedronis: and now?20:11
zyga-ubuntuYes20:11
zyga-ubuntuPastebin20:11
pedronisChipaca: I don't know, will not be fun to merge into 2.32 I suppose20:11
* Chipaca hugs mvo20:12
pedronisI'll see in the morning, anyway I also saw I can simplify the follow-up20:15
muravey_omskhttps://pastebin.com/vy1WB7Hk20:15
muravey_omskWhat am I doing wrong?20:17
muravey_omskmy program do not see my locale and don't show messages on my language20:18
fireclawTheFoxHey everyone, can someone help me get the desktopfile of my snap package show up in the dash? I've tried quite a lot of things but none have helped so far.20:48
popeyfireclawTheFox: hiya20:51
popeyfireclawTheFox: can you link to your yaml maybe?20:51
popeyNote that some desktops have bugs that require you to logout/back in to make the icon appear20:51
fireclawTheFoxHey popey, sure, here's the yaml: https://bazaar.launchpad.net/~fireclawthefox/thetravelingfox/snap/view/head:/snap/snapcraft.yaml20:52
popeyfireclawTheFox: ah, easy one, name your .desktop file the same as the snap20:52
popeyso thetravelingfox.desktop20:52
mupPR snapd#4813 closed: release: snapd 2.31.2 <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4813>20:52
fireclawTheFoxpopey: I thought it already fits the name as the snap also is also named the-traveling-fox20:53
popeyoh, you're right. huh.20:54
fireclawTheFoxI've also tried naming it the-traveling-fox_the-traveling-fox as well as directly add it in the yaml file using desktop:20:56
popeylemme take a better look, one moment20:57
mvozyga-ubuntu: yeah, its rather unfortunate20:57
mvozyga-ubuntu: my latest PR seems to get a step further, but it now fails in interfaces-content-mkdir-writable:snap20:57
popeyfireclawTheFox: the snap fails to build here. Do you rely on having PPAs or something enabled?21:01
fireclawTheFoxI don't rely on PPAs, just on a pipy package. Which version of snapcraft do you use? I've just pushed a version of my custom plugin to make it build on the version used on LP.21:02
popeysnapcraft, version 2.39.221:03
popeyon 16.04 (well, I'm doing snapcraft cleanbuild)21:03
popeyI need to disappear soon to get my daughter from dancing, if we don't fix it here, I'd recommend a thread on the forum21:04
fireclawTheFoxok, then the x-panda3d.py script has to be changed for that version21:04
popeyahh21:04
fireclawTheFoxI've once opened up a thread in the forums but it didn't got much attention.21:05
fireclawTheFoxAnyways, in the x-panda3d.py script just two things have to be changed, first enable the code from line 38 and disable line 49 to 54 as well as switch line 78 and 7921:07
cachioPharaoh_Atem, no way21:08
cachiodidn't work21:08
Pharaoh_Atem:'(21:08
cachioit is rejecting to set the type as unconfined_t aparently21:08
popeyfireclawTheFox: ok, lemme rebuild and see21:09
cachioPharaoh_Atem, even if I do it manually with chcon21:09
Pharaoh_Atemhmm21:10
Pharaoh_Atemit's probably not letting you transition domains from init_t to unconfined_t21:10
cachioany other idea to exec that file?21:11
cachioPharaoh_Atem, create a new test domain to set as permissive?21:13
popeyfireclawTheFox: ok, that built! :D21:13
Pharaoh_Atemeither that or just set the VM to permissive while running the tests21:13
fireclawTheFoxawesome21:13
Pharaoh_Atemand collecting the audit results21:13
popeyfireclawTheFox: ah, your exec line is wrong21:14
popeyfireclawTheFox: the exec line should not be launching the command name, but the app name21:15
popeyexec=the-traveling-fox21:15
fireclawTheFoxpopey: ah, yeah now that you say it, makes sense.21:16
popeyalso, add this21:16
popeyhttps://www.irccloud.com/pastebin/XsBC54Nc/21:16
popeyto the game part21:16
popeythat will put the pulseaudio library in an accessible place21:16
popeyoh, you mung the LD_LIBRARY_PATH... never mind21:16
popeyalso if you put libs in $SNAP/lib you won't need to "cd ${SNAP}"21:17
popeybecause $SNAP/lib is automagically in the path21:18
zyga-ubuntumvo: I will check your pull request tomorrow. Spending time with homework and kids21:19
mvozyga-ubuntu: sure, thats fine, I had some strange results, I suspect there is also the cache (apparmor cache) that is making things compilicated21:21
mvozyga-ubuntu: I will let the tests run over night, fingers crossed21:21
fireclawTheFoxpopey: sorry, my laptop just crashed, did you wrote anything after (22:16:58) popey: oh, you mung the LD_LIBRARY_PATH... never mind21:21
mvozyga-ubuntu: lets talk tomorrow :)21:22
* mvo waves21:22
popeyfireclawTheFox: no21:27
* cachio afk21:34
fireclawTheFoxpopey: just got the snap built, the desktop file works fine now, thanks so much for your help.21:41
popeyYay21:41
popeyGood. Looking forward to playing it21:41

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!