| jam | anyone around that could review https://github.com/juju/juju/8477 ? | 07:58 |
|---|---|---|
| jam | it refreshes AWS instance types, since now x1e, c5, m5 are supported in more regions. | 07:59 |
| === frankban|afk is now known as frankban | ||
| jam | manadart: any chance you can look at https://github.com/juju/juju/8474 as well? | 08:37 |
| manadart | jam: Am currently :) | 08:38 |
| jam | thx | 08:38 |
| jam | manadart: thanks for the review on https://github.com/juju/juju/8474 care to look at the renames and see if it makes more sense to you? | 09:04 |
| manadart | jam: K. | 09:05 |
| manadart | jam: LGTM | 09:06 |
| jam | wpk: are you around? I was wondering what happened with patching vmware dependency to support go 1.10? | 09:14 |
| manadart | jam: Is https://bugs.launchpad.net/juju/+bug/1726317 effectively sorted now? | 09:16 |
| mup | Bug #1726317: multiple addresses in a space confuses peergrouper <4010> <juju:In Progress by manadart> <https://launchpad.net/bugs/1726317> | 09:16 |
| wpk | jam: It's fixed in upstream, I want to put it as a part of my 'big' vmware update | 09:19 |
| jam | wpk: any chance you could split out that as a small patch to 2.3 so we can build both 2.3 and 2.4 w/ go 1.10? | 09:20 |
| wpk | sure, sec | 09:23 |
| wpk | one small fix is needed in constraints too | 09:23 |
| jam | wpk: thanks | 09:28 |
| jam | manadart: one more? https://github.com/juju/juju/8478 it seems my last patch for OpenTimeout created a race condition (the goroutine that writes to a channel is the only one that should close it) | 09:28 |
| jam | or wpk ^^ its pretty small, and then I'll merge 2.3 into develop | 09:30 |
| wpk | jam: looking, govmomi dep updated | 09:32 |
| jam | wpk: approved | 09:33 |
| manadart | jam externalreality: Small one - https://github.com/juju/juju/pull/8481/files | 11:13 |
| jam | looking | 11:13 |
| externalreality_ | manadart, what is that for? | 12:31 |
| externalreality_ | manadart, how did you know that was needed? | 12:31 |
| manadart | externalreality_: We spoke with John in Budapest. | 12:33 |
| externalreality_ | I didn't | 12:35 |
| externalreality_ | manadart, I am afraid I am often ignored often | 12:35 |
| externalreality_ | manadart, I am beginning to dislike being left out all the time | 12:35 |
| mup | Bug #1751153 changed: juju 2.3.4: vsphere units automatically remove jujud across reboot when cloud-init /var/lib/cloud is removed <juju:New> <juju-core:Won't Fix> <https://launchpad.net/bugs/1751153> | 14:22 |
| === frankban is now known as frankban|afk | ||
| wallyworld | balloons: sorry, internet died. ffs. tethered to my phone now for a bit | 22:29 |
| balloons | wallyworld, ahh.. I figured something like that happened | 22:29 |
| wallyworld | i have another meeting now but i think we had more or less finished | 22:29 |
| balloons | wallyworld, yea, I think it's fine. Thanks for catching up | 22:30 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!