[07:58] anyone around that could review https://github.com/juju/juju/8477 ? [07:59] it refreshes AWS instance types, since now x1e, c5, m5 are supported in more regions. === frankban|afk is now known as frankban [08:37] manadart: any chance you can look at https://github.com/juju/juju/8474 as well? [08:38] jam: Am currently :) [08:38] thx [09:04] manadart: thanks for the review on https://github.com/juju/juju/8474 care to look at the renames and see if it makes more sense to you? [09:05] jam: K. [09:06] jam: LGTM [09:14] wpk: are you around? I was wondering what happened with patching vmware dependency to support go 1.10? [09:16] jam: Is https://bugs.launchpad.net/juju/+bug/1726317 effectively sorted now? [09:16] Bug #1726317: multiple addresses in a space confuses peergrouper <4010> [09:19] jam: It's fixed in upstream, I want to put it as a part of my 'big' vmware update [09:20] wpk: any chance you could split out that as a small patch to 2.3 so we can build both 2.3 and 2.4 w/ go 1.10? [09:23] sure, sec [09:23] one small fix is needed in constraints too [09:28] wpk: thanks [09:28] manadart: one more? https://github.com/juju/juju/8478 it seems my last patch for OpenTimeout created a race condition (the goroutine that writes to a channel is the only one that should close it) [09:30] or wpk ^^ its pretty small, and then I'll merge 2.3 into develop [09:32] jam: looking, govmomi dep updated [09:33] wpk: approved [11:13] jam externalreality: Small one - https://github.com/juju/juju/pull/8481/files [11:13] looking [12:31] manadart, what is that for? [12:31] manadart, how did you know that was needed? [12:33] externalreality_: We spoke with John in Budapest. [12:35] I didn't [12:35] manadart, I am afraid I am often ignored often [12:35] manadart, I am beginning to dislike being left out all the time [14:22] Bug #1751153 changed: juju 2.3.4: vsphere units automatically remove jujud across reboot when cloud-init /var/lib/cloud is removed === frankban is now known as frankban|afk [22:29] balloons: sorry, internet died. ffs. tethered to my phone now for a bit [22:29] wallyworld, ahh.. I figured something like that happened [22:29] i have another meeting now but i think we had more or less finished [22:30] wallyworld, yea, I think it's fine. Thanks for catching up