| blackboxsw | smoser: for tomorrow https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341437 a cut at the subp fix to allow for string as a command | 03:48 |
|---|---|---|
| === _cpaelzer is now known as cpaelzer | ||
| === frickler_ is now known as frickler | ||
| === ilianaw_ is now known as ilianaw | ||
| * smoser thinks we should format code with isort | 14:42 | |
| smoser | https://pypi.python.org/pypi/isort | 14:42 |
| ch007m | Hi | 14:52 |
| ch007m | Can we define the version of the package to be installed under `packages:`? | 14:52 |
| smoser | ch007m: possibly. | 14:53 |
| smoser | packages are installed from the distro | 14:54 |
| smoser | so.. for example in apt/ubuntu, you could do: | 14:55 |
| smoser | packages: ['mypackage=1.2'] | 14:55 |
| smoser | but that assumes taht there is a 'mypackage' at version 1.2 in your repos | 14:55 |
| smoser | if you had ppas or somethign that would work, but generally speaking ubuntu doesnt have 2 versions of the same package in its archives. | 14:56 |
| === r-daneel_ is now known as r-daneel | ||
| smoser | blackboxsw: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341465 | 15:36 |
| blackboxsw | smoser: you can try landing that | 15:38 |
| blackboxsw | since review-mps runs tox, I'm not concerned about waiting for ci | 15:39 |
| smoser | k | 15:41 |
| blackboxsw | hrm something failed integration testing of my subp branch twice in a row last night. I can't reproduce the failure locally with: tox -e citest -- run --verbose --os-name xenial --test modules/set_password_list. I'm kicking the builder again since we know some services were under maintenance last night | 15:58 |
| do3meli | smoser: you may have some spare mins to look at https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/340757 ? ci run completed successfully. | 16:27 |
| smoser | do3meli: that looks fine. I dont like the long line though. | 16:34 |
| smoser | not sure what to do with it. | 16:34 |
| smoser | maybe just: See rc.conf(5) in FreeBSD 11.1 | 16:34 |
| do3meli | smoser: hmm that would be possible. it's the same whay in rhel.py distro class... | 16:36 |
| do3meli | *way | 16:37 |
| smoser | see comment in MP | 16:37 |
| smoser | just change the comment i think to make shorter. | 16:38 |
| do3meli | smoser: fine for me. will do right now. | 16:38 |
| do3meli | as it is not version specific i will leave that away. ok? | 16:40 |
| smoser | sure. you can drop the version | 16:42 |
| smoser | you had that inherently in the link | 16:42 |
| smoser | so i left it | 16:42 |
| do3meli | smoser: perfect, i have commited it. ready for setting it to approve ;-) thank you | 16:44 |
| do3meli | (local tox run was good) | 16:44 |
| do3meli | thanks smoser. wish you guys a restful evening. cheers | 16:49 |
| ch007m | @smoser. thanks for the answer | 17:07 |
| smoser | blackboxsw: commented on subp branch. just a suggestion. feel free to pull either way. | 17:09 |
| smoser | blackboxsw: i'd like a review of https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/340140 | 17:16 |
| blackboxsw | smoser: just left comments on https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341417 to see what you think | 17:20 |
| blackboxsw | grabbing your other branch | 17:20 |
| blackboxsw | I know apt retries is a bit of a hot button issue :) | 17:20 |
| smoser | blackboxsw: hm.. that should be fixed | 17:22 |
| smoser | the apt thing. | 17:22 |
| smoser | there it is | 17:23 |
| smoser | 6f2aaf7b0fa9fd9376561e9b6233b4d36de51da1 | 17:23 |
| blackboxsw | you mean apt should fix it, or cloud-init should work around it | 17:23 |
| blackboxsw | checking | 17:23 |
| blackboxsw | git push :) I'm still on d7e5385 | 17:25 |
| smoser | blackboxsw: https://bugs.launchpad.net/cloud-init/+bug/1693361 | 17:26 |
| ubot5` | Ubuntu bug 1693361 in APT "cloud-init sometimes fails on dpkg lock due to concurrent apt-daily.service execution" [Unknown,Confirmed] | 17:26 |
| blackboxsw | ohh I see, then this is a symptom of another problem | 17:27 |
| smoser | or it wasnt correclty fixed. | 17:28 |
| blackboxsw | each cloud-init clean --reboot --logs traces on "apt update" on a xenial container when providing #cloud-config\ndrivers:\nnvidia: {license-accepted: true} | 17:30 |
| blackboxsw | without some sort of retry on CalledProcessError. I could try emitting ps output to see what else might have apt locks | 17:31 |
| blackboxsw | took your suggestion on fix-subp branch | 17:36 |
| blackboxsw | awaiting my local tox run before merging | 17:36 |
| === r-daneel_ is now known as r-daneel | ||
| blackboxsw | simpoir: I just rebased the feature/snap -module branch to pull in the util-supb fixes so unit tests will now pass there | 17:54 |
| blackboxsw | I didn't have to resolve any conflicts in the rebase so no changes to what you are reviewing, but thought you should know | 17:54 |
| blackboxsw | as unit tests locally wouldn't run until the rebase fixed it | 17:54 |
| simpoir | blackboxsw: ok | 17:55 |
| simpoir | blackboxsw: I was wondering about those | 17:55 |
| smoser | blackboxsw: your mrege tool should comment on the bug (possibly in addition to the merge proposal) | 18:04 |
| smoser | or instead of. dont know. | 18:05 |
| blackboxsw | smoser: you mean on merge, the bug comment should point to the commitish as committed in trunk? | 18:05 |
| blackboxsw | I think you mentioned that last week, and I failed to add it | 18:06 |
| * blackboxsw has to grab lunch back in a bit | 18:06 | |
| smoser | hm.. | 18:10 |
| smoser | no. you added it so it adds a comment. | 18:10 |
| smoser | blackboxsw: well, it makes a comment on the merge proposal | 18:14 |
| smoser | but does not comment on a linked bug | 18:14 |
| smoser | https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341437 | 18:14 |
| smoser | is an example. | 18:14 |
| smoser | i'd like for the bug to also get a comment. possibly instead of the merge proposal, as the merge proposal does get a state change event. | 18:14 |
| smoser | blackboxsw: ping when around | 19:13 |
| blackboxsw | smoser: hangout? | 19:30 |
| blackboxsw | simpoir: I think we are going to try wrapping up the snap module for inclusion in cloud-init if you have a chance to wrap up a review there https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366 | 20:16 |
| blackboxsw | smoser: bionic MP https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341482 | 20:50 |
| blackboxsw | I was awaiting snap module, but I don't think it'll make it by EOD | 20:50 |
| smoser | This commit fixes get_hostname on the AzureDataSource. | 20:51 |
| smoser | we need to be better when reading messages. | 20:51 |
| smoser | self referencing in the subject :) | 20:51 |
| smoser | instead just | 20:52 |
| smoser | Fix get_hostname in Azure | 20:52 |
| blackboxsw | ahh I see s/This commit fixes/Fix/ gotcha. makes sense too noisy +1 | 20:53 |
| * blackboxsw and "too noisy" are synonymous | 20:54 | |
| simpoir | blackboxsw: added comments on MP; mostly typos and small things that may be symptomatic of my lack of knowing the codebase | 20:55 |
| blackboxsw | +1 simpoir I see review comments on snap stuff. fielding them now thank you | 20:55 |
| blackboxsw | simpoir:.... "lack of knowing the codebase" welcome to my life. :) | 20:55 |
| * blackboxsw might have a fixup to handle for containers on this branch as a result of my testing. simpoir and I left you without a leg to stand on because I didn't give testing instructions | 20:56 | |
| blackboxsw | sorry about that. I'll add them for reference now in the description | 20:57 |
| smoser | blackboxsw: ok. uploaded | 20:59 |
| smoser | and i fixed my branch for drivers i think | 20:59 |
| smoser | pylint really being a pain. | 20:59 |
| * blackboxsw sits on artful & xenial dev environments. I need to move to a bionic container/base system for development so I can feel the pain too | 21:00 | |
| blackboxsw | thx smoser | 21:00 |
| blackboxsw | ok so we can queue drivers and snap modules for tomorrows bionic build. I might have time for review of some of the other outstanding branches too. | 21:01 |
| blackboxsw | my goal is to get the ubuntu-advantage module up for your review tomorrow | 21:01 |
| blackboxsw | simpoir: thanks again, I finally added testing instructions that would have helped a bit. https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366 sorry 'bout that | 21:11 |
| simpoir | blackboxsw: were your testing instructions to run tox && make deb && throw in a container and call manually with a random snap like lolcat? | 21:11 |
| blackboxsw | yeah just that. minor sneakiness with user-data seeding | 21:11 |
| * simpoir feels proud for figuring it out | 21:12 | |
| blackboxsw | I'm sure you did all that. but, it would have helped me, and I just lacked the consideration making you work hard for it | 21:12 |
| blackboxsw | :) | 21:12 |
| blackboxsw | lolcat.... good choice ;) | 21:12 |
| simpoir | did not know know about the clean command. I'll keep that in mind | 21:13 |
| === r-daneel_ is now known as r-daneel | ||
| === r-daneel_ is now known as r-daneel | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!