| === r-daneel_ is now known as r-daneel | ||
| === shardy is now known as shardy_lunch | ||
| === shardy_lunch is now known as shardy | ||
| AscII | smoser: regarding https://code.launchpad.net/~lp-markusschade/cloud-init/+git/cloud-init/+merge/338439 | 13:56 |
|---|---|---|
| AscII | you asked if the local-hostname is always present | 13:57 |
| AscII | we do generate or enforce a valid hostname in the API/frontend | 13:58 |
| AscII | so it should be present | 13:58 |
| do3meli | smoser: re your comment in https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/340220 - am i seeing that right that for resizefs module no unit tests at all exists so far? | 14:12 |
| smoser | do3meli: :-( | 14:40 |
| smoser | probably | 14:40 |
| do3meli | i found some in the meanwhile. but not a lot... | 14:41 |
| smoser | AscII: could you put a comment in coede to that affect ? | 14:41 |
| smoser | thanks. | 14:42 |
| AscII | sure | 14:43 |
| AscII | smoser: done and pushed | 15:17 |
| === Gaffel_ is now known as Gaffel | ||
| smoser | blackboxsw: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341530 | 16:43 |
| smoser | and want to chat on ntp ? | 16:43 |
| blackboxsw | smoser: probably 10 mins for me. wrapping up unit tests on ubuntu-advantage | 16:47 |
| smoser | k. | 16:47 |
| blackboxsw | I'm sitting in hangout, but will be distracted until then | 16:48 |
| dojordan | hey @blackboxsw, any chance to take a look at the azuretimeouts branch? https://code.launchpad.net/~dojordan/cloud-init/+git/cloud-init/+merge/340546 | 17:59 |
| blackboxsw | dojordan: nope, but it's 2nd in my queue today so it'll definitely get reviewed today | 18:01 |
| dojordan | :) thanks for the update | 18:01 |
| bemis | hey, google is failing me here - is this an expected error? https://paste.fedoraproject.org/paste/8KirXN0pTDwsFOlzzlaZOA | 18:05 |
| bemis | (AttributeError: 'Namespace' object has no attribute 'action') for those that don't wish to click | 18:05 |
| bemis | output from cloud-init-18.1 on centos6 built from copr url linked in here earlier this week (i went back to 18.1 release day so no git-tag) | 18:07 |
| blackboxsw | https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341542 | 18:25 |
| blackboxsw | smoser: simpoir ubuntu-advantage module is up for review | 18:26 |
| blackboxsw | bemis: +1 on that, it is a valid bug.... I can sort that next week | 18:26 |
| blackboxsw | bemis: if you get a chance can you file a bug for it? https://bugs.launchpad.net/cloud-init/+filebug | 18:26 |
| simpoir | blackboxsw: oh, good! I was wondering where this was | 18:26 |
| blackboxsw | simpoir: yeah just had to sort unit tests | 18:27 |
| blackboxsw | always takes me a while | 18:27 |
| blackboxsw | I'll add a testing description now (but basically the same thing as the snap module | 18:27 |
| blackboxsw | simpoir: oops and I need to set prerequisite branch one min | 18:28 |
| bemis | blackboxsw: thanks - another seems to be that 18.1 can't detect OracleLinux's distro (there's inconsistency between whether it returns "none" or "ubuntu") | 18:28 |
| bemis | i'll file a bug once i have some real data on that | 18:28 |
| blackboxsw | simpoir: smoser resubmitted the branch https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341543 | 18:31 |
| blackboxsw | thanks bemis for the heads up there. yeah a bug will give us something actionable. | 18:31 |
| blackboxsw | smoser: per lint warnings that you recently fixed: did you see this one? cloudinit/config/cc_puppet.py:143: [W1505(deprecated-method), handle] Using deprecated method readfp() | 18:33 |
| * blackboxsw needs to rebase I think | 18:38 | |
| smoser | blackboxsw: i have not seen that. | 18:49 |
| * blackboxsw lands snap-module branch | 19:39 | |
| blackboxsw | and smoser 's pylint branch | 19:39 |
| smoser | AscII: hostname may be fqdn and also may not be ? | 19:46 |
| === r-daneel_ is now known as r-daneel | ||
| smoser | blackboxsw: ugh. deprecated method | 20:14 |
| smoser | are you fixing that ? | 20:14 |
| smoser | what started that. | 20:14 |
| blackboxsw | smoser: pylint picked it up today afaict. I landed a workaround in snap module | 20:14 |
| blackboxsw | to ignore the warning on readfd | 20:14 |
| blackboxsw | but I think we need a helpers fix | 20:15 |
| blackboxsw | smoser: that's in cc_puppet right? | 20:15 |
| blackboxsw | or somewhere else? | 20:15 |
| smoser | why did pylint start seeing it ? | 20:15 |
| * blackboxsw thinks it could have been seeing it for a while, I just today ran tox -r -e pylint to rebuild dependencies before linting | 20:16 | |
| blackboxsw | I'll check on the origins | 20:16 |
| smoser | hm. | 20:16 |
| smoser | http://paste.ubuntu.com/p/3j6QNh8Q9j/ | 20:17 |
| smoser | bugger. you ruined my tox output | 20:17 |
| blackboxsw | gah fixing unmocked stderr | 20:17 |
| smoser | blackboxsw: i thin the warnings are a new pip version. | 20:22 |
| smoser | as the hetzner is starting to show it, and it didnt' move with trunk. | 20:22 |
| smoser | and the c-i reviewer will always (i hope) do a clean tox | 20:22 |
| smoser | we froze the version of pylint, but not of any dependencies | 20:23 |
| blackboxsw | smoser: want an MP for that stderr leak or a trivial fix? | 20:23 |
| blackboxsw | http://paste.ubuntu.com/p/n4vQSjZXf8/ | 20:23 |
| blackboxsw | this stops the leaked msgs on tox -e xenial cloudinit/config/tests/test_snap.py | 20:24 |
| smoser | you can quick-fix | 20:25 |
| blackboxsw | ok landing | 20:25 |
| blackboxsw | smoser: minor nit on https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/340140 | 20:35 |
| blackboxsw | smoser: is it time for me to make a bionic release cut for today? | 20:36 |
| smoser | yeah.... if you want i just pushed to fix-iscsi | 20:38 |
| smoser | we can grab that. | 20:38 |
| smoser | assuming tox pass. | 20:38 |
| smoser | blackboxsw: ping | 21:02 |
| smoser | bugger. | 21:02 |
| smoser | cloudinit/config/tests/test_snap.py | 21:02 |
| blackboxsw | pong | 21:02 |
| smoser | cloudinit/config/tests/test_snap.py:448:62: F841 local variable 'm_stderr' is assigned to but never used | 21:02 |
| blackboxsw | bah you are out of time. lost track of it. | 21:02 |
| blackboxsw | can hangout to see what you want to do | 21:02 |
| smoser | well,. fix that... or i can. | 21:04 |
| blackboxsw | fixing that | 21:04 |
| blackboxsw | pushing and making and MP for bionic | 21:04 |
| smoser | k | 21:04 |
| smoser | i can come back in in a while... so why not try grab the iscsi | 21:04 |
| smoser | get your fix in, then i can rebase and push | 21:04 |
| blackboxsw | ok | 21:05 |
| smoser | then wait on c-i for that and approve. | 21:05 |
| blackboxsw | waitingon flake | 21:05 |
| smoser | and then bioinc | 21:05 |
| blackboxsw | smoser: 7ce839f846de705980839f9c7851bd0fd7353aad pushed | 21:07 |
| blackboxsw | will watch your iscsi branch and land it prior to bionic MP | 21:07 |
| smoser | just pushed. | 21:09 |
| smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/340140 should get marked c-i happy "real soon now" | 21:19 |
| * blackboxsw watches | 21:20 | |
| bemis | blackboxsw: it's like a pot waiting to boil dude - stop watching or it'll take forever | 21:32 |
| blackboxsw | hahaha | 21:32 |
| blackboxsw | I looked away and wham, tea is ready ;) | 21:33 |
| blackboxsw | merging now and proposing a bionic merge of tip :) | 21:33 |
| bemis | just the tip | 21:37 |
| bemis | (sorry - it's like a macro-trigger or something) | 21:38 |
| blackboxsw | heh, ok Bionic update proposed smoser https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341552 | 21:50 |
| * blackboxsw needs to wrap up the azuretimeouts review. nearly there | 21:50 | |
| bemis | i don't recall who all i've spoken with on this, but it looks like 18.1 actually does drop EL6 support (via using python27+ methods) | 21:51 |
| blackboxsw | bemis: I recall seeing your message exchanges earlier, generally we try not to break compatibility with older versions of python. We even monkey patch functionality in some cases to bridge the gap (even as far back as py2.6). It might be worth bringing up the specific discussion on this on Monday's status meeting | 21:56 |
| blackboxsw | as RHEL folks may be in attendance | 21:56 |
| blackboxsw | per the topic: Next status meeting: Monday 3/19 16:00 UTC | 21:56 |
| blackboxsw | in this channel | 21:57 |
| blackboxsw | if nothing else. more eyes will be on this channel for discussion | 21:57 |
| bemis | blackboxsw: awesome, i'll try very hard to attend with useful data -- for right now the only confirmed thing i have is running analyze show https://paste.fedoraproject.org/paste/S5xXDUkIuW-Vl5pplr5uaw | 22:10 |
| blackboxsw | bemis: out of my own curiousity, what prompted you to play with some of cloud-init's commandline utilities/scripts? I'm asking as I merged a bunch of them into cloud-init proper recently as they were helpful for me, but I wasn't sure about the general population. | 22:13 |
| blackboxsw | did you find out about those features via cloudinit.readthedocs.io? or just playing around with "cloud-init -h" | 22:14 |
| blackboxsw | analyze specifcally was our own development tool written by rharper, but I hadn't known if others outside of our team were interested in using it | 22:15 |
| bemis | blackboxsw: 100% tinkering - i think i might have seen it in readthedocs when trying to figure out why my userdata that worked in 079 didn't work in 18.1? | 22:35 |
| bemis | so it kinda turned into "what throws errors?" | 22:35 |
| bemis | (i still haven't finished reading the docs at readthedocs - so i'm in the weekend reading phase) | 22:36 |
| smoser | blackboxsw 'build-and-push' is in progress. should get uploaded in 3 minutes or so. | 23:03 |
| smoser | later. | 23:03 |
| blackboxsw | couple minor comments posted dojordan. I need a bit of discussion on this with folks on Monday to see if we want to tweak UrlError handling a bit more | 23:31 |
| dojordan | awesome- will address asap | 23:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!