anastasiamac | wallyworld: is this the pr u need a review on? https://github.com/juju/juju/pull/8486 | 02:13 |
---|---|---|
wallyworld | anastasiamac: my network dropped just before, not ure if you saw my msg. sorry i missed your question, was intrviewing | 03:35 |
anastasiamac | wallyworld: what msg? | 04:06 |
wallyworld | otp in another interview, sorry give me a sec | 04:06 |
anastasiamac | nws -saw ur responses on PR anyway - lgtm still stands :D | 04:06 |
wallyworld | anastasiamac: nfi how that got merged, am sending email to nic to ask | 05:59 |
=== frankban|afk is now known as frankban | ||
manadart | Anyone up for a review? | 14:53 |
manadart | https://github.com/juju/juju/pull/8501 | 14:53 |
=== akhavr1 is now known as akhavr | ||
=== icey_ is now known as icey | ||
balloons | manadart, passing tests too? :-) | 16:23 |
manadart | balloons: Crazy talk :) Yes, sorted my little issue. It was indeed to do with wrestling out test scenarios with the fakes. | 16:26 |
=== frankban is now known as frankban|afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!