| redcavalier | Hi, several months ago I reported https://bugs.launchpad.net/cloud-init/+bug/1722992 . Since then, we've been running an outdated version of cloud-init. Are there plans to fix this soon? | 02:09 |
|---|---|---|
| ubot5` | Ubuntu bug 1722992 in cloud-init "On the latest centos 7 release, we are unable to resize our instances filesystems" [Medium,Confirmed] | 02:10 |
| === r-daneel_ is now known as r-daneel | ||
| === shardy is now known as shardy_afk | ||
| === shardy_afk is now known as shardy | ||
| Odd_Bloke | smoser: blackboxsw: Is https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1757176 a known issue? | 15:09 |
| ubot5` | Ubuntu bug 1757176 in cloud-init (Ubuntu) "TypeError: get_hostname() got an unexpected keyword argument 'metadata_only' on GCE bionic boot" [Undecided,New] | 15:09 |
| blackboxsw | wow Odd_Bloke I'll look at that. thanks. That feels like version mismatch (as we just grew the metadata_only arg)... but will glance after this meeting I'm in. | 15:10 |
| Odd_Bloke | blackboxsw: Thanks! | 15:11 |
| blackboxsw | Odd_Bloke: have access to cloud-init collect-logs on the CLI there? it'll dump a *log.tar in the cwd | 15:11 |
| Odd_Bloke | blackboxsw: I can't get in to the machine, unfortunately. | 15:12 |
| blackboxsw | no prob. will see if I can reproduce the prob | 15:12 |
| Odd_Bloke | SSH host keys weren't created, so I can't SSH in. | 15:12 |
| blackboxsw | Odd_Bloke: confirmed and I can fix that today | 15:14 |
| Odd_Bloke | Thanks! | 15:14 |
| blackboxsw | I see what happened | 15:14 |
| Odd_Bloke | blackboxsw: Should we expect it to only happen on GCE? | 15:14 |
| blackboxsw | working it right now Odd_Bloke . I'm checking other datasources now | 15:15 |
| blackboxsw | Odd_Bloke: CloudSigma AliYun, OpenNebula looks like too | 15:17 |
| blackboxsw | but fallout is contained to those | 15:17 |
| Odd_Bloke | Ack, thanks. | 15:18 |
| blackboxsw | easy fix, should be up, reviewed and posted to bionic today | 15:18 |
| blackboxsw | smoser: rharper here's the fix the the bug above http://paste.ubuntu.com/p/RVC6FQbwTB/ | 15:39 |
| blackboxsw | I'm trying to decide how much unit testing we should have to cover it | 15:40 |
| smoser | surprised pylint didnt scream on that. | 15:41 |
| smoser | well, mayb e not | 15:41 |
| blackboxsw | to exercise this, I could have a suite of tests that initializes each fake datasource only to run the base class get_hostname method passing metadata_only to make sure it is accepted... but that seems overkill. | 15:41 |
| smoser | different signatures on subclasses. | 15:41 |
| smoser | yeah. i agree. | 15:41 |
| smoser | i dont know. | 15:42 |
| smoser | ii dont want to say "no unit tests are OK". | 15:42 |
| blackboxsw | yeah smoser I was suprised about the different named param especiialy in b/cloudinit/sources/DataSourceAliYun.py case which renames resolve_ip to _resolve_ip | 15:42 |
| smoser | but agree on the pain. | 15:42 |
| smoser | well, that is probably fallout *from* pylint | 15:42 |
| blackboxsw | I feel like I should fix aliyin param name too so it matches base class | 15:42 |
| smoser | it complains if you dont use a varibable somteims | 15:43 |
| smoser | i think its fine to change the aliyun param name | 15:43 |
| blackboxsw | maybe I add a unit test per datasource I've changed to make sure get_hostname accepts the proper param names as defined in base class? | 15:44 |
| blackboxsw | at least then the subclass tests that it's implementation provides the same 'api' as the base class | 15:45 |
| blackboxsw | s/it's/its/ | 15:45 |
| blackboxsw | though if parent class implementation moves on, these unit tests would still incorrectly succeed | 15:46 |
| blackboxsw | I've got an idea. | 15:46 |
| === pickle is now known as dhill_ | ||
| === pickle is now known as dhill_ | ||
| smoser | blackboxsw: did we have a general soltuion for json.dumps({dictionary that miht have some binary keys }) | 16:01 |
| blackboxsw | hrm, we have process_base64_metadata in cloudinit.sources.__init__ | 16:03 |
| blackboxsw | and json_dumps uses json_serialize_default in cloudinit.util | 16:03 |
| blackboxsw | which prefixes base64 content with ci-b64 | 16:04 |
| smoser | nice. thanks | 16:04 |
| smoser | blackboxsw: http://paste.ubuntu.com/p/8Hxy67h5X2/ | 17:35 |
| blackboxsw | smoser: interesting, will fix now. | 17:36 |
| blackboxsw | smoser: care if I land that branch in the process of fixing review-mps? | 17:37 |
| smoser | blackboxsw: fine wit em | 17:38 |
| blackboxsw | my regex was bad | 17:38 |
| blackboxsw | didn't allow for digits in the lp_user | 17:39 |
| blackboxsw | strangely we hand't hit that type of user until now | 17:39 |
| blackboxsw | ok tox is running against it prior to merge. should land in a couple mins | 17:41 |
| blackboxsw | review-mps pushed | 17:43 |
| blackboxsw | OpenNebula should land shortly | 17:43 |
| blackboxsw | ...done | 17:45 |
| blackboxsw | smoser: rharper for review and landing today to unblock GCE bionic | 18:25 |
| blackboxsw | https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341757 | 18:25 |
| rharper | looking | 18:26 |
| blackboxsw | thanks | 18:26 |
| rharper | inspect, nifty | 18:27 |
| smoser | blackboxsw: fyi, c-i says go away | 18:29 |
| smoser | i suspect due to 'inspect' :) | 18:29 |
| smoser | no. py27 | 18:30 |
| * blackboxsw is testing on py2.6 now too and no go on that unit test approach | 18:32 | |
| blackboxsw | hrm | 18:32 |
| blackboxsw | ahh gotit smoser rharper 30 seconds | 18:34 |
| blackboxsw | my last change with lints busted it | 18:34 |
| blackboxsw | will push a fix | 18:35 |
| blackboxsw | smoser: rharper fd165e92b0e22245d41e7f55a5f89de4b6b522a6 pushed | 18:38 |
| blackboxsw | just tested on py2.6 | 18:38 |
| rharper | k | 18:38 |
| blackboxsw | as well | 18:38 |
| blackboxsw | giving a GCE deployment of it to confirm sucees | 18:39 |
| blackboxsw | giving a GCE deployment of it to confirm sucess | 18:39 |
| blackboxsw | validated on GCE by upgrading xenial to my branch and cloud-init clean --logs --reboot | 19:00 |
| * blackboxsw validates failure case on GCE now using cloud-init-tip without get_hostname fix | 19:00 | |
| blackboxsw | sure enough, here's the failure on GCE without my changeset https://pastebin.ubuntu.com/p/NpMNDVMhz6/ | 19:01 |
| blackboxsw | ok gotta run. I still need to sort that lint error on my branch looks like | 19:03 |
| blackboxsw | back in 30 | 19:03 |
| blackboxsw | back | 19:44 |
| dojordan | @blackboxsw, any update on the UrlError handling discussion? | 19:49 |
| blackboxsw | dojordan: saw your changes at least to readurl yesterday. hadn't gotten through a followup discussion on URLError handling. | 20:00 |
| blackboxsw | let's see if we can hash it out here. | 20:00 |
| blackboxsw | so URLError can be raised by readurl in two cases: | 20:00 |
| Odd_Bloke | Can someone remind me what the new cloud-init SRU process/cadence is? | 20:00 |
| blackboxsw | 1. IMDS service is currently unavailable (during service upgrade or something) This would raise an URLError with the string "[Errno 111] Connection refused" | 20:01 |
| blackboxsw | 2. No network is configured on the instance with the e.cause string containing '[Errno 101] Network is unreachable' | 20:02 |
| blackboxsw | right now cloudinit's URLError doesn't surface errno on the exception raised | 20:02 |
| blackboxsw | should it handle that programmatically when raising an URLError? I'm not certain we really need to do that or Azure should really care a much about Errno 101 | 20:03 |
| blackboxsw | Odd_Bloke: cadence is at will currently when we've decided there is enough content to warrant an SRU. Generally I'd like to keep it minimally at quarterly (or at least when shortly we cut a cloud-init upstream release). The higher frequency the better | 20:04 |
| dojordan | hmm, where does timeout fit into the picture | 20:05 |
| dojordan | because in reality that is what is used in the happy path | 20:05 |
| dpb1 | blackboxsw: let's just simpmlify that... "after we release"? | 20:05 |
| blackboxsw | Odd_Bloke: for the short term, Since we have a cut of cloud-init v.18.2 next week, I'd like to start an SRU of that to xenial within a week after the release. | 20:05 |
| Odd_Bloke | blackboxsw: "the release" == the 18.2 release, or bionic? | 20:06 |
| blackboxsw | +1 dpb1 ... /me is rambling a bit too much on that. so, post 18.2 cut next week, we'll kick off an SRU | 20:06 |
| Odd_Bloke | OK, cool; I'm interested in https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1752391 ending up in xenial, and it sounds like we're on the path to that being true pretty soon. | 20:07 |
| ubot5` | Ubuntu bug 1752391 in cloud-init "cloud-init does not recognize initramfs provided network config in all cases" [Medium,Fix committed] | 20:07 |
| blackboxsw | Odd_Bloke: SRU to xenial after cloud-init 18.2 is cut next week. I'd estimate 2 weeks until SRU publish | 20:07 |
| Odd_Bloke | Ack, thanks. :) | 20:08 |
| blackboxsw | dojordan: I think the timeout you provide to readurl is on the intial readurl request cap for when it raises a TimeoutException, it's passed into requests directly | 20:10 |
| blackboxsw | so readurl will sit 1 second in your use case before raising that timeout exception | 20:11 |
| blackboxsw | if IMDS is not functional for some reason | 20:11 |
| dojordan | and then does timeout exception get wrapped in a urlerror? (sorry its been a little while since i wrote this code) | 20:11 |
| dojordan | I believe it does | 20:12 |
| blackboxsw | in testing, that's what it looks like happened. on my end. I setup a SimpleHTTPService and killed it | 20:12 |
| dojordan | I don't think cloud init needs to do too much special casing here - but maybe im wrong | 20:13 |
| dojordan | we tried to communicate, and didn't get a response | 20:13 |
| dojordan | vs got a response we don't like (5xx) | 20:14 |
| blackboxsw | right only difference in the first case was that you are re-EphemeralDHCPv4'ing when you don't really need to. | 20:15 |
| blackboxsw | but I think that's probably an unlikely corner case | 20:15 |
| dojordan | except with a timeout exception we do need to re dhcp | 20:15 |
| dojordan | which was the first case | 20:16 |
| blackboxsw | ahh right, much concern about nothing then | 20:16 |
| dojordan | but i agree, if we got a 101 we wouldn't necessarily need to re dhcp but it does' | 20:17 |
| dojordan | t really harm anything IMO | 20:17 |
| blackboxsw | dojordan: yeah and generally I can't imagine what case would actually get you down the path of Errno 101, because that means you got a temporary dhcp lease and something managed to get there at the moment and ifdown your interface | 20:18 |
| blackboxsw | .... not going to happen. | 20:18 |
| dojordan | right, since systemd-networkd is not up yet | 20:20 |
| blackboxsw | ok I'm good with this approach. will mark approved after I get one test run on EC2 | 20:24 |
| blackboxsw | thanks for your patience | 20:24 |
| dojordan | sounds good, thanks! | 20:31 |
| blackboxsw | smoser: rharper finally sorted my CI woes https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341757 | 21:00 |
| rharper | dojordan: in other threads about using netlink, there is some mention of reducing as much downtime as possible; if we can avoid DHCP'ing when we don't need to; that will keep the waiting overhead to a min, no ? | 21:07 |
| smoser | blackboxsw: rharper https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341774 | 21:08 |
| smoser | i have to run now. blackboxsw i can come back in in ~ 4 hours and upload anything that you've got landed. | 21:08 |
| blackboxsw | +1 smoser thanks will have something up | 21:09 |
| smoser | just approved your branch there. | 21:09 |
| blackboxsw | just approved your Hetzner enable branch too smoser https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341679 | 21:10 |
| blackboxsw | smoser: Odd_Bloke put up https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341778 for bionic GCE fix | 22:43 |
| blackboxsw | that's to publish our fix which is in tip | 22:43 |
| blackboxsw | if it lands tonight it should be in bionic cloudimages tomorrow morn | 22:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!