[00:50] <thumper> babbageclunk: let's chat
[00:51] <babbageclunk> thumper: sure - 1:1
[00:51] <thumper> ok
[02:00] <wallyworld> anastasiamac: not sure if you have time for a review? https://github.com/juju/juju/pull/8514
[02:01] <anastasiamac> wallyworld: i can try :)
[02:01]  * anastasiamac looking while lunching :D
[02:01] <wallyworld> ty, spreading the love around
[02:01] <wallyworld> have lunch first
[02:01] <wallyworld> there's no rush
=== frankban|afk is now known as frankban
=== salmankhan1 is now known as salmankhan
[12:30] <balloons> jam, have to reboot the PC
[12:31] <jam> balloons: k
[12:32] <jam> manadart, externalreality: btw, I added a card on the ha-space stuff that Tim pointed out. Namely "juju enable-ha --to X" should check that X is in the ha-space and prevent you from doing so if it isn't
[12:33] <manadart> jam: Yes, saw it; thanks.
[16:37] <manadart> jam externalreality: PR for the multi-address/no-ha-space-config is up.
[16:37] <manadart> https://github.com/juju/juju/pull/8517
[16:38] <manadart> Only the second commit is relevant, as per description.
=== frankban is now known as frankban|afk
[17:16] <jam> manadart: reviewed
[17:24] <cmars> hi balloons, could i get a review of https://github.com/juju/juju/pull/8513 ? this exposes labels in the `juju metrics` command output
=== daniel is now known as Guest77671
=== Guest77671 is now known as Odd_Bloke
[19:37] <thumper> morning
[19:43] <wpk> evening
[19:57] <hml> review anyone?  https://github.com/go-goose/goose/pull/62
[20:37] <hml> wpk: on pr8407, for createDefaultBridgeInDefaultProfile() why only ipv6 settings and not ipv4?
[20:44] <wpk> hml: because we offically support only ipv4 on LXD, we even have special error messages for that occassion :)
[20:45] <wpk> hml: we should do it for v6 to, but I wouldn't make it in this PR
[20:46] <hml> wpk: something isn’t parsing in my brain… we write ipv6 settings because we only support ipv4?
[20:48] <wpk> hml: we disable v6 explicitly
[20:49] <wpk> hml: that's what we've been doing previously, we could 'fix' that bug, again, not this PR
[20:49] <hml> wpk: duh - ipv6.address: none
[20:49] <hml> does the network already contain ipv4 information?
[20:49] <wpk> hml: by default
[20:49] <hml> or the profile
[20:49] <hml> ah
[20:49] <hml> i missed the word none  :-)
[20:52] <balloons> hml, I left some comments for you
[20:52] <hml> balloons: ty
[21:01] <hml> —keep-broken only applies to bootstrap yes?
[21:03] <balloons> veebers, appears you are correct. We can't use our awesome versioning anymore it seems for snaps
[21:09] <balloons> I take that back, our version is missing something
[21:17] <wpk> balloons: btw
[21:17] <wpk> balloons: I had a weird 'hang' in CI run today
[21:17] <wpk> balloons: let me find the run...