| smoser | blackboxsw: responded to the open-telekom branch | 00:30 |
|---|---|---|
| blackboxsw | smoser: I'm going to land the open-telekom branch (wanted to test review-mps getting the authorship correct there) | 01:56 |
| smoser | blackboxsw: ok. great. thanks. | 02:47 |
| blackboxsw | smoser: is this the comment you wanted to see on bugs when commits happen in tip, or something a bit different? https://bugs.launchpad.net/cloud-init/+bug/1756471/comments/6 | 02:49 |
| ubot5 | Ubuntu bug 1756471 in cloud-init "ds-identify does not identify openstack Open Telecom Cloud" [Medium,Fix committed] | 02:49 |
| blackboxsw | when we release to bionic I'd expect a comment along the lines of "cloud-init v.X released in Bionic, if this is still an issue, re-open the bug or create a new one" | 02:50 |
| blackboxsw | anyway it's late. can chat tomorrow about it | 02:50 |
| smoser | blackboxsw: yes, that is great. | 02:59 |
| blackboxsw | AscII: if you're around today rharper/smoser was peeking at your metadata network config and the thought was that your metadata service should actually not be presenting the aliases eth0:0 interface name, but it could fold the subnet defined under eth0:0 under a single interface 'eth0' | 15:21 |
| blackboxsw | AscII: lines 23-32 should live @ line 17 http://paste.ubuntu.com/p/PDjVZTM9sp/ | 15:24 |
| blackboxsw | rharper: I'm tweaking your commit message and landing https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/341662 review-mps balked at line length.. sorry about the mp comment noise on that | 15:52 |
| rharper | thanks | 15:52 |
| danMS_ | hey scott, https://git.launchpad.net/cloud-init/tree/cloudinit/sources/DataSourceAzure.py#n606, can we make this ‘NTFS – one file’ check failure ignorable, because if the OS doesn’t know how to do NTFS, the contents *can’t* be important? | 17:11 |
| AscII | blackboxsw: thx for the input. If I remember correctly this is again a workaround for rhel/fedora | 18:39 |
| rharper | well, in general the v1 config format doesn't regonize an alias interface as a physical device | 18:47 |
| === r-daneel_ is now known as r-daneel | ||
| smoser | danMS_: you're saying that line 642 could return True, "you probably didnt have anything there because your kernel couldnt mount ntfs" | 19:29 |
| smoser | right ? | 19:29 |
| smoser | it is probably reasonably safe, but could obviously false positive and destroy data. | 19:29 |
| smoser | if you booted into a new kernel and had forgot some module s or something. | 19:29 |
| === r-daneel_ is now known as r-daneel | ||
| smoser | blackboxsw: https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341844 | 20:33 |
| smoser | that one is good. | 20:33 |
| blackboxsw | smoser: good like you wanted it landed or reviewed? | 20:41 |
| smoser | please give it some thought. | 20:41 |
| smoser | i pointed c-i bot at it | 20:42 |
| smoser | but it looked logically good ot me | 20:42 |
| blackboxsw | roger, it affects dojordans Azure branch I think | 20:42 |
| blackboxsw | as he's now using readurl w/ exception_cb too | 20:43 |
| blackboxsw | will take it into account. | 20:43 |
| smoser | blackboxsw: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341543 | 20:50 |
| smoser | Simon pointed out you seemed to have dropped the TestPrependBaseCommand tests. | 20:50 |
| blackboxsw | yes, I finished testing that this morning. | 20:50 |
| smoser | oh. ok. | 20:50 |
| smoser | you didnt respond ot that | 20:50 |
| blackboxsw | checking the dropped basecommand test... I moved it into cloudinit/tests/test_subp.py | 20:50 |
| blackboxsw | only question I have smoser is the order in which I'm running ubuntu-advantage module in cloud.cfg.tmpl | 20:51 |
| blackboxsw | I put it after the apt pipelining and apt configure modules as they might tweak apt a bit prior to ubuntu-advantage installing the deb | 20:52 |
| smoser | yeah. | 20:53 |
| blackboxsw | if you had any thoughts there it feels a bit heavy to order an {% if variant in ["ubuntu"] %} just after a section that was ubuntu|debian|unknown | 20:53 |
| smoser | those couldprobably move earlier... they just set configuration. but you definitely want to be after them if you're going to install packags. | 20:53 |
| smoser | you have a merge conflict showing right now there. | 20:53 |
| smoser | i think | 20:53 |
| smoser | look for <<<< | 20:53 |
| smoser | i think its fine as you have it. | 20:54 |
| smoser | "heavy" doesnt matter really there... its build time. | 20:54 |
| smoser | if thats what you meant | 20:54 |
| blackboxsw | smoser: if I git merge cs/feature/ubuntu-advantage-module against tip of master checked out locally I get no conflicts | 20:54 |
| smoser | ah. so lp is just out of sorts | 20:55 |
| blackboxsw | yeah, it just felt like I'm being ubuntu-explicit in the template just after a more general ubuntu, debian, unknown section felt like it might have been overkill, but as you said, template build happens once, so no biggie | 20:56 |
| blackboxsw | and we don't want ubuntu-advantage to show of in cloud.cfg anywhere else | 20:56 |
| blackboxsw | and we don't want ubuntu-advantage to show up in cloud.cfg anywhere else | 20:56 |
| blackboxsw | smoser: ahh I forgot to add cloudinit/tests/test_subp.py | 20:58 |
| blackboxsw | that's why simpoir suggested I dropped it without replace. pushing now | 20:58 |
| blackboxsw | man it's a bit confusing in that wait_for_url's exception_cb is expected to behave differently than readurl's exception_cb | 21:21 |
| blackboxsw | but anyway, doesn't need to be aligned with this branch | 21:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!