* thumper is back | 00:43 | |
thumper | anastasiamac_: I left a comment on the pr asking if possible to split up | 00:45 |
---|---|---|
thumper | 4k reviews are really hard | 00:45 |
anastasiamac_ | thumper: thnx. i have broken it into separate commits (I thought) but I'll look at ur suggestion :D | 00:46 |
thumper | anastasiamac_: I think we may be talking about different PRs :) | 00:48 |
thumper | anastasiamac_: I was talking about oracle one :) | 00:49 |
anastasiamac_ | thumper: oooh, yes, this one is hard :) it also has conflicts/broken CI run.... thank you for looking at it.. | 00:49 |
thumper | veebers: got some time to chat? | 01:00 |
veebers | thumper: for you? Always | 01:00 |
thumper | 1:1? | 01:01 |
veebers | thumper: ack, omw | 01:01 |
* thumper afk to collect kid from school | 02:08 | |
wallyworld | anastasiamac_: if you're so inclined, here's that PR https://github.com/juju/juju/pull/8524 | 05:17 |
anastasiamac_ | wallyworld: looking, altho m variously inclined :D | 05:24 |
=== frankban|afk is now known as frankban | ||
=== salmankhan1 is now known as salmankhan | ||
balloons | cmars, reviewed. Sorry it took so long | 17:18 |
cmars | balloons: thanks! | 17:18 |
=== frankban is now known as frankban|afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!