[02:57] <wallyworld> babbageclunk: i'm just grabbing a coffee, will be a few minutes
[02:57] <babbageclunk> wallyworld: ok
[03:17] <wallyworld> babbageclunk: righto, meet in 1:1?
[03:17] <babbageclunk> yup yup
[03:18] <wallyworld> anastasiamac: if you have a chance this arvo, here's a 2.3.5 bug fix i'd like to get in for the release https://github.com/juju/juju/pull/8527
[03:33]  * anastasiamac looking
[03:56] <babbageclunk> wallyworld: rather than making it something the test needs to do, I just don't return the server until the handlers have been registered.
[03:56] <wallyworld> that sounds reasonable to me
[03:57] <babbageclunk> ok, shall we wait until the tests pass or start now?
[04:07] <babbageclunk> wallyworld: hmm, it looks like the apiserver tests are good now, but my run's going to fail with the show-output test again.
[04:07] <babbageclunk> I'm chasing that down
[04:07] <wallyworld> ok
[04:08] <wallyworld> anastasiamac: i updated the PR with a new commit to fix another related bug
[04:09] <anastasiamac> k
[04:54] <babbageclunk> wallyworld: ok, cracked it - the tests are running now but I'm doner for day so I guess we're reviewing it tomorrow!
[04:55] <wallyworld> babbageclunk: great! look forward to tomorrow
[06:41] <jam> wallyworld: bug #1758828 we had a test suite failure from CAAS stuff. It seems something assumes we'll call Watch then Life, but somehow Watch happened very late.
[06:41] <mup> Bug #1758828: intermittent failure caasoperator_test.go WorkerSuite.TestWorkerDownloadsCharm <intermittent-failure> <juju:Triaged> <https://launchpad.net/bugs/1758828>
[06:43] <wallyworld> jam: ok, i'll take a look
=== frankban|afk is now known as frankban
[08:06] <wallyworld> anastasiamac: i added an additional test to the PR; let me know if there's anything else
[08:13] <manadart> What does valid/invalid do as a directive in placement?
[08:36] <jam> manadart: as in, an 'invalid placement directive' or are you saying you can "juju deploy --to invalid" (literal "invalid")
[08:37] <manadart> jam: as in https://github.com/juju/juju/blob/develop/apiserver/facades/client/highavailability/highavailability_test.go#L320
[08:39] <manadart> I also see valid/invalid used in .../facades/client/application/application_test.go
[08:41] <jam> manadart: https://github.com/juju/juju/blob/develop/provider/dummy/environs.go#L673
[08:41] <jam> manadart: seems to be very specific that Dummy provider supports a placement directive of "valid", but only that
[08:42] <manadart> jam: Got it. Ta.
[14:02] <manadart> For review: https://github.com/juju/juju/pull/8530
[14:34] <jam> small pr for review: https://github.com/juju/juju/pull/8528
[15:34] <manadart> PR for 2.3: https://github.com/juju/juju/pull/8531
[15:36] <manadart> I am EoD, so if it is approved, it can be merged to make the 2.3.5 release tomorrow (AEDT).
[16:39] <cmars> morning juju folks! can someone please review a small PR, https://github.com/juju/juju/pull/8520 ?
[16:40] <cmars> this adds (non-authoritative, but highly informative) model names to metrics, which gives us an idea of nice display names for certain models in jaas
[16:42] <cmars> balloons: ^^