blackboxsw | thx smoser, review-mps commit message linting. bah | 01:49 |
---|---|---|
smoser | blackboxsw: good now. i fixed. | 02:16 |
blackboxsw | yeah, I think we'll have to make a cut of cc_ntp tomorrow for bionic. some things need wrap up there and I want a couple of live tests centos/sles which I'm going through now | 02:17 |
blackboxsw | and it's bedtime ;) | 02:17 |
smoser | indeed. | 02:24 |
smoser | nn | 02:24 |
smoser | rharper: https://code.launchpad.net/~mwhudson/livecd-rootfs/default-LANG-C.UTF-8/+merge/342144 | 02:28 |
smoser | \o/ | 02:28 |
smoser | i think that means we wont hit that generate any more. | 02:28 |
smoser | do3meli: https://jenkins.ubuntu.com/server/job/cloud-init-ci/933/ | 13:20 |
smoser | and i am going to add you to the group that gets c-i run automatically for you. | 13:20 |
do3meli | @smoser: thanks | 13:46 |
do3meli | smoser: ci build was successfull. from my point of view good to merge now. if you feel the same you can set the status of the MR to approve ;-) | 13:51 |
rharper | smoser: yay LANG! | 13:55 |
smoser | do3meli: on its way. | 14:08 |
smoser | thanks! | 14:08 |
smoser | do3meli: you need more work now ? | 14:08 |
smoser | :) | 14:08 |
do3meli | haha :-) guess my company wants me to move on with other stuff now :-P | 14:25 |
smoser | boooo | 14:25 |
do3meli | well i will stay connected i guess ;-) maybe bit bug management or something like that | 14:27 |
do3meli | well see | 14:27 |
smoser | alright. then i wont set you up to get auto c-i just yet. | 14:30 |
smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342214 | 16:07 |
blackboxsw | smoser: rharper filed the release 18.2 bug | 16:15 |
blackboxsw | including it in a cloud-init release bump branch now | 16:15 |
blackboxsw | smoser: let's include the dependency | 16:16 |
blackboxsw | sound good? | 16:16 |
blackboxsw | https://bugs.launchpad.net/cloud-init/+bug/1759318 | 16:16 |
ubot5 | Ubuntu bug 1759318 in cloud-init "Release 18.2" [Undecided,New] | 16:17 |
smoser | eyah. in trunk it doesnt hurt anythin. and we want it in packaging. | 16:17 |
smoser | so if you want to pull that, go ahead. | 16:17 |
blackboxsw | yeah, figured almost zero risk | 16:17 |
blackboxsw | landing your branch (after tox) | 16:17 |
smoser | blackboxsw: i'm landing ubuntu branch change now. | 16:20 |
blackboxsw | +1 smoser | 16:20 |
blackboxsw | not touching it | 16:21 |
smoser | done | 16:21 |
blackboxsw | thx pulling | 16:21 |
blackboxsw | smoser: are you landing https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342215 ? | 16:33 |
blackboxsw | wanted to pull that into 18.2 | 16:33 |
* blackboxsw misunderstood the 'I'm landing ubuntu branch change" comment | 16:35 | |
smoser | yeah, lets grab that. | 16:36 |
smoser | blackboxsw: i'm landing that one now | 16:37 |
blackboxsw | thanks ok will repropose 18.2 after that then | 16:37 |
blackboxsw | hrm just dropped tip of master on a cent6 container. it didn't dedect DataSourceNoCloud and it's currently trying to hit Hetzner cloud... checking out what's up | 17:03 |
smoser | hm. | 17:05 |
* blackboxsw is thinking minimally something is up with the exception_cb | 17:08 | |
smoser | hm. hm. | 17:08 |
smoser | blackboxsw: how do i reproduce that? | 17:10 |
blackboxsw | 2018-03-27 17:00:29,960 - handlers.py[DEBUG]: finish: init-local/search-NoCloud: SUCCESS: no local data found from DataSourceNoCloud | 17:10 |
blackboxsw | hmm, umm I expected that to find yes in the cent6 container. /me thinks.. | 17:10 |
blackboxsw | looking over ubuntu | 17:10 |
smoser | blackboxsw: you're sure you have /var/lib/cloud/ stuff there ? | 17:10 |
blackboxsw | [root@cloud-init-centos-2f4670b4 ~]# ls /var/lib/cloud/seed/ | 17:11 |
blackboxsw | [root@cloud-init-centos-2f4670b4 ~]# | 17:11 |
smoser | the linuxcontainers.org provided images do not have metaata that says it should write that. | 17:11 |
blackboxsw | hrm why not, thought that was baked into the lxc images | 17:11 |
smoser | you would have to add the metadata to them to write it. | 17:11 |
blackboxsw | ahh, ok, oops. thought I hadn't had to do that in the past... but maybe I just forgot a step (as I've only recently just run unittests on cent*) | 17:12 |
blackboxsw | nevermind the crazy guy in the corner: PEBCAK | 17:13 |
smoser | well, to run unit tests. | 17:15 |
smoser | ./tools/run-centos | 17:15 |
smoser | ./tools/run-centos --rpm --srpm --unittest 6 | 17:15 |
blackboxsw | yeah that's what I kicked with -k -r | 17:15 |
blackboxsw | it left me with the container that I then attempted to install the rpm on. neglecting to make sure the image had a seed | 17:15 |
smoser | ah. right. | 17:16 |
blackboxsw | ok created the seed on centos container, everything happy again with ds detection | 17:18 |
blackboxsw | sorry for the noise | 17:18 |
blackboxsw | though /me wants to test hetzner cloud again to make sure get_data bails quickly if !hetzner cloud | 17:19 |
smoser | blackboxsw: it does not. | 17:20 |
blackboxsw | ahh right timeout=2, sec_between=2, retries=30): | 17:21 |
blackboxsw | ok | 17:21 |
blackboxsw | so 2 mins of read_metadata attempts | 17:21 |
blackboxsw | ok; as intended. I was uncertain if it was looping forever on my container. will check that it limits to 30 retries | 17:22 |
blackboxsw | I see you landed the dhcp client. ... putting up cloud-init 18.2 in a min here | 17:23 |
smoser | blackboxsw: i can fix hetzer | 17:24 |
smoser | and i think maybe we should | 17:24 |
blackboxsw | it's near last in our list of datasources, but I think we could throw up our hands a bit earlier | 17:24 |
blackboxsw | to avoid making IBM wait :) | 17:24 |
blackboxsw | smoser: ok on awaiting hetzner fix for 18.2 | 17:25 |
smoser | http://paste.ubuntu.com/p/YvkFJCFyXk/ | 17:25 |
blackboxsw | checking ds-identify for comparison | 17:26 |
blackboxsw | +1 system-manafacturer -> sys_vendor in sysfs | 17:28 |
blackboxsw | ok | 17:28 |
blackboxsw | s/hetzer/hetzner | 17:30 |
blackboxsw | yeah 4 mins of Hetzner waiting for both read_metadata, read_userdata is too much waiting | 17:32 |
smoser | blackboxsw: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342226 | 17:36 |
* smoser goes to fire up a hetzner cloud instance to just make sure i dont break it. | 17:39 | |
blackboxsw | smoser: +1, I'll let you merge it once you've hitup hetzner | 17:45 |
blackboxsw | I | 17:46 |
blackboxsw | I've approved the branch and tested on lxc without seed to see a quick fail | 17:46 |
smoser | i put some info there that it was good. | 17:46 |
smoser | now actually installing the deb and cloud-init-clean | 17:46 |
blackboxsw | pylint and flake8 good on your branch | 17:50 |
smoser | you can merge ? | 17:53 |
blackboxsw | https://jenkins.ubuntu.com/server/view/cloud-init/job/cloud-init-ci/937/ waiting on ci, about 10 mins left looks like. but I think I can merge it when it's done. | 17:55 |
blackboxsw | or I can merge now if you want as I expect a clean CI bill of health | 17:55 |
smoser | oh. right. | 17:55 |
smoser | i thought you were saying it ran | 17:55 |
smoser | we wait on the all powerful jenkins | 17:55 |
blackboxsw | pay no attention to the man behind the curtain | 17:56 |
blackboxsw | yeah will wait and merge post-jenkins | 17:56 |
* blackboxsw relocates | 18:13 | |
blackboxsw | smoser: rharper https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342217 is ready for review | 18:52 |
blackboxsw | I pushed a new 18.2 signed tag hopefully that's all we need.as git describe now tells me I'm on 18.2 | 18:52 |
blackboxsw | smoser's dhcp and hetzner fixes are landed | 18:53 |
smoser | blackboxsw: woot. | 19:18 |
smoser | ok. | 19:18 |
rharper | citest noob; so the ntp tests fail on my branch, if I ran citest via tox, where do I find the collected data, like cloud-init logs and the files the test collected? | 19:24 |
rharper | smoser: for the ntp updates I think I need to a) update the ntp test-case match trunk w.r.t which client is to be installed; note this test changes depending on the release image; xenial, for example is going to always use timesyncd, but in bionic it would be chrony; b) do we have a way to construct yaml on a per-release basis? c) does ci-test run only on xenial or what other releases ? | 19:29 |
blackboxsw | back | 19:51 |
blackboxsw | rharper: ../results generally | 19:51 |
rharper | that | 19:51 |
rharper | that's in toplevel ? | 19:51 |
rharper | when run via tox ? | 19:51 |
blackboxsw | it's above your source tree root | 19:51 |
blackboxsw | I *think* that's the default... checking | 19:52 |
rharper | I think tox ends up doing tmpdir thingys ... I dunno | 19:52 |
blackboxsw | might need --preserve-data | 19:53 |
rharper | ok, and I wonder if that works under tox | 19:53 |
rharper | well, I should just install the deps and run from tree getting it working and then test tox | 19:53 |
blackboxsw | tox -e citest -- --preserve-data --results ../results | 19:53 |
blackboxsw | or something like that... checking | 19:53 |
blackboxsw | rharper .tox/citest/bin/python3 -m tests.cloud_tests run --os-name=bionic --platform=lxd --preserve-data --data-dir=../results --verbose -t modules/ntp | 19:54 |
blackboxsw | and -t modules/ntp_servers -t modules/ntp_pools | 19:55 |
smoser | rharper: http://paste.ubuntu.com/p/629gZx94qs/ | 19:56 |
smoser | that is what i run | 19:57 |
smoser | like: | 19:57 |
smoser | ../scripts/go-test lxc --test=tests/cloud_tests/testcases/modules/final_message.py | 19:57 |
smoser | and it puts results into ./results.lxc.d/ | 19:57 |
smoser | you can change the 'xenial' around | 19:57 |
smoser | c-i i think only runs with xenial | 19:57 |
smoser | but we have other runners that run on test with different releases. | 19:57 |
rharper | k | 19:58 |
smoser | you should be able to check the release that is being used in the test case | 19:59 |
smoser | i dont think we have per-release config | 19:59 |
smoser | but you can make pre-release assertions | 19:59 |
blackboxsw | ci looks done on 18.2 for cloud-init https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342217 | 20:09 |
rharper | smoser: ok, I'm going to update the config to work with xenial, and branch out into other variants after that | 20:12 |
rharper | tox-venv ? | 20:14 |
rharper | need to pip install that I guess | 20:15 |
* rharper relocates | 20:15 | |
smoser | rharper: tox-venv is ./tools/ | 20:17 |
smoser | tox-venv <name> | 20:18 |
smoser | enters <name> and executes a command | 20:18 |
smoser | the difference compared to 'tox -e' is that you can run any command and it doesnt do setup.py first (which is slow) | 20:23 |
blackboxsw | incredibly slow | 20:24 |
smoser | blackboxsw: where is the doc for release ? | 20:25 |
smoser | https://hackmd.io/zbeM1cG-REq2NE3BvesqOw | 20:25 |
blackboxsw | smoser: you mean rtd? | 20:25 |
blackboxsw | ahh | 20:25 |
smoser | we need to move that to somewhere i think | 20:25 |
smoser | blackboxsw: do you want to do the rest ? | 20:26 |
blackboxsw | +1, yeah, gist? | 20:26 |
smoser | i pushed your tag | 20:26 |
smoser | i can do curtin release then. | 20:27 |
blackboxsw | +1 I'll do the rest | 20:27 |
blackboxsw | on cloud-init | 20:27 |
blackboxsw | smoser: rharper can you see Create release here? https://launchpad.net/cloud-init/+milestone/18.2 | 20:36 |
rharper | looking | 20:36 |
blackboxsw | I think I'm missing perms, as I can see that option on landscape projects | 20:36 |
rharper | nope | 20:37 |
blackboxsw | I hoped to see it under "Expected: " | 20:37 |
blackboxsw | but that date is already set to today(maybe smoser already ticked it) | 20:38 |
smoser | https://launchpad.net/cloud-init/+milestone/18.2 <-- | 20:38 |
blackboxsw | hrm nope: cloud-init 18.22018-03-22not yet released from https://launchpad.net/cloud-init/trunk | 20:38 |
smoser | thta was teh "due date" | 20:38 |
smoser | now we have the release date | 20:38 |
blackboxsw | hrm, ok that view changed for me now from what it used to be. probably clicked something I didn't have perms for I guess. | 20:40 |
rharper | https://launchpad.net/cloud-init/+series that has a reference to 2.0 and stackforge ... | 20:43 |
rharper | we probably can nuke that | 20:43 |
rharper | smoser: ^ | 20:43 |
smoser | gonzo | 20:44 |
rharper | sweet | 20:47 |
blackboxsw | smoser: I'm closing bugs now for 18.2 ok ? | 20:50 |
smoser | yeah. i'm doing it now for curtin | 20:52 |
smoser | stepping away from machine. | 20:53 |
smoser | will check back in later tonight. | 20:53 |
smoser | bugger | 20:53 |
smoser | that stupid script really needs '--project' | 20:53 |
smoser | i missed a s/Cloud-init/curtin/ | 20:53 |
smoser | oh well | 20:53 |
blackboxsw | ohh right smoser lp-bugs-released needs a --project-name | 20:54 |
blackboxsw | will add it | 20:54 |
rharper | hehe | 20:54 |
blackboxsw | cloud-init bugs are marked fix-released | 20:55 |
blackboxsw | missing tasks for: 1298921 1757176 1759307.... checking those out now | 20:55 |
blackboxsw | I marked the cloud-init task fix released on https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1759307 | 20:57 |
ubot5 | Ubuntu bug 1759307 in initramfs-tools (Ubuntu) "missing dependency on isc-dhcp-client (dhclient)" [Undecided,New] | 20:57 |
* blackboxsw fires up a cloud-init MP for bionic | 20:57 | |
* rharper is iterating with ci-test script from smoser; excellent | 20:59 | |
rharper | having fun with system_config and user-data merging ... now, I wonder what's going on; don't seem to be getting user-data ntp: dict merged when cc_ntp is running, so it's running in auto mode even when we specify a ntp_client in user-data | 21:00 |
blackboxsw | 18.2 release publish MP into bionic https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342239 | 21:01 |
* blackboxsw creates an SRU bug for xenial for 18.2 | 21:06 | |
blackboxsw | xenial & artful rather | 21:07 |
rharper | can confirm that the distro object is created before we cloudify, which reads the user-data, so distro itself doesn't have user-data; =( | 21:09 |
smoser | blackboxsw: ok. that MP is on its way up... assuming it builds here. | 21:26 |
smoser | i uploaded source tarball to https://launchpad.net/cloud-init/trunk/18.2 | 21:26 |
smoser | and now i'm out. | 21:26 |
blackboxsw | thanks smoser see ya | 21:26 |
* rharper refactors getting user-data config back int | 21:29 | |
rharper | and | 21:30 |
* rharper relocates | 21:30 | |
blackboxsw | Xenial SRU for 18.2: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342248 | 22:30 |
blackboxsw | Artful SRU for 18.2: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342249 | 22:32 |
blackboxsw | ^ includes the debian/control changes for isc-dhcp-client | 22:32 |
blackboxsw | ok just gen'd a trello card for cloud-init SRU https://trello.com/b/hFtWKUn3/daily-cloud-init-curtin | 22:57 |
blackboxsw | oops | 22:57 |
blackboxsw | https://trello.com/c/RZDKaWSv/719-cloud-init-sru-182-artful-xenial | 22:57 |
rharper | ok, unbricked unittests after re-introducing usercfg to the get_ntp_client_info() path as distro object does not have user-data config | 23:13 |
rharper | \o/ passing the updated ntp tests | 23:38 |
rharper | now to add new client tests | 23:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!