[01:49] thx smoser, review-mps commit message linting. bah [02:16] blackboxsw: good now. i fixed. [02:17] yeah, I think we'll have to make a cut of cc_ntp tomorrow for bionic. some things need wrap up there and I want a couple of live tests centos/sles which I'm going through now [02:17] and it's bedtime ;) [02:24] indeed. [02:24] nn [02:28] rharper: https://code.launchpad.net/~mwhudson/livecd-rootfs/default-LANG-C.UTF-8/+merge/342144 [02:28] \o/ [02:28] i think that means we wont hit that generate any more. [13:20] do3meli: https://jenkins.ubuntu.com/server/job/cloud-init-ci/933/ [13:20] and i am going to add you to the group that gets c-i run automatically for you. [13:46] @smoser: thanks [13:51] smoser: ci build was successfull. from my point of view good to merge now. if you feel the same you can set the status of the MR to approve ;-) [13:55] smoser: yay LANG! [14:08] do3meli: on its way. [14:08] thanks! [14:08] do3meli: you need more work now ? [14:08] :) [14:25] haha :-) guess my company wants me to move on with other stuff now :-P [14:25] boooo [14:27] well i will stay connected i guess ;-) maybe bit bug management or something like that [14:27] well see [14:30] alright. then i wont set you up to get auto c-i just yet. [16:07] https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342214 [16:15] smoser: rharper filed the release 18.2 bug [16:15] including it in a cloud-init release bump branch now [16:16] smoser: let's include the dependency [16:16] sound good? [16:16] https://bugs.launchpad.net/cloud-init/+bug/1759318 [16:17] Ubuntu bug 1759318 in cloud-init "Release 18.2" [Undecided,New] [16:17] eyah. in trunk it doesnt hurt anythin. and we want it in packaging. [16:17] so if you want to pull that, go ahead. [16:17] yeah, figured almost zero risk [16:17] landing your branch (after tox) [16:20] blackboxsw: i'm landing ubuntu branch change now. [16:20] +1 smoser [16:21] not touching it [16:21] done [16:21] thx pulling [16:33] smoser: are you landing https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342215 ? [16:33] wanted to pull that into 18.2 [16:35] * blackboxsw misunderstood the 'I'm landing ubuntu branch change" comment [16:36] yeah, lets grab that. [16:37] blackboxsw: i'm landing that one now [16:37] thanks ok will repropose 18.2 after that then [17:03] hrm just dropped tip of master on a cent6 container. it didn't dedect DataSourceNoCloud and it's currently trying to hit Hetzner cloud... checking out what's up [17:05] hm. [17:08] * blackboxsw is thinking minimally something is up with the exception_cb [17:08] hm. hm. [17:10] blackboxsw: how do i reproduce that? [17:10] 2018-03-27 17:00:29,960 - handlers.py[DEBUG]: finish: init-local/search-NoCloud: SUCCESS: no local data found from DataSourceNoCloud [17:10] hmm, umm I expected that to find yes in the cent6 container. /me thinks.. [17:10] looking over ubuntu [17:10] blackboxsw: you're sure you have /var/lib/cloud/ stuff there ? [17:11] [root@cloud-init-centos-2f4670b4 ~]# ls /var/lib/cloud/seed/ [17:11] [root@cloud-init-centos-2f4670b4 ~]# [17:11] the linuxcontainers.org provided images do not have metaata that says it should write that. [17:11] hrm why not, thought that was baked into the lxc images [17:11] you would have to add the metadata to them to write it. [17:12] ahh, ok, oops. thought I hadn't had to do that in the past... but maybe I just forgot a step (as I've only recently just run unittests on cent*) [17:13] nevermind the crazy guy in the corner: PEBCAK [17:15] well, to run unit tests. [17:15] ./tools/run-centos [17:15] ./tools/run-centos --rpm --srpm --unittest 6 [17:15] yeah that's what I kicked with -k -r [17:15] it left me with the container that I then attempted to install the rpm on. neglecting to make sure the image had a seed [17:16] ah. right. [17:18] ok created the seed on centos container, everything happy again with ds detection [17:18] sorry for the noise [17:19] though /me wants to test hetzner cloud again to make sure get_data bails quickly if !hetzner cloud [17:20] blackboxsw: it does not. [17:21] ahh right timeout=2, sec_between=2, retries=30): [17:21] ok [17:21] so 2 mins of read_metadata attempts [17:22] ok; as intended. I was uncertain if it was looping forever on my container. will check that it limits to 30 retries [17:23] I see you landed the dhcp client. ... putting up cloud-init 18.2 in a min here [17:24] blackboxsw: i can fix hetzer [17:24] and i think maybe we should [17:24] it's near last in our list of datasources, but I think we could throw up our hands a bit earlier [17:24] to avoid making IBM wait :) [17:25] smoser: ok on awaiting hetzner fix for 18.2 [17:25] http://paste.ubuntu.com/p/YvkFJCFyXk/ [17:26] checking ds-identify for comparison [17:28] +1 system-manafacturer -> sys_vendor in sysfs [17:28] ok [17:30] s/hetzer/hetzner [17:32] yeah 4 mins of Hetzner waiting for both read_metadata, read_userdata is too much waiting [17:36] blackboxsw: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342226 [17:39] * smoser goes to fire up a hetzner cloud instance to just make sure i dont break it. [17:45] smoser: +1, I'll let you merge it once you've hitup hetzner [17:46] I [17:46] I've approved the branch and tested on lxc without seed to see a quick fail [17:46] i put some info there that it was good. [17:46] now actually installing the deb and cloud-init-clean [17:50] pylint and flake8 good on your branch [17:53] you can merge ? [17:55] https://jenkins.ubuntu.com/server/view/cloud-init/job/cloud-init-ci/937/ waiting on ci, about 10 mins left looks like. but I think I can merge it when it's done. [17:55] or I can merge now if you want as I expect a clean CI bill of health [17:55] oh. right. [17:55] i thought you were saying it ran [17:55] we wait on the all powerful jenkins [17:56] pay no attention to the man behind the curtain [17:56] yeah will wait and merge post-jenkins [18:13] * blackboxsw relocates [18:52] smoser: rharper https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342217 is ready for review [18:52] I pushed a new 18.2 signed tag hopefully that's all we need.as git describe now tells me I'm on 18.2 [18:53] smoser's dhcp and hetzner fixes are landed [19:18] blackboxsw: woot. [19:18] ok. [19:24] citest noob; so the ntp tests fail on my branch, if I ran citest via tox, where do I find the collected data, like cloud-init logs and the files the test collected? [19:29] smoser: for the ntp updates I think I need to a) update the ntp test-case match trunk w.r.t which client is to be installed; note this test changes depending on the release image; xenial, for example is going to always use timesyncd, but in bionic it would be chrony; b) do we have a way to construct yaml on a per-release basis? c) does ci-test run only on xenial or what other releases ? [19:51] back [19:51] rharper: ../results generally [19:51] that [19:51] that's in toplevel ? [19:51] when run via tox ? [19:51] it's above your source tree root [19:52] I *think* that's the default... checking [19:52] I think tox ends up doing tmpdir thingys ... I dunno [19:53] might need --preserve-data [19:53] ok, and I wonder if that works under tox [19:53] well, I should just install the deps and run from tree getting it working and then test tox [19:53] tox -e citest -- --preserve-data --results ../results [19:53] or something like that... checking [19:54] rharper .tox/citest/bin/python3 -m tests.cloud_tests run --os-name=bionic --platform=lxd --preserve-data --data-dir=../results --verbose -t modules/ntp [19:55] and -t modules/ntp_servers -t modules/ntp_pools [19:56] rharper: http://paste.ubuntu.com/p/629gZx94qs/ [19:57] that is what i run [19:57] like: [19:57] ../scripts/go-test lxc --test=tests/cloud_tests/testcases/modules/final_message.py [19:57] and it puts results into ./results.lxc.d/ [19:57] you can change the 'xenial' around [19:57] c-i i think only runs with xenial [19:57] but we have other runners that run on test with different releases. [19:58] k [19:59] you should be able to check the release that is being used in the test case [19:59] i dont think we have per-release config [19:59] but you can make pre-release assertions [20:09] ci looks done on 18.2 for cloud-init https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342217 [20:12] smoser: ok, I'm going to update the config to work with xenial, and branch out into other variants after that [20:14] tox-venv ? [20:15] need to pip install that I guess [20:15] * rharper relocates [20:17] rharper: tox-venv is ./tools/ [20:18] tox-venv [20:18] enters and executes a command [20:23] the difference compared to 'tox -e' is that you can run any command and it doesnt do setup.py first (which is slow) [20:24] incredibly slow [20:25] blackboxsw: where is the doc for release ? [20:25] https://hackmd.io/zbeM1cG-REq2NE3BvesqOw [20:25] smoser: you mean rtd? [20:25] ahh [20:25] we need to move that to somewhere i think [20:26] blackboxsw: do you want to do the rest ? [20:26] +1, yeah, gist? [20:26] i pushed your tag [20:27] i can do curtin release then. [20:27] +1 I'll do the rest [20:27] on cloud-init [20:36] smoser: rharper can you see Create release here? https://launchpad.net/cloud-init/+milestone/18.2 [20:36] looking [20:36] I think I'm missing perms, as I can see that option on landscape projects [20:37] nope [20:37] I hoped to see it under "Expected: " [20:38] but that date is already set to today(maybe smoser already ticked it) [20:38] https://launchpad.net/cloud-init/+milestone/18.2 <-- [20:38] hrm nope: cloud-init 18.2 2018-03-22 not yet released from https://launchpad.net/cloud-init/trunk [20:38] thta was teh "due date" [20:38] now we have the release date [20:40] hrm, ok that view changed for me now from what it used to be. probably clicked something I didn't have perms for I guess. [20:43] https://launchpad.net/cloud-init/+series that has a reference to 2.0 and stackforge ... [20:43] we probably can nuke that [20:43] smoser: ^ [20:44] gonzo [20:47] sweet [20:50] smoser: I'm closing bugs now for 18.2 ok ? [20:52] yeah. i'm doing it now for curtin [20:53] stepping away from machine. [20:53] will check back in later tonight. [20:53] bugger [20:53] that stupid script really needs '--project' [20:53] i missed a s/Cloud-init/curtin/ [20:53] oh well [20:54] ohh right smoser lp-bugs-released needs a --project-name [20:54] will add it [20:54] hehe [20:55] cloud-init bugs are marked fix-released [20:55] missing tasks for: 1298921 1757176 1759307.... checking those out now [20:57] I marked the cloud-init task fix released on https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1759307 [20:57] Ubuntu bug 1759307 in initramfs-tools (Ubuntu) "missing dependency on isc-dhcp-client (dhclient)" [Undecided,New] [20:57] * blackboxsw fires up a cloud-init MP for bionic [20:59] * rharper is iterating with ci-test script from smoser; excellent [21:00] having fun with system_config and user-data merging ... now, I wonder what's going on; don't seem to be getting user-data ntp: dict merged when cc_ntp is running, so it's running in auto mode even when we specify a ntp_client in user-data [21:01] 18.2 release publish MP into bionic https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342239 [21:06] * blackboxsw creates an SRU bug for xenial for 18.2 [21:07] xenial & artful rather [21:09] can confirm that the distro object is created before we cloudify, which reads the user-data, so distro itself doesn't have user-data; =( [21:26] blackboxsw: ok. that MP is on its way up... assuming it builds here. [21:26] i uploaded source tarball to https://launchpad.net/cloud-init/trunk/18.2 [21:26] and now i'm out. [21:26] thanks smoser see ya [21:29] * rharper refactors getting user-data config back int [21:30] and [21:30] * rharper relocates [22:30] Xenial SRU for 18.2: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342248 [22:32] Artful SRU for 18.2: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342249 [22:32] ^ includes the debian/control changes for isc-dhcp-client [22:57] ok just gen'd a trello card for cloud-init SRU https://trello.com/b/hFtWKUn3/daily-cloud-init-curtin [22:57] oops [22:57] https://trello.com/c/RZDKaWSv/719-cloud-init-sru-182-artful-xenial [23:13] ok, unbricked unittests after re-introducing usercfg to the get_ntp_client_info() path as distro object does not have user-data config [23:38] \o/ passing the updated ntp tests [23:39] now to add new client tests