| === frankban|afk is now known as frankban | ||
| === salmankhan1 is now known as salmankhan | ||
| manadart | jam: Made changes to https://github.com/juju/juju/pull/8551 | 11:37 |
|---|---|---|
| manadart | I need to discuss https://github.com/juju/juju/pull/8550 | 11:37 |
| === salmankhan1 is now known as salmankhan | ||
| jam | manadart: replied to https://github.com/juju/juju/pull/8551 | 11:58 |
| manadart | jam: Ack. | 11:58 |
| jam | manadart: any chance you can meet with gsamfira today for Oracle call? | 12:01 |
| jam | (now-ish) | 12:01 |
| manadart | jam: Sure. Where? | 12:03 |
| jam | manadart: https://hangouts.google.com/hangouts/_/canonical.com/cloudbase-sync | 12:03 |
| manadart | omw | 12:03 |
| jam | manadart: might need https://hangouts.google.com/hangouts/_/canonical.com/cloudbase-sync?authuser=1 ? | 12:05 |
| jam | manadart: I'll be happy to chat with you about 8550 in a bit, trying to get my cleanups code working | 12:16 |
| manadart | jam: K. Standup is looming in any case. | 12:16 |
| jam | manadart: heading to standup now if you want to chat a bit | 12:24 |
| manadart | jam: brt | 12:25 |
| jam | balloons: standup? | 13:01 |
| === frankban is now known as frankban|afk | ||
| === hml_ is now known as hml | ||
| thumper | balloons, veebers: why... why is develop failing to build for me? | 21:46 |
| thumper | container/lxd/lxd_test.go:18:2: cannot find package "github.com/lxc/lxd/client/mocks" in any of: | 21:46 |
| veebers | thumper: I noticed the other day, you'll need to add patches to it | 21:47 |
| thumper | why? | 21:47 |
| veebers | thumper: there is some mock/patch stuff that was added recently (by wpk I think) | 21:47 |
| thumper | ffs | 21:47 |
| veebers | thumper: I think GoMock related? I haven't followed up yet | 21:47 |
| veebers | thumper: the header of the patch states: Code generated by MockGen. DO NOT EDIT. | 21:48 |
| thumper | the fact that I can't grab develop and run "make check" is a big deal | 21:49 |
| balloons | thumper, YEP. I ran into the same thing | 21:50 |
| balloons | we have new patches.. we're going backwards :-( | 21:50 |
| balloons | make add-patches | 21:51 |
| wpk | thumper: that's temporary as juju has to use very specific version of lxd (freshest one that still has old API), when provider will be moved completely to new API (and therefore HEAD) that should be gone. Alternatively, this mock could be moved into juju/juju/tools/lxdtools/lxdmock | 21:51 |
| thumper | at the very least, we should move it internally then kill it with fire | 21:52 |
| wpk | kill what? mock? | 21:53 |
| wpk | patch? | 21:53 |
| wpk | ah, but it still won't work as lxd has no NewOperation/NewRemoteOperation in the 'magical' version. | 21:55 |
| wpk | (in HEAD they changed Operation/RemoteOperation to be interfaces | 21:56 |
| thumper | hmm.. | 22:13 |
| wpk | thumper: a very ugly but very effective solution would be to disable those tests for now | 22:20 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!