[01:25] <mup> PR snapd#5000 closed: errtracker: make TestJournalErrorSilentError work on gccgo <Critical> <Created by mvo5> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/5000>
[05:13] <zyga> Caelum: yeah, I'll ask for that now
[05:15] <mborzecki> morning
[05:16] <Caelum> zyga: ideally they'd have a nightly cron job or something
[05:16] <zyga> I just asked, not sure how it is set up
[05:16] <zyga> And we have another point release of snapd
[05:16] <Caelum> nice
[05:17] <zyga> I will prepare the build
[05:17] <zyga> And maybe, just maybe, work on features again
[05:17] <zyga> This week was tough
[05:18] <zyga> Useful, fantastic bug fixes, but tough
[06:21] <zyga> I have updated https://github.com/snapcore/snapd/releases/tag/2.32.3
[06:22] <zyga> Caelum: do you want to update the package to 2.32.3?
[07:14] <kalikiana> good morning
[07:22] <Caelum> zyga: sure I'll give it a go
[07:22] <zyga> thank you!
[07:24] <mup> PR snapd#4998 closed: release: 2.32.3 <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4998>
[07:27] <pstolowski> mornings
[07:30] <zyga> hey pawel
[07:30] <Caelum> I figured out how to make my laptop not shutoff randomly so that should help
[07:36] <mborzecki> zyga: i left one comment in #4996
[07:36] <mup> PR #4996: overlord/ifacestate: store and use revision with security profiles set <Created by zyga> <https://github.com/snapcore/snapd/pull/4996>
[07:36] <zyga> thanks
[07:36] <mborzecki> otherwise looks sane to me
[07:40] <zyga> fixed
[07:40] <zyga> the formatting
[07:40] <zyga> is the error really a problem?
[07:41] <mborzecki> zyga: it is in if/then/else block, the thing is if Get() fails, the err will be swallowed up, don't know if that's intended (maybe it is?)
[07:43] <zyga> which err is swallowed?
[07:43] <zyga> the one from Get or the one from setup affected tasks
[07:43] <mborzecki> zyga: one in line 206
[07:43] <zyga> the Get one is deliberate
[07:43] <zyga> yes
[07:43] <mborzecki> aah ok then
[07:43] <zyga> we don't want to err n that
[07:44] <zyga> ah
[07:44] <zyga> I misunderstood your comment then
[07:45] <mborzecki> all clear now
[07:45] <Caelum> zyga: do you know if we still even need the libtool patch?
[07:46] <zyga> I suspect it is needed
[07:46] <zyga> because there's some build flags that get injected in some odd way I don't understand
[07:46] <zyga> we will simplify the C build system soon
[07:46] <zyga> drop auto mess
[07:46] <zyga> and remove more (all) conditionals
[07:47] <Caelum> cool
[08:10] <zyga> popey: I reverted irccloud-desktop on my system as the latest revision is not working
[08:10] <zyga> revision 25 is ok
[08:10] <zyga> 41 doesn't start
[08:12] <popey> This is because you reverted snapd
[08:12] <popey> 2.31 breaks irccloud
[08:12] <popey> 2.32 fixes it.
[08:13] <popey> When will 2.32 come back to stable? (You could get core from beta to work around)
[08:17] <zyga> I see
[08:17] <zyga> I think next week
[08:17] <zyga> but I don't know for sure
[08:17] <zyga> we just released a new beta
[08:22] <tomwardill> i got core from beta due to the nvidia fixes, can confirm irccloud-desktop works
[08:23] <tomwardill> also the font issue I had in irccloud-desktop with twitter previews appears to have gone away, so thanks whoever fixed that! :)
[08:24] <popey> zyga: it broke other applications too, ones we were waiting for 2.32 for. Quite frustrating as I'm now being pinged everywhere that my applications are all broken
[08:25] <zyga> do you know which feature missing in 2.31 is key?
[08:25] <zyga> I hope we can update to 2.32.3
[08:26] <popey> It's the new stuff from jd strand to turn kernel errors into warnings.
[08:26] <popey> things that request process-control or try to chmod files break
[08:26] <popey> so games break, nodejs applications break. we waited for 2.32 before releasing them and making a splash, now we have to go and clear up that mess
[08:34] <Skuggen> I'm struggling a bit with updating an older snap (mysql). Paths for various library files and binaries are no longer loaded by default. Do I need to manually specify every path to LD_LIBRARY_PATH?
[08:34] <Skuggen> (snapcraft 2.39.2)
[08:36] <Chipaca> Skuggen: you're updating _the_ mysql snap?
[08:36] <Chipaca> Skuggen: or a snap that uses mysql?
[08:37] <pedronis> popey: 2.32 broke people doing snap install lxd though
[08:37] <Skuggen> Chipaca: The mysql snap
[08:37] <Chipaca> Skuggen: nice :-)
[08:37] <popey> Sure. I understand there was an issue. But we got a "surprise, we broke your apps to fix someone elses"
[08:37] <popey> I would like for there to be an incident report for this. Why was this not caught in QA?
[08:38] <pedronis> because basically    snap install lxd  only exercise core once its in stable
[08:38] <pedronis> we need to find a way to test that before
[08:38] <Skuggen> Chipaca: We were blocked by various missing features (privilege dropping, setting file ownership, etc.) so haven't looked at it for a while. I'm working on getting it updated so we can see what might still be missing for us to properly support it
[08:39] <Caelum> zyga: any new data files in .32 I should know about?
[08:39] <Chipaca> Skuggen: daemons still only run as root, that hasn't changed
[08:39] <Chipaca> fwiw
[08:39] <pedronis> popey: about  an IR, that's fair,  mvo should look into that
[08:40] <popey> Thanks
[08:44] <Skuggen> Chipaca: Yeah, that is an issue. We could have some limited support of it even so, though. But first I need to actually get it working again :)
[08:44] <Chipaca> :)
[08:44] <Chipaca> Skuggen: just the other day somebody was asking about using mysql in a snap, fwiw (via embedding), and looked at the mysql snap as an example
[08:45] <Chipaca> (and then looked away in haste)
[08:45] <Chipaca> Skuggen: https://forum.snapcraft.io/t/mysql-server/4877
[08:45] <Chipaca> just yesterday, in fact
[08:45] <zyga> Caelum: no, it's all the same
[08:46] <Caelum> awesome
[08:47] <Caelum> I need to redo it at some point to do a make install on data
[08:47] <Skuggen> Chipaca: Ah, can respond to that at least :)
[08:48] <Chipaca> Skuggen: do you know what version of snapcraft you used to build the snap before?
[08:49] <Skuggen> Hm, can you get that information from the snap itself?
[08:50] <Chipaca> Skuggen: I don't think you can
[08:50]  * Chipaca is not a snapcraft expert though
[08:50] <Chipaca> kalikiana: snapcraft doesn't record its version in the snap in any way, does it?
[08:51] <Skuggen> We used a xenial host, but don't know what version it had at the time
[08:52] <Skuggen> Submission date
[08:52] <Skuggen> 2017-01-27 08:18 - 1 year, 2 months ago
[08:52] <Skuggen> Oold
[08:52] <Skuggen> That's the one on the store
[08:54] <Chipaca> Skuggen: and the one in the 'latest' track is even older, 2016-12-19
[08:54] <Chipaca> that's latest/beta
[08:54] <zyga> Caelum: and I heard the install instructions are now live
[08:55] <Caelum> indeed they are, fantastic
[08:57] <Chipaca> popey: do you know if there's a guide or knowledge base or sth to update a snap that was created using snapcraft in the pleistocene?
[09:00] <Caelum> zyga: /usr/lib/udev/snappy-app-dev is gone, do we drop it or add it as a source
[09:00] <popey> Chipaca: wat
[09:00] <zyga> I think we want to copy snap-device-helper over as snappy-app-dev
[09:00] <zyga> Caelum: I think that's what we do for now, as there are still some transition complexities
[09:01] <kalikiana> Chipaca: Nope. Though you can use SNAPCRAFT_BUILD_INFO=1 to have it record manifest.yaml which contains Debian packages and snaps installed during the build.
[09:01] <kalikiana> And therefore indirectly Snapcraft's versions or revision
[09:01] <Caelum> zyga: got it
[09:01] <Chipaca> kalikiana: popey: Skuggen here is tasked with updating the mysql snap, and the newest revision is over a year old, and the snapcraft.yaml no longer works, and they don't know what snapcraft it was built with
[09:02] <Skuggen> Might be simplest to start over; It's not super complicated, but contains extra binaries and libraries that are accessed by shell scripts (to replicate some of the install logic of the regular deb packages so users don't need to manually initialize databases and such)
[09:02] <Chipaca> Skuggen: possibly, snapcraft's changed a lot, although i'm surprised a snap stopped building entirely (i thought it had tests for that)
[09:02] <Skuggen> e.g. I got it to build, but it has issues finding things like the libaio1.so we include
[09:02] <popey> Ah, understood.
[09:03] <kalikiana> Right. If the existing snap doesn't contain manifest.yaml I'm afraid that information won't be available.
[09:03] <Chipaca> Skuggen: so, that's one thing to do: for your future self, make sure SNAPCRAFT_BUILD_INFO=1 is set in the build environment
[09:03] <Chipaca> Skuggen: so you can answer 'what was this built with'
[09:04] <popey> Skuggen: I'm a touch busy today, but I think if you pasted the yaml in the forum we could mobilise some people to look
[09:05] <Chipaca> kalikiana: wait, can you drop SNAPCRAFT_BUILD_INFO into the snapcraft.yaml itself?
[09:05] <Skuggen> popey: Can do that, sure. Thanks
[09:06] <kalikiana> Chipaca: No, it's an envrionment variable.
[09:06] <Chipaca> kalikiana: and the environment: section of snapcraft.yaml is passed through to the snap, not acted on?
[09:06] <Chipaca> i thought it influenced the build
[09:08] <kalikiana> Chipaca: Right, those don't actually affect what Snapcraft will look at
[09:14] <Caelum> zyga: this test fails completely randomly on me, usually it passes but sometimes I get this: https://gist.github.com/rkitover/460ebe31c6bc3d7508ff584d505cdbce
[09:14] <zyga> hmmm
[09:14] <zyga> feels like a timing racy test
[09:16] <pedronis> those tests use settle
[09:16] <pedronis> so it's probably deeper
[09:16] <pedronis> a bit hard to tell from that error though
[09:22] <zyga> Caelum: has that happened before?
[09:22] <zyga> I suspect it's not new to this release
[09:38] <Chipaca> zyga: question about your lab
[09:38] <zyga> yes sir?
[09:38] <Chipaca> zyga: do you have an nfs mount in there
[09:38] <zyga> no, I'm afraid I don't
[09:38] <zyga> but it could be arranged
[09:38] <zyga> the pi3-1 machine has a HDD and we could arrange for NFS export there
[09:39] <zyga> do you want one on the ppc box or somewhere else? (client side)
[09:39] <Chipaca> zyga: I don't mind the arch for this
[09:40] <Chipaca> just need nfs
[09:40] <zyga> sure,
[09:40] <Chipaca> zyga: but if it's not set up i can probably do something at home instead
[09:40] <zyga> Chipaca: I just installed nfs server on pi3-1
[09:40] <zyga> can you ssh there?
[09:40] <Chipaca> i can
[09:40] <zyga> now it's just a matter of exporting something
[09:41] <Chipaca> zyga: I can't sudo there though
[09:41] <zyga> oh
[09:41] <zyga> let me fix that
[09:41] <Chipaca> zyga: because the password i have for the others doesn't work there
[09:41] <zyga> Chipaca: reset your password to your username and gave you sudo
[09:42] <zyga> feel free to export /home or something you want
[09:42] <zyga> I can stick another device if you want really networked NFS
[09:42] <zyga> I have a few more PIs and beagles
[09:43] <Chipaca> zyga: thanks
[09:45] <mborzecki> bash: line 3: cannot create temp file for here-document: No space left on device <--- 2018-04-06 11:42:41 Error preparing google:ubuntu-16.04-32:tests/main/
[09:45] <zyga> who used all the space? :)
[09:45] <Chipaca> hue hue hue
[09:45]  * Chipaca laughs in brazilian
[09:48] <pedronis> is resizing broken?
[09:48] <Caelum> zyga: yes it happened with .31 too
[09:49] <mup> PR snapd#4986 closed: snapstate: fix `snap refresh --amend` when the snap is not available in stable <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4986>
[09:49] <pedronis> zyga:  blargh
[09:49] <zyga> what's wrong?
[09:49] <pedronis> we don't want that fix
[09:49] <zyga> oh?!
[09:49] <pedronis> because is going to conflict with the new code
[09:49] <zyga> sorry, I can revert taht
[09:49] <pedronis> that just works
[09:50] <zyga> no worries, it's a revert away
[09:50] <pedronis> I'm going to merge 4900 today, once it's green
[09:50] <pedronis> it should have been marked blocked
[09:50] <pedronis> but lots of stuff going on yesterday
[09:51] <zyga> https://github.com/snapcore/snapd/pull/5001
[09:51] <mup> PR #5001: Revert "snapstate: fix `snap refresh --amend` when the snap is not av… <Created by zyga> <https://github.com/snapcore/snapd/pull/5001>
[09:52] <mup> PR snapd#5001 opened: Revert "snapstate: fix `snap refresh --amend` when the snap is not av… <Created by zyga> <https://github.com/snapcore/snapd/pull/5001>
[09:53] <zyga> pedronis: can you do a review of https://github.com/snapcore/snapd/pull/4996
[09:53] <mup> PR #4996: overlord/ifacestate: store and use revision with security profiles set <Created by zyga> <https://github.com/snapcore/snapd/pull/4996>
[09:53] <zyga> and I guess we want to add gustavo to review list
[09:54] <pedronis> not sure I get to it today, more likely monday
[10:02] <Caelum> zyga: request sent
[10:02] <zyga> thanks, looking
[10:04] <zyga> i forgot the details but fair that symlink must be a real cop
[10:04] <zyga> copy
[10:05] <zyga> otherwise +1
[10:16] <Caelum> sure, one moment
[10:17] <Chipaca> mborzecki: setre[ug]id works \o/
[10:17] <mborzecki> Chipaca: yay :)
[10:17] <Chipaca> mborzecki: yes =)
[10:18] <mup> PR snapcraft#2053 opened: meta: implement pass-through of properties to snap.yaml <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/2053>
[10:18] <mborzecki> Chipaca: nfs too?
[10:18] <Chipaca> mborzecki: that's what i was testing =)
[10:20] <mborzecki> Chipaca: great, so we can kill #4990 now
[10:20] <mup> PR #4990: many: implement a poor man's privileges drop, use for auth.json <Created by chipaca> <https://github.com/snapcore/snapd/pull/4990>
[10:20] <Chipaca> mborzecki: with extreme prejudice
[10:20] <mborzecki> haha :)
[10:21] <kalikiana> greyback: I reckon you might wanna take a peek at snapcraft#2053 as you expressed your interest in the forum
[10:21] <mup> PR snapcraft#2053: meta: implement pass-through of properties to snap.yaml <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/2053>
[10:21] <Chipaca> mborzecki: I'll tweak the code to retry a couple of times on EAGAIN before panic'ing
[10:21] <Chipaca> mborzecki: as we've learned that EAGAIN happens =)
[10:22] <Chipaca> mborzecki: also might as well move Sete[ug]id to sys
[10:22] <Chipaca> mborzecki: thank you again for reminding me about this =)
[10:24] <mup> PR snapd#4990 closed: many: implement a poor man's privileges drop, use for auth.json <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/4990>
[10:24] <mup> PR snapd#4983 opened: osutil/sys, client: add sys.RunAsUidGid, use it for auth.json <Created by chipaca> <https://github.com/snapcore/snapd/pull/4983>
[10:25] <Caelum> zyga: fixed
[10:25] <zyga> thank you, looking
[10:26] <zyga> and sorry I didn't mention this
[10:26] <Caelum> you did say copy over
[10:26] <zyga> yes but I wasn't clear it is important :)
[10:26] <zyga> thank you for the work, it should be out soon :)
[10:27] <Caelum> nice
[10:29] <pstolowski> zyga: i've updated the tests of #4968 ; that got me thinking a bit about the old code of ubuntu-core -> core migration that's executed on startup; I remove stale connections *after* all the renaming in initialize. that's ok isn't it?
[10:29] <mup> PR #4968: RFC: ifacemgr: remove stale connections on startup <Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/4968>
[10:29] <zyga> interesting
[10:29]  * zyga thinks
[10:30] <pstolowski> zyga: question is if the core snap is alrady under new name, or is there a risk of considering the renamed connections "stale"
[10:31] <pstolowski> it's hard to reason about this based on unit tests
[10:32] <zyga> the transition is a task
[10:32] <zyga> it's not instant
[10:33] <pstolowski> zyga: right. but the renaming of conns happens on snapmgr init
[10:33] <pstolowski> zyga: so it kicks inafter re-exec, so we have new snap at hand correct?
[10:34] <zyga> yes
[10:34] <zyga> well, remember the is a version of this code that runs on ubuntu-core
[10:34] <zyga> that's not as up-to-date
[10:36] <zyga> I think this is ok
[10:36] <zyga> but more than happy we didn't do it earlier
[10:44] <zyga> pedronis: can you please merge https://github.com/snapcore/snapd/pull/5001
[10:44] <mup> PR #5001: Revert "snapstate: fix `snap refresh --amend` when the snap is not av… <Created by zyga> <https://github.com/snapcore/snapd/pull/5001>
[10:46] <popey> I have reverted back to core stable and now I get this when launching snaps:- failed to create prefix path: /tmp/snap.rootfs_M8USmi/var/lib/snapd/lib/vulkan/icd.d: Permission denied
[10:46] <zyga> popey: that's fixed in beta
[10:46] <zyga> stable is stable but buggy
[10:46] <popey> yeah, i am trying to use stable because that's what normal people use
[10:47] <zyga> I think this will be fixed once beta promotes
[10:47] <popey> we're lining up snaps to promote on the social media, but I can't tell what will and won't work for users
[10:47] <zyga> it's a bad week
[10:47] <zyga> we have nothing better
[10:47] <popey> ok
[10:47] <zyga> beta is most stable IMO
[10:47] <zyga> (today)
[10:59] <mup> PR snapd#5001 closed: Revert "snapstate: fix `snap refresh --amend` when the snap is not av… <Created by zyga> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/5001>
[10:59] <pedronis> zyga: done, thanks
[11:00] <zyga> thank you
[11:00] <pedronis> trying to get #4900 to green again and then will merge it
[11:00] <mup> PR #4900: many: use the new install/refresh API by switching snapstate to use store.SnapAction <Blocked> <Critical> <Squash-merge> <Created by pedronis> <https://github.com/snapcore/snapd/pull/4900>
[11:00] <pedronis> and prepare the backport, but the backport  is probably to merge once .3 is in stable
[11:00] <pedronis> and then we can do a .4 in beta
[11:00] <zyga> the backport will be for 2.32.4?
[11:00] <pedronis> yes
[11:01] <pedronis> thats' what I discussed with mvo
[11:01] <zyga> ack
[11:39] <zyga> are we doing standup at 14:00 or 15:00?
[11:39] <zyga> I need to leave in 40 minutes to go to school
[11:40] <mborzecki> 3pm i presume
[11:42] <mborzecki> heh, amazon linux 2 is 64bit only, they don't provide any *.i686 libs
[11:43] <mborzecki> this makes one of our unit tests to fail https://paste.ubuntu.com/p/JyqX9Wh9Rw/
[11:47] <pedronis> we should really add some sort of skip logic to that test
[11:47] <pedronis> it also fails if you don't have the right deps
[11:47] <pedronis> installed
[11:50] <Chipaca> it also fails if you try to run it on a banana
[11:50] <Chipaca> ¯\_(ツ)_/¯
[11:50]  * Chipaca is full of ¯\_(ツ)_/¯ today
[11:51] <pedronis> Chipaca: let put it this way, as written is not very friendly to porting to random other distro
[11:54] <Chipaca> pedronis: tbh i'm surprised multilib works at all
[11:54] <Chipaca> cross-distro i mean
[11:54] <Chipaca> but, yes, agreed
[11:54] <Chipaca> i'm being somewhat facetious
[11:56] <zyga> I need to go AFK
[11:56] <zyga> see you at the standup, from the phone
[11:57] <mup> Bug #1761253 changed: Installing a network-bind snap along with core fails results in incorrect permissions <Snappy:Fix Released> <https://launchpad.net/bugs/1761253>
[11:57] <zyga> Caelum: approved, it's out :)
[12:03] <mup> PR snapd#4900 closed: many: use the new install/refresh API by switching snapstate to use store.SnapAction <Critical> <Squash-merge> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/4900>
[12:18] <Caelum> sweet!
[12:20]  * cachio afk
[12:22] <mup> PR snapd#5002 opened: many: use the new install/refresh API by switching snapstate to use store.SnapAction <Critical> <Created by pedronis> <https://github.com/snapcore/snapd/pull/5002>
[12:38] <Chipaca> mborzecki: #4983 is green and happy as a bean
[12:38] <mup> PR #4983: osutil/sys, client: add sys.RunAsUidGid, use it for auth.json <Created by chipaca> <https://github.com/snapcore/snapd/pull/4983>
[12:39]  * kalikiana lunch
[13:02] <pstolowski> Chipaca: standup?
[13:03] <Chipaca> pstolowski: yeah, was jiggering my camera
[13:04] <mup> PR snapd#5003 opened: cmd/snap-seccomp: graceful handling of non-multilib host <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5003>
[13:11] <eraserpencil> Hey guys! are snaps able to work with USB and serial devices well?
[13:12] <Chipaca> eraserpencil: yes :)
[13:12] <eraserpencil> thanks!
[13:12] <Chipaca> eraserpencil: only issue might be if it's a new flavour of serial, as they're whitelisted
[13:12] <Chipaca> ie if you start having /dev/ttyFunky0, it'll need a patch
[13:13] <Chipaca> (although that one in particular might not =) )
[13:13] <eraserpencil> nice
[13:14] <eraserpencil> like erm communicate with multiple USB ports and one serial connection whilst having web servers and processing algorithms?
[13:14] <eraserpencil> I'm looking at the ROS-Snap tutorial, not sure what the limits of snaps are
[13:23] <Chipaca> eraserpencil: probably a kyrofa question
[13:30] <pedronis> cachio: now I see, the issue is that secrets are encrypted per repository, you cannot reuse a snapd secret for snapd-cron
[13:31] <cachio> ahh
[13:31] <cachio> pedronis, that makes sense
[13:31] <pedronis> cachio: I'm not sure how gustavo created the key for snapd, but  we need to rencrypt it for snapd-cron, or create a new one and encrypt
[13:32] <pedronis> cachio: probably need to discuss with him
[13:32] <cachio> pedronis, yes, I'll wait until next week
[13:34] <zyga> pedronis, cachio: yes, I bumped into that as well
[13:34] <kalikiana> re
[13:34] <zyga> this prevents people from copy-pasting secrets around
[13:34] <zyga> but if you know the decrypted secret you can easily re-encrypt it and add it via travis
[13:35] <pedronis> yea, but we don't
[13:51] <eraserpencil> Chipaca: whats a kyrofa question
[13:52] <Chipaca> eraserpencil: 'multiple USB ports and one serial connection', in the context of ROS
[13:52] <Chipaca> eraserpencil: I see ROS, I defer to the kyrofa
[13:52] <Chipaca> :-)
[13:53] <mborzecki> off to pick up the kids
[13:59] <jdstrand> roadmr: hi! can you pull in r1018? (just a few more overrides)
[13:59] <roadmr> jdstrand: absolutely. Here I go!
[14:00] <jdstrand> roadmr: thanks! :)
[14:03] <zyga> jdstrand: hey
[14:08] <jdstrand> zyga: hi!
[14:09] <jdstrand> roadmr: fyi, snapcraft 2.40 is now in stable and -updates everwhere. this is what we were waiting on for the resquash tests. in the coming weeks I'm going to request an isolated pull to turn on enforcement
[14:10] <jdstrand> roadmr: we'll want to keep an eye on it though in case we want to back it out
[14:10] <roadmr> jdstrand: ok. How do we turn it on? set an env var?
[14:10] <jdstrand> roadmr: today, that is how. I'm going to flip the logic for that
[14:11] <jdstrand> and request a pull
[14:11] <roadmr> jdstrand: oh understood. Think we should put that behind a feature flag so we can have a panic switch in case it all goes awry?
[14:12] <jdstrand> roadmr: how do you envision implementing that? I figured that was what the env var would do
[14:15] <zyga> jdstrand: I'd like to deconflict and merge https://github.com/snapcore/snapd/pull/4868
[14:15] <mup> PR #4868: cmd/snap-update-ns: add secure bind mount implementation for use with user mounts <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/4868>
[14:15] <zyga> it's already reviewed just FYI
[14:15] <zyga> I picked up user mounts
[14:15] <zyga> expect useful stuff on ~Tuesday
[14:15] <jdstrand> zyga: well, it needs an additional comment
[14:16]  * zyga -> cooking
[14:16] <jdstrand> 4868
[14:16] <jdstrand> I owe the PR a response. I plan to do that today
[14:16] <zyga> aha
[14:16] <zyga> I will look for your response then
[14:16] <jdstrand> codewise it is fine. james and I disagreed on the phrasing of a comment
[14:17] <jdstrand> (a comment I suggested, so it wasn't added)
[14:17] <roadmr> jdstrand: yes but how do we set/unset the env var in the store? a feature switch is a thingy we can flip on/off in the django admin and that controls stuff in the code
[14:18] <roadmr> jdstrand: so something like if is_set('the_flag'): os.environ['RESQUASH_CHECK'] = "true"
[14:18] <roadmr> jdstrand: because otherwise, if we need to switch this on quickly, we'd need a redeploy or something
[14:18] <roadmr> s/on/off/
[14:18] <jdstrand> roadmr: ok, I wasn't sure where you wanted the feature
[14:18] <roadmr> jdstrand: well no matter, let me ponder and we'll implement this if needed
[14:19] <roadmr> jdstrand: I mean - it's fine that the tools themselves have a way to control this, but remember this lives on a production server where I have no direct access
[14:19] <jdstrand> roadmr: I think it sounds like a nice idea. the worst that can happen is things end up in manual review. but, that could be a big number so being able to stop the bleeding quickly would be good
[14:19] <roadmr> so I can't easily e.g. ssh in and set/unset that variable in /etc/environment
[14:19] <roadmr> jdstrand: ok so I'll look into doing that then
[14:20] <jdstrand> obviously tyhicks and I believe that things are all worked out, but, you never know :)
[14:22] <jdstrand> zyga: I was confused. the comment I owe is in pr 4957
[14:22] <mup> PR #4957: cmd/snap-update-ns: remove the need for stash directory in secure bind mount implementation <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/4957>
[14:23] <zyga> ahh
[14:23] <zyga> ok
[14:23]  * Chipaca hears rumours of cake and goes forth
[14:23] <jdstrand> also, the code in 4957 is also ok
[14:24] <jdstrand> I'll add my response to that so you can consider it too
[14:26] <jdstrand> zyga: what is the 'squash-merge' label?
[14:29] <Chipaca> jdstrand: PRs that are to be cherry-picked should be squashed before merging
[14:29] <Chipaca> jdstrand: so it's just the one cherry
[14:29] <jdstrand> Chipaca: does that remove all the comments/etc/etc that are in github?
[14:30] <Chipaca> jdstrand: not the comments on github, but it replaces all the commits with one (the default commit message is a summary of the commits it's squashing)
[14:30] <jdstrand> Chipaca: eg, for a commit that ends up squashed? it would be a shame if there was a ton of discussion on a particular point, then we resquash and it goes *poof*
[14:31] <jdstrand> I feel like this has happened in the past...
[14:31] <Chipaca> jdstrand: it only affects the git history, not the github discussion
[14:32] <jdstrand> interesting. since the git hub discussion is hidden based on certain commits
[14:32] <jdstrand> ok, well, if it is not supposed to remove anything, cool
[14:33] <Chipaca> jdstrand: do you have an example of a hidden discussion?
[14:35] <Chipaca> (that is, i'll admit, a bit like asking "can you show me what was stolen")
[14:36] <zyga> jdstrand: it's not really hiding it
[14:41] <pedronis> it's not something that happens to the PR, it happens on master
[14:42] <zyga> jdstrand: I merged master into 4868
[14:44] <zyga> jdstrand: if you want to make some comment changes please go ahead
[15:04]  * zyga is happy that latest core build is really just new snapd
[15:07] <cwayne> Me too :)
[15:16] <Chipaca> zyga: note #4999 is now green
[15:16] <mup> PR #4999: advisor: use json for package database <Created by mvo5> <https://github.com/snapcore/snapd/pull/4999>
[15:18] <zyga> thanks, looking
[15:47]  * Chipaca off for a while
[15:47] <Chipaca> have a good weekend all, if i don't see you before your eow
[15:48] <jdstrand> popey: btw, that request for a review tools sync has the emoj override
[15:48] <jdstrand> ^
[15:50] <popey> thanks!
[15:50] <popey> cjwatson: https://launchpadlibrarian.net/363464768/buildlog_snap_ubuntu_xenial_armhf_b69a088aa70edd446e36c2072b30e222-xenial_BUILDING.txt.gz
[15:51] <popey> something odd going on with this build - it's looping over a couple of files
[15:51] <popey> (giant log file, note)
[15:58] <popey> Wondered if this was something broken at the launchpad end as the yaml seems fine to me.
[15:58] <cjwatson> popey: is there any particular reason to believe it's a problem with LP rather than snapcraft?
[15:58] <popey> fair point, I'd just never seen that happen before.
[15:58] <cjwatson> popey: it would be pretty unusual for that to be caused by LP.
[15:58] <popey> Hmph. Ok. will dig more.
[15:59] <cjwatson> node-pre-gyp ERR! Tried to download(404): https://github.com/kelektiv/node.bcrypt.js/releases/download/v1.0.3/bcrypt_lib-v1.0.3-node-v57-linux-arm.tar.gz
[15:59] <cjwatson> node-pre-gyp ERR! Pre-built binaries not found for bcrypt@1.0.3 and node@8.11.1 (node-v57 ABI) (falling back to source compile with node-gyp)
[15:59] <cjwatson> so it's probably just failing to pass proxy parameters to some bit of the build.
[16:00] <popey> ah that url is 404
[16:00] <cjwatson> (unless it's a real 404, which it could be.  but there's an "undefined" error earlier.)
[16:00] <cjwatson> and then it loses its mind for many thousands of lines.
[16:01] <popey> ahh that project has no armhf builds.
[16:01] <popey> sorry for the noise.
[16:23] <mup> Issue snapcraft#1886 closed: Support for yarn --extra-args <bug> <Created by sergiusens> <Closed by kyrofa> <https://github.com/snapcore/snapcraft/issue/1886>
[16:23]  * zyga -> shopping, ttyl
[16:50] <mup> PR snapcraft#2054 opened: tests: extract sources suite from general suite <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/2054>
[16:56] <popey> jdstrand: will you have time today to sort the aliases for ruby please?
[16:56] <mup> PR snapcraft#2055 opened: python: bring back support for older versions of pip <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/2055>
[17:07]  * kalikiana wrapping up for the week
[17:22] <jdstrand> popey: I can, sure. 7 days haven't passed...
[18:39] <mup> PR snapd#5004 opened: daemon,overlord/hookstate: stop/wait for running hooks before closing the snapctl socket <Created by pedronis> <https://github.com/snapcore/snapd/pull/5004>
[18:41] <mup> PR snapd#5005 opened: interfaces/hostname-control: allow setting the hostname via syscall and systemd <Created by jdstrand> <https://github.com/snapcore/snapd/pull/5005>
[19:08] <mup> PR snapd#5006 opened: interfaces: misc updates for default, firewall-control, fuse-support and process-control <Created by jdstrand> <https://github.com/snapcore/snapd/pull/5006>
[19:15] <mup> PR snapd#5007 opened: interfaces/desktop-legacy: allow access to gnome-shell screenshot/screencast <Created by jdstrand> <https://github.com/snapcore/snapd/pull/5007>
[19:17] <mup> PR snapd#5007 closed: interfaces/desktop-legacy: allow access to gnome-shell screenshot/screencast <Created by jdstrand> <Closed by jdstrand> <https://github.com/snapcore/snapd/pull/5007>
[19:24] <mup> PR snapd#5008 opened: interfaces: misc updates for default, firewall-control, fuse-support and process-control - 2.32 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/5008>
[19:57] <mup> PR snapcraft#2054 closed: tests: extract sources suite from general suite <Created by kyrofa> <Merged by kyrofa> <https://github.com/snapcore/snapcraft/pull/2054>
[20:21] <mup> PR snapcraft#2056 opened: Fix formatting of some store errors <Created by cjwatson> <https://github.com/snapcore/snapcraft/pull/2056>
[23:58] <mup> Issue snapcraft#1673 closed: Add pre-stage/stage/post-stage <Created by sergiusens> <Closed by kyrofa> <https://github.com/snapcore/snapcraft/issue/1673>
[23:58] <mup> PR snapcraft#2049 closed: many: add override-stage scriptlet <Created by kyrofa> <Merged by kyrofa> <https://github.com/snapcore/snapcraft/pull/2049>