[00:00] <bluesabre> Smaller future diffs that way
[00:05] <ali1234> after the vacuum there are 114 instances of the target colour
[00:06] <ali1234> some files still have multiple copies :(
[00:08] <ali1234> ah, some of this are not the same gradient at all
[00:45] <ali1234> this should be a list of every svg which has a linear gradient with exactly two stops, and both of those stops are #d7e866 or #8cab2a
[00:45] <ali1234> http://paste.ubuntu.com/p/9gqZH9dJ3Z/
[01:32] <bluesabre> All the arrows are there, so that's a good sign
[02:18] <Unit193> bluesabre: https://salsa.debian.org/dbnpolicy/policy/blob/master/policy/upgrading-checklist.rst#version-4-1-4
[07:14] <ochosi> ali1234: have you pushed your vacuumed stuff anywhere?
[07:14] <ochosi> if you want to, i can take a look and review later
[08:11] <jarnos> Hello, how can you change keyboard layout, when booting 18.04 ISO? In 14.04 
[08:58] <ali1234> ochosi: pushed to https://github.com/ali1234/elementary-xfce
[08:58] <ali1234> vacuum-defs and export-plain branches
[09:46] <ochosi> ali1234: any recommendations/feedback on the two branches..? shall i just "take a look" to see if i spot diffs? :p
[09:47] <ochosi> also, is it easier with either of the two branches to script the color-change?
[09:47] <ali1234> export-plain cleans out more stuff
[09:48] <ochosi> (without the latter benefit i think i'd postpone the vacuum stuff for post 18.04)
[09:48] <ali1234> it probably isn't any easier
[09:49] <knome> otoh, the package would then be "clean"
[09:57] <ochosi> knome: the package contains only pngs
[09:58] <ochosi> the git repo would be clean/er
[09:58] <ochosi> we convert and optipng everything anyway
[09:58] <ochosi> also because it's way faster than using svg-based themes
[10:00] <ali1234> where's the script to build pngs?
[10:00] <knome> ochosi, right
[10:00] <knome> ochosi, so why wait then?
[10:04] <ali1234> found it
[10:39] <ali1234> both of the branches produce byte-identical png files
[10:40] <ali1234> tested with http://paste.ubuntu.com/p/f2NtDMt6rP/
[10:40] <ali1234> all three directories are identical according to diff -Nur
[10:47] <bluesabre> Neat
[12:53] <flocculant> afternoon 
[15:07] <ochosi> ali1234: wanna file a PR on github? i'll go ahead and merge then and then we can continue considering a scripted conversion
[15:07] <ochosi> frankly even just adding the gradient to every file would help because thats otherwise a manual process
[15:07] <ochosi> so that would save me a lot of time
[15:08] <ochosi> and the old gradient would be kicked out by vacuuming anyway
[15:09] <ochosi> knome: i wanted to wait because i didnt want to have to manually check the output after the vacuuming. but if the png output is the same then that's not necessary anyway
[15:45] <willem> hi all, in testcases I'm asked to start "thunar". But in Xubuntu, in the whiskermenu, typing "thu..." thunar does not show up. I got in contact with the whiskermenu maintainer (https://bugzilla.xfce.org/show_bug.cgi?id=14326); he's looked into it, and now thinks it is something that should be reported at Xubuntu. I don't know against which package I need to report this issue; could anyone give me a pointer?
[15:46] <flocculant> that's really a testcase issue
[15:47] <flocculant> well - kind of - the reason you found it is at least, bluesabre ^^
[15:47] <willem> hmm, I don't know: when I open whisker and start typing "fire..." 
[15:48] <willem> ... yes, indeed, I found it thanks to a testcas
[15:48] <willem> but thunar should pop up if I start typing its name in whisker I think
[15:48] <flocculant> possibly a .desktop file
[15:49] <willem> I'd be happy to report this on launchpad, but I don't know against which package.
[15:49] <flocculant> we'll let sean see the ping first
[15:53] <willem> let's
[16:09] <ali1234> ochosi:  okay but which?
[16:23] <ali1234> i'm rerunning the vacuum now cos you added stuff...
[16:39] <ochosi> ali1234: if both produce bit-identical png output i'd go with the more stripped down version
[16:39] <ali1234> okay
[16:39] <ochosi> or with whatever elementary use, as its 'proven in use'
[16:39] <ali1234> same
[16:39] <ochosi> thought so
[16:40] <ali1234> i just hope it doesn't re-order all the attribs every time you run it
[16:40] <ali1234> that's possible if it uses unordered dicts
[16:40] <ali1234> or hash tables or whatever
[16:40] <ochosi> i'll add a local pre-commit hook
[16:40] <ochosi> so it'll happen automatically for all new/edited files
[16:42] <ochosi> i'm also considering to add a makefile that runs the svgtopng converter and then installs the icon theme
[16:42] <ochosi> for people who dont use the package or xubuntu as a wholr
[16:53] <ali1234> just going to run export-plain again on the previous output to check it doesn't change anything
[16:53] <ali1234> if it doesn't then i'm happy
[16:54] <ali1234> okay bad news
[16:55] <ali1234> export-plain shuffles the order of attributes every time you run it
[16:55] <ali1234> meaning every time you run it on a file, the entire file changes, even if you didn't change anything at all
[17:00] <ali1234> i will try a newer inkscape
[17:18] <ali1234> getting somewhere
[17:18] <ali1234> inkscape doesn't randomize the attributes, it always reverses their order
[17:19] <ali1234> so running it twice will cancel out the effect :)
[17:22] <flocculant> evening you two
[17:59] <ali1234> okay, megapatch incoming
[17:59] <ali1234> just need to run the png diff one more time
[18:00] <ali1234> passed :)
[18:03] <ali1234> PR sent
[18:37] <pleia2> all the sticker+note letters are ready to be sent out to our wallpaper winners \o/
[18:38] <pleia2> didn't do anything formal, but I did include a quick hand-written thank you
[18:44] <ochosi> ali1234: awesome, thanks! will review/merge later
[18:44] <ochosi> pleia: nice work!
[18:47] <flocculant> pleia2: thanks for doing that stuff
[18:47] <pleia2> np
[18:47] <flocculant> bluesabre: you might want to be aware of bug 1761593
[18:48] <flocculant> can't remember if you commented here about that 
[18:48] <flocculant> at the time it would have been against nvidia
[20:26] <Unit193> Thunar was accepted, of course.
[20:28] <ochosi> sweet
[20:28] <ochosi> ali1234: what a homungous commit :p
[20:29] <ali1234> it's 60% smaller than the previous version...
[20:30] <ochosi> hehe
[20:31] <ochosi> you still pushed yourself to #9 of the contributor list with this one commit :D
[20:32] <ochosi> and you have more deleted lines than me now
[20:33] <ochosi> so would you suggest to just run the whole inkscape command twice as pre-commit hook?
[20:33] <ali1234> it's the simplest thing to do
[20:33] <ali1234> the alternative is to use a totally different tool
[20:34] <ali1234> or try to get inkscape fixed
[20:34] <ali1234> since we're working to a deadline i'd say go with the simplest workaround for now
[20:34] <ochosi> sure
[20:34] <ochosi> i mean the pre-commit hook is not *essential* for getting the arrows fixed
[20:35] <ali1234> agreed
[20:35] <ali1234> changing to a different tool could mean another monster commit
[20:35] <ochosi> yeah
[20:35] <ochosi> i would stick to just "doing it twice"
[20:36] <ali1234> it's not that slow unless you are doing the whole file
[20:36] <ali1234> the whole repo i mean
[20:37] <ochosi> yeah
[20:37] <ochosi> i usually change not more than 10 icons per commit
[20:39] <ali1234> ou probably saw i sent an upstream bug report. probably best to just see what they do and copy it :)
[20:40] <ochosi> yup, true that :)
[20:52] <ochosi> knome: i would love for inkscape to throw a readable warning when things like "union" don't work...
[21:07] <ochosi> knome: also, this is a direction that elementary is considering currently (not really decided at all yet though) https://github.com/elementary/icons/blob/26fed9053f2731351f36fa1aebcc7f248012b0a0/places/128/folder-documents.svg
[21:36] <ochosi> ali1234: how do we best continue regarding the scripting? shall i convert a single arrow now manually as a sample so we see if it's doable?
[21:36] <ali1234> that would help actually
[21:36] <ali1234> i'm going to do it partially by hand
[21:42] <ochosi> craaaaap
[21:42] <ochosi> there's more to it than the gradient and stroke :(
[21:42] <ochosi> at least if i wanna do it properly
[21:47] <ochosi> ali1234: https://github.com/shimmerproject/elementary-xfce/commit/960ff154294826a96e3653d8c98fd19ba46b62f4
[21:48] <ochosi> these are the changes that need to be done
[21:49] <ochosi> craaap, should've pulled before i did the changes to clean up the diff
[21:52] <ali1234> well i can substitute all the linear gradients
[21:53] <ali1234> there's a whole new path in there?
[21:54] <ochosi> this is the rebased commit: https://github.com/shimmerproject/elementary-xfce/commit/7ef5bd97c92c7eb2399d1281524c08cc99bec180
[21:54] <ochosi> yeah, there is a "new" path
[21:54] <ochosi> the arrow is one path in the old icon
[21:54] <ochosi> fill + stroke
[21:54] <ochosi> for the new style, they have to be separated into two objects
[21:55] <ali1234> the one i looked at was already two parts
[21:55] <ochosi> so that the stroke can be 50% opacity and overlaying the fill
[21:55] <ali1234> hmm
[21:55] <ochosi> yeah, i just cleaned up the diff a little
[21:55] <ochosi> so it's more readable
[21:55] <ali1234> no i mean yesterday
[21:55] <ochosi> ah
[21:55] <ochosi> hm
[21:55] <ali1234> i'll do all the gradients and then we can look at what's left
[21:55] <ochosi> maybe not all of those arrows are consistnt
[21:55] <ochosi> awesome
[21:55] <ochosi> thanks a bunch for helping on this!
[21:56] <ochosi> gotta get some sleep now...