| thumper | veebers: is there something wrong with the merge bot? | 21:32 |
|---|---|---|
| veebers | thumper: not that I'm aware of, whats the issue/ | 21:32 |
| veebers | thumper: (which merge job?) | 21:32 |
| thumper | I was just looking at one of jam's branches | 21:33 |
| thumper | saw the merge request but no bot response | 21:33 |
| thumper | https://github.com/juju/juju/pull/8557 | 21:33 |
| veebers | thumper: it's possible it's the issue where the hook gets dropped or ignored by jenkins. | 21:33 |
| thumper | do the checks on a PR get cleared on new pushes? | 21:33 |
| veebers | thumper: checks get re-run on pushes. (you can see ticks/crosses beside the commit sha in the list) | 21:34 |
| thumper | I know that the merge jobs just show up as checks now... | 21:35 |
| thumper | perhaps it was just that | 21:35 |
| thumper | never mind me | 21:35 |
| veebers | thumper: If the merge bot had run it would have been merged, unless there was an issue then it would show as a failure | 21:35 |
| thumper | but we don't add a comment on failure, do we? | 21:36 |
| veebers | thumper: if you click "show all checks" you'll see that only the check-merge job has run | 21:36 |
| veebers | thumper: it would show up in the checks list | 21:36 |
| thumper | ah, found it | 21:37 |
| veebers | thumper: argh, so the merge job did run (before your current one) and went unstable, no idea why it didn't update the PR. :-\ Having a quick look now | 21:38 |
| thumper | ok, thanks | 21:38 |
| veebers | thumper: I'm a little confused :-\ jams merge command worked, it ran and failed and marked that commit broken (red cross) but it wasn't mentioned in the checks section. Jam then pushed up some . .. ah | 21:51 |
| veebers | thumper: It seems that pushing up a commit and getting a run on it clears any previous runs (incl. failures) so the updated push removed the check comment for the failed merge (it was still marked as error by the red cross though) | 21:51 |
| * veebers is no longer confused | 21:52 | |
| * thumper nods | 21:52 | |
| thumper | morning wallyworld | 21:57 |
| wallyworld | hey | 21:57 |
| thumper | veebers: do you use spacemacs with vim editing or emacs? | 21:57 |
| veebers | thumper: emacs | 22:08 |
| veebers | wallyworld: hey o/ | 22:08 |
| wallyworld | hiya | 22:08 |
| anastasiamac | o/ | 22:09 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!