[00:33] anastasiamac: review done, lgtm with some comments, see what you think [00:33] \o/ ta [00:34] wallyworld: btw, we've agreed that m changing the tests to use new .SupportedLts() too, right? :D [00:34] yeah [00:34] awesome [03:25] babbageclunk: if you can find 15 minutes before your EOD, would love a review today so that i can land this before my caas meeting tomorrow https://github.com/juju/juju/pull/8568 [03:28] anastasiamac: lts pr lgtm, tyvm [03:28] \o/ [03:35] wallyworld: yup, looking now [03:35] yay [03:46] wallyworld: are you free in about 25 minutes to talk through this white paper idea? [03:46] sure [03:46] cool [04:34] wallyworld: reviewed [04:34] great ty! [05:03] wallyworld: so our approach of supportedlts in juju/juju/version introduces cycle import... :( pondering whereelse to put it that makes sense... [05:05] ah, awesome [05:07] yep... if testing.BaseSuite was not in juju/juju/testing directly, everything'd b peachy... for real [05:29] wallyworld: so i have a cunning plan :) but i think i want to run it by u...lemme know when u have a chance :) [05:29] i am free [05:48] thumper/wallyworld - if you have a worker with a child worker (say it was added to the parent's catacomb in the Plan.Init list), can the child worker cause the parent to stop? [05:49] I'm not sure [05:49] babbageclunk: do you mean if it ends in an error? [05:49] if it errors, the parent will error also [05:49] unless [05:49] you set up a custom runner [05:49] and provide IsFatal [05:50] the catacomb doesn't have a runner does it? [05:50] thumper: no it doesn't - oh nice, thanks. [05:52] I think the problem is that at the moment the raft-transport worker makes a streamLayer (which is another worker) but doesn't add it to the raft-transport catacomb. [05:52] So I'm fixing that now. === frankban|afk is now known as frankban [07:57] manadart: do you mind if we move the oracle review back by 30min? that gives me time to have lunch every day instead of trying to squeeze it in [07:57] I'm looking at the gomock stuff now [07:57] jam: No problem. [08:12] wallyworld: 8567 was updated with func moved to juju/juju/juju as version... what do u think? it passes now, is ready for landing... [08:14] looking [08:16] anastasiamac: works for me [08:20] wallyworld: awesome \o/ i'll land it on 2.3 [08:36] manadart: https://pastebin.canonical.com/p/wrNMVKHRXg/ === salmankhan1 is now known as salmankhan === frankban is now known as frankban|afk [17:49] balloons: CI help please? if i run the command out side of CI it works, inside it fails?? https://pastebin.canonical.com/p/4WJkdkGsFf/ [18:09] hml, looking [18:12] hml, that looks more or less correct [18:13] hml, I would put a try block around the call, expect this error, and fail if something else happens [18:13] hml, subprocess isn't going to return cleanly because the remote just hangs up [18:15] balloons: I did have a try block around it… which just confirmed the timeout [18:15] balloons: what I don’t understand is why it’s timing out in one place, but not the other [18:15] balloons: in both cases the reboot happened [18:16] balloons: other things start failing then too… timing out [18:24] hml, I'm not sure I'm seeing what you are. [18:25] hml, yor paste just shows me a calledprocesserror when you run the reboot command. Off the cuff, that makes sense to me to expect [18:25] balloons: why? [18:26] hml, do you think the subprocess call is exiting cleanly? [18:26] my guess is it just hangs up because the host goes away [18:26] hence the error [18:27] hml, we might be able to tweak your call so it exits clean [18:27] balloons: hrm… perhaps. so, after this happens, i also get a timeout trying to run lsb_release -c on the host too [18:28] balloons: i was looking at that, then found the first timout of reboot [18:30] hml, so I was thinking of something like 'sudo shutdown -r 0 && exit' [18:31] hml, googling gave a slightly complex and interesting answer as well: 'nohup sudo halt &>/dev/null & exit' [18:31] balloons: will try [18:31] hml the goal is to tell the machine to reboot, but exit cleanly from the ssh command before it does so [18:33] nohup shutdown -r now & exit .. all variants on the same idea :p [18:35] balloons: && exit helped, can do lsb_release after… will try with try now [18:42] hml, ohh.. so clean exit? So no need to catch an error then [18:42] balloons: okay [18:42] make sense? [21:34] morning vino [21:52] hi vino! [21:53] Hi vino o/ [22:03] hey vino, you're in the staff directory now! [22:03] hi vino! [22:03] w00t [22:23] Hi Everyone! [23:17] babbageclunk: standup? [23:43] babbageclunk: would you have a link handy for the wiki/readme section re: running the mongo client on a juju machine to query the db? [23:45] thumper: do you need to add vino to our team on Trello before she can see our board? [23:46] babbageclunk: nvm I found it, I was blind. [23:46] veebers: sorry, was just finding it myself. I guess I didn't have it handy. [23:47] ^_^ [23:47] :) [23:49] thumper: and while u r looking at team members on trello, mayb some ppl need to be removed? :D [23:50] anastasiamac_: heh [23:50] ok [23:50] sorry was interviewing [23:50] :) m not sorry u were :D