| veebers | Morning all o/ | 20:36 |
|---|---|---|
| vino | Morning :) | 20:38 |
| veebers | Hey vino o/ How has your morning gone? I just had to call the insurance company because I broke the stovetop :-( | 21:07 |
| vino | Hey Veebers! I am good. Awake from 5:am this morning. | 21:14 |
| vino | Excellent its a good start for you :p | 21:14 |
| vino | Looks like u had a fun weekend | 21:15 |
| veebers | vino: hah that's earlier than me and I have a baby alarm clock ^_^ | 21:17 |
| veebers | thumper: going to propose http://paste.ubuntu.com/p/bPYQSpV5Kq/ to fix https://bugs.launchpad.net/juju/+bug/1745031 (finally). Wanted to add a test for ValidateFileAttrValue (none currently), seems either I need to write actual files or mock os.Stat to do so. I presume mocking os.Stat would be preferred? | 22:09 |
| mup | Bug #1745031: gce add credentials "Enter file" absolute path msg improvment <juju:Triaged by veebers> <https://launchpad.net/bugs/1745031> | 22:09 |
| thumper | or writing some creds to a temporary file | 22:11 |
| thumper | that would be preferable to mocking os.Stat | 22:11 |
| veebers | thumper: the function in question only deals with file paths, doesn't care about the content | 22:13 |
| thumper | write actual files | 22:13 |
| thumper | ioutil.WriteFile | 22:13 |
| veebers | thumper: also, juju add-credential google is happy with an empty json file, says "Credential "blah" added locally for cloud "google".: | 22:13 |
| veebers | thumper: ack, can do | 22:13 |
| thumper | veebers: that seems like a different validation bug for credentials :) | 22:14 |
| veebers | thumper: it does | 22:14 |
| thumper | veebers: are you almost ready to land the simple fix from Jan now? | 22:14 |
| thumper | heh | 22:14 |
| veebers | thumper: hah yeah ^_^ it's been a journey | 22:14 |
| * thumper goes back to his weaving of presence | 22:16 | |
| wallyworld | vino: standup? | 23:17 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!