[20:36] Morning all o/ [20:38] Morning :) [21:07] Hey vino o/ How has your morning gone? I just had to call the insurance company because I broke the stovetop :-( [21:14] Hey Veebers! I am good. Awake from 5:am this morning. [21:14] Excellent its a good start for you :p [21:15] Looks like u had a fun weekend [21:17] vino: hah that's earlier than me and I have a baby alarm clock ^_^ [22:09] thumper: going to propose http://paste.ubuntu.com/p/bPYQSpV5Kq/ to fix https://bugs.launchpad.net/juju/+bug/1745031 (finally). Wanted to add a test for ValidateFileAttrValue (none currently), seems either I need to write actual files or mock os.Stat to do so. I presume mocking os.Stat would be preferred? [22:09] Bug #1745031: gce add credentials "Enter file" absolute path msg improvment [22:11] or writing some creds to a temporary file [22:11] that would be preferable to mocking os.Stat [22:13] thumper: the function in question only deals with file paths, doesn't care about the content [22:13] write actual files [22:13] ioutil.WriteFile [22:13] thumper: also, juju add-credential google is happy with an empty json file, says "Credential "blah" added locally for cloud "google".: [22:13] thumper: ack, can do [22:14] veebers: that seems like a different validation bug for credentials :) [22:14] thumper: it does [22:14] veebers: are you almost ready to land the simple fix from Jan now? [22:14] heh [22:14] thumper: hah yeah ^_^ it's been a journey [22:16] * thumper goes back to his weaving of presence [23:17] vino: standup?