/srv/irclogs.ubuntu.com/2018/04/19/#snappy.txt

elopiojamespage: I was going to tell you that vault is on snapcrafters with some fancy (or hacky) stepped upgrade. But I see you have the latest commit there. Let me know if I can help.03:53
pbek_thank you for the link, popey04:10
pbek_I didn't make the mental connection from the issue page to the acutal page to edit the documentation sheet ;)04:11
mupPR snapcraft#1909 closed: dotnet plugin: add dotnet command to path and enable developer scenario for  snap <enhancement> <Created by rakeshsinghranchi> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1909>04:17
=== pbek_ is now known as pbek
pbekpopey: I created a pull request at https://github.com/canonical-docs/snappy-docs/pull/39004:18
mupPR canonical-docs/snappy-docs#390: added documentation for version-script <Created by pbek> <https://github.com/canonical-docs/snappy-docs/pull/390>04:18
mborzeckimorning05:04
zygagood morning :)05:06
mborzeckiwanted to try opensuse TW with snapd and nvidia last night, dd'ed gnome live image to usb stick, ran it, zypper dup'ed, installed snapd & NVIDIA (nvidia now maintains a repo with the packages!!) and got a hard lock up, most probably nvidia related :/05:10
zygauh, not fun05:19
mborzeckimy guess it's gdm trying to do wayland05:21
mborzeckiit locked up in plymouth screen, just when the tw infinity sign stopped spinning05:22
zygapedronis: updated https://github.com/snapcore/snapd/pull/506705:47
mupPR #5067: snap,tests : don't fail if we cannot stat MountFile <Created by zyga> <https://github.com/snapcore/snapd/pull/5067>05:47
jamespageelopio: hi - popey sorted me out with pertinent access yesterday afternoon - I think I'm all set now aside from some minor confusion around how build.snapcraft.io permissions work05:49
mborzeckizyga: left you a comment06:25
mborzeckibtw. somehow also managed to break polkit & gnome-shell agent06:27
mborzeckiwow, cannot remove the snap either06:28
zygamborzecki: Ack, looking06:41
zygaFin06:41
zygaFun06:41
zygaLooks like another fix on top06:41
mborzecki if anyone wants to give it a try, https://github.com/snapcore/snapd/pull/5034 is simple and easy review06:44
mupPR #5034: userd: set up journal logging streams for autostarted apps <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5034>06:44
mvozyga: I pushed a core18 PR, it does now show up in mup yet apparently06:56
mvoniemeyer: could you please add github.com/snapcore/core18 to the mup announcements?06:56
zygaack, looking06:58
zygamvo: are you sure about the security-policy-stamp?07:01
mvozyga: I can look again07:01
zygaI mean, I assume you looked07:01
mvozyga: the description is definitely wrong07:01
mvozyga: we don't have snappy policygen07:01
mvozyga: grep -r securtiy-policy-version over the entire image has no hit07:03
zygayeah, I'm doing the same thing07:03
zygathat's a good indication that it is dead07:03
zygayeah, looks like 15.04 leftover07:04
* mvo ods07:04
zygamvo: about the writable paths07:05
mvozyga: I will poke at it a bit to see if I can remove more but iirc that wasn't working last time07:05
mvozyga: sure07:05
zygahow did you pick the things to remove?07:05
zygaand are we going to have tests after this PR?07:05
mvozyga: starring at it hard enough07:05
mvozyga: right, tests07:05
mvozyga: man, you ask a lot!07:05
mvo;)07:05
* mvo hugs zyga 07:05
zygaI'm sorry for asking the hard questions :)07:06
=== pstolowski|eod is now known as pstolowski
pstolowskimorning07:06
mvozyga: so the short term goal is just to get a base out that is stable enough, i.e. we don't remove packages from it07:06
mborzeckipstolowski, mvo: morning guys07:06
mvozyga: so ideally a test would ensure that, i.e. we don't break ABI07:06
mvohey mborzecki and pstolowski ! good morning07:07
zygamvo: sent my full review07:07
mvozyga: thank you07:07
zygasorry for being hard on that one07:07
mvozyga: we could simply remove the entire writable-path in the first go?07:08
zygaah, perhaps07:08
mvozyga: I mean for the purpose of what we need to archive its irrelevant until we boot from core1807:08
zygaquestion: can we mark this as a non-bootable base?07:08
mvozyga: it is right now :) we have no language to mark a base bootable yet07:09
zygamvo: ok, let's just add a comment to snap.yaml07:09
zygadescribing that given the lack of language we just say it is not bootable yet07:09
zygathen +107:09
mvozyga: cool, will do07:09
mvozyga: I need to tweak it a little bit more it seems, travis failed with some odd error07:10
zygathe error look like the binaries have more recent libc requirement than what is in the image07:13
zygamvo: perhaps as a sanity check run tests without your changes07:14
zyga https://toggl.com/blog/startup-zoo-comic/07:16
zyga:D07:16
kalikianagood morning, snappy07:19
zygahey ho07:20
mborzeckitravis builds merge the PR branch to master right?07:29
zyga...07:29
zygaI don't think so07:29
mvomborzecki: I don't think it does, iirc it just uses whatever is in the PR07:29
zygait tests whatever is pushed07:29
zygathere is an option to test the merged branch but we are not using it07:29
mborzeckiappears we do merge origin/master before running tests, 'tested' empirically07:34
mvointeressting, I think this was different in the past07:35
mborzeckiunit tests in #4844 were failing quite suspiciously07:35
mupPR #4844: overlord/snapstate: allow core defaults configuration via 'system' key <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4844>07:35
mborzeckizyga: BrokenSnapError? (we already show that snaps are 'broken')07:39
zygaI called it Corrupted for now but yeah, Broken looks good07:41
pstolowskizyga: i found my problem with layouts from yesterday; it was in the fact the i expected it to create extra directory levels before actual mountpoint (maybe it should? are the devs expected to know what existis in the fs?). once it bound /usr/lib/tclk to $SNAP/usr/lib/tclk, it didn't complain anymore07:50
zygaInteresting07:51
zygaI suspected that while biking07:51
zygaI never tested that case07:51
zygathank you for finding it :)07:51
pstolowskiyw :)07:51
pstolowskibut i'm nowhere close to get my snap working... tcl/tk is tricky07:52
pstolowskizyga: nb, snapcraft will not allow snap with experimental features (passthrough for layout) in the store, it displays explicit warning07:53
zygaheh07:53
zygawhy?07:53
zygathat's silly07:53
zygait was not supposed to be that07:53
pstolowskiThe 'passthrough' property is being used to propagate experimental properties to snap.yaml that have not been validated. The snap cannot be released to the store.07:54
pstolowskithat's what it says07:54
zygayeah but that's not what we discussed07:55
pstolowskithat's snapcraft from beta channel, so perhaps there is time to change it07:56
=== devil is now known as Guest27019
mupPR snapd#5072 opened: snap,overlord/snapstate: introduce and use BrokenSnapError <Created by zyga> <https://github.com/snapcore/snapd/pull/5072>07:58
zygamborzecki: ^ built on top of the earlier one07:58
mborzeckiack07:58
mborzeckipstolowski: zyga: https://forum.snapcraft.io/t/support-for-passthrough-into-snap-yaml/469807:58
zygareading the first post reinforces my opinion07:59
mborzeckiand the message was in the PR that's mentioned in the post08:00
zygayeah but it should not prevent sending that to the store08:00
zygathe store should flag08:00
zygabut snapcraft should allow it08:00
pstolowskiindeed, manual review in the store, that's what Jamie said08:01
zygapedronis: 5072 is a follow up to 506708:02
pedroniszyga: I don't think we can use a single error08:03
pedronisfor exampel the check in doMountSnap is really about presence (mounted, not mounted)08:03
mvozyga: I pushed a poor mans abi test for now08:04
zygaI read that08:04
zygaI wonder what `which cp` says08:04
zygawhat's that cp that broke on us?08:04
mvozyga: yeah, something strange in the PATH, when I use /bin/cp its fine08:04
pstolowskicommented in the passthrough topic08:06
mvozyga: I was wondering earlier if the tar got things messed up, i.e. unpacking to the wrong dir but it was not that08:06
zygapedronis: is #5067 ready from your pop?08:07
mupPR #5067: snap,tests : don't fail if we cannot stat MountFile <Created by zyga> <https://github.com/snapcore/snapd/pull/5067>08:07
zygapov?08:07
pedroniszyga: I don't think you addressed my comment about Path being optional08:08
zygaoh, I didn't notice that08:09
zygadone08:14
pedronisthx08:16
pedronisprobably mvo should give it a 2nd quick look08:16
pedronishe reviewed an early version08:16
mvopedronis: sure, this is 5067?08:20
zygayes08:20
pedronisyes08:20
mvozyga: commented08:25
zygathanks, I'll add notes to both tests08:25
mvota08:26
eraserpencilafter successfully running snapcraft and installing the resultant snap with --dangerous --devmode flags, I get this error saying Multiple packages found with the same name "xxx" in snap/parts, snap/prime, and snap/stage08:26
mvozyga: I disabled the core18 writable-path stuff now as well, so we should be good in this area08:26
eraserpencilmust i delete them to remove that error?08:26
zygakalikiana: ^08:27
mvozyga: if you could have a final look before the merge that would be appreciated, then I can go ahead and build a new core and talk to the desktop team about the details08:27
Chipacaeraserpencil: you get those errors after installing your snap?08:27
eraserpencilyes08:28
Chipacaeraserpencil: but those are snapcraft errors08:28
zygamvo: done on the "snap try" PR08:28
zygalooking at core PR now08:28
eraserpencilsorry, im not following08:29
Chipacaeraserpencil: me neither08:29
zygaeraserpencil: can you show the command you ran08:30
Chipacaeraserpencil: your snap builds using snapcraft, yes?08:30
zygaeraserpencil: and the full error you saw08:30
eraserpencilyes08:30
Chipacaeraserpencil: was that yes to me or to zyga08:30
eraserpencilerm, it's a snap of a ROS package. The command I ran was to initialise ROS.08:31
eraserpencilhere is the error: https://ghostbin.com/paste/dcdw708:33
zygamvo: commented08:33
mborzeckipedronis: pstolowski: updated #484408:34
mupPR #4844: overlord/snapstate: allow core defaults configuration via 'system' key <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4844>08:34
eraserpencilsorry i was disconnected08:37
zygaeraserpencil: it looks like the snap is wrong08:38
zygait contains build files from snapcraft08:38
zygaonly the prime directory should be snapped08:38
eraserpencilwhat does that mean08:38
zyganot the whole thing08:38
Chipacazyga: hold on08:38
Chipacaeraserpencil: could you run a command and show us its output please:08:38
Chipacaeraserpencil: which roscore08:38
Chipacaeraserpencil: ^ that's the command08:38
eraserpencilhere: /opt/ros/kinetic/bin/roscore08:39
Chipacaeraserpencil: you're not running the snap08:39
Chipacaeraserpencil: could you run this other command: printf "%q\n" "$PYTHONPATH"08:40
Chipacaeraserpencil: (and show us its output)08:40
eraserpencilYea, im not. I wanted to run roscore on it's on but snap is tripping it up.08:40
pstolowskimborzecki: thanks, looking08:40
eraserpencilhere: /home/nvidia/mov/catkin_ws/devel/lib/python2.7/dist-packages:/opt/ros/kinetic/lib/python2.7/dist-packages08:41
Chipacaeraserpencil: ok, I don't know why ros is picking up libraries from under your current directory08:42
Chipacaeraserpencil: but, it's not the snap's fault, I figure08:42
Chipacaeraserpencil: run roscore from a different directory08:42
eraserpencilsame thing08:45
Chipacaeraserpencil: show me please08:46
eraserpencilerm exact same error08:46
Chipacaok, let me re-read this conversation because I'm getting lost08:47
Chipacaeraserpencil: how did you build the snap?08:48
eraserpencilhttps://ghostbin.com/paste/d7ox508:49
eraserpencilthe error shows that python tried to find packages but found multiple packages of the same name08:50
Chipacaeraserpencil: I saw it that way first, but it's not python, it's ros itself08:53
Chipacaeraserpencil: and it's not looking in the snap08:53
eraserpencilahh, the python plugin for ROS has a script that searches recursively for packages.08:53
Chipacaeraserpencil: I think the most productive use of our time would be to wait for kyrofa to be online08:54
eraserpencilMy snap is within the catkin workspace08:54
eraserpencilok08:54
Chipacaeraserpencil: he's on -0700 so it'll be a while still08:54
eraserpencilwhich time line is that?08:55
Chipacaeraserpencil: PDT I think08:55
eraserpencilok thanks08:57
eraserpencilbtw im having trouble with both demos of  https://docs.snapcraft.io/build-snaps/python08:58
Chipacaeraserpencil: what sort of trouble?09:00
eraserpencilhttps://ghostbin.com/paste/teoza09:05
eraserpencilfor the youtube-dl demo09:05
Chipacalet's see...09:06
Chipacaeraserpencil: I'm not sure what you're doing exactly, but I just made a directory, entered it, copied the youtube-dl snapcraft.yaml, and run snapcraft, and it's compiling libavcodec and stuff after successfully getting the source09:10
Chipacaeraserpencil: what version of snapcraft do you have?09:10
eraserpencil2.409:11
Chipacaeraserpencil: 2.4, or 2.40?09:11
eraserpencil2.4009:11
Chipacasnapcraft just finished building youtube-dl09:11
Chipacaso, it works09:11
Chipacaeraserpencil: there's something nonstandard about your setup you're not telling us09:12
eraserpencilreally wish i knew. I've tried it on different computers09:12
Chipacaeraserpencil: ok, walk me through what you do, step by step09:13
Chipacaeraserpencil: first, what distribution are you on?09:14
eraserpencilmkdir ~/snap09:15
eraserpencilcd ~/snap09:15
eraserpencilgit clone git clone https://github.com/snapcraft-docs/youtube-dl09:15
eraserpencilcd youtube-dl09:15
eraserpencilsnapcraft09:15
eraserpencilUbuntu 16.0409:15
popeydont do mkdir ~/snap :)09:15
popeybuild your snaps somewhere else.09:15
popeyit will get all very confusing once you install a snap and the ~/snap directory will then contain a youtube-dl directory which contains the runtime data for the app09:16
Chipacagood point (although I doubt that's the cause of the errors)09:17
Chipacaeraserpencil: repeating those steps here (also 16.04)09:17
Chipacaeraserpencil: I didn't get that error09:18
Chipacaeraserpencil: is snapcraft version 2.40, or 2.40.1?09:19
eraserpencil2.4009:19
Chipacaeraserpencil: from where did you install it?09:19
eraserpencili cant rem09:19
eraserpencilI was installing spotify as a snap09:19
Chipacaeraserpencil: dpkg -l snapcraft09:20
eraserpencil2.4009:21
zygapstolowski: can you please amend your forum post on layouts with the denial you saw09:21
zygait will make it easier to fix09:22
Chipacaeraserpencil: looks like you're running it from the deb, ok09:22
Chipacaeraserpencil: i've just installed it as well09:22
pstolowskizyga: sure09:22
zygathank you09:23
Chipacaeraserpencil: what does "git version" say?09:23
popeyOk, who wants a fun bug for today? snap install isn't pulling in core... http://paste.ubuntu.com/p/KyPhgc5zHs/09:23
eraserpencil2.7.409:23
zygapopey: oh, maybe mvo09:24
zygamvo: ^ looks bad09:24
eraserpencili removed ~/snap and recloned youtube-dl09:25
eraserpencildoes look good for now09:25
mvozyga: Setting up snapd (2.21-2+b1) ...09:25
Chipacaeraserpencil: FWIW I cloned it into ~/snap as well and it worked here09:26
zygamvo: yes, that's debian09:26
mvopopey: what does `snap changes` tell you?09:26
Chipacaeraserpencil: I'm now trying to downgrade my git to see if it's that09:26
threshhmm, did something change wrt to .config access from the apps?  I seem to get apparmor denials.09:26
mvozyga, popey: ohhh, debian09:26
popeymvo: fwiw, installing a snap on its own, not multiple, it installs core09:26
threshlike [94066.971259] audit: type=1400 audit(1524129374.572:1024): apparmor="DENIED" operation="link" profile="snap.vlc.vlc" name="/home/thresh/snap/vlc/273/.config/vlc/vlc-qt-interface.conf" pid=9800 comm="vlc" requested_mask="l" denied_mask="l" fsuid=1000 ouid=1000 target="/home/thresh/snap/vlc/273/.config/vlc/#270577332"09:26
mvopopey: thats sad09:26
Chipacamvo: that might be 2.21's way though09:27
mvopopey: I mean, its good that at least in the one-snap case it is DTRT09:27
mvoChipaca: yeah09:27
popeyhttp://paste.ubuntu.com/p/6ZHDG2Hhtq/09:27
zygabut ...09:28
zygacore       16-2.32.3      4408  stable    canonical     core09:28
zygayou have core now09:28
zygaso what happened09:28
popeyyeah, now I installed nextcloud09:28
popeythe second paste is immediately after the first09:28
popeyi had no core, installed nextcloud (one snap on its own) and now have core09:28
popeyif you specify multiple snaps you dont get core09:28
popeythats my current way to reproduce it09:28
mvopopey: could you please also pasetbin snap change 1 and snap change 2 ?09:28
mvopopey: it might be that you get ubuntu-core in the first transaction that re-execs, does the ubuntu-core -> core transition behind your back09:29
popeymvo: http://paste.ubuntu.com/p/D6SZypWQPy/09:29
mvopopey: ta!09:29
popeyno, got no core09:29
mvopopey: yeah, no core at all09:29
mvopopey: :(09:29
popeyi can file a bug with steps to reproduce09:30
popey?09:30
mvopopey: please do09:30
popeyon it09:30
mvopopey: I am not sure what we can do about it though, I think we would have to upload a fixed deb09:30
mvopopey: because the re-exec fix will not be pulled down because there will be no core :/09:31
popeygreat! I love the sound of an updated snapd in debian ;)09:31
Chipacamvo: popey: 2.21 had the install core only for single snaps09:31
mvoChipaca: yes, I vaguely remember it was different code-paths09:31
Chipacamvo: it used ensureUbuntuCore in daemon/api.go09:32
Chipacamvo: instead of a flag in snapstate09:32
* mvo nods09:32
Chipacadoes debian let us SRU09:32
zygaI just reproduced this on debian09:33
Chipacazyga: it's not a bug, it's a missing feature09:33
zygaChipaca: it's not a bug it's a hole in the plane09:33
Chipacaeraserpencil: I can't reproduce your issue,  even with the same versions of git and snapcraft and doing it in the same directory on the same ubuntu09:33
Chipacaeraserpencil: ¯\_(ツ)_/¯09:33
zygamvo: can we get to 2.32.5 in debian ;)09:34
Chipacazyga: I mean: 2.21 did not add core to the list when doing a multi-snap install09:34
mvoChipaca, zyga debian has pretty strict policies, but we can always try if the diff is not too terrible we have a chance. or we put an updated snapd into the debian backports repository09:34
mvozyga: 2.32.5 would be for -backports but I like the sound of it09:35
zygaback ports sounds good but they are not enabled by default, right?09:35
Chipacamvo: is backports an enabled-by-default-but-not-used job? ie a flag to apt away from working, or does it need enabling?09:35
popeyhttps://bugs.launchpad.net/snapd/+bug/176535509:36
mupBug #1765355: Installing multiple snaps doesn't install core (debian snapd2.21) <snapd:New> <https://launchpad.net/bugs/1765355>09:36
Chipacapopey: which debian is this btw09:36
* popey looks in the bug report09:36
popeyhttps://www.raspberrypi.org/downloads/raspberry-pi-desktop/09:36
popeythat debian :)09:36
popey9.409:37
zygaChipaca: it also affects vanilla 909:37
mvoChipaca: I think its just like our -backports, i.e. "apt install -t foo-backports snapd"09:37
mvoChipaca: but I'm not 100% certain09:37
Chipacapopey: can you try that ^09:37
mvoif they are not enabled its much less appealing :/09:37
popeyi see no backports in sources.list09:38
popeyonly stretch and stretch-updates09:38
zygasame09:38
zygaI think we want backports anyway09:38
zygawe can then get more recent snapd cleanly09:38
zygawith all the non-reexec fixes09:38
popeythat would add some additional steps to getting snapd on debian09:39
pedronismvo: zyga: can't we have people opt-in into reexec somehow on debian? I understand we cannot make it the default09:40
zygapedronis: sure09:40
zygapedronis: but reexec doesn't fix this issue09:40
zygapedronis: and on that version it is actually the default09:41
pedroniswhat's the issue?09:41
zygasnap install foo bar; # not pulling in core09:41
pedronisah09:41
pedroniswell, too bad09:41
pedronisdoing a fix for exactly that will be annoying09:42
pedronisit might be easier to return an error in that case if there is no core09:44
pedronisif we are looking at doing a change only for that09:45
pedronison top of an old snapd09:45
mupPR snapd#5067 closed: snap,tests : don't fail if we cannot stat MountFile <Squash-merge> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5067>09:47
eraserpencilChipaca: either how, thanks alot09:48
eraserpencillots to ask kyrofa09:48
zygahttps://github.com/mjl-/duit :D09:50
zygamvo: your missing UI toolkit for the prompts ;-)09:50
mvozyga: oh09:53
mvokalikiana: quick question: is the snapcraft that is used in LP building using snap pack? I asked because it looks like for core18 it breaks permissions, i.e. it maps everything to root. I think we need to ensure that bases are not using "-all-root"10:00
Chipacamvo: snapcraft is not yet building using snap pack afaik10:01
mvoChipaca: ta10:02
Chipacamvo: for that we need to package the standalone snap helper thing10:02
axinohi10:04
axinoare snaps in LXDs still somewhat problematic ? (on xenial)10:04
popeyinstalling them or building them?10:04
zygaaxino: I think so, until 2.32.5 hits xenial (SRU)10:06
axinopopey: installing10:13
axinozyga: OK thanks10:14
popeyi found just installing squashfuse allowed me to install snaps inside lxd10:14
mupPR snapcraft#2090 opened: internal: skip -all-root for base snaps <Created by mvo5> <https://github.com/snapcore/snapcraft/pull/2090>10:15
zygapopey: that's correct but there are more issues later10:19
popeyoh ok10:19
zygastill, it's all fixed and the SRU will be released shortly (hopefully)10:19
mvopopey: what version of snapd do you have in lxd right now?10:29
popeyhard to say, i have a ton of lxd containers :)10:30
mborzeckiChipaca: left a couple more comments in the snapshots pr10:30
mvopopey: ok, the sru with the fix should be in -updates at tihs point so if that was something you experienced recently it would be great to know what version the snapd deb had10:31
popeyah, these are often long standing lxd containers that i forget to apt upgrade10:32
mvopopey: thats fine, if you experience issues in a fresh (and up-to-date) one, please shout so that we can investigate :)10:33
=== pstolowski is now known as pstolowski|lunch
mvozyga: another (trivial) core18 thing10:37
zygaack10:38
zygacan we do two things10:38
zygadrop debconf + debconf i18n10:38
zygaand and and10:38
zygaif you can measure the size10:38
mvozyga: I will probably do two more and then it should be fine. all related to uids - remove the apt user and make the two systemd users auto-created instead of hardcoded10:38
zygainstall locales-all10:38
zygaah, awesome10:38
mvozyga: but probably after lunch10:39
zygareviewed10:39
mvozyga: locales-all? hm, hm, I think it makes sense, let me add it and see what size impact it has10:39
mvozyga: looks like it jumps from 24mb to 36mb with locales-all10:45
zyga8 megs10:46
zygais that with compression10:46
zygaor without?10:46
mvozyga: that is the raw snap size, so with compression10:46
zygaI wonder if each language contributes the same amount of space10:47
Chipacamborzecki: what are the comments about cleanup about?10:47
zygamvo: are those with i18n or just with non LC_MESSAGE things?10:47
zygaif we drop .mo files is it the same?10:47
mborzeckiChipaca: just stating the fact that the code looks good and afaict does not leave garbage behind :)10:47
Chipacamborzecki: ah, phew :-)10:47
Chipacawaaaait10:50
Chipacamborzecki: why is snapshotmgr in that PR10:50
Chipacaoh dammit i pushed the whole thing D:10:50
mborzeckiChipaca: hah, no clue ;)10:50
Chipacamborzecki: sorry, will fix10:50
Chipacauh, probably with a --force10:51
mborzeckiChipaca: and i was like, nice, new stuff for review ;)10:51
Chipacathat was meant to go in the _next_ batch10:51
Chipacathis one was already over the 1k10:51
Chipaca… i guess i can leave it if you've already reviewed it10:52
Chipacanah, it'd be messy. cleaning it up.10:52
Chipacathat should do it10:55
mborzeckiChipaca: no worries, i went though cachio's pr in the morning, i think yours was shorter10:57
Chipacaheh10:57
Chipacawait, QA is supposed to be about raising the bar, not lowering it :-p10:57
mvozyga: one more for core18 and then I consider that bit finished for today11:04
zygaok11:04
zygamvo: ok11:05
zygamvo: nothing about locale?11:05
jameshzyga: finally got a green tick on https://github.com/snapcore/snapd/pull/396311:08
mupPR #3963: cmd/snap-confine: add support for per-user mounts <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/3963>11:08
zygaI read all the changes you made since11:11
zyganow reading the whole diff again11:11
zygajamesh: any reason file bind mounts are not using sec.BindMount?11:13
zygakind == "" || kind == "file" would work IMO11:13
jameshzyga: at the moment, Secure.OpenPath uses the O_DIRECTORY flag, so it would fail.11:14
zygaah, indeed11:15
jameshzyga: it would be pretty easy to get BindMount to work for files, but I thought it would be better to do that as a follow up branch rather than making this one bigger11:15
zygayeah, I agree11:15
zyga+111:16
zygamborzecki: can you do a 2nd review please11:16
jameshthe last few spread test failures were down to "su" on Ubuntu and Debian being different to the other distros.  I've got something working everywhere now though11:17
zygajdstrand: I believe the non-persistent per-user mount namespaces are okay now. Can you have look please.11:17
zygayeah, saw that, interesting; I would say it would be easier of spread ran as a user but it's too late for that11:17
threshout of curiousity, am I the only one experiencing way longer build times than previously with snapcraft?  my builds get "stuck" on "Preparing to build $foo", with snapcraft using 100% for minutes, apparently reading every file there is?11:24
threshthis is happening since a couple of weeks at least11:25
threshe.g. now it takes an hour to do a build, while at the end of March the builds took around 40 minutes11:25
threshthis is reproducible on every machine I have, with snapcraft 2.40 from Xenial11:26
threshhttps://jenkins.videolan.org/job/vlc-nightly/job/vlc-nightly-snap/buildTimeTrend shows the trend pretty nicely11:27
Chipacajamesh: zyga: how is su different?11:28
jameshChipaca: we have the version from shadow, and everyone else uses the one from util-linux11:29
Chipacaah11:29
jameshChipaca: shadow's su allows --login and --preserve-environment together, while util-linux's one ignores -p if used with -l11:29
Chipacawe are rather brilliant at that, aren't we11:30
Chipacawe should find a distro that's linux with no gnu tools just for extra fun11:31
Chipacaanyway, lunch now because meeting later11:31
jameshdo you want to port snapd to OpenBSD? :)11:31
* Chipaca afk11:31
mupPR snapd#5034 closed: userd: set up journal logging streams for autostarted apps <Squash-merge> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/5034>11:31
Chipacajamesh: is there openbsd/linux?11:31
jameshthey've got something even better: openbsd/openbsd11:32
Chipaca'starch linux'11:33
=== pstolowski|lunch is now known as pstolowski
mupPR snapd#5070 closed: debian: update LP bug for the 2.32.5 SRU <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5070>11:34
mborzeckiChipaca: starch linux - sticky when wet11:36
pstolowskiSon_Goku: hi Neal! can you help push https://bugzilla.redhat.com/show_bug.cgi?id=1567819 through?11:36
mupPR snapd#5073 opened: set up journal streams in user session application autostart (2.32) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5073>11:38
Chipacamborzecki: it's dead now i think, but it was a statically-linked arch-based thing11:43
Son_Gokupstolowski, yes I can11:50
Son_GokuI've taken the review (though note *any* Fedora packager can review another Fedora package)11:50
Son_Gokuso even zyga and kyrofa could have done it11:51
zygammm,11:51
Son_Gokuthe only thing *I* can do is sponsor new packagers in11:52
seb128thresh, did you report a bug or post on the forum about it?11:53
threshseb128, I found a similar thread on the forums saying it's a feature https://forum.snapcraft.io/t/snapcraft-builds-taking-a-long-time-in-snap-vs-run-from-source/4280/311:55
pstolowskiSon_Goku: thanks, I see; but surely some "core" fedora dev need to bless it for landing even if it has reviews of other packages, right? is that your role?11:56
seb128thresh, is there any chance you could try if .41 fixes your issue?11:57
threshseb128, is it in xenial already?11:57
Son_Gokupstolowski, nope11:57
threshI suppose I could if it's packaged.11:57
Son_Gokuonly because you don't have any packages in fedora am I required to step in at all11:57
seb128thresh, in xenial-proposed at the moment11:57
Son_Gokupstolowski: that's what FE-NEEDSPONSOR is about11:57
zygapstolowski: fedora is very open for contribution11:58
seb128thresh, https://launchpad.net/ubuntu/+source/snapcraft/2.4111:58
seb128thresh, you can download the debs on https://launchpad.net/ubuntu/+source/snapcraft/2.41/+build/1477094711:58
Son_Gokupstolowski: forget everything you learned about the bureaucracy of Debian and Ubuntu11:59
Son_Gokualmost none of it applies to Fedora11:59
pstolowskiSon_Goku: :D12:00
zygathe only issues we may encounter is if we wish to influence the default kernel configuration12:01
zygaso if we want to enable apparmor in the kernel, that's not going to fly easily and we'd have to discuss this and how it would be supported12:02
Chipacadoes hangouts not work with the snapped firefox?12:03
threshthanks seb128, trying it now12:03
seb128thresh, great, let us know if it works better!12:04
zygaChipaca: it should work with the ESR thing12:04
zygabut not with normal ff12:04
mborzeckioff to pick up the kids, bb for standup12:04
zygabecause die plugins, die12:04
mvozyga: fwiw, duit looks exceedingly cool12:23
mvozyga: at least from a quick glance12:23
zygait's a "send yaml to C helper" design12:23
mvozyga: the wrapper pointer is interessting but I'm sure people will hate it12:26
Son_Gokupstolowski: https://bugzilla.redhat.com/show_bug.cgi?id=1567819#c812:26
zygaI wasn't suggesting we actually use it12:26
zygajust that I found it interesting12:26
zygapedronis: updated #507212:27
mupPR #5072: snap,overlord/snapstate: introduce and use BrokenSnapError <Created by zyga> <https://github.com/snapcore/snapd/pull/5072>12:27
zygalet me know if that's what you had on your mind12:27
zygaI think it's close to the original idea where we just held an internal error reference12:28
pstolowskiSon_Goku: great, thanks a lot! will do the reviews12:28
zygabut I agree this is cleaner as an interface12:28
zygaoh, I misread part of your review12:28
zygaI'll make NotFoundError public again and restore that part of the code12:28
mupPR snapd#5057 closed: tests: bring back one missing test in snap-service-stop-mode <Created by mvo5> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/5057>12:30
zygapedronis: corrected now12:34
pedroniszyga: I'm in a meeting atm12:37
* kalikiana lunch12:41
Chipacacurrent meeting overrunning13:00
mupPR snapd#5074 opened: interfaces/apparmor: add test case for tricky writable mimic <Created by zyga> <https://github.com/snapcore/snapd/pull/5074>13:08
Chipacai'll be a minute13:08
threshseb128, no, it didnt change it at all, still 65 minutes per time(1)13:10
seb128:/13:10
seb128sergio is not around13:10
seb128Chipaca, do you know who knows about snapcraft and could help thresh with a regression that impact vlc builds?13:10
Chipacaseb128: kalikiana? kyrofa ?13:16
seb128Chipaca, thanks13:17
seb128kalikiana, kyrofa, can you help thresh?13:17
zygajdstrand: hey, around?13:38
kalikianathresh: Looking at the backlog... so as of 2.40 builds take a lot longer than before?13:41
threshkalikiana, yep, correct.13:41
jdstrandzyga: hey, yes13:44
zygajdstrand: something interesting came up wrt layouts13:44
zygajdstrand: I summarised it in this short comment: https://github.com/snapcore/snapd/pull/5074#issuecomment-38272821813:45
mupPR #5074: interfaces/apparmor: add test case for tricky writable mimic <Created by zyga> <https://github.com/snapcore/snapd/pull/5074>13:45
jdstrandzyga: did you also say pr 3963 could be reviewed?13:45
mupPR #3963: cmd/snap-confine: add support for per-user mounts <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/3963>13:45
zygayes13:46
zygaplease do, though that's a bigger cookie :)13:46
jdstrandzyga: I commented on 5074. I did not review the pr13:48
kalikianathresh: Considering it's not a classic snap the forum post you linked shouldn't matter...  Do you happen to know what version it was that became so slow?13:49
threshkalikiana, what version of what exactly?13:49
threshkalikiana, snapcraft?  2.40 from ubuntu xenial repos.13:50
kalikianathresh: Lemme re-phrase. You said with 2.40 it became slow. What were you using before?13:50
threshkalikiana, it was 2.39.3+really2.35.13:51
kalikianaOkay13:55
kalikianathresh: Is this just building vlc from git?13:55
kalikianaGoing from the log13:56
threshkalikiana, plus some contribs;  essentially yes.  https://jenkins.videolan.org/job/vlc-nightly/job/vlc-nightly-snap/13:56
kalikianaYeah. Just checking what's needed to repro13:56
threshthe slowest part is "Preparing to build vlc" -- the build stays there for 15-20 minutes afaict13:57
mupPR snapd#5060 closed: tests: detect kernel oops during tests and abort tests in this case <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5060>13:57
threshwe're building in the docker images, containing needed packages since I don't allow jenkins users to be in a sudo group.  The image is registry.videolan.org:5000/vlc-ubuntu-xenial.13:58
seb128sergiusens, hey, ^ do you have any idea about that vlc issue?14:07
sergiusensseb128 thresh: `Preparing build` is basically unpacking all the stage-packages to their destination14:09
seb128sergiusens, is that known to be longer/having an issue since 2.40? thresh said it was working fine with 2.39.3+really2.3514:09
sergiusenshow many stage-packages are we talking about. I have an item to improve the messaging there14:10
sergiusensseb128: we have no known issues on this side14:10
sergiusensis it slow just on that docker container or out of it as well?14:10
threshjenkins@0792d2e4c997:~$ find .cache/snapcraft/stage-packages/ -type f -name "*.deb" | wc -l14:11
thresh41914:11
threshI never tried out of a docker container;  could try with an lxd, but not right now and on a very different power-wise machine14:12
threshbut that also happens on my laptop with an nvme, I wouldnt imagine that unpacking a few hundred megabytes of .debs should take that much time14:14
mvocachio: 2.32.5 is in *-proposed now, no rush though with the verification14:15
sergiusensseb128: the only potential change we have is we went from calling dpkg-deb to using a python implementationdebian.arfile14:15
sergiusensthresh: ^14:15
sergiusensI will run some numbers against that, but I cannot do that today14:16
threshI do see python proccess doing a lot of read/write under strace, yes14:16
seb128thresh, I recommend you open a post on the forum which can be used for debugging/discussion14:16
seb128the python thing might be much slower than dpkg-deb?14:16
sergiusensseb128: we do track bugs too you know ;-)14:16
seb128sergiusens, you mean you prefer  bug report on launchpad? or that rather you don't need me in that discussion? ;)14:17
threshheheh14:17
seb128sergiusens, I started responding because nobody picked up his question earlier14:17
sergiusensseb128: we do not have a need for that feature anymore given the last PR I am working on, so we could potentially move back to dpkg-deb without much thought14:17
threshand you are most welcome for that, seb12814:18
seb128:)14:18
sergiusensseb128, thresh: a bug report makes it not fall through the cracks, that's all14:18
seb128sergiusens, it does for the snappy team, that's why I asked to use the forum ... but good to know snapcraft is better at that :)14:18
sergiusensthe forum is nice to have something like this initial conversation we just had on irc :-)14:19
seb128right14:19
zygajdstrand: quick feedback, I wrote a helper that constructs the /{,funky/{,paths}}14:35
zygaand this is the apparmor profile after the change14:35
zygaxmas-tree-ified profile https://www.irccloud.com/pastebin/UWVbEfBd/14:36
zygaLooking at line like: ...     "  mount fstype=tmpfs options=(rw) tmpfs -> /{,usr/{,lib/{,tcltk/{,x86_64-linux-gnu}}}}/,\n" +14:36
zygamakes me say, use right-recursion and isProbablyPresent to avoid some of the things14:36
zygaas this essentially allows tmpfs over /14:37
jdstrandzyga: heh, just make sure you have a test that runs apparmor_parser on the resulting profile :)14:39
zygahaha14:40
zygawell, layouts tests will do14:40
zygabut yeah14:40
zygabut I was wondering if / should be off limits somehow14:40
zygaso that we allow at most /foo but not /14:40
zygathis profile will certainly make apparmor parser more busy ;)14:40
jdstrandzyga: so you have /{,usr/{,lib/{,tcltk/{,x86_64-linux-gnu}}}}/14:42
jdstrandzyga: why not /usr/{,lib/{,tcltk/{,x86_64-linux-gnu}}}/ ?14:42
zygayes14:42
zygathat's my thinking14:42
zygaI can easily adjust that14:42
zygaand we cannot do things on / directly anyway14:42
zygaI added xmasTree function14:42
jdstrandright14:42
zygaI'll add trunkedXmasTree14:43
jdstrandzyga: btw, 3963 is approved14:43
zygawoot, thank you14:43
zygaI have some things on top I will try to propose but probably not today (or late)14:43
zygaI want to use the sun and go biking with my wife14:44
jdstrandzyga: well, I'm still working on other things14:44
jdstrandwith critical priority, so... take your time :)14:44
zygasure, thank you for the feedback! :)14:44
jdstrandnp :)14:50
zygajdstrand this with variable trunk size https://www.irccloud.com/pastebin/3SkvTtEr/15:03
zygaThere are some things that can be simplified now15:03
zyga...     "  /snap/tricky/42/{,usr/{,lib/{,tcltk/{,x86_64-linux-gnu}}}}/** rw,\n" +15:03
zyga...     "  /snap/tricky/42/usr/lib/tcltk/x86_64-linux-gnu/ rw,\n" +15:03
zygaI think we can essentially stop making the non-xmas versions15:03
zygaas they represent the same assumption15:04
jdstrandneat15:04
zygaI'm happy how it looks like15:04
zygathe trunk length depends on what we do15:04
zygaso for $SNAP it is 315:04
zygabut for target it is 115:04
zygaso /snap/name/rev is expected to be there15:04
zygabut on the other side we just expect /toplevel15:04
mupPR snapd#5075 opened: snap/env: fix env duplication logic <Created by didrocks> <https://github.com/snapcore/snapd/pull/5075>15:06
mupPR snapcraft#2090 closed: internal: skip -all-root for base snaps <bug> <Created by mvo5> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2090>15:08
pedroniszyga: should I pick up pushing my small comment fixes to #5072 if you are busy with other things?15:32
mupPR #5072: snap,overlord/snapstate: introduce and use BrokenSnapError <Squash-merge> <Created by zyga> <https://github.com/snapcore/snapd/pull/5072>15:32
mvosergiusens: \o/ for merging the -allroot pr15:33
zygapedronis: re, please! thank you15:44
pedroniszyga: ok, will do15:45
zygasorry, I was focusing on apparmor and I didn't notice the ping15:45
sergiusensmvo: glad to make you happy15:52
zygapstolowski: I fixed the bug you found locally, I will re-run spread and push the fix :)16:04
=== alan_g_ is now known as alan_g|EOD
pedronismvo:  the failure here looks weird:  https://travis-ci.org/snapcore/snapd/builds/368626305?utm_source=github_status&utm_medium=notification16:06
pstolowskizyga: very nice, thank you! i'm honored you considered this case tricky ;)16:06
pedronismvo:  Reading package lists...16:07
pedronisE: Type 'curity' is not known on line 50 in source list /etc/apt/sources.list16:07
pedronisin the lxd test16:07
zygapedronis: ha16:07
zygawe had that once before16:07
zygaI wonder how that happens16:07
zygait went away on re-try16:07
zygaseems like sed gone wrong16:07
pedronisok, anyway about to repush16:07
zyga's'ecurity16:07
pedroniszyga: pushed16:11
zygathanks16:12
=== pstolowski is now known as pstolowski|afk
mupPR snapcraft#2091 opened: meta: soften warning about using passthrough <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/2091>16:29
rogpeppequick question: is it possible to give a snap the privilege to be able to open a web page in the user's browser (without using classic confinement) ?16:45
sergiusensrogpeppe: if the app uses xdg-open that should already work16:49
matiasbsergiusens, o/ fyi, this one https://github.com/snapcore/snapcraft/pull/2086 finally completed and passed its travis run, we are trying to get the store changes rolled out this afternoon17:12
mupPR snapcraft#2086: tests: update metadata store integration test, no previous push required <Created by matiasb> <https://github.com/snapcore/snapcraft/pull/2086>17:12
sergiusensmatiasb: ack17:26
jdstrandroadmr (cc Wimpress, sergiusens, niemeyer): hey, can you pull r1026 of the review-tools? this has the refresh-mode and stop-mode work17:37
kyrofaIs the store down?17:37
jdstrandJamieBennett: fyi ^17:37
roadmrno17:37
jdstrandroadmr: no? :P17:37
roadmrjdstrand: yes to you, no to kyrofa  :)17:38
jdstrand:)17:38
kyrofaLooks like api.snapcraft.io is17:38
roadmrkyrofa: correction, looks like it *is* down17:38
cprovdeadly slow17:39
cprovand it's back to normal request timing, investigating what caused the blip17:42
roadmrcprov: oh is it?17:43
jdstrandroadmr: oh, thanks btw :)17:46
roadmrjdstrand: np, I'm submitting the merge proposal now17:46
jdstrand\o/17:47
jdstrandroadmr: fyi, upstream electron-builder claims to have fixed the resquashfs, so in r1027 I updated the resquash error output to reference the fixed version. r1027 is not urgent, but if it can piggyback on r1026 from earlier, that would be cool18:32
jdstrandroadmr: sorry for the quick extra request18:33
jdstrandroadmr: we still have a partner issue and I'd like for electron-builder to have a chance to get out there, so don't want to turn on enforcement just yet18:33
jdstrandroadmr: but having r1027 in place when we do would be good18:34
roadmrjdstrand: no problem! I'll put 1027 in, probably willjust leapfrog 1026 which is already queued18:55
jdstrandroadmr: cool, thanks18:58
cratliffHey, I asked this on the forum a while ago and didn't get a response: Some of the different gadget snaps don't have associated licenses, under the license field on launchpad they say "I don't know" Are they available for use?19:46
=== sergiusens_ is now known as sergiusens
sergiusenskenvandine: today was the day for core18 in stable, do you know if that happened?20:17
sergiusensor was it 7 days from now?20:17
sergiusenscratliff: which gadget in particular? I suspect that ogra_ could help, but you should be able to use the ones from Canonical just fine, as usual, IANAL ;-)20:21
cratliffpc_amd64 in particular, but others don't have licenses as well.  I mean, I thought so, because it's used in demos and tutorials published on your website.  IANAL either, but my understanding is no license should be treated as proprietary.20:24
naccwho do I talk to about modifying the publisher entry for a snap?20:56
mupPR snapcraft#2092 opened: schema: allow refresh-mode and stop-mode <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2092>21:09
sergiusensmatiasb: can you confirm that https://github.com/snapcore/snapcraft/pull/2086 works against production?21:14
mupPR snapcraft#2086: tests: update metadata store integration test, no previous push required <Created by matiasb> <https://github.com/snapcore/snapcraft/pull/2086>21:14
sergiusensnacc: on the forum or maybe noise][ or roadmr can help21:14
naccsergiusens: thanks, will do21:15
matiasbsergiusens, it will work as soon as we rollout, which is in the queue; in any case the failing test is really a restriction we lifted store-side, so we are not breaking anything just enabling something that wasn't possible before21:17
sergiusensthanks for confirming matiasb21:20
matiasbnp21:21

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!