| admcleod_ | thumper: https://bugs.launchpad.net/juju/+bug/1765571 | 01:28 |
|---|---|---|
| mup | Bug #1765571: lxd container fails to launch on bionic host: No associated target operation <juju:New> <https://launchpad.net/bugs/1765571> | 01:28 |
| admcleod_ | thumper: im going to EOD but ill leave those envs up so if you want me to try anything/get more info let me know | 01:29 |
| thumper | admcleod_: ack | 01:33 |
| thumper | babbageclunk: ping | 01:33 |
| babbageclunk | thumper pingback - good timing! | 01:34 |
| babbageclunk | in 1:1? | 01:34 |
| thumper | ack | 01:34 |
| thumper | wallyworld: can you reply to Junien on https://bugs.launchpad.net/bugs/1762979 ? | 02:52 |
| mup | Bug #1762979: juju resolve --no-retry behaviour is inverted <juju:Fix Committed by wallyworld> <juju 2.3:Fix Released by wallyworld> <https://launchpad.net/bugs/1762979> | 02:52 |
| wallyworld | looking | 02:52 |
| veebers | babbageclunk (thumper?) I found go-guru-hl-identifier-mode, I find it useful you may too (highlights identifier under point). | 03:30 |
| babbageclunk | veebers: might try it, thanks! | 03:30 |
| veebers | I enabled with "(add-hook 'go-mode-hook #'go-guru-hl-identifier-mode)", I tweaked the face a little too '(go-guru-hl-identifier-face ((t (:inherit highlight :slant italic)))) | 03:32 |
| babbageclunk | I like it! It feels a bit inconsistent though - it highlights instaces of time (in time.Duration) but not Duration, and not a different package. Maybe it's just if that name (time) happens to have been used as a local somewhere in the file? | 03:47 |
| wallyworld | thumper: :-) pretty please? https://github.com/juju/juju/pull/8634 | 03:48 |
| * thumper looks | 03:48 | |
| wallyworld | need for CI etc | 03:49 |
| thumper | wallyworld: got a sec to chat about this? | 03:49 |
| wallyworld | sure | 03:49 |
| thumper | 1:! | 03:49 |
| kelvinliu | hi wallyworld: can I have ur 5mins on hangout? | 04:29 |
| wallyworld | kelvinliu: just talking to chris, give me | 04:29 |
| wallyworld | 5 | 04:29 |
| wallyworld | unless you want to join standup hangout | 04:29 |
| kelvinliu | wallyworld: sure, I will just join soon. thx | 04:30 |
| wallyworld | kelvinliu: i *need* coffee, let me go make one and i'll ping you in 5 | 04:32 |
| kelvinliu | wallyworld: yup, no problem, thx | 04:33 |
| babbageclunk | thumper: retrying that benchmarking on aws machines I can get between 340 - 400 updates per second. Weirdly, tweaking that parameter I was talking about didn't seem to make much difference. | 04:38 |
| thumper | hmm... ok | 04:39 |
| wallyworld | kelvinliu: free now, see you in hangout? | 04:42 |
| kelvinliu | wallyworld: yup | 04:42 |
| * thumper sighs | 05:09 | |
| thumper | looks like gofmt is sad on develop | 05:09 |
| thumper | how? | 05:09 |
| veebers | did wallyworlds change land for make check? | 05:10 |
| thumper | type DBusAPIFactory = func() (DBusAPI, error) | 05:10 |
| thumper | there is an = there | 05:11 |
| thumper | service/systemd/service.go | 05:11 |
| thumper | go test passes in there | 05:11 |
| thumper | but the prepush hook fails | 05:12 |
| kelvinliu | wallyworld: a quick one https://github.com/wallyworld/caas/pull/2 thx | 05:13 |
| thumper | https://github.com/juju/juju/commit/4185a33acc39527276de908c2492f6286d87f0d1 | 05:13 |
| thumper | funny, but Joe's change was just renaming | 05:13 |
| wallyworld | kelvinliu: thks | 05:13 |
| thumper | the type alias is from before | 05:14 |
| thumper | perhaps this is a new check? | 05:14 |
| veebers | thumper: which go version are you using? | 05:14 |
| thumper | 1.10.1 | 05:14 |
| veebers | I see the prechecks are happening (this run fron ~17 hours ago: http://ci.jujucharms.com/job/github-check-merge-juju/963/console) | 05:14 |
| wallyworld | kelvinliu: it includes your bundle changes, they will need to be backed out | 05:15 |
| wallyworld | kelvinliu: also build dirs like charms/gitlab/deps/interface/pgsql | 05:16 |
| wallyworld | need to not be pushed | 05:16 |
| kelvinliu | wallyworld: use INTERFACE_PATH=/path-to-ur-local-interfaces-dir use local interface | 05:17 |
| wallyworld | kelvinliu: thanks, yeah, i already had that set as it turns out | 05:17 |
| kelvinliu | wallyworld: ah, ok, I will gitignore deps | 05:19 |
| kelvinliu | wallyworld: is the deps required or not | 05:19 |
| wallyworld | no | 05:19 |
| wallyworld | can be removed from PR | 05:20 |
| wallyworld | is generated on build AFAIK | 05:20 |
| wallyworld | kelvinliu: looks good with a few comments to fix | 05:21 |
| thumper | wallyworld: https://github.com/juju/juju/pull/8635 | 05:22 |
| kelvinliu | wallyworld: made changes for the comments. thx | 05:30 |
| wallyworld | kelvinliu: where does ##MODEL## come from? | 05:31 |
| wallyworld | i've not seen that before | 05:31 |
| kelvinliu | wallyworld: in the $profile | 05:31 |
| wallyworld | the bash profile? | 05:31 |
| wallyworld | ih wait | 05:32 |
| wallyworld | i see | 05:32 |
| kelvinliu | wallyworld: yes | 05:33 |
| wallyworld | thanks, haven't noticed that before | 05:33 |
| kelvinliu | wallyworld: np :) | 05:33 |
| wallyworld | kelvinliu: looks good, i'll merge when the mysql layer change gets merged so as not to break existing users | 05:34 |
| kelvinliu | wallyworld: yeah, thx | 05:35 |
| axino | wallyworld: hi | 05:40 |
| wallyworld | hey | 05:40 |
| axino | wallyworld: so afaik, "juju resolved" has been, by default, retrying _by default_ since 2.x (1.x default was to not retry) | 05:40 |
| axino | wallyworld: and you're saying in the bug that most 2.x versions didn't retry if one simply ran "juju resolved" ? | 05:41 |
| wallyworld | yeah, in 2.x the behaviour was meant to be swapped | 05:41 |
| wallyworld | 2.x requires --no-retry to not retry | 05:41 |
| wallyworld | 2.x retries by default | 05:41 |
| wallyworld | or is supposed to | 05:41 |
| wallyworld | but i was testing an found it didn't | 05:42 |
| thumper | wallyworld: if you are happy with the proxy rework branch, just add the merge comment, otherwise I'll address anything monday morning | 05:42 |
| thumper | laters peeps | 05:42 |
| wallyworld | thumper: looking | 05:42 |
| wallyworld | axino: and i looked at the code and saw a bug | 05:42 |
| axino | wallyworld: I'm suprised no one saw it in 1+ years | 05:44 |
| wallyworld | axino: me too. apparently tim was talking to xav from bootstack and when the bug was mentioned, xav said somrthing like "oh, i was wondering why it never seemed to work properly" | 05:45 |
| axino | heh | 05:45 |
| wallyworld | better late than never for a fix i guess | 05:45 |
| axino | oh yeah definitely | 05:48 |
| axino | wallyworld: and this is an agent thing right ? not a client thing ? | 05:48 |
| wallyworld | yeah, if i recall correctly | 05:48 |
| wallyworld | CLI was modified but agent wasn't | 05:49 |
| wallyworld | modified to the reversed behaviour | 05:49 |
| wallyworld | kelvinliu: see this error? https://pastebin.ubuntu.com/p/MF3wRbZWFp/ | 06:30 |
| wallyworld | the mysql charm relation joined isn't happy | 06:30 |
| kelvinliu | wallyworld: ah, sorry. I changed the code inside the container by exec into it, but forgot change it into the repo. | 06:31 |
| wallyworld | ok, np, just push the change :-) | 06:32 |
| kelvinliu | wallyworld: done. | 06:33 |
| wallyworld | thanks, looking | 06:33 |
| kelvinliu | wallyworld: np | 06:34 |
| wallyworld | kelvinliu: it seems then that he doc string is wrong in the mysql layer | 06:39 |
| wallyworld | they leave off the items() also | 06:39 |
| kelvinliu | wallyworld: yes, I was about to add comment to the PR | 06:39 |
| wallyworld | great! | 06:40 |
| wallyworld | just waiting for gitlab to start now so i can see the result | 06:40 |
| wallyworld | kelvinliu: there is indeed a problem - gitlab can't talk to mysql, gets auth error it seems | 06:45 |
| kelvinliu | wallyworld: just found one issue on operators. so it seems operator was deployed by k8s pod api, so no `deployment` resources created. So k8s will not be able to manage it for recovering for example. | 06:45 |
| wallyworld | you sure? i get deployments | 06:46 |
| wallyworld | $ kubectl -n caas get deployments | 06:46 |
| wallyworld | NAME DESIRED CURRENT UP-TO-DATE AVAILABLE AGE | 06:46 |
| wallyworld | juju-gitlab 1 1 1 1 6m | 06:46 |
| wallyworld | juju-mysql 1 1 1 1 8m | 06:46 |
| kelvinliu | that's the deployments for app pod | 06:47 |
| kelvinliu | i mean depployment for operator pod | 06:47 |
| wallyworld | oh right yes, deployment for operator pod not done yet | 06:47 |
| wallyworld | there's a todo in the code | 06:47 |
| kelvinliu | ah, ic. I was just deleted gitlab operator pod, so it's gone | 06:48 |
| wallyworld | kelvinliu: so if mysql password is being correctly passed to gitlab docker image, but gitlab can't connect, that implies an issue in provides.py on the mysql side i think | 06:48 |
| wallyworld | you'll have to remove-application from juju and deploy again | 06:49 |
| kelvinliu | yup. | 06:49 |
| wallyworld | kelvinliu: actually, it looks like an issue with the gitlab image https://pastebin.ubuntu.com/p/2yxHnJffqT/ | 06:50 |
| wallyworld | we use latest, i might try an older one | 06:51 |
| kelvinliu | wallyworld: yes, i got the same error. | 06:51 |
| kelvinliu | wallyworld: but latest image was pushed 10 days ago | 06:54 |
| === frankban|afk is now known as frankban | ||
| wallyworld | kelvinliu: i tried an older version 10.6.4, same error :-( | 07:02 |
| kelvinliu | wallyworld: i guess it's related with the db access | 07:13 |
| wallyworld | it is but we need to find out why | 07:14 |
| wallyworld | will have to try with theold mysql layer | 07:14 |
| wallyworld | kelvinliu: solved! | 07:16 |
| wallyworld | it was new mysql version 8 | 07:16 |
| wallyworld | this works | 07:16 |
| wallyworld | juju deploy ./mysql --config mysql_image=mysql/mysql-server:5.7 | 07:16 |
| wallyworld | i will push a change to the charm to use that tag | 07:17 |
| kelvinliu | wallyworld: ah mysql had a recent push. | 07:18 |
| wallyworld | yeah | 07:18 |
| kelvinliu | wallyworld: would be better to lock the version tag | 07:20 |
| wallyworld | kelvinliu: that's what i'm going to do - change the tag in the charm config | 07:20 |
| wallyworld | config.yaml has the default image path | 07:21 |
| wallyworld | in my example above, i overrode the default when deploying | 07:21 |
| kelvinliu | wallyworld: ah, ic. the charm actually should be latest, then overwrite it from cmd when we deploy. probably we can just add the current compatible versions to the README? | 07:30 |
| anastasiamac | kelvinliu: wallyworld would not have seen ur message, he logged out just before it. | 07:32 |
| kelvinliu | anastasiamac: yeah, just saw that. thx for remind. haha | 07:33 |
| anastasiamac | nws :) | 07:34 |
| anastasiamac | m guessing u r not using tab to autocomplete the nick :D | 07:34 |
| kelvinliu | ah, how did u know? i just ctl+c ^-^ | 07:40 |
| wallyworld | kelvinli_: i've pushed changes to pin the image version. you could rebase your branch | 08:04 |
| wallyworld | kelvinli_: left some more comments in the PR | 08:08 |
| kelvinliu | wallyworld, looking the comments now | 08:13 |
| wallyworld | kelvinli_: thanks for changes! perhaps a comment that the -o directory can be anywhere convenient; doesn't have to necessarily be ~/.local/shared/charms | 08:26 |
| kelvinliu | wallyworld, yeah, agreed. | 08:54 |
| wallyworld | \o/ | 08:54 |
| kelvinliu | Have a good weekend :-) | 09:06 |
| balloons | Good morning | 12:35 |
| === frankban is now known as frankban|afk | ||
| mup | Bug #1729930 changed: juju.state.leadership manager.go:72 stopping leadership manager with error: state changing too quickly; try again soon <sts> <juju-core:Fix Released by axwalk> <https://launchpad.net/bugs/1729930> | 18:45 |
| hml | balloons: regarding the prehook checks not working on first push of new branch: https://paste.ubuntu.com/p/jV84x29pZm/ | 20:18 |
| hml | balloons: perhaps because master is now not used? guessing in the dark | 20:19 |
| balloons | Ah, yea we should remove master and staging | 20:19 |
| balloons | hml, did you try a quick fix of looking in develop? | 20:20 |
| hml | balloons: sure | 20:20 |
| balloons | I would rather we must added the meta linter instead of that old script | 20:21 |
| hml | balloons: i did a simple change of master to develop and still fails… something else is wrong.. not a git master | 20:25 |
| balloons | Gotcha. Sorry it's a pain | 20:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!